- 12 Apr, 2018 40 commits
-
-
Matt Falkenhagen authored
This makes more sense as SharedWorkerHost's destructor calls WorkerDestroyed to balance it out. It also simplifies the params to Start(). Not strictly needed for the linked bug. Refactoring that will make it easier to fix. Bug: 830288 Change-Id: I3be38ad7cc58c35bef301cd21074987ea9e5c64d Reviewed-on: https://chromium-review.googlesource.com/1004887 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550213}
-
Alexey Kozyatinskiy authored
Nicer arrow is always better. R=pfeldman@chromium.org Bug: none Change-Id: I38f58ca5adbdaa55516bc215928e99ac0c1f1c2d Reviewed-on: https://chromium-review.googlesource.com/1008630Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550212}
-
Jonathan Backer authored
On certain CrOS device, we --enable-native-gpu-memory-buffers. This causes the target for texture to become GL_TEXTURE_EXTERNAL_OES in a RasterDecoder::CreateTexture call. OnceCopyRasterProvider calls TexParameteri(...), which binds gpu::Texture and sets it immutable service side via a call to TextureManager::SetTarget(...). A subsequent call to BindTexImage2DCHROMIUM then fails on the IsImmutable check. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibde88dd449a246573343ac435116e529ce4e88cf Reviewed-on: https://chromium-review.googlesource.com/1008130Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550211}
-
Helen Li authored
This is a reland of 53553a99 Original change's description: > Add a net::TransportClientSocket class > > This CL adds a net::TransportClientSocket so that we can have an interface > to expose socket Bind() method. > > This CL changes the following: > - socket_test_util.cc > Changes MockClientSocket to subclass this new net::TransportClientSocket > class instead of net::SSLClientSocket. This new class hierarchy is more > intuitive because not all client sockets are ssl socket. > - client_socket_factory.cc > Makes CreateTransportClientSocket() returns a net::TransportClientSocket > instead of a StreamSocket. > - services/network/* > Makes network::SocketFactory take in a net::ClientSocketFactory. > - cast_socket.cc/h and cast_socket_unittest.cc. > > > Bug: 721401 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ie258114565e76529555e244364be421e66637960 > Reviewed-on: https://chromium-review.googlesource.com/995554 > Commit-Queue: Helen Li <xunjieli@chromium.org> > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549731} TBR=imcheng@chromium.org Bug: 721401 Change-Id: I93fb736881be6554bdaf17359b881370be1d7fea Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1007034Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550210}
-
Peter Boström authored
Rounded omnibox results apply to touchable and Material refresh. This is not in spec for refresh and touchable doesn't need to diverge here. Bug: chromium:826606 Change-Id: If9ea12ae3912b50fce92c9368452bf342b395e6c Reviewed-on: https://chromium-review.googlesource.com/1007898Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#550209}
-
Jun Choi authored
Currenly FakeFidoTask used in unit test for FidoRequestHandler categorizes response types depending on whether the response received from the mock device is base::nullopt, empty vector, or a non-empty vector. Change this categorization to use clearly readable enums instead. Bug: 827677 Change-Id: I6817808a6ace85e88bba48039c9cbe054cfbfb81 Reviewed-on: https://chromium-review.googlesource.com/1006233 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#550208}
-
Daniel Bratell authored
When building chrome_app_unittests chrome/common/crash_keys.cc are compiled both as a dependency and locally. Enough to compile it as a dependency. (Noticed in jumbo build experiments where the duplicate symbols met in the linker) Change-Id: I517436d21ae17c2ff664afeed43ad8e1b7e529e9 Reviewed-on: https://chromium-review.googlesource.com/1005341Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#550207}
-
chrome://inspectKen Rockot authored
Bug: 829412 Change-Id: Ia42efe7c749e0eaa44ea9c45a1a4be1a7d43580f Reviewed-on: https://chromium-review.googlesource.com/1007980 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550206}
-
Ashley Enstad authored
Bug: 816458 Change-Id: Iba29c656f02789baa8d0f9153bfaabe0fc1121e8 Reviewed-on: https://chromium-review.googlesource.com/1005032 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#550205}
-
Biao She authored
This CL also did the following three things: 1. refactored the code for checking if we should suppress 2D UI. 2. add kOsStoragePermission enum to represent suppress native storage UI request(currently only Android). 3. add kMediaRouterPresentationRequest enum to represent suppress media router presentation. Bug: 817148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id8e0bdc961ffcbcd1f0bc7145be2998ca949602e Reviewed-on: https://chromium-review.googlesource.com/1005842 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#550204}
-
Emily Hanley authored
Bug: 779634 Change-Id: I613fed97d31045ed7d15bbe17e0d3153fd19812e Reviewed-on: https://chromium-review.googlesource.com/1002922 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#550203}
-
Bence Béky authored
WebSocketEndpointLockManager being a singleton is causing a number of issues, including test flakiness. This CL makes HttpNetworkSession create and own an WebSocketEndpointLockManager instance instead, as suggested in https://crbug.com/450518#c8. I have verified locally that the following test invokation fails on trunk but passes with this CL: out/gn/net_unittests --gtest_filter=\ HttpStreamFactoryTest.RequestWebSocketBasicHandshakeStreamOverSSL:\ WebSocketEndpointLockManagerTest.LockEndpointReturnsOkOnce This is like the one reported in https://crbug.com/814985, but using LockEndpointReturnsOkOnce instead of GetInstanceWorks, because GetInstanceWorks is removed in this CL. Bug: 450518 Change-Id: Ie882dd7584c8cd3917844e0583370e453e316964 Reviewed-on: https://chromium-review.googlesource.com/1009962Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550202}
-
Yuqian Li authored
Bug: chromium:821353 Change-Id: I69a86f539e5e7d3b038fd085abfbba0826eb04bc Reviewed-on: https://chromium-review.googlesource.com/1008043Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Yuqian Li <liyuqian@chromium.org> Cr-Commit-Position: refs/heads/master@{#550201}
-
yiyix authored
In the current implementation, if the new RenderFrameMetadata is same as the initial value, then Browser will not receive the RenderFrameMetadata until it changes. After this patch, Browser will always receive the initial RenderFrameMetadata. Bug:830540 Change-Id: Ic0723d03aff1e4e7fa9eaabe80c27d5dd9bb31d0 Reviewed-on: https://chromium-review.googlesource.com/1006374Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
-
Katie D authored
This uses window.speechSynthesis, which should be using the TTS engine and voice prefs selected by the user. Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2b8cd29a2b1fd1da2a5cb002aeb877ed2e615196 Reviewed-on: https://chromium-review.googlesource.com/996764 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550199}
-
Andrew Grieve authored
Change-Id: If11054d64db33bef5f32561950604706d8a55b52 Reviewed-on: https://chromium-review.googlesource.com/1006043Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550198}
-
jdoerrie authored
This change promotes the DCHECKs in base::Optional::value() to CHECKs in order to match std::optional more closely. Furthermore, it also CHECKs when dereferencing a base::Optional via operator* or operator->. Bug: 817982 Change-Id: Ib2bfdd3a863e8bade21fa1b6b1c10c7c4d2ca135 Reviewed-on: https://chromium-review.googlesource.com/997335 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550197}
-
Istiaque Ahmed authored
Currently calling DictionaryValue::Set(??, bool) and ListValue::Append(bool) would result in calling int variant from the overloaded methods(!). This is confusing and can be a source of bugs. (The current suggested way is to explicitly call SetBoolean and AppendBoolean). There is only once place where this was happening, in extension_printer_handler.cc. Fix that code to use boolean variant, by using SetBoolean() method. This CL will also let us overload the bool variant in future. This CL - Provides an explicit "const char*" param overload. - Declares a bool overload but makes it inaccessible (= delete). This will - Make sure attempting to call DictionaryValue::Set with bool will fail compile (call to deleted member function 'Set'). So accidental introduction of such bugs won't be possible. - The char* variant will make sure we don't attempt to resolve bool to this pointer variant. - Give us the ability to remove GetBoolean/AppendBoolean. Bug: 831839 Change-Id: If61ce8a44799ff8e12957d5206baf74467655894 Test: Expect no behavior change, touches webui/print_preview FYI Reviewed-on: https://chromium-review.googlesource.com/1008870Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Adam Langley authored
The spec suggests aborting an operation when focus[1] is lost, but that's advice for site developers. I can't find anything in the spec about preventing background tabs from triggering operations. The cryptotoken extension refused to start a registration request, or to send a registration response to, anything but the active tab in the focused window. But background tabs could complete an authentication request. This change does something similar: it rejects both authentication and registration requests unless the requesting frame is in a focused window. It also performs that check before returning responses. This is slightly different from the cryptotoken behaviour because cryptotoken could only use what the extensions API exposed. For example, if the omnibox was focused, cryptotoken would complete a registration from the foreground tab but this code will reject it. I think this behaviour is better, and it's certainly far more inline with the content / browser separation. This change has been split from its tests, which will come in a future CL. [1] https://w3c.github.io/webauthn/#abortoperation Bug: 827266 Change-Id: If6e97dd6526e175f40718724eda21e3efd434f7f Reviewed-on: https://chromium-review.googlesource.com/991073 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550195}
-
Lukasz Anforowicz authored
Bug: 831671 Change-Id: Ib0de8b66ebe2963bf25cfde26ab8fef7e1070e56 Reviewed-on: https://chromium-review.googlesource.com/1008172 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550194}
-
vasilii authored
Bug: 819626 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4ea56f1d4d7d12184b2fdfbdbc9c44330b72b94e Reviewed-on: https://chromium-review.googlesource.com/1007059 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550193}
-
Min Qin authored
For download service, we are going to pass a class that retrieves URLLoaderFactory. This CL defines a common interface for that purpose. And the implementation can support either a blob url or a network url. BUG=803135 Change-Id: I505e025fc54553753180f05b97fbd3c4b654253a Reviewed-on: https://chromium-review.googlesource.com/1007974 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550192}
-
Xi Han authored
This is the precursor step before creating a thread to start the ServiceManager before content_main_runner is running. It is because no thread is expected to be when the zygote process is forked. In this CL, we move the setup to ContentMainRunner::Initialize(). Bug: 740677,729596 Change-Id: I90e95cce8bc32be03c944aaa17f96c79d555e7cb Reviewed-on: https://chromium-review.googlesource.com/999741Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550191}
-
Henrik Boström authored
This adds RuntimeEnabled feature RTCUnifiedPlanByDefault (off by default even in LayoutTests) which overrides the default SDP semantics of RTCPeerConnection, and adds running external/wpt/webrtc/* as a virtual test suite with this flag enabled. The tests can be run as: virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/ The -expected.txt files are identical to the non-virtual versions. The only problem introduced with Unified Plan is that the following test times out: virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/ RTCPeerConnection-setRemoteDescription-tracks.https.html Bug filed: https://crbug.com/828866 And unlike external/wpt/webrtc/ RTCPeerConnection-setLocalDescription-answer.html, virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/ RTCPeerConnection-setLocalDescription-answer.html does not fail against the -expected.txt file. Bug: 828793, 828866 Change-Id: I51d86fc5a0388ae1d8bf5f8497f31795d205d5d2 Reviewed-on: https://chromium-review.googlesource.com/995278 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#550190}
-
Francois Doray authored
This CL previously landed as https://chromium-review.googlesource.com/997892. It was reverted because of an access race in ChromeStorageImpl https://crbug.com/829122. This CL fixes the issue by deleting both callbacks on the origin sequence when they can't run. Before, there was always leak when an internal task posted by PostTaskAndReplyImpl didn't run. With this CL, PostTaskAndReplyImpl notices when its internal callbacks aren't scheduled and schedules deletion of all its internal state (including callbacks that didn't run) on the origin sequence via a DeleteSoon(). Note that a deletion scheduled via DeleteSoon() might not happen if Chrome is shutting down. R=gab@chromium.org Bug: 807013 Change-Id: I17abffd3e7afcc861c8c92dce30c14ce8629b125 Reviewed-on: https://chromium-review.googlesource.com/1006045 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Corentin Wallez authored
Also fixup some documentation links for GPU optional bots. Also change a PRESUBMIT.py's master name for win_angle_rel_ng. TBR=kbr@chromium.org TBR=sky@chromium.org BUG=chromium:815092 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ifda505e121f67f922f19da466a37b7f6266cea05 Reviewed-on: https://chromium-review.googlesource.com/1008182Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#550188}
-
Devlin Cronin authored
Update profile_signin_confirmation_helper_unittest.cc and sync_extension_helper.cc to generate extensions with manifest_version 2. Bug: 816679 Change-Id: I302693e92b7925f900cd41b7fa3751a4a299a8cf Reviewed-on: https://chromium-review.googlesource.com/1008624Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550187}
-
Asanka Herath authored
The generate-quic-chain.sh scripts expects the latter. Also the line endings are not significant. R=jam@chromium.org, rch@chromium.org Change-Id: I6dc0a14bd2f3b7f7e1438ee6207dfbc53deb4eba Reviewed-on: https://chromium-review.googlesource.com/1007642Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Thomas Tangl authored
This is a follow-up CL from crrev.com/c/998112, adding the sync-paused icon to the avatar button on Mac. Bug: 825533 Change-Id: Ia07908a362150f784ce91ef7a8dea96d2cea7b59 Reviewed-on: https://chromium-review.googlesource.com/1007135Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#550185}
-
Danyao Wang authored
This removes flicker in Omnibox that briefly exposes the internal URL when restoring session history. Virtual URL must be set on the pending item before calling |loadCurrentURLInWebView| because WebStateObserver::DidStartLoading event fires during this call, which triggers ToolbarModelDelegateIOS to update itself using the virtual URL of the pending item. Bug: 815248 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I260e251d90ad832120b908a61843fe30df261be3 Reviewed-on: https://chromium-review.googlesource.com/1003252 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#550184}
-
Moe Ahmadi authored
- This CL expands on the dynamic form filling logic by tracking the filling context for multiple forms, therefore allowing multiple dynamic forms on the same page to get filled, e.g., billing and shipping address forms on victoriassecret.com _ It also fixes a bug where previously filled fields were not being refilled even if their value was reset during the dynamic form change. - It also rewrites the JS logic in the test html files to eliminate race conditions and improve readability. Change-Id: I44681742820d5285e77a4e9e4a61917ae4bfc41e Reviewed-on: https://chromium-review.googlesource.com/1003381Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550183}
-
David 'Digit' Turner authored
This CL tries to document more internal GN build rules, as a preliminary for future patches that will perform refactoring of some of them. In particular to simplify the impressive java_library_impl() rule. Also perform a little cleanup, since this led to discover a few obsolete things: - Remove the 'manifest_entries' variable since it is never set, and its entries passed as --manifest-entry= arguments to javac.py, which doesn't support it! - Remove forwarding of the optional public_deps variable, in cases where it would never be used by the final rules that receive it (it was never being set by any upstream callers). - Remove un-needed passing of processors_javac which seems obsolete. - Move more variables in the (type == "android_apk") block of java_library_impl() to make it clearer that these are only used for android_apk() targets. BUG=830641 R=agrieve@chromium.org Change-Id: I489c1921d58bc9f649a5bc02cf630c36e607b20a Reviewed-on: https://chromium-review.googlesource.com/1007061 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550182}
-
Maks Orlovich authored
Once NetLog moves to NetworkService, it'll be desirable to have the output files used for netlogs passed in from browser process, since sandboxing of network service process probably will limit where it can write on disk. base::File (mapped as mojo_base.mojom.File) is the preferred way of transferring files per https://chromium.googlesource.com/chromium/src/+/lkcr/docs/security/mojo.md#Use-structured-types This doesn't address actually passing in the file or configuring a separate in-progress directory for the bounded mode (assuming the network service will have some temp dir it can write to); that would be the next steps. Bug: 767450 Change-Id: I814d2fdf6d95016e32d08902038fc84b391411b8 Reviewed-on: https://chromium-review.googlesource.com/1005425 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550181}
-
Devlin Cronin authored
A bunch of extension unittests generate extension objects at runtime. Update these to generate extensions with manifest_version: 2. Where trivial, update these to use ExtensionBuilder (if they weren't already), which uses manifest v2 by default. Bug: 816679 Bug: 756488 Change-Id: Iec80a5dd288452e70e5dbdd1902180611f6bbcca Reviewed-on: https://chromium-review.googlesource.com/1007501 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550180}
-
Ken Rockot authored
Instances are explicitly stopped during Service Manager shutdown, but then "stopped" again during individual Instance destruction. That results in listeners being notified twice about each instance being stopped if they aren't stopped before Service Manager shutdown. This CL fixes that. Bug: 831386 Change-Id: I210c9ce07cfa386d39bba7aa42244e00519b6f81 Reviewed-on: https://chromium-review.googlesource.com/1008968Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#550179}
-
Robert Ma authored
The tests have unstable failure messages. Add these expectations in advance to unblock wpt-importer. TBR=kereliuk No-Try: True Bug: 832071 Change-Id: I4a1efcd869f3660f4a88d37e9a02bf4bc9f0ee40 Reviewed-on: https://chromium-review.googlesource.com/1010243 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#550178}
-
Christopher Grant authored
BUG= R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2db855f4a560e521537c5016f564aee69edc0073 Reviewed-on: https://chromium-review.googlesource.com/1007632Reviewed-by:
-
Adam Rice authored
Mark virtual/off-main-thread-websocket/http/tests/websocket/close-code-and-reason.html as flaky. BUG=831320 Change-Id: I388617a9d8269da334bfa3d1de1cdafbb8203efb Reviewed-on: https://chromium-review.googlesource.com/1009782 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Fady Samuel authored
This reverts commit 3fb6e543. Reason for revert: This is blocking branch cut. We know we hit this case and we've collected some crash logs to sift through now. Original change's description: > Surface synchronization: Add diagnostic CHECK > > Current evidence points to a race in cc that is causing surface invariants > violations (No invariants violations detected in LayerTreeHost but detected > in ClientLayerTreeFrameSink). > > My suspicion is viewport is updated out of sync with LocalSurfaceId and > device scale factor. > > This CL adds a diagnostic CHECK between the pending and active LayerImpls to > attempt to detect the race and produce a better stack trace. The invariant > we want to test here is if active tree has an invalid viewport (viewport has > changed), then the LocalSurfaceId MUST change. > > Bug: 672962 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I975c9dfb9c86c292d7aac052bac01510e6efb1c2 > Reviewed-on: https://chromium-review.googlesource.com/989851 > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547457} TBR=enne@chromium.org,fsamuel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 672962 Change-Id: Id1ad5997e12b7f966df5f7b034bd5a30baa5ae60 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1008642Reviewed-by:
-
Takumi Fujimoto authored
This feature is getting rolled out on M66. Enable it by default for M67. Bug: 758005 Change-Id: Id96a86f8e7140f61496b8bfcf7ac5c4f3e00b56a Reviewed-on: https://chromium-review.googlesource.com/1003519Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#550174}
-
