GitLab

When using navigation such as the "Back" arrow in Inspector, the layout
view is null when shutting down the session. Add checks for this.

Change-Id: Ic2ac27aadda67e5926498648b434fcb7e0fda9ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065734
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743337}

Bug: 1043696
Change-Id: I43e7a3667218c8cf6c0add27f23d52a28f15cbd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060391Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743336}

https://chromium.googlesource.com/codecs/libgav1.git/+log/25dc90ee0776..8e8c13b9e821

$ git log 25dc90ee0..8e8c13b9e --date=short --no-merges --format='%ad %ae %s'
2020-02-17 wtc Remove aligned_width() and aligned_height().
2020-02-16 wtc Change aligned_height to current_process_unit_heig
2020-02-15 johannkoenig arm: do multiple ConvolveCopy rows at once
2020-02-14 johannkoenig warp: take into account warp ranges
2020-02-14 wtc Use uintptr_t instead of size_t in AlignAddr().
2020-02-14 wtc Add ComputeFrameBufferInfo() and SetFrameBuffer().
2020-02-14 vigneshv tile: Generalize DecodeSuperBlockRow
2020-02-14 vigneshv Re-use loop restoration info across frames
2020-02-14 johannkoenig prediction: remove offsets for bitdepth == 8
2020-02-14 slavarnway x86: Add Adst8 dc only support
(...)
2020-02-03 johannkoenig cleanup: use constants for bitdepth
2020-02-03 johannkoenig convolve: ensure no accidental copies
2020-02-03 wtc Add a C API.
2020-02-03 johannkoenig arm: remove inter_round_bits from warp
2020-02-03 johannkoenig dsp: remove inter_round_bits_vertical
2020-02-03 johannkoenig warp: rename is_clip to is_compound
2020-02-03 linfengz trivial: remove pos_index in Tile::ReadSignAndApplyDequantization
2020-02-03 linfengz reduce quantized coefficient padding
2020-02-03 linfengz trivial: update DaalaBitReader::ReadLiteral()
2020-02-03 wtc Declare local var 'v1_callbacks' right before use.

Created with:
  roll-dep src/third_party/libgav1/src

Convert the FormatVideoFrame() method to a non-member function in the
unnamed namespace in gav1_video_decoder.cc. This avoids the forward
declaration of the libgav1::DecoderBuffer type in gav1_video_decoder.h.
It is tricky to forward-declare libgav1::DecoderBuffer because it is now
a type alias, not a struct.

Add the "libgav1_dsp" source_set to work around having two files named
film_grain.cc.

Tested:
  $ gn args out/Default
  # In the editor, add the following build argument:
  # enable_libgav1_decoder = true
  $ autoninja -C out/Default media_unittests
  $ out/Default/media_unittests
  $ out/Default/media_unittests --enable-features=Gav1VideoDecoder

R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@google.com

Bug: 1026522
Change-Id: I6db24dd117083665d24453c8b69c00424b625869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066137Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#743335}

This CL adds user action recordSettingChange() calls in instances in
OS settings related to the internet page settings that the user
can change.

Bug: 1049830
Change-Id: Id35a02c3c9fb58660061e243348f0633109fc873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063261Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743334}

Change-Id: I34269e4b0ee6299ad438b405db37802e864a8e41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063414Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743333}

Former will be go/no-go'ed for stable by M85, we'll know more about the latter by M84

Change-Id: I6b506c3465c8d7f1e309f219f3e7e4920e7be7e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067661Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743332}

Bug: 634140
Change-Id: I177393c1950a475c44e0d35f0f27b48fecf800e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056190Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743331}

Currently, cups_ipp_util.h is used by files outside of the "printing"
target, and contains exported methods. However, we might want to add
utility functions that we don't want to expose to other targets, and we
might want to place these in a header that is named similarly to
cups_ipp_util.h.

The name cups_ipp_helper.h was chosen because it contains methods
for parsing IPP printer attributes, and cups_helper.h, which contains
methods for parsing PPD printer attributes, already exists. The new
name is consistent with the existing one.

Bug: 226176
Change-Id: I333d4380e6e333c319989879d41d93404a38de4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062579Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743330}

No change to default code path. This adds a debugging flag to tint all
WebViews yellow. This exposes the flag through the developer UI and
documents the flag.

Bug: 1051554
Test: build/android/adb_system_webview_command_line --highlight-all-webviews
Test: out/Default/bin/system_webview_shell_apk launch "https://developer.mozilla.org/en-US/"
Change-Id: Ib1cf2191cd51cb793d040ce9e8d5eb9e7ecebe68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066144Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743329}

Bug: 1052544
Change-Id: I173a4e3c364fc6f69e4dd24b934f7ed50a50572e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058063Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743328}

After app list config change, the apps container was not clearing cached
margins for current app list bounds, even though they depended on the
app list config. So if app list config was updated after bounds change
(and the associated layout), the apps container was getting laid out
using obsolete apps container margins.
This cl fixes the issue.

Also, when AppListView updates the widget bounds (e.g. because the
display, and thus root window bounds change), update app list config
before setting new bounds, so the app list uses the new config while
laying out the app list view for bounds change (and avoid another pass
for the app list config update).

BUG=1053911

Change-Id: Ic6249a86f350c11ba3a2be006368aefba9975719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067445
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743327}

Provides a whitelist entry for the Activity URL filter as a parameter
to CastWebContents. No whitelist implies no restrictions.

Bug: internal b/148820675
Test: CQ, verified url request blocking in devtools

Merge-With: eureka-internal/360987

Cq-Depend: chromium:2050038
Change-Id: I9e0c329b31e62e9c6c8e039c0f9de395fd119412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050039
Commit-Queue: Jiaqi Han <jiaqih@google.com>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743326}

Bug: 1053463
Change-Id: I3fd46315c971c6377e194f956b769950b9129d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064183Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743325}

Moves configs around to fix a bug introduced by
https://crrev.com/c/2039597

Bug: 1052737
Change-Id: I311fc4c082c214046f84e3c7b3823bfa290f838f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062902Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gregory Guterman <guterman@google.com>
Cr-Commit-Position: refs/heads/master@{#743324}

Migrate AndroidSmsAppSetupController to use the new web_app:: APIs,
in preparation for the extensions-based implementation of desktop PWAs
being retired.

Bug: 1052709
Change-Id: I2dfb503975d5073dc7f152d2dcced2943819e8c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060403
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743323}

https://skia.googlesource.com/skia.git/+log/5725e9b55494..706851dc99d9

git log 5725e9b55494..706851dc99d9 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 bsalomon@google.com Fix issue where GrQuadPerEdgeAA GP doesn't emit coord transforms
2020-02-20 dmazzoni@chromium.org Simplify interface to StructureElementNode.
2020-02-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-02-20 michaelludwig@google.com Use scalar instead of int for offset in drop shadow filter
2020-02-20 bsalomon@google.com Make SkSL CPP code gen copy explicit coord status for cloned FPs
2020-02-20 robertphillips@google.com Add temporary header to shift clients over to include/core/SkDeferredDisplayList.h

Created with:
  gclient setdep -r src/third_party/skia@706851dc99d9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:607777,chromium:994037
Tbr: lovisolo@google.com
Change-Id: If1be8336698891f277b4c1b433865d2141464bfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067579Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743322}

Previously DFM load (for native libraries / resources) takes place when
a DFM's Module.getImpl() is called. However, VR is an exception; its
Module.getImpl() is called early, before main library load (which is
needed by DFM load). A worked around was to defer loading at first, and
flush then in Module.doDeferredNativeRegistrations().

This CL cleans up the above by giving more control to each DFM to
specify whether to automatically load DFMs in Module.getImpl(). A DFM can
override the default (true) behavior to manage its own native loading,
which may take place on start-up, on first use, and/or on install.

This CL also makes the following changes to specific DFMs:
* VR: Disable load-on-getImpl, with explicit load added to
  VrShellDelegate.onNativeLibraryAvailable(), which gets called on
  start-up and on install.
* DevUI: Disables load-on-getImpl since Module.getImpl() doesn't get
  used anyway. Keep existing calls for load-on-use and load-on-install.

Other implementation details:
* Remove Module.doDeferredNativeRegistrations() and it list of deferred
  DFM loads.
* Add flag |load_native_on_get_impl| to be given in DFM target
  *_module_desc. This is compulsory iff DFM specifies native libraries
  or resources.
* Replace Module.loadNative() with Module.ensureNativeLoaded(), which
  is specific to a module (i.e., no longer static). The name emphasizes
  that repeated calls are simply ignored. It assumes that the DFM
  installed, and requires Chrome's native library to be loaded.
* Replace static map |Module.sInitializedModules| by per-module flag
  |mIsLoaded|.

Bug: 1048740
Change-Id: I2fa844239fc3d741d91d28f384b2bc75a712b574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044489
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743321}

This CL is to add three UKM metrics.

TotalInputDelay
sum(Input Delay)

TotalAdjustedInputDelay
sum(max(Input Delay - 50ms), 0)

NumInputEvents
The number of Input Events.

The ‘Input Delay’ here refers to the InputEvent.InteractiveTiming.InputDelay which is the duration between the hardware timestamp and the start of event processing on the main thread for the meaningful input.

UKM privacy review: https://docs.google.com/document/d/1sejEIb-uaZuZ6BzvKB5Ao4uUoJYmRkPFE5j1fsgEWnQ

Change-Id: I6ed40a72945b008e1d84d9a9fc37aea72eb81b1d
Bug: 1051042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051709
Commit-Queue: Hongbo Song <hbsong@google.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743320}

Bug: 648382
Change-Id: Ic87f156e9661efc832bf054d4f901895bb9671b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067258Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743319}

This CL adds event fires for the custom 'user-action-setting-change'
in os settings ui to record settings metrics for user action internet
page settings change events that may occur outside of settings.

Bug: 1049830
Change-Id: Icb78e07319fc9d81bdf46a78805037e7185bb096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063676
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743318}

The consent will be shown to user:
- Cumulative 8 seconds (based on reading speed from notification study)
OR
- Up to a total of 3 times.

Bug: 1054575
Test: unit tests
Change-Id: Id05fe4edda8cf04005684d84ed7d36df32c06cd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039890Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743317}

NavigationGlow can be destroyed after the window and view
associated with it, so we need to observe those events happening
and clean up accordingly.

OnDetachCompositor is called prior to the WindowAndroid being destroyed,
and surprisingly clears the observer list, so that is the best option
we have to clean up that reference.

BUG=1048851

Change-Id: I61e081dcab951ceeb6515a4e79e2d42ea2a96f84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065416
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743316}

The hide animation for stacked notification bar is not
correctly initiated in the current implementation.

Bug: 1051671
Change-Id: I94b75c161eddff9b6123e48c869e277a2e67ac31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067334Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743315}

Adds a URL filter for generic Activity third party
applications. This introduces filter logic for http
and websocket requests according to a provided whitelist.

A follow up CL to introduce the whitelist entry in
cast_web_contents that enable the filters.

Bug: 1054535
Test: CQ, verified url request blocking in devtools
Change-Id: I6a6a50bea79b70e7e91e08832bf9807c91faa53a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050038Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Jiaqi Han <jiaqih@google.com>
Cr-Commit-Position: refs/heads/master@{#743314}

Change-Id: I15a437a11922af307a7cbf800b01529131429dea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064229Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743313}

This CL converts base::Bind and base::Callback in //chrome/app to Once
or Repeating

Bug: 1007634
Change-Id: Ie12853158482a1d16e8074dc3eeaf98f1e610d48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067453Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743312}

Report the following aggregated to UKM, since these are the aggregation
of some of the other UKM metrics already reported:

  Graphics.Smoothness.Throughput.AllAnimations
  Graphics.Smoothness.Throughput.AllInteractions
  Graphics.Smoothness.Throughput.AllSequences

BUG=852482, 790761

Change-Id: I86d40ba677bd3b8e01e7b9a04b2787651f06d9d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053843
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743311}

- Changes both positioners to weak from assign.
- Removes a DCHECK since it seems that the positioner can be niled
in certain conditions like shutdown, in order to make sure these are
set they are now part of the initializer.
- Adds a containerViewWillLayoutSubviews super call to both positioners.

Bug: 1034635
Change-Id: Iee46b2b2313831a289100f47e3ef8a96c4e20dcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067382Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743310}

For the WebNFC Origin Trial the feature flag needs to be enabled by
default and configured as "disable only" in runtime_features.cc so that
it can still be used as a kill switch but will not enable the feature
on sites which don't have a valid Origin Trial token.

Bug: 1035048
Change-Id: I139a79dd0f93013bc59d5023017b49c820532fb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052198
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743309}

https://chromium.googlesource.com/angle/angle.git/+log/b4357d46c6c6..166875eb84cc

git log b4357d46c6c6..166875eb84cc --date=short --first-parent --format='%ad %ae %s'
2020-02-20 jgilbert@mozilla.com Don't clamp in glBlendColor if context supports renderable [half-]float.
2020-02-20 jmadill@chromium.org Vulkan: Fix store ops with linear command recording.

Created with:
  gclient setdep -r src/third_party/angle@166875eb84cc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I5a14cbf8aedac6559ccc0a924ad5dcfeb3b6b21f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067536Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743308}

viz::HitTestManager::submit_hit_test_region_list_index_ is used to avoid
sending hit test information to the browser if the underlying hit test
data hasn't changed. It increments the index every time a new batch of
hit test data arrives from a renderer process. However, there is another
way that hit test data can be invalidated, requiring hit test data to
be re-aggregated and sent to the browser:

HitTestAggregator::Aggregate is not a simple pass-through for the data
collected by HitTestManager. It also modifies flags on the hit test
regions, based on whether or not a surface is active (see
HitTestRegionFlags::kHitTestNotActive). "Active", in this case, does
*not* mean that the surface has submitted a compositor frame. Rather,
it means that the surface has submitted a compositor frame *and* the
frame was included in the output of SurfaceAggregator::Aggregate. It is
possible for a surface to change from inactive to active without
triggering the re-aggregation of hit test data. In particular:

- child surface submits a compositor frame with hit test data
- SurfaceAggregator omits the child surface, because the parent surface
  has not yet reported bounds for the child surface.
- HitTestAggregator marks the child surface's hit test regions as
  kHitTestNotActive.
- parent surface submits a compositor frame with bounds for the child
  surface, but without new hit test data.

In this situation, HitTestAggregator will never send new hit test data
to the browser with updated flags for the child surface's regions.

I have not seen this fail in the wild, but then again I don't generally
pay attention to viz bugs. For the bug in question, I have a separate
fix in blink; but that fix causes some changes in the order of data
sent from the renderer to viz, which exacerbates this hit test data
problem, causing failures in SitePerProcessHitTestBrowsertest.

BUG=1033746

Change-Id: Ic338ad64465a1427ed29017b20370b54ed747d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044435
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743307}

Bug: 1026426
Change-Id: Idc3a899fd41f2a215013549731dd73483614ff0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065853Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743306}

This CL adds a test to ensure the changes made in crrev.com/c/2040201
behave as expected and will not regress with time.

In essence, this ensures we can no longer go back to occluders with a
single rect in cases where more than one should be used.

Bug: 1022544
Test: viz_unittest
Change-Id: I7a7cda96bde232143d20e24b41ae9b306ad195f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063917Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Gil Dekel <gildekel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743305}

The new source.chromium.org site accepts the link as-is, but for
cs.chromium.org, I get a "Request to Git backend failed." error. After
this CL, the link should work for both code search versions.

Change-Id: I576d88b3a6eb8bcbf7fcd26fa5ef6d3bba40d31b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067478Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743304}

Compile Paint Previews on official builds. This has already been
compiled/tested on trybots/waterfall for a long time so shouldn't cause
any issues. The goal is to get this code shipping so we can start some
experiments.

Binary-Size: Regression is known about and approved by agrieve@.
Bug: 1035118
Change-Id: I9ff9f053cf0149e2aa68eeea9e052eb5edd1293c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067282Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743303}

Bug: 1054577
Change-Id: Id016a5d8f3f511851dfd91861b2ec42f03068e14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067638
Commit-Queue: Luke Z <lpz@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Auto-Submit: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743302}

Bug: 1054502, 1023833, 836460
Change-Id: I3c5b7f91dcd7bef66307bb0706dd0b9dee8c2ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067328Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743301}

See discussion thread at
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/h4bdRqbduNY

The recommendation style is as follows:

// Declaration
class Foo : public IComIsFun {
  IFACEMETHODIMP IsFun(BOOL* fun) override;
};

// Implementation
HRESULT Foo::IsFun(BOOL* fun) { *fun = false; return S_OK; }

Tbr: dmazzoni@chromium.org
Change-Id: I06abe1c69a67a954cc346ec936018bcfe8d12825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050742
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743300}

url_lookup_service is currently managed in database_manager, which
does not operate at profile level. To make each profile have its own
url_lookup_service, create a singleton which owns all
url_lookup_service, and make url_lookup_service a keyed service.

This is the first CL of refactoring url_lookup_service to be profile
based. The actual service change will be implemented in a follow-up
CL. For more details, see: go/chrome-protego-refactor-profile.

Bug: 1050859
Change-Id: If1862546c2cf8fc9a23375e680c790c72a5913e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061119Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743299}

Bug: 976352
Change-Id: I39ec8f4364554f7650a484c41d6134ac01a62d25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065423Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743298}