- 06 Jan, 2021 40 commits
-
-
Nancy Wang authored
The new ModifyWindowInfo function will be used by FullRestoreSaveHandler::SaveWindowInfo in CL:2597519 to modify and save the window information for the restore data. Modify the unit tests to verify the window info modification function. Move the position of the AppRestoreData constructor function, and the field restore_bounds name to consistent with the WindowInfo structure. BUG=1146900 Change-Id: I0e5755ffdf966d29139be67bf9a9a00a981c7df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598084Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840619}
-
Dave Tapuska authored
This is a reland of crrev.com/3da5569e with a rename of the class PepperPluginInstance to PepperPluginInstanceHost on the browser side. The two classes named the same caused vtable confusion on the debug build and the browser side class was getting called from the renderer code. Naming the classes separately avoids this confusion. This adds some base plumbing for pepper plugin instance handling. The pepper renderer code allocates and manages the PepperPluginInstanceImpl, this creates the correct encapsulation moving code out of RenderFrameImpl. On the browser side a PepperPluginInstance is created to handle the messages and relay them to the WebContentsImpl which use to handle the processing of Pepper messages. BUG=1157519 Change-Id: I45b238ce76bde0db35a9fd74baddb04333ebb593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611047Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#840618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a718c4e909e..cdde253e4082 2021-01-06 brianosman@google.com Runtime effects: Disallow bitwise ops and integer remainder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I3faedde605dc07b783aabde49d1b9cf387ec2839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840617}
-
Joshua Pawlicki authored
Also introduces an in-process test server. Also increases logging levels on the mac server. Also adjusts NSUserDefaults domain to allow test and app code to communicate. Bug: 1142591, 1119857 Fixed: 1142591, 1119857 Change-Id: Ic4f2f16924aba95a01186f07f488a0e49322fd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518214 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840616}
-
Ian Clelland authored
As part of removing the ExperimentalProductivityFeatures flag, the current experimental Permissions and Document Policy features are moved to a single new flag, introduced here as ExperimentalPolicies. Change-Id: Ib395cd9a1d54e727749cbcfaca1e905608c65a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601056 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#840615}
-
Ewann authored
This CL defines what we consider to be a small device. Bug: 1152730, 922511 Change-Id: I9b7fad0b45c20f823cf1655483b5c8ccff3ccfcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600902Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#840614}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101060600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/-wDCr73uudKYVUOYqQJOHIYQHhh7Luoz49wve50i6eoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/175639859 Tbr: media-app@grotations.appspotmail.com Change-Id: I0639043c9f5afa2460a962ef7a4cb61ba9437576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840613}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/382bf2883fa9..8ef860714479 2021-01-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ff29e249d317 to b9e179f1f239 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I59738c83be4c47ab458c99207f3c352a0ea9d9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613006Reviewed-by:
-
Morten Stenshorne authored
This reverts commit 9b04f2c2. Reason for revert: Most likely broke AppControllerProfilePickerBrowserTest.LockedProfileReopenWithNoWindows on Mac 10.11 https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/59140 Original change's description: > [profiles] The profile picker supports the force signin policy > > This CL removes the restriction that disables the profile picker if the > force signin enterprise policy is enabled. > > Force signin dialogs will be hosted by the profile picker if the > corresponding feature is enabled. > > Bug: 1156096 > Change-Id: I19ec58afc7a451fbd868eae5e3d8d13899e78719 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595412 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840575} TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I698a89a9214fd179994706d40ae58498cff4b9c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611270Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#840611}
-
cfredric authored
Bug: 1143756 Change-Id: Iedb06734ee09b9529f80952370f238df25110a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611584 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840610}
-
Tanmoy Mollik authored
FeedSurfaceMediator and ChromeBackupWatcher Replace IdentityManager.Observer.(onPrimaryAccountSet/Cleared) calls with onPrimaryAccountChanged call. Bug: 1158855 Change-Id: Ic9233c925b36188c7c52e183c52bed9044d86cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603575 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840609}
-
Stephen Nusko authored
each of these are failing 10% of runs for mac-arm_dtk_arm-perf. Bug: 1163528 Change-Id: I367ced10531dc3cb374170ffcb484dc98567ec35 Cc: mythria@chromium.org,tmrts@chromium.org No-Try: True Tbr: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611954Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#840608}
-
Monica Basta authored
This CL adds the edit avatar button in the local profile creation flow. Bug: 1162443 Change-Id: Ie6b9c1907dde8fbd5609ab28b77cace32ff69b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607305 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#840607}
-
WangHui authored
Rename *_web_view.h/cc to *_webview.h/cc to be consistent with other file styles and some code cleanup. Bug:None Change-Id: I782ac7c4d20943e48fb98366b611675f8a6575ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602972 Commit-Queue: HuiWang <wanghui210@huawei.com> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840606}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I49da68522ed2dee1ce23aa81c39ee13d24e9859f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613004Reviewed-by:
-
Zach Kirschenbaum authored
This reverts commit 0ec4e032. Reason for revert: so in the reland, we can remove NOTREACHED Original change's description: > Revert "[fuchsia] handle RetrySystemUpdate reboot reason" > > This reverts commit 394a78b4. > > Reason for revert: this breaks something > > Original change's description: > > [fuchsia] handle RetrySystemUpdate reboot reason > > > > In this change, we add support for RetrySystemUpdate. Also, we stop > > mapping `RebootSource::OTA` to `StateControlRebootReason::SystemUpdate` > > because reboots for system updates should only be called from > > fuchsia.git -- the code we remove isn't being run anyway. > > > > BUG=fuchsia:64591 > > TEST=cast_reboot_unittests > > > > Change-Id: Ic15f86d31d3985d2fa5a2a3957c5ca61066cd476 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600053 > > Reviewed-by: Sergey Volk <servolk@chromium.org> > > Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> > > Cr-Commit-Position: refs/heads/master@{#838871} > > TBR=spang@chromium.org,servolk@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zkbaum@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: fuchsia:64591 > Change-Id: I9a2dd0fe105b1750c733925a8320a2f4e71cded2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611448 > Reviewed-by: Sergey Volk <servolk@chromium.org> > Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> > Cr-Commit-Position: refs/heads/master@{#840361} TBR=spang@chromium.org,servolk@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zkbaum@google.com Bug: fuchsia:64591 Change-Id: I4d6fffa0df883dbb6dae6add7f8e81aedcd0a95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611526 Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#840604}
-
Morten Stenshorne authored
This reverts commit 20ec4591. Reason for revert: StartupTracingTest failures. https://ci.chromium.org/p/chromium/builders/ci/win-asan/16653 Original change's description: > Reland "[tracing] Align --trace-startup and --enable-tracing." > > This is a reland of 0823dbae > > Original change's description: > > [tracing] Align --trace-startup and --enable-tracing. > > > > Use StartupTracingController both for --trace-startup (primary use case: > > browser startup perf profiling) and --enable-tracing (primary use case: > > browser test tracing). > > > > Due to historical reasons both flags are kept, but now their behaviour > > is mostly the same. If both are present, --trace-startup takes > > precedence. > > > > Differences: > > - `trace-startup` finishes after 5 seconds by default, while `enable-tracing` > > continues until the browser is closed. (--trace-startup-duration overrides > > both). > > - `trace-startup-file` always treats the path as absolute, while if > > `enable-tracing-output` ends with /, it uses the provided value as the > > directory and generates the base name based on the current runtime > > metadata. > > > > R=skyostil@chromium.org,eseckler@chromium.org > > BUG=1157954 > > > > Change-Id: Ia76316aa8927b431784e2fb94c8e42e4e2c0b479 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589834 > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Commit-Queue: Alexander Timin <altimin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#839992} > > TBR=skyostil@chromium.org,eseckler@chromium.org,nasko@chromium.org > > Bug: 1157954 > Change-Id: Ic16992026beebddea39c8a6b247b4301512057e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609139 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840015} TBR=nasko@chromium.org,skyostil@chromium.org,altimin@chromium.org,eseckler@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1157954 Change-Id: Icfe2c800d65223f4b603370e1a7f50c2ee01283b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611268Reviewed-by:
-
Sebastien Lalancette authored
Bug: 1110944 Change-Id: I83d2e15de5ef086c86a55c064159e7b75c69e251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611049Reviewed-by:
-
Mihai Sardarescu authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the chrome/browser/password_manager/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: I5d3439b94ef7214debf58439c46078b70dbfc305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611245Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#840601}
-
Ulan Degenbaev authored
Change-Id: Ic9c6c58d324f93cfab923b45200eec9131732fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612995Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840600}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/74f1b6be4a91..c6345ca36de9 2021-01-06 emacs.nolkaf@hilbrich.tk * meson.build: Fix 'png' build option (#59458). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ieb07820ab0fea8a203a59bc8cfd5b207b83faadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612804Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840599}
-
Alex Ilin authored
Keep the picker disabled on startup until: - multiple profiles were used in the last 28 days, or - the picker has been shown once A new prefs::kBrowserProfilePickerShown pref is added to track whether the picker has been shown before. Bug: 1063856 Change-Id: Ia35a3b2212b3811ed592d81fa516bc1ffc07accc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598848 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Peng Huang authored
* Fix tiling problem in OutputPresenterX11 * Do not handle IdleNotify event, since we will always wait on the x11 fence before reusing the buffer. Bug: 1153156 Change-Id: I308e9f7346c8fea5ba5939e4c3fe17b733e7e535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596104Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840597}
-
Robbie Gibson authored
When the thumb strip is in peeked state (horizontal tab thumbnails), switching tabs should not close the thumb strip. Bug: 1155211 Change-Id: I8b6e7312af391538dbea155a10433e8ade9d01fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600983 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840596}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609912549-c91a8fa5efe894cd1dbcbf24f242fd8e4fea7dac.profdata to chrome-linux-master-1609934346-e8075e70051f1cf5498240cc23c791e5411fb4de.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I613b247379325e578df949111ba1e50e6797eb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611880Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609912549-27b0371d28f026dcf49b02c005becd8eabbb3dbd.profdata to chrome-mac-master-1609934346-5c74c9288bb90a2547279b7951f6e0eb771b0f27.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic166f33b3cd934c7f9556b6066553a0e633fbf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611879Reviewed-by:
-
Ben Mason authored
This reverts commit 2a3f2a4e. Reason for revert: Suspected build failure: crbug.com/1163418 Original change's description: > Not link ANGLE statically on Android for stable and beta channels > > Bug: 1161513 > Change-Id: Ia0a82f44b878dbcb7589a2aec9ec597ff517660b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600390 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840191} TBR=penghuang@chromium.org,zmo@chromium.org,kbr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: If804b48a0b27fe6873fcdeafa3ca7530027348a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1161513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610922Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#840593}
-
Stephen Nusko authored
This reverts commit 30d16f41. Reason for revert: crbug/1163513 android perf build is broken due to missing module six. Original change's description: > Roll Catapult from de6e3a9d85af to 6c876045de14 (1 revision) > > https://chromium.googlesource.com/catapult.git/+log/de6e3a9d85af..6c876045de14 > > 2021-01-05 jbudorick@chromium.org devil: make devil_env_test pass under py3. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/catapult-autoroll > Please CC matthewdeluca@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:1007101 > Tbr: matthewdeluca@google.com > Change-Id: I2e0359bddda1f8287cfd881439299926ad0fc2e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611890 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#840364} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,matthewdeluca@chromium.org Change-Id: I85025d04a0f56ef302e06b658a2da6c66a9ff61c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1007101 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612520Reviewed-by:
-
Alexander Surkov authored
Allow scripts to be used from accessibility dumptree tests Bug: 1136957 Change-Id: I3d2a1e0fcd1a69266455062b462124fb7b7b3245 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597000 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840591}
-
Ewann authored
This CL deletes SettingsMultilineDetailCell and replaces its occurrences with SettingsImageDetailTextCell. Bug: 1153313 Change-Id: I11f8940b7899adc1df43c41e809be731df21f400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612945 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609912549-501f8e0b1fb8f960dee14203abdc5f5559a20bab.profdata to chrome-win32-master-1609923503-082d3636d9b7f0ebc97af69fa1fe05452441e219.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie47b0928cde1afc88cdea48bbfed0c9c0b7d3a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612822Reviewed-by:
-
Nohemi Fernandez authored
Fixes a bug where the unified consent screen is not dismissed when interrupted by a Siri search on the Recent Tabs page. - Performs complete view controller cleanup on interrupt. - Dismisses UnifiedConsentViewController when explicitly required. - Does not explicitly release SigninCoordinator in scene controller, this is already handled in the completion callback. Bug: 1115997 Change-Id: Ib4663fe1136a394020020abc76969761c5e0f170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600835Reviewed-by:
-
Benoit Lize authored
Some PartitionAlloc crashes are likely due to freelist corruption. PartitionAlloc has two types of freelists: in the central allocator, and in the thread cache. The central allocator one already has a DCHECK() to verify that subsequent entries belong the same superpage, which doesn't hold for the thread cache freelists. This CL: - Makes these crash lead to a NOINLINE function - Add an interity check to all freelists. This is not meant to be a security mitigation, but to prevent against accidental issues. Bug: 998048 Change-Id: I21aedfe2b6363069362514a8edd6cd5bdea1acfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582218 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#840587}
-
Benoit Lize authored
The issues seen on Windows (see crbug.com/1155905) also happen on Android, so disable it everywhere. Keep it for DCHECK() builds to investigate the root cause, which hasn't been identified. Bug: 1155905, 998048 Change-Id: I4d8bf3c6af3e745b5956a0a12413899c2e1c4056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612966Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9a1b53d2809..4dde23fea599 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I541760809ef52741b735aab5266004a578c33c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613005Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cfc9da2f6195..8a3bba16ba86 2021-01-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-06 jacktfranklin@chromium.org Fix sub menu context menu interaction tests on Mac 2021-01-06 dnlbellfield@gmail.com Fix text overlap in Settings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I468701655768383d8040f67cbfe99d2022dc6ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611614Reviewed-by:
-
Stephen McGruer authored
This rolls up to SHA d3ce095fcc6b5a85e6056fdebbf939caf2e2719f This also cherry-picks 0dd83ea7, as the upstream version has still not landed. Bug: None Change-Id: I36c86cd06acb2a37e6a0521bc437cac2044db25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611924 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#840583}
-
Monica Basta authored
This CL does the following: 1. Specify height for product logo which avoid a shift down on page first render. 2. Specify max width for the title and subtitle. 3. Add margins to the profile card menu. This is necessary for the box shadow on item focus to be fully visible. Bug: 1063856 Change-Id: I0546a719df76b1aba6b717e5965a97211564150e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611089Reviewed-by:
-
arthursonzogni authored
Due to a bug, CSP embedded enforcement was ignoring the whole CSP directive when it contained one using the sandbox directive. This patch trivially fix it. This is intented to be merged into M89 This patch also adds many tests for the documents: 1. initial empty document 2. about-blank 3. about-srcdoc 4. data-url 5. blob-url 6. same-origin 7. cross-origin (1)(2)(3) are failing, because of https://crbug.com/1163174 Bug: 1163108,1163174 Change-Id: I888ab01009ae914809680451beee37c69b12734f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611264Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840581}
-
Patrick Brosset authored
We are removing the cssGridFeatures experiment in DevTools (the feature still exists, it is no longer an experiment). 2 web tests need to be modified to ensure relevant grid-related cases are taken into account. These cases were previously removed in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2418315 Bug: 1162894 Change-Id: Ic0cfad3581590326feccd58d54e3d74eeea0dcd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608663Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840580}
-
