GitLab

This CL makes the empty view to be a simple TextView with compound
drawable, instead of a linear layout that nests a textview and an image
view.

BUG=NONE

Review-Url: https://codereview.chromium.org/2343383002
Cr-Commit-Position: refs/heads/master@{#419600}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b496036ace04eed39f864147805cba03d9f40c71 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/e465667e78b3f898f25b64a3ec4f5c003f7554e7 bot_update: add --auth-refresh-token-json passthrough for apply_issue (hinoka@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=642150

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2346413002
Cr-Commit-Position: refs/heads/master@{#419599}

Revert of Always use valid enum values in gfx::ColorSpace (patchset #3 id:40001 of https://codereview.chromium.org/2338213009/ )

Reason for revert:
broke build:

https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Release%20%28AMD%29/builds/17323

DCHECK failure:

[29864:20227:0919/143752:FATAL:gfx_param_traits_macros.h(19)] Check failed: (static_cast<int>(value) >= static_cast<int>(0) && static_cast<int>(value) <= static_cast<int>(gfx::ColorSpace::PrimaryID::LAST)).
0   Chromium Framework                  0x0000000107a6caf3 _ZN4base5debug10StackTraceC1Ev + 19
1   Chromium Framework                  0x0000000107a8eb17 _ZN7logging10LogMessageD2Ev + 71
2   Chromium Framework                  0x00000001090ac690 _ZN3IPC11ParamTraitsIN3gfx10ColorSpaceEE5WriteEPN4base6PickleERKS2_ + 96
3   Chromium Framework                  0x000000010909096e _ZN3IPC11ParamTraitsIN2cc20TransferableResourceEE5WriteEPN4base6PickleERKS2_ + 270

Original issue's description:
> Always use valid enum values in gfx::ColorSpace
>
> As a bonus, we get warnings if you add a new enum value without
> updating gfx::ColorTransform.
>
> Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
> Cr-Commit-Position: refs/heads/master@{#419552}

TBR=sandersd@chromium.org,ccameron@chromium.org,hubbe@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2352903002
Cr-Commit-Position: refs/heads/master@{#419598}

BBC recommends simply using gamma 2.4 when displaying HLG content on non-HDR.

Review-Url: https://codereview.chromium.org/2355633002
Cr-Commit-Position: refs/heads/master@{#419597}

We are not guranteed a mouse motion event before receiving a button
event, which can lead to clicks at the wrong location.
This CL makes sure that button events will report any location and
pointer changes before generating the button event.

BUG=645576

Review-Url: https://codereview.chromium.org/2342413002
Cr-Commit-Position: refs/heads/master@{#419596}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/9cc146d974a9814686e25baf7d6dbe4afeab708a Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/e4abcee60eea8f5a1bc81ddee64d44f847066224 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/f7ada90c926c78704f048767e29e8ae836d8a65b Prefer overridden dependencies. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2351073002
Cr-Commit-Position: refs/heads/master@{#419595}

Changes the datastore push logic to use the new gcloud
datastore client library.

BUG=646877
R=rdevlin.cronin@chromium.org
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2352813003
Cr-Commit-Position: refs/heads/master@{#419594}

PostmortemReportCollector handles the collection of stability reports,
their packaging to minidump format and registration to the Crashpad
database for reporting.

BUG=620813

Review-Url: https://codereview.chromium.org/2339193003
Cr-Commit-Position: refs/heads/master@{#419593}

This still fails on Windows official builds.
This is in lieu of reverting all of https://codereview.chromium.org/2354633002

TBR=dimich@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2356603002
Cr-Commit-Position: refs/heads/master@{#419592}

https://pdfium.googlesource.com/pdfium.git/+log/b12fbddece43..c6c2e36f59f5

$ git log b12fbddec..c6c2e36f5 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 tsepez Remove CPDF_Object::Destroy { delete this; }
2016-09-19 art-snake Fix "heap use after free" bug.
2016-09-19 kcwu Add fuzzer for fax codec

BUG=647612

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2350993002
Cr-Commit-Position: refs/heads/master@{#419591}

https://chromium.googlesource.com/skia.git/+log/613664b1bc64..304e6745dc5e

$ git log 613664b1b..304e6745d --date=short --no-merges --format='%ad %ae %s'
2016-09-19 rmistry Reland of Run SVGs through nanobench on all Perf bots (patchset #1 id:1 of https://codereview.chromium.org/2348563003/ )
2016-09-19 egdaniel Create GrVkCopyPipeline class
2016-09-19 reed remove dead code around SK_ENABLE_CLIP_QUICKREJECT
2016-09-19 mtklein Add FrameworkDefs bot to the CQ.
2016-09-19 hinoka Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil
2016-09-19 bungeman Split SkFontConfigInterface globals and factory.
2016-09-19 csmartdalton Add adb support to skpbench

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2356523003
Cr-Commit-Position: refs/heads/master@{#419590}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bb8206eeece0eb7ec7dfa832535a0f1a5a56c500 Remove package build step from dart recipes (whesse@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2352713003
Cr-Commit-Position: refs/heads/master@{#419589}

Inspired by https://codereview.chromium.org/2347973002/ .

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2349213004
Cr-Commit-Position: refs/heads/master@{#419588}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/4654e248929bffb7eee1df0ba851f608dbe6eee1 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/8cde6a2835f03e5bf18e1bd8e84e8421dc206495 Revert of Changed sequence of package_build step (patchset #2 id:20001 of https://codereview.chromium.org/2335383002/ ) (dtu@chromium.org)
depot_tools:
  https://crrev.com/8ea74908a6b6f9ec1ab1a8333d40b54cef0f6f19 depot_tools: Remove third_party/gsutil (hinoka@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=645662

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2351013002
Cr-Commit-Position: refs/heads/master@{#419587}

Speculative fix for crasher in RenderWidgetHostViewGuest::
OnSwapCompositorFrame(), in case it is caused by guest_ being null.

BUG=646736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2346863004
Cr-Commit-Position: refs/heads/master@{#419586}

Since the GYP files have been removed, the "GYP version" annotations above
targets can be removed.

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2356543002
Cr-Commit-Position: refs/heads/master@{#419585}

Since the GYP files have been removed, the "GYP version" annotations above
targets can be removed.

TBR=dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2351003002
Cr-Commit-Position: refs/heads/master@{#419584}

Plus add TODO for https://bugs.chromium.org/p/chromium/issues/detail?id=647892

BUG=630498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2346973004
Cr-Commit-Position: refs/heads/master@{#419583}

Since the GYP files have been removed, the "GYP version" annotations above
targets can be removed.

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2350843003
Cr-Commit-Position: refs/heads/master@{#419582}

This CL is part 1 of 3 CLs to implement ephemeral toolbar icon for media router:

1. Implement MediaRouterActionController (this CL)
2. Show ephemeral icon for active local routes and issues [1]
3. Show ephemeral icon for open dialog

The icon will be shown when the "always show icon" setting is on, or there is a local media route, an unresolved issue, or an open dialog. The MediaRouterActionController will be responsible for telling the ToolbarActionsModel to show/hide the MR icon.

MediaRouterUIService is a KeyedService (a per-profile instance) that owns MediaRouterActionController.

These CLs are a redesign of a previous CL [2], which has been reverted for its bugs.

[1] https://codereview.chromium.org/2332693003/
[2] https://codereview.chromium.org/2155293002/

BUG=594577

Review-Url: https://codereview.chromium.org/2294973002
Cr-Commit-Position: refs/heads/master@{#419581}

DoesLeafDrawContents in content_layer.cc traverses the tree to check if
the content layer for a tab will draw content. Currently if a layer
hides itself and its subtree, but has a descendent which draws content
and does not have a background color set, it would assume that the
layer will draw. This is wrong since if the layer hides it subtree then
its children will never draw.

How did this manage to cause the peculiar bug in the tab switcher?
Before http://crrev.com/2133873004, the RenderWidgetHostViewAndroid
would hold a SurfaceLayer with the frame from the renderer. When the
view is hidden, it would SetHideLayerAndSubtree on this layer, and
since the layer was the leaf node, DoesLeafDrawContents would correctly
identify that the tab's layer does not draw content. This is important
since in ContentLayer while we attach both the live and static layer
for a tab, the static layer's opacity is left 0 if the content layer
draws.

After this change, the DelegatedFrameHostAndroid holds a layer which is
a container for the SurfaceLayer. When the RenderWidgetHostViewAndroid
is now hidden, it hides this container layer instead. This causes
DoesLeafDrawContents to incorrectly assume that the tab's content layer
will draw.

The reason why we see a momentory black flash is that when a tab is
hidden, we enter the state above. But in the meanwhile, the now
visible tab receives its first frame from the renderer. This will cause
the RendererFrameManager to ask the invisible tab to evict its frame.
When this happens the DelegatedFrameHostAndroid will destroy the
SurfaceLayer and DoesLeafDrawContents in ContentLayer will now know
that the tab's layer will not draw.

BUG=644159

Review-Url: https://codereview.chromium.org/2352733002
Cr-Commit-Position: refs/heads/master@{#419580}

Simply displays a webpage with "Bluetooth Internals" in the
header and loads associated JavaScript and CSS resources to
verify correct inclusion in browser resources.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2354663002
Cr-Commit-Position: refs/heads/master@{#419579}

Delete the omnibox experiment and launch the new behavior unconditionally.

BUG=369989,468908

Review-Url: https://codereview.chromium.org/2351443002
Cr-Commit-Position: refs/heads/master@{#419578}

This also splits out reload tracking to be from menu (phones)
vs from toolbar (tablets), which is consistent with the other
actions such as download.

BUG=645294

Review-Url: https://codereview.chromium.org/2341593003
Cr-Commit-Position: refs/heads/master@{#419577}

BUG=none

Review-Url: https://codereview.chromium.org/2348083005
Cr-Commit-Position: refs/heads/master@{#419576}

This patch cleans up the web layer impl fixed bounds test a bit to
use less pointers (some of which were leaked).

R=danakj
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2347343002
Cr-Commit-Position: refs/heads/master@{#419575}

future skia CL that will migrate to specialized type for clipops : https://codereview.chromium.org/2355483002

BUG=skia:3191, skia:5773

Review-Url: https://codereview.chromium.org/2355583002
Cr-Commit-Position: refs/heads/master@{#419574}

The scheduler uses timing history (and other inputs) to decide if it
should try to recover latency.  This makes some tests dependent
on timing in terms of whether the scheduler will ever send a begin
frame (or not, if it's trying to recover main thread latency).  In
some cases, this also can cause a live lock in tests where the
scheduler is waiting for activation to send a begin frame and the
activation is waiting for a begin frame before it lets itself finish.
This has been fixed in the past by just making the tests tick quicker,
but that's not very future proof.

So, in order to make cc tests more robust, add a setting that disables
all latency recover in the scheduler.

R=brianderson@chromium.org
BUG=632544

Review-Url: https://codereview.chromium.org/2354673003
Cr-Commit-Position: refs/heads/master@{#419573}

[OfflinePages, NetworkQualityEstimator] Use NetworkQualityEstimator to decide on triggering Background Loading immediately.
Defines a NetworkQualityEstimator interface, plumbs it into Offline Pages RequestCoordinator, and uses it in logic to determine immediate StartProcessing.

BUG=647724

Review-Url: https://codereview.chromium.org/2347783003
Cr-Commit-Position: refs/heads/master@{#419572}

This is the part of preparation to DIP scale change
processing. These parameters are converted from DIP
to pixels but never used.

BUG=620929

Review-Url: https://codereview.chromium.org/2347373002
Cr-Commit-Position: refs/heads/master@{#419571}

The auto-rebaseline bot failed to update the affected tests so they were updated manually.

see https://bugs.chromium.org/p/chromium/issues/detail?id=262679#c30

BUG=262679

Review-Url: https://codereview.chromium.org/2345183003
Cr-Commit-Position: refs/heads/master@{#419570}

1. Enable SearchEngineTabHelper on Android to auto-detect and fetch OpenSearch description document.
2. Add native function to retrieve recent visited search engines.
3. Allow recent visited search engine to be selected as default search engine.

BUG=348360

Review-Url: https://codereview.chromium.org/2349473002
Cr-Commit-Position: refs/heads/master@{#419569}

Adds some missing dependencies, converts some to public.

Adds a chrome_dll_resource target and move all direct includes of this header to this target.

Review-Url: https://codereview.chromium.org/2354633002
Cr-Commit-Position: refs/heads/master@{#419568}

BUG=646238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2350103003
Cr-Commit-Position: refs/heads/master@{#419567}

BUG=634525
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

patch from issue 2354483002 at patchset 1 (http://crrev.com/2354483002#ps1)

Review-Url: https://codereview.chromium.org/2354693002
Cr-Commit-Position: refs/heads/master@{#419566}

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.6.

This CL is a step towards being able to reuse the classes VideoCaptureDeviceClient
and VideoCaptureBufferPool as part of the Video Capture Mojo Service, because they
implement functionality that is needed there. Expressed in class-diagram form, we
want to go from [2] to [3].

Currently, the classes VideoCaptureDeviceClient and VideoCaptureBufferPool live in
content/browser/renderer_host/media. Even though their functionality is not specific
to renderer_host, their dependencies create a tight coupling to code that is. In order
to use them in services/video_capture, we need to move them out of there (and probably
into media/capture/video).

In this CL we break the tight coupling by extracting interfaces and having the two
classes depend on the abstractions instead of the implementations.

The class VideoCaptureDeviceClient has a second type of tight coupling, which is that
it knows about BrowserThread and wants to post tasks to the Browser IO thread. We
break this dependency by moving the logic to forward calls to the Browser IO Thread
into a decorator "PostOnBrowserIoThreadDecorator" (using the Decorator Pattern).

No new files are created in this CL. Interfaces will be moved to new files in a new
location in a follow-up CL.

BUG=584797
TEST=This is a pure refactoring. No new functionality. All tests still pass.

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
[2] https://docs.google.com/a/chromium.org/drawings/d/1jgDkxl1WvQCO-zeg87eLh5XkB4RP0wt46xlsB_XFfP8/edit?usp=sharing
[3] https://docs.google.com/a/chromium.org/drawings/d/12yOdum03TP1dL7DmUjPxtAfSo16K8La6GJovSisqyRk/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2308533003
Cr-Commit-Position: refs/heads/master@{#419565}

BUG=628417

TBR=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2300543003
Cr-Commit-Position: refs/heads/master@{#419564}

There are currently two ways a display can be closed in mustash. First,
the NDD can update and indicated the display is gone. Second, when
running off device the user can close the platform window. This CL
unifies the two code paths.

When running off device and the platform window calls
PlatformWindowDelegate::OnRequestClose() the request is forwarded to
PlatformScreen. PlatformScreen then tells the NDD to remove the fake
display. The display configuration will update and the display will be
gone. This allows the same display removed code path to get used in all
cases.

This also fixes PlatformScreen not knowing about the user closing a
display.

BUG=641012

Review-Url: https://codereview.chromium.org/2345043003
Cr-Commit-Position: refs/heads/master@{#419563}

If requesting a desktop site on mobile, Reader Mode will no longer
trigger unless its heuristic is set to ALWAYS_TRUE.

BUG=647086

Review-Url: https://codereview.chromium.org/2342873005
Cr-Commit-Position: refs/heads/master@{#419562}

BUG=chromium:633253

Review-Url: https://codereview.chromium.org/2348233005
Cr-Commit-Position: refs/heads/master@{#419561}