- 03 Dec, 2019 40 commits
-
-
Jian Cai authored
Add the flag so we can turn on pattern initialization from https://reviews.llvm.org/D54604 in the future. Bug: 966551 Change-Id: I631bd71f5e1da553ec7a9e480537adc8573d1047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835027 Commit-Queue: Jian Cai <jiancai@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#721174}
-
Ahmed Mehfooz authored
This will ensure the focus ring is visible with it's full thickness. Bug: 1015348 Change-Id: I8d618d3b39b7a4cb48e709eb541f70c10a71573f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947641Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721173}
-
Daniel Hosseinian authored
constexpr variables must be initialized and computed at compile-time, unlike their const counterparts that can defer their initializations to run-time. This change allows for a slight run-time performance boost. Correct a typo by changing the static variable kSizeTrasholdUm to kSizeThresholdUm. The use of the variable is limited to printer_description.cc. Change-Id: I4e43df7666570fa37a15e8860a635badbac306e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937253 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721172}
-
Connie Wan authored
Created a TabGroupController interface that lets TabGroup notify the TabStrip (via TabStripModel) of changes to its contents and visuals. The TabGroupController interface splits out the event handling for tab groups -- I created a family of observer notifications that handle creation, modification, and deletion as separate events on tab groups. Next step (Part 3) would be to create a TabGroupViews class that would simplify the various maps being kept in TabStrip (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip.h?rcl=74a75649aa028187ccde250a98c23d324d9f9728&l=636,639). I also still want to look into removing the TabStripController APIs like ListTabsInGroup, since I was able to remove some of the references in TabStrip by splitting out the event handling. Change-Id: I9334b0e66be3053fdfffd8b77a32b9e4f3ef83c6 Bug: 940677 Change-Id: I9334b0e66be3053fdfffd8b77a32b9e4f3ef83c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918715 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#721171}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22e4696f2435..84e94841f5ea Created with: gclient setdep -r src-internal@84e94841f5ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iec0733a8e65f138e5c6b6f7bf543d5f9ff986ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949167Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721170}
-
Shakti Sahu authored
When ephemeral tab is gone, we should destroy the WebContents. Earlier destroy was called when the sheet is hidden, which causes an issue if we go to tab switcher and come back to the same tab. This CL moves it to the onSheetContentChanged method, which is a better way of knowing if the sheet has been closed. Bug: 1029291 Change-Id: I1008355aa9ed4fc407f4d827ab3d0eecf2cc98b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949079Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721169}
-
Lei Zhang authored
The code that interacts with plugin code in these files are already guarded with BUILDFLAG(ENABLE_PLUGINS), but the headers are not. Fix lint errors about duplicate #includes along the way. Bug: 1027360 Change-Id: Ida542b2b6817cd7a81c3522f2652cb9c7be3935b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930103Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721168}
-
Joon Ahn authored
Instead of hiding attach-error on fileSelect callback, hook onto the click event to clear out attach-error before fileselected callback is called. This will reannounce the alert as needed. BUG=chromium:1020047 TEST=ChromeVox on ChromeOS. Verify by choosing files over 3mb over and over. Change-Id: I2e41d61c1bc226573a4cc1a30f675b5a6693c486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936763Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#721167}
-
Roger Tawa authored
TBR=xiyuan@chromium.org Bug: 1030393 Change-Id: Ia1255af64bc57ef0bd5d9a43fc781c1a79cf07f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947460Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
This reverts commit f3e4b94f. Reason for revert: This broke tast.arc.VirtualDesks tests which makes use of the automation API to verify the window tree. BUG=b/145555421 Original change's description: > Avoid cycle in Accessibility tree > > This is a temporary fix. By ignoring the node when it is invisible, we > avoid navigating the cycle repeatedly. However the underlying issue > is not addressed, and requires further investigation. > > Bug: 1020733 > Change-Id: I70334259b4f271256f21dab47271f7a8346f1f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919434 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717755} TBR=dtseng@chromium.org,anastasi@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1020733 Change-Id: I94cbac6cc42289eee336a0dca7c85452bf7ec4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947638Reviewed-by:
-
Michael Spang authored
This is already in use as evidenced by the build failures in https://chromium-review.googlesource.com/c/chromium/src/+/1918654. Enable it so the //ui/views build file can verify toolkit_views=true, which will help diagnose invalid dependencies on platforms that don't intend to use views (such as Chromecast Android). Bug: 1021770 Change-Id: Iefef6bf25f26d50ac6e871bc17c96b1ba74b3c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946850 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#721164}
-
Roger Tawa authored
This reverts commit 576773e7. Reason for revert: This broke the compile on win32-archive-rel when writing the policy template for german. There were two CLs that touched policies in the same build: this one and another: https://chromium-review.googlesource.com/c/chromium/src/+/1925190 The latter CL was speculatively reverted first but the compile error still happened. Now reverting this CL. Original change's description: > Printing: Make Background Graphics policies not ChromeOS-specific > > Bug: 943746 > Change-Id: Ic54edc8c0475aa1c31ce59b092e356a28ffbc743 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937170 > Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721125} TBR=poromov@chromium.org,rbpotter@chromium.org,nikitapodguzov@chromium.org Change-Id: Iab3be8f858df88f8943da1d05caa57685355789d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 943746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948088Reviewed-by:
-
Dana Fried authored
When in keyboard accessibility mode, with a tab keyboard-focused, pressing CTRL-LEFT or CTRL-RIGHT moves a tab left or right; holding SHIFT as well moves the tab first or last. On Mac, since CTRL keys are used to do things like swapping workspaces we now instead use combinations with the CMD key. Bug: 996850 Change-Id: I08443c066f6998eb4bfff3fea7ab5be56b005d43 Fixes: 996850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949205 Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#721162}
-
Yi Gu authored
cc::ScrollTimeline::ScrollDirection uses different enums from the spec because it does not know about the writing modes. Adding comments to reduce ambiguity. Bug: None Change-Id: I1f9bf443df42d52a1a5bd9960423d2fa94d4f565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949113 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#721161}
-
Mike Dougherty authored
This reverts commit 4b14f5d8. Reason for revert: The following tests are failing, please investigate and run on ios-simulator-noncq bot to test eg2 tests. SigninSettingsTestCase/testSignInPromoWithWarmStateUsingSecondaryButton SigninSettingsTestCase/testSignInPromoWithWarmStateUsingPrimaryButton Failure can be seen here: https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/6352 since build #6346 Original change's description: > [iOS][eg2] Convert signin settings EG tests to EG2 > > This CL adds all signin settings tests to EG2 target > and updates headers and adds eg2_test source_set in > build file. New app interface for signin settings > tests is being introduced. > > Bug: 987646 > > Change-Id: I6d888342c059b8b1767e910697b3f4d1a9b483e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903192 > Commit-Queue: Nazerke Kalidolda <nazerke@google.com> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Auto-Submit: Nazerke Kalidolda <nazerke@google.com> > Cr-Commit-Position: refs/heads/master@{#720941} TBR=eugenebut@chromium.org,stkhapugin@chromium.org,nazerke@google.com Change-Id: I8753c7aefeb7fed69c092ad3519ed412b7e10856 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948086Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721160}
-
Ian Prest authored
This change forces NVDA/Jaws to read the entire live-region whenever it is updated, regardless of whether the text is actually different. These ATs perform synchronous, in-proc callbacks to get_newText, so the end result is accomplished by forcing get_newText to return the entire text chunk. This change has no effect on Narrator, which isn't hosted in-proc. Narrator *does* listen for the LIVE_REGION_CHANGED message (via the MSAA->UIA bridge), but it appears to be doing its own change-detection internally to prevent repeated messages from being read. Bug: 863375 Change-Id: I073f06c2b514cf3332f8cf141229130fe223d60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817215 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#721159}
-
Manu Cornet authored
This is a pure refactor/rename, with no expected behavior change. Prepared with help from grep and sed! Change-Id: I448f95cd9d5dbedb5b94943b3704e065a21728db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947628Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 1029866 Change-Id: I0458d5ac48be2d32d5cfb78c75c8f5fe2c72758c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939966Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721157}
-
Peter Boström authored
IconLabelBubbleView::AnimationEnded used to call GetInkDrop()->SetShowHighlightOnFocus(true) to restore the original InkDrop highlight state before this change. This is incorrect as the initial highlight focus depends on the presence of a focus ring. This changes the call to restore highlight-on-focus based on the presence of a focus ring instead of unconditionally highlighting. Bug: chromium:1025152 Change-Id: I5e6d563bc012a16a5bf4a63404375c4d4d1418e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949034 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#721156}
-
Ahmed Mehfooz authored
Changing the node role to kGenericContainer so that accessiblity focus moves through all child elements. Bug: 1009705 Change-Id: I7193521707d747fcc5e7a4b1b1c45da6b569a64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947191Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721155}
-
Mitsuru Oshima authored
Bug: 1947193 Test: covered by unit tests Change-Id: I56603f8a4664aa6941f9e1e8bcd56a7464392a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947193 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Jared Saul authored
The following changes have been made at the request of Chrome Privacy: - Closing promo bubble now gives 3 strikes instead of 2 - Declining main bubble now gives 6 (max) strikes instead of 3 - Accepting main bubble now gives 6 (max) strikes instead of 0 - As a result of the above, there is now no reason to add strikes for having deselected cards on the main dialog - Strikes no longer expire after 1 year Change-Id: I57c80fb94f120b9132b7f129d8e20996821de35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931652Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#721153}
-
Justin Cohen authored
Bug: 619982 Change-Id: I504c62ff7c2fc9d4cb2f2197d39425ba6aa97cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932167 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#721152}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b6b7e7b6c8de..c694627157f2 git log b6b7e7b6c8de..c694627157f2 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 herb@google.com Don't draw strikes that are too small 2019-12-03 mtklein@google.com remove SkColorSpaceXformSteps::Required 2019-12-03 kjlubick@google.com [skottieWASM] make sure we are using CPU or GPU correctly 2019-12-03 fmalita@chromium.org Reland "[skottie] Remove defensive seek(0) from Animation ctor" 2019-12-03 mtklein@google.com replace CSXformSteps::Required() in GrSurfaceContext 2019-12-03 mtklein@google.com Fix sprite blitter choice logic 2019-12-03 mtklein@google.com replace CSXformSteps::Required() in SkShader 2019-12-03 mtklein@google.com add friendly new ctor for xform steps 2019-12-03 jvanverth@google.com Some more tweaks to perspective path clipping 2019-12-03 fmalita@chromium.org Revert "[skottie] Remove defensive seek(0) from Animation ctor" Created with: gclient setdep -r src/third_party/skia@c694627157f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029831 Tbr: bsalomon@google.com Change-Id: I9ca41f472ee2a7964cba3cd289a2028f104090a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947978Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721151}
-
chrome://device-logMartin Kreichgauer authored
This helps with reasoning from the logs whether an outstanding CTAP2 request was cancelled, e.g. by sending CTAPHID_CANCEL. Change-Id: I3c93cbd399a074f03821cebcfa2825b6d96b3f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949037 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#721150}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a61151f11cbe..d006a8572a47 git log a61151f11cbe..d006a8572a47 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 crouleau@chromium.org [Telemetry] Only find relevant browsers on Android. Created with: gclient setdep -r src/third_party/catapult@d006a8572a47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1030053 Tbr: sadrul@google.com Change-Id: Ia1e4cdd3a59d92c5fd012da8a994bd12f81ffdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947981Reviewed-by:
-
Megan Jablonski authored
This makes sure it is updated for same language translations as well as if the user changes it via the UI. If the user opens the UI on the same page load, their changes via settings are now there rather than reset to the original values. Bug: 976352, 1024512 Change-Id: I1bafea9e8f95267d2388590b194d82996ad3d206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940560Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#721148}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5030e7a4a8f032987f23396f35a598fcbb8f5e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947980Reviewed-by:
-
Fei Ling authored
In fact we already detect whether the mouse is in the resize control. The problem is that the cursor is always set to the pointer cursor in this case. What we should do is to change the cursor depending on the value of the resize style. Bug: 942017 Change-Id: I4205c85627afbad8f59bd85784d4f34046621a9b Fixed: 942017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944315 Commit-Queue: Fei Ling <feiling@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721146}
-
David Bienvenu authored
Use .find to determine if hwnd is a root window in root_window_hwnds_occlusion_state_ instead of iterating through it. Bug: 1029842 Change-Id: I6e2fb476635e0479355983a07149ec7d85149f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949026 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#721145}
-
David Black authored
Previously the rich entry point HTML had been stubbed on the client, but now it is retrieved from the headers of the HTTP response. Eventually this endpoint will migrate to be GRPC/proto based but as of now we rely on passing metadata via response headers. Bug: b:145056104 Change-Id: Ic454a955912d80d916c16f1b26523cd02b202d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949108 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
Bug: 1030357 Change-Id: I04d43c5c4fd65d5050e7dd5b2162b2d82a7b7340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949109 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#721143}
-
Anqing Zhao authored
In Chrome OS, the client id and dm token are generated and maintained in cloud_policy_client. Therefore, the SetupRegistration method will be skipped if the operation system is Chrome OS. Related unit tests are changed accordingly. Bug: 1010213 Change-Id: Iaf5da70c226f372bc0f5d125af49de9935d4ceab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940180 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721142}
-
Nektarios Paisios authored
No information as to how to reproduce the linked bug has been provided in the crash reports. Therefore, using two CHECKs as a quick way of gathering more information from the field. TBR=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1022601 Change-Id: Id7ef83bc58e0b41a16f8a0a7df1720c7f2470618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948495Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#721141}
-
Natalie Chouinard authored
Remove feature-specific method from PreferencesLauncher to the class where it's used. Bug: 1029194 Change-Id: I845474b13e67df8d562a661fa916e47ac05e9405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941307 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721140}
-
Takumi Fujimoto authored
This reverts commit d44d94c6. Reason for revert: I think this is the cause for this tree-closing failure: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/7768 Original change's description: > Include compatibility checks when submitting policy_templates.json. > > This will change the presubmit checks for policy_templates.json to > ensure that policy changes are backwards compatible with policies > definitions that have already shipped. > > Bug: 1026330 > Change-Id: If054d2376397432c66d948eaf0d2d42d5db13a0b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925190 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Commit-Queue: Tien Mai <tienmai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721123} TBR=pastarmovj@chromium.org,poromov@chromium.org,tienmai@chromium.org Change-Id: I0ac66ee107a0ad25675e149192b47868653c525c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949265Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721139}
-
Lambros Lambrou authored
Also updated it to deal with _debug_log replies, and other cleanups. Change-Id: I83484acd33df759f02f37d1d6eef6c2300132a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947478 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#721138}
-
Sebastien Marchand authored
These restrictions are not necessary now that most stuff have been moved to //components/performance_manager. Change-Id: I84a93c998e77ef5da01b0b7264f83c5432dba030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947480 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Robert Ogden authored
This test fails and sometimes flakes because the statistics recorder is interfering with the HistogramTester's init, causing no new entries to be populated during the test. Bug: 1002223 Change-Id: Ia7cfe227a5be11c2f8e7826d3377fb6b79952cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946843Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#721136}
-
Alex Cooper authored
This changes pose_reset and input_state attributes that lived on VRPose to instead live on XRFrameData. This de-couples some frame state from VRPose and paves the way for it to be used instead of gfx::Transforms for some entities. Bug: 1017872 Change-Id: I76474845436168a144f929c8cb94bd4a50b15fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945278Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#721135}
-
