- 28 Aug, 2019 40 commits
-
-
Erik Chen authored
Previously, BrowserPlugin was going to the main frame RenderWidget. This assumes that the main frame RenderWidget exists, which in the future will not exist for remote main frames. Bug: 995981 Change-Id: I25b76e4ee9f99c7c0ca60a57088ecf95c99fe2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772485 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#690987}
-
David Bokan authored
This is a small amendment to https://crrev.com/c/1763375. The null check added there should go before the DCHECK. Bug: 997430 Change-Id: Iabdef43de616b6207516b7efff1c6ecd8e81de81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771621 Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690986}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f79bd7c2ef34..2002bac5500d git log f79bd7c2ef34..2002bac5500d --date=short --no-merges --format='%ad %ae %s' 2019-08-28 haddowk@chromium.org [moblab] Enlarge the size of the moblab vm disk. 2019-08-27 saklein@chromium.org Package/GetBestVisible: Add chroot and build target handling. Created with: gclient setdep -r src/third_party/chromite@2002bac5500d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If34424d8cd2c1f58e5d76edec0f2a9280d901dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774037Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690985}
-
Ben Joyce authored
Bug: 896775 Change-Id: I93c45f7a35e9293d52a7014d4033f25b6364fe96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772059Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#690984}
-
Tarun Bansal authored
Navigating to some websites with DeferAllScript enabled for that site could cause a client redirect loop. A previous CL (https://chromium-review.googlesource.com/c/chromium/src/+/1739493) implemented this in a different way but that CL is not mergeable back. This CL alternates it in a different way which also fixes the problem and can be merged back. All the logic is behind a finch parameter and so can be easil turned off using finch. Tested by commenting out the older code. This will also be tested by beta builders using browser tests. Change-Id: Icb1075580d12890fe0ee9e902925eaf212744d37 Bug: 987062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760667 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#690983}
-
Erik Chen authored
This CL adds either DCHECKs or conditionals to all non-test callsites of WebView::MainFrameWidget. This is in preparation for remote main frame WebViews returning nullptr. Bug: 995981 Change-Id: I15b20a3a06da341c8e32c7585da190ac6c685012 TBR: tommycli@chromium.org, thestig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769688 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Now special scroll/clip hierarchy is fully handled in property trees after launch of BlinkGenPropertyTrees. Previously special properties on cc::Layers were set for special scroll/clip hierarchy, and cc::PropertyTreeBuilder built property trees according to the special properties. Now cc::PropertyTreeBuilder is only for ui compositor which doesn't have special scroll/clip hierarchy. Bug: 994361 Change-Id: I2579fe0ba0dafff6f3640d69ca12540df4c78685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768910 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690981}
-
Dominic Farolino authored
Remove the UseCounter associated with kLinkHeaderStylesheet, as we have sufficient data on the feature. See https://crrev.com/c/1710505. Bug: 19237 Change-Id: I95876d4ef4a4b4f8af96c0d1413b3f891c289bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772927Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#690980}
-
Andrii Sagaidak authored
The old message "reset complete" will be replaced with "Reset acknowledged". The old message could have been interpreted as the changes were already applied, when they will be applied only after restart. Also, the message was announced on page load. This PR will fix that. Bug: 997353 Change-Id: I090eb15c71e8af0bfc442327d5bbda5ebb4600e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769676Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690979}
-
Darren Shen authored
TBR=guidou@chromium.org Bug: 998305,998304 Change-Id: I8cbef0a94f5c339c1dceb332b2a81caad233d050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773996Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#690978}
-
Yue Li authored
This cl migrates kAssistantContextEnabled preference from arc_prefs to assistant_prefs. Also updated usages in Assistant Service and ash, removed obsolete methods. Detailed design doc: https://goto.google.com/assistant-prefs Bug: b/110211045 Test: Run AssistantPrefsControllerTest.* in ash_unittests Change-Id: Id1d2bf85be27b1db7af9f94f68566185e69c0b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719830Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#690977}
-
Xiaoqian Dai authored
To be consistent with tablet splitview behavior, we decided to do the same when in overview dragging an overview window to snap to a position that already has a snapped window in place: the previous snapped window will be put back into overview. Bug:991695 TEST: SplitViewOverviewSessionInClamshellTest.BasicFunctionalitiesTest Change-Id: I3411fff3257146bdcd6b4344206a7bbb1fbd6340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765444 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#690976}
-
Andrew Luo authored
Bug: 997759 Change-Id: Ib8130b4c5b606095e98c4eacf1d419e1e1656cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771946 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#690975}
-
Yves Arrouye authored
Bug: N/A Test: N/A Change-Id: I389186132907a4ceb2bfbfe800113bd393517c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773422 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#690974}
-
Xiaoqian Dai authored
Previously it was by design that we don't end overview when opening app list while splitview + overview are both active. But after the discussion in Issue 991390, we decided to follow the current existing behavior and let app list end splitview+overview in this case. Bug: 996869 Change-Id: I15689b5cf61872110254446bdecce3bc3103aca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766090 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Sophie Chang authored
This also does other cleanup around the browser tests. The HintsFetcher test within OGKSBrowserTest is covered by the existing HintsFetcherBrowserTest and the hint cache UMA is now logged only once per code path. Bug: 969558 Change-Id: I989c648ead0106a3527de877f9c069e5050d8fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773957Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#690972}
-
John Budorick authored
Bug: 990454 Change-Id: Id2051e013bc1727ce320f1b5c2c6f0c9d83628b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772388 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690971}
-
Xianzhu Wang authored
They were set by blink before BlinkGenPropertyTrees when cc:PropertyTreeBuilder used them to generate property trees at cc side. Now blink generate property trees directly, so remove them. Bug: 994361, 754339, 993936 Change-Id: I98559a49778ef6f14f96de61f1f6f54ad16631b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767492 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Albert J. Wong authored
This is a simple consistency cleanup that makes it easier to read through all the functions. Bug: 998273 Change-Id: I2c45fe1befcf4bc72a3c92f63854e65e13d7aa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773215Reviewed-by:
-
Erik Chen authored
RenderWidget holds onto a WebWidget. It has two methods GetFrameWidget() and GetWebWidget() which should both just reference the WebWidget. Instead, RenderWidget will [inappropriately] call out to its delegate to get the FrameWebWidget, which the WebWidget should already be. This induces confusion. This CL fixes the RenderWidget's webwidget_internal_ to always be a WebFrameWidget when the RenderWidget is associated with a RenderView. This changes the semantics, as we will never pass a WebViewImpl as a RenderWidget's webwidget_internal_. This has one main side effect -- a remote main frame's RenderWidget will now have a null WebWidget. Change-Id: I930a9c91a88ac05882289df795ed1c4008e146fd Bug: 995981, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766889Reviewed-by:
-
Ken Rockot authored
This changes RPHI::Cleanup to tear down the corresponding IOThreadHostImpl, preventing further IO-thread tasks from being handled by the object. This ensures that no further incoming interface requests will be handled on the IO thread for the RPHI. Specifically the purpose of this CL is to avoid any potential interface binders referencing the host's ResourceContext, which may be destroyed after Cleanup is run. Bug: 997634 Change-Id: I25fb96daebd5b2801bb95189e5715986dc4af88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773403 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#690967}
-
Friedrich Horschig authored
The new borderless icons are based on transparency which works in all places that have a white background. In some dark mode surfaces, some dark icons have nearly no contrast. This looks bad, like shown in the linked bug. Therefore, this CL reintroduces the white backgrounds. The borders are still gone on all surfaces. Bug: 985318 Change-Id: I064b500934b47aecb6321fbacaade461f161c251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771967 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
i Bug: 993746, 860467 Change-Id: I6922f39db47de5c20d01d8eaf42894b8469f2dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773257 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Darren Shen authored
Tbr: kyleju@chromium.org Bug: 856601 Change-Id: I971d50f4f6629d3496e5c70d8ceaf7e1b00543a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772207Reviewed-by:
-
David Black authored
The proactive suggestions service needs locale to support I18N. Bug: b:140108241 Change-Id: I18a651cb61cc1c4bf37eeae95833a9fdc6229f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769684Reviewed-by:
-
Chris Hall authored
Test was failing because the final inlineTextBox element has split into two. The layout of the text on this page is not critical for this test. Using BLINK-DENY-NODE to ignore inlineTextBox elements. R=aleventhal,aboxhall Change-Id: Ib805e7b9d99975eb775eefde67d40c98e96772df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768513Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690962}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/daddc3da9672..ea78a142b81f Created with: gclient setdep -r src-internal@ea78a142b81f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I575483fdde4142de0dad27678da12d77cb33ce72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772432Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690961}
-
David Black authored
Per UX requirement, if the user doesn't interact with proactive suggestions within 15sec, the widget should automatically be closed. Bug: b:139199754 Change-Id: I77d398a4d6d376b2ee3aadf4888da3fb764ee77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772481 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
John Abd-El-Malek authored
It was previously using GetLastCommittedURL but that's not the correct one to use as sky mentioned in https://chromium-review.googlesource.com/c/chromium/src/+/1772123/1/weblayer/browser/browser_controller_impl.cc#62 Change-Id: I1e4e470de6babd43c3d2506d676f907218484730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772645Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#690959}
-
Abhishek Bhardwaj authored
This changed moves device scheduled update checker file to a sub folder called scheduled_update_checker. BUG=924762 TEST=Compile. Change-Id: I7bb5be971524daf32c8e88333f9d9a9354194585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757392 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#690958}
-
Julie Jeongeun Kim authored
This CL converts TrustedHeaderClientPtr and TrustedHeaderClientRequest to new Mojo types. It also updates OnLoaderCreated and CreateWebSocket from network_context.mojom. Bug: 955171, 978694 Change-Id: If288b38aa8efd7d2fd7f76f817ee2434e10e9edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767298Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Kurt Catti-Schmidt authored
GetUnignoredSelection (introduced in crrev.com/c/1691559) introduced a new selection API built on AXPosition. Exposing AXPosition in such a broad way revealed limitations of AXPosition on specific platforms. In particular, ChromeOS doesn't have a BrowserAccessibilityManager, so workarounds were necessary for selection to work there. This DCHECK is another of those exceptions - BrowserAccessibilityManager isn't available on ChromeOS, so the DCHECK is too aggressive to be a universal expectation. The callers of the function already handle it returning nullptr, so it's safe to simply return nullptr if there's no BrowserAccessibilityManager available instead of DCHECKing. Bug: 995807 Change-Id: I43d21337ce071045d0653be39e10f5003402675e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773209 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#690956}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 601cc468. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" eaee4be5 "CSS: Consolidate block/inline tests for scroll-margin, scroll-padding" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jrummell@chromium.org: external/wpt/encrypted-media NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5af457a1214a420e67c783bc4912e041eb7bd0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772644Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690955}
-
John Lee authored
Pinned tabs are presented as a grid, with a maximum of 4 tabs stacked vertically. This CL adds placeholder "ghost" tabs to fill in each column where there are not enough actually pinned tabs to fill the 4 spaces. This CL aims to create the placeholders using only HTML and CSS, with minimum JS to avoid keeping track of a dynamic number of placeholders and constantly re-creating and removing placeholders. https://i.imgur.com/0NK8ikk.png Bug: 989131 Change-Id: I511a7f82fbf4480b53a437dae4b6d9445249514a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772227Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#690954}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cde5dea64717..f79bd7c2ef34 git log cde5dea64717..f79bd7c2ef34 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 vapier@chromium.org cros_build_lib_unittest: fix env test after LC_MESSAGES=C tweak 2019-08-27 tcwang@google.com afdo: Rename release-afdo-verify to chrome-* 2019-08-27 yueherngl@google.com drallion/zork: mark paladins important Created with: gclient setdep -r src/third_party/chromite@f79bd7c2ef34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9f8b3af731106474bd51a0d9578c0d77c2a6ba23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769695Reviewed-by:
-
Jimmy Gong authored
- When there is no connectivity, we disable the ability to add a printer and display a message to users. Bug: 993834 Test: browser tests, end to end manual Change-Id: I6f0eb28bcd2df604c8e27e799df239a646d0119a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761482 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690952}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5059864006c0d88f302f4e29d863222db2b228bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772519Reviewed-by:
-
Xida Chen authored
Right now we have places in Blink that uses std::vector<std::pair<std::string, CompositorElementId>, which is exactly the CompositorPaintWorkletInput::PropertyKeys. This CL makes changes to those places, no behavior change is introduced. Bug: None Change-Id: I16b60f258ad54a7ae807d222a2472d9eeedcb67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768894Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690950}
-
Darren Shen authored
Test has been failing for over 50 runs. TBR=alemate@chromium.org Bug: 998330 Change-Id: Ib9c5446d32b1354011407b2b8597655a40159741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772930Reviewed-by:
-
Brian Sheedy authored
Updates the golden images for the VR browser suggestion hovering pixel test, as the order of suggestions was recently changed. TBR=alcooper@chromium.org Change-Id: I943f62372414470a038e4a16633acb3f75e8cfa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773860Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#690948}
-
