GitLab

These both have unqualified usernames but the actual correct email
addresses are at domains other than chromium.org.

Bug: None
Change-Id: If1e1153fa53cd43b24008c43b2892025a74bc554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014103Reviewed-by: Cliff Smolinsky <cliffsmo@microsoft.com>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734056}

Leaving _node set while posting the notification can lead to VoiceOver
re-entering AXPlatformNodeCocoa while the AXPlatformNodeBase it
corresponds to is already being destroyed.

Bug: 1037855
Change-Id: I8ff959998f05821b5f258d32f4a9328cb29d234c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014104Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734055}

This CL marks
org.chromium.android_webview.test.AwAutofillTest#testPageScrollTriggerViewExitAndEnter
and
org.chromium.android_webview.test.AwAutofillTest#testPageScrollTriggerViewExitAndEnter__multiprocess_mode
as flaky.

TBR=michaelbai@chromium.org

Bug: 1033179
Change-Id: I5829718f47165867ac1041bf8d24e972f55f1948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014941
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734054}

Today, this mojo call comes from LocalFrameClientImpl::DispatchDidHandleOnloadEvents(),
which used to make sense when RenderFrameImpl::DispatchDidHandleOnloadEvents()
used to send the respective message to content::mojom::FrameHost interface,
and calling observers.

Now that this mojo message got moved from content.mojom.FrameHost to
blink.mojom.LocalFrameHost [1], it seems logical to call it from out
of LocalFrameClientImpl class.

BUG=1043760
R=dtapuska@chromium.org

Change-Id: Ie3917cca5fa687a3d7ede91970321c6d1aa8f3a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014763Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#734053}

https://skia.googlesource.com/skia.git/+log/d59053987a27..b19c78ebad84

git log d59053987a27..b19c78ebad84 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 robertphillips@google.com Add compressed backend textures to Metal

Created with:
  gclient setdep -r src/third_party/skia@b19c78ebad84

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: benjaminwagner@google.com
Change-Id: Icd9a409d1bd0546f8af719acde6f26c8a7d18fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014673Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734052}

https://android.googlesource.com/platform/external/perfetto.git/+log/0a5ac419555b..84dafa149509

git log 0a5ac419555b..84dafa149509 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 ilkos@google.com Merge "Filter empty symbols"
2020-01-22 lalitm@google.com Merge "ui: add global slice tracks"
2020-01-22 buss@google.com Merge "Add link to prebuilt binaries/wrapper."
2020-01-22 fmayer@google.com Merge changes Ie5ab30a4,I3d3577d1

Created with:
  gclient setdep -r src/third_party/perfetto@84dafa149509

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I4835429f5772fa339c316f8fea959f5e6645ff26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014670Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734051}

Using wpt-import in Chromium b6c28694.
With Chromium commits locally applied on WPT:
0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: Ibfbcee6de7585c24153abfc460346d261775cbe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014800Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734050}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/2cdf87411246..5f411e4e022c

git log 2cdf87411246..5f411e4e022c --date=short --first-parent --format='%ad %ae %s'
2020-01-22 kimjae@chromium.org build_dlc: Selective preloading of DLC(s)
2020-01-22 mmortensen@google.com Add goma log handling to the Sysroot.InstallPackages endpoint.
2020-01-22 bpastene@chromium.org chrome_committer: Apply CQ+2 during the initial git-cl-upload.
2020-01-22 dhaddock@chromium.org Disable paygen_au on jetstream devices.
2020-01-21 chrome-bot@chromium.org Update config settings by config-updater.
2020-01-21 saklein@chromium.org Build API config: Use a proto-based configuration
2020-01-21 mmortensen@google.com Generate updated sysroot_pb2.py and common_pb2.py including goma fields.
2020-01-21 chrome-bot@chromium.org Update config settings by config-updater.
2020-01-21 jacobraz@google.com flash_ap: update volteer support, linter cleanup

Created with:
  gclient setdep -r src/third_party/chromite@5f411e4e022c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I70ed8739210a48cd3f9c3d465e2b29fa1efa0f1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014672Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734049}

This CL also moves some custom IPH code from ToolbarManager to
ToolbarButtonInProductHelpController.

Bug: 865801
Change-Id: I49ea9a8954c17be39d99e598208a5b4e78f9fa31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995466
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734048}

Test:
BrowserNavigatorTest.ReuseRVHWithWebUI

See bug for falkiness dashboard link and sample failure.

TBR=ellyjones

Bug: 1044335
Change-Id: Ia5c8742a82aa8f750d46f011326a0fa2edeaee24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013756Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734047}

Change viz::Display, viz::mojom::DisplayPrivate, and
viz::SurfaceAggregator to take a gfx::DisplayColorSpaces.

Change Windows' gfx::DisplayColorSpaces to indicate that opaque
HDR content should use PQ, while transparent HDR content should use
sRGB-linear.

On Windows, the decision of which HDR space to use was made both
in display::ScreenWin and in the ui::Compositor. The reason for the
latter is that, when alpha is needed, we cannot use a 10-10-10-2
format, and have to promote ourselves up to half-float. Move this
logic to be in viz::SurfaceAggregator.

This logic will further be updated to dynamically determine if each
RenderPass has HDR or WCG content, and upgrade/downgrade its buffer
format accordingly.

Add tests to ensure the new SurfaceAggregator behavior, and delete
old tests of the ui::Compositor intervention.

Bug: 1037954, 958166
Change-Id: I960a1c247efc5489f1f85ddf32afae68822d67f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008134Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734046}

This CL relands the test portion (web_tests/*) of r1979258, and removes
external/wpt/css/compositing from W3CImportExpectations.

It is marked as No-Export because the tests were successfully upstreamed
to WPT and are not deleted (this is the expected behaviour;
W3CImportExpectations does not affect upstream):
https://github.com/web-platform-tests/wpt/commit/4209d7961bab7dce31baab0918fa9f6dcd74bd8d

No-Export: True
Bug: 1044405
Change-Id: Ie59c35118de96256816fa35f20aca1c10f5759b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013476
Auto-Submit: Robert Ma <robertma@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734045}

Bug: 927509
Change-Id: I40a99ea449f51fa20553a480de18768575290f68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013124Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734044}

When depending on multiple similar proto_library targets, each target
can create its own public_config. In the case of perfetto, this adds up
to about a dozen configs, each adding the exact same include path.

Because gn doesn't eliminate duplicate include paths (crbug.com/gn/142),
these configs end up adding duplicate -I command line flags to build
commands. On some bots, this recently caused us to exceed command line
length limits (see crbug.com/1043279).

This patch adds an invoker argument to the proto_library gn template,
which disables the public_config propgation of the proto_library target
and will allow perfetto to define and propagate a separate
public_config instead to avoid this duplication.

Bug: 1043279, gn:142
Change-Id: Ifa68c164b2b4c631bdaf98f63ba5bf7537e8e166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010860
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734043}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de885c91d53b..afc469d68c53


Created with:
  gclient setdep -r src-internal@afc469d68c53

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1022981
Tbr: jbudorick@google.com
Change-Id: I6e8eb69a8c9af48e7e19726d385356ee6b72913f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014671Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734042}

Tests in SyncAndGooglePreferencesTest start settings activity. So they
should be annotated with @LargeTest and @Feature({"Sync", "Preferences"}).

Bug: 1036314
Change-Id: I459a71041c5350c1d1c1e5b953a205436969f260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002814
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734041}

So that we don't accidentally add new targets that don't set
the variable (which is required for compile deps and wrapper scripts
to work properly).

Change-Id: I8541f2fe83bd7ced7a9d215b415c009abda37468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003568Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734040}

We are in the process of componentizing CaptivePortalService. As part
of this we need to eliminate its sending of a notification: as there
is no enum of notification types in //components and we don't want to
introduce one when notifications have been deprecated for 7+ years.

This CL starts the process of that elimination by introducing the
ability to register for callbacks when CaptivePortalService completes a
query, notifying the callbacks at the same time as the notification,
and porting a couple of initial consumers to validate the approach.
There remain a handful of consumers to be converted.

Bug: 1030692
Change-Id: I2bc682a092fac0c3ab2ebf4b152d6ee62e80d324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010775
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734039}

Extends the life of quota metrics that will be used for analysis
around upcoming storage management changes.

Bug: 997258
Change-Id: I96991c7087dc2ed038c8f4f8295e0e4e3618059f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013022Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734038}

The deprecated TRACE_EVENT_ASYNC* macros have been superseded by
TRACE_EVENT_NESTABLE_ASYNC*.

Updating to the new macros is mostly straight-forward, except in cases
where STEP_INTO/PAST macros were used extensively (ui/latancy doesn't
appear to use any): In those cases, the steps have been converted into
nested sub-events.

Bug: 1038710
Change-Id: Ic9d0c503aff5b0111c958e90c8fee7c7fb075fdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014503Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734037}

The comment does not make sense any more after
https://crrev.com/c/2013046. It should have been removed together with
that CL.

R=jsbell@chromium.org

No-Try: true
Change-Id: I7fcaa85f66377bbefe3527313e7a6f72ddca9a91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014923
Auto-Submit: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734036}

Bug: 955194
Change-Id: I4f269e48f09bebe02faed24de8396b9f67486f71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012940Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734035}

A lot of client code assumes that if a context is lost (which could be
a GPU process crash or an error in the command stream) any resources
created by it will be cleaned up automatically. This is particularly
true for SharedGpuContext where all users hold a weakptr and the object
is destroyed on a context error.

While the above assumption is true for any resources created using the
command buffer (GL/Raster/Dawn) which is per context, its not true for
shared images where the service side ties their lifetime to the shared
GpuChannel for a process. This inconsistency can result in leaking these
images if the client doesn't try to re-create a new context to delete
them. On the flip side deleting a non-existent shared image results in a
fatal error on the service side which tears down the GpuChannel, which
means clients need to distinguish between losing a single context versus
the GpuChannel to know when cleanup is needed making the ownership
management here quite brittle.

This change makes shared image ownership semantics similar to other
resources created using a context by adding tracking for shared images
created using the SharedImageInterface on a particular context. If that
context is destroyed, it internally ensures any associated alive shared
images are destroyed.

R=ericrk@chromium.org

Change-Id: Iaba4b1f791a2c0ed7890d3a593b9f158c152bc7d
Bug: 1042446,1042481,1036142
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006731Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734034}

This reverts commit 68ea97aa.

Reason for revert: Speculative; suspected root cause of Deterministic Fuchsia failures.

BUG=1044617e

Original change's description:
> Move ManifestUpdateManager and ManifestUpdateTask into web_application:common
> 
> ManifestUpdateManager and ManifestUpdateTask are not used outside of
> web_applications and are not isolated components, they should live one
> level up while maintaining independence from the BMO/Extension backend.
> 
> This CL is in preparation to add a dependency from
> ManifestUpdateManager to SystemWebAppManager.
> 
> Bug: 1035242
> Change-Id: I3a5e8e691079619e5b063ac90653dcae6ee3f76f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973441
> Auto-Submit: Alan Cutter <alancutter@chromium.org>
> Commit-Queue: Alexey Baskakov <loyso@chromium.org>
> Reviewed-by: Alexey Baskakov <loyso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733898}

TBR=alancutter@chromium.org,loyso@chromium.org

Change-Id: Ie1a4f075a6515b85effd5c853b82d7daeb2aa7b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1035242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014922Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734033}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=sczs@chromium.org

Bug: 1042208
Change-Id: Ic94da0d49905274b80bf5c5e164dbb98f2936d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007744
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734032}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=sczs@chromium.org

Bug: 1042208
Change-Id: I13fdd8e2da505c318b26b0934a8a73b1bc89e37f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010840
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734031}

Intent: https://groups.google.com/a/chromium.org/g/blink-dev/c/SV8evGSU_dw/m/DIrx9XzvDQAJ

Bug: 1043655
Change-Id: I340ad755fe4a33c566a4374e1f45bc9014f5e2d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010845
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734030}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=sczs@chromium.org

Bug: 1042208
Change-Id: I048c314ac3bdd58c9f871357f677de36c0b772e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010781
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734029}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=sczs@chromium.org

Bug: 1042208
Change-Id: Ia7408640cb544f336e0353da4577c220242f5a91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007817
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734028}

Content's TestLauncherDelegate was doing this, but that isn't
called in all paths and there was a lot of tests setting the
switch as well.

Some tests need to change the value, which are updated to remove
the switch and then set it.

BUG=none
TEST=none

Change-Id: Ia7be97b01eeadd35fba9b31906f120ef58b8e99e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007524Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734027}

This CL fixes ForcedSigninProcessor by marking the sync flow as
completed after a forced sign-in.

Bug: b/146775602
Change-Id: I5ea64edb79a975ff37ec5d19650534b5ac8c2cc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013100Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734026}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4a1aaa1a..3ff3368a

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I88c64605be0d2924b0059a80899d21369cb27dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014780Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734025}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=mathp@chromium.org

Bug: 1042208
Change-Id: I572b636065ae19af26ff57ec90a98a002a5eb381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010767Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734024}

Fixed: 1037321
Bug: 1037321
Change-Id: I2291c0dd3908a095d68a74751a395a5590c0147f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003211
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734023}

Members in stack allocated types issue redundant write-barriers. This CL
provides an option --no-members-in-gc-allocated, which prohibits use of
them.

Bug: 1044611
Change-Id: Icc83756d9a1d6e414a09b705c0f008f9e79c4ae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010986
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734022}

CIPD packages:
  infra_internal/ios/xcode/mac  11c29
  infra_internal/ios/xcode/ios  11c29

Bug: 1041618
Change-Id: I1cdbb3e33e21dc69307a535d63caeae109042951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999545
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734021}

This CL alters viz for WebView BeginFrame handling to use the same
path as without viz. It also implements viz side View.Invalidation
heuristics.

Bug: 805739
Change-Id: I8bb1dd2879f50cdfff0df3a6f75b81e3785a2737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001120
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734020}

According to crbug.com/1043557, we should use blink::mojom::blink::T
or mojom::blink::T in Blink over blink::mojom::T.

This CL replaces all mojom::FeaturePolicyFeature with

mojom: :blink::FeaturePolicyFeature and all mojom::PolicyValueType with
mojom: :blink::PolicyValueType.
Change-Id: I177c6186a1cd14578dd5dfffbf98a1fc7f221247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011171Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#734019}

BUG=None

Change-Id: I5973080c15ffaa50b01a08cc271950e935ba8fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014102Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734018}

Per the JSON specification base::JSONParser aims to follow [1]
(as well as JSON specifications that supersede it, such as [2]),
JSON can encode Unicode non-characters. This patch adds support
for such characters to base::JSONParser so that they can safely
be transmitted via the Chrome DevTools Protocol. Thus, this patch
removes the need for workarounds like [3] that were only needed
due to lack of support.

For symmetry, support for non-characters is added to
base::JSONWriter as well.

Note that although base::JSONParser and base::JSONWriter now
support Unicode non-characters, invalid code points (i.e. lone
surrogates) remain unsupported.

Note that this change impacts JsonSanitizer as well: previously, if
its input contains a non-character, JsonSanitizer would produce an
error. Now, JsonSanitizer successfully generates sanitized JSON in
this case, and as always, this sanitized JSON parses to the same
exact value as the original JSON.

Tests:

    autoninja -C out/Release content_shell base base_unittests services services_unittests
    out/Release/base_unittests --gtest_filter=JSONParserTest.*:JSONReaderTest.*:JSONStringEscapeTest.*:StringUtilTest.IsStringUTF8
    out/Release/services_unittests --gtest_filter=DataDecoderJsonSanitizerTest.Unicode
    third_party/blink/tools/run_web_tests.py -t Release http/tests/devtools/runtime/runtime-evaluate-bad-unicode.js

    autoninja -C out/Android services services_unittests
    out/Android/services_unittests --gtest_filter=DataDecoderJsonSanitizerTest.Unicode

[1]: https://tools.ietf.org/html/rfc4627#section-2.5
[2]: https://ecma-international.org/publications/standards/Ecma-404.htm
[3]: https://chromium-review.googlesource.com/c/1352588

Bug: chromium:848823, chromium:1042269
Change-Id: Ib949425939517d85f1545da9d215dd2d137cedfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002813
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734017}