- 17 Aug, 2020 17 commits
-
-
Koji Ishii authored
This patch checks hyphenation alias first, before trying to open dictionaries. When the `lang` attribute is aliases, this change can reduce one IPC call. Bug: 1116540 Change-Id: I2ffe71a7f7c063238545320b538474e0e03307b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358714Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#798523}
-
Fergus Dall authored
Mark compositing/layer-creation/overflow-scroll-overlap.html as failing on Mac This appears to have been broken by CL:2146093 which won't revert cleanly at this point. TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org Bug: 1069546 Change-Id: I8a72c5e9e4e9d61df0365f4bb6b4158a6a11b9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359317Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798522}
-
danielng authored
Adding lxj to owners for pluginvm-show-camera-permissions and plugin-vm-show-microphone-permissions. Bug: 1106149 Change-Id: Ifcaf168fb48142632098f4ad3206878bc8240880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355359Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Auto-Submit: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#798521}
-
Adam Rice authored
Always resolve tee's cancel promise after stream closes or errors. Applies https://github.com/whatwg/streams/pull/1039 to our implementation. BUG=1114014 Change-Id: Ic6d665bd928553ea3a292fe8221f0812d1c613e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358929Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#798520}
-
Mike Jackson authored
Update AppBannerManagerDesktop::OnWebAppInstalled to use the winning display mode when display_override is set. To test the change use: chrome --enable-features=WebAppManifestDisplayOverride Example websites: https://mwjacksonmsft.github.io/pwa/display-override-custom/index.html (display == browser, display_override == [standard]) Explainer: https://github.com/WICG/display-override/blob/master/explainer.m Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion Bug: 1109520 Change-Id: If0b589f0a19367f01501e2eb52aec16f4f2645cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354665Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798519}
-
Justin Donnelly authored
This preserves the existing behavior where you can focus the omnibox and <text matching keyword><tab key> enters keyword mode. Bug: 1046523 Change-Id: I2e7d380cf31938e056b90b072df54e21e16ad348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346732 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#798518}
-
Dominic Mazzoni authored
This looks better and better matches the mock. Bug: 1108114 Change-Id: I7f31c856bfe66b7d3fb4d4ae277ac633e8517295 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357855 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798517}
-
Peter Kasting authored
* Shorten code * Trivial naming/comment fixes * Use const more * Inline temps * Event::marking_time_in_bytes_per_second() is unused (and actually mis-named); remove * Use TimeDelta::InMicrosecondsF() to get a double Bug: none Change-Id: I324c6d82e04514e2a9105df05b5942eb2cfd9efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359006 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This CL adds kReadOnceStream enum value for fetch upload streaming instead of kChunkedDataPipe. kReadOnceStream means the data is non repeatable unlike kChunkedDataPipe. This is a preparation for "[fetch] Cache request stream body up to 64k bytes." (crrev.com/c/2269622) Bug: 1077174, 688906 Change-Id: I78c45777eb85751b20287bab6e55be0dd3502cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342525 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#798515}
-
David Maunder authored
We now do not allow Tab attributes to be acquired on an uninitialized Tab. We are finding tabs passed to getDomain() are uninitialized so we should handle this. Bug: 1116341 Change-Id: I69510196bf47b2b4939450905552a30ccb536d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358050 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798514}
-
Thanh Nguyen authored
This is a reland of dd116903 The original CL was reverted because mac-arm64-rel was failing. It works fine now. TBR=xiyuan@chromium.org,jiameng@chromium.org,tby@chromium.org,austinct@chromium.org Original change's description: > Using vector icons for launcher search provider > > Currently LauncherSearchProvider use png as the format for the result. > This CL changes the format to vector icons (.icon). > > Bug: 1067326 > Change-Id: I55fb11ed50906a5199bc28339de42d4903433b36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352290 > Reviewed-by: Austin Tankiang <austinct@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Reviewed-by: Tony Yeoman <tby@chromium.org> > Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798087} Bug: 1067326 Change-Id: I3558b2f0b023227d06893eda14b88fe3fe967b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358936Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798513}
-
Sam McNally authored
When initialized incorrectly, some touchscreen controllers can report bogus values for their sizes. Chrome uses the touchscreen area in calculations; if that area overflows a signed 32-bit int, it check-fails. Thus, a misbehaving touchscreen can cause Chrome to crash-loop, rendering a device unusable. Mitigate this by warning about the bogus size and then ignoring the touchscreen input device. A non-functional touchscreen is better than an unusable device. BUG=b:162596241 Change-Id: I9291c176ed778f5ddb8a80d9ea75f17be7bd0554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353973Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798512}
-
Luciano Pacheco authored
The disabled state wasn't applied to disabled button because the selector was less specific. Fixed by adding a rule with "files-ng" to increase the specificity and using the semantic color. FIXED: 1116401 Change-Id: Ib3bb638d82b2bf488eca34894c86c63550ccb63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359590 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#798511}
-
Naoki Fukino authored
When file-type filters in Recents is available, it provides equivalent functionality with media views and they become redundant. We can hide media views to save vertical space in directory tree in this situation. Bug: 1114721 Change-Id: Id4dd9660634560c71eb1a2a8e62879ad3b5206a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358937Reviewed-by:
-
Fergus Dall authored
PasswordManagerBrowserTest.PlaceholderPasswordOverwritten TBR=dvadym@chromium.org TBR=jdoerrie@chromium.org TBR=kolos@chromium.org TBR=mamir@chromium.org TBR=vasilii@chromium.org Bug: 1116886 Change-Id: I24b11647678d1cecefacc98dac6455f2e001399a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359589Reviewed-by:
-
Fergus Dall authored
AddressViewControllerTestCase/testIPadTappingOutsidePopOverDismissAddressController TBR=javierrobles@chromium.org TBR=mahmadi@chromium.org TBR=olivierrobin@chromium.org Bug: 1116887 Change-Id: Ic0af6e48c22db51e49d2e0959c40bfa91e7850d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358935Reviewed-by:
-
Mei Liang authored
This CL adds the release candidate of TabGroups to chrome://flags. It also removes all the old options that are related to changing the thumbnail aspect ratio. Bug: 1116699 Change-Id: I658bdb20383a9169149faf645c3c4b263bed6b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359400Reviewed-by:
-
- 16 Aug, 2020 23 commits
-
-
Fergus Dall authored
This reverts commit 0e1132cc. Reason for revert: Probably broke the Windows deterministic builder, see https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic/17001 for first failure Original change's description: > Roll clang llvmorg-12-init-1771-g1bd7046e-5 : llvmorg-12-init-3132-g95fad44e-1. > > Ran `./tools/clang/scripts/upload_revision.py 95fad44e34c3c20263961a715571d798d90921f6`. > > Bug: 1113154 > Change-Id: I2cbd4533fcedea8acfb6d5f5067e56c7d758d25b > Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng > Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan > Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel > Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng > Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 > Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng > Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 > Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel > Cq-Include-Trybots: chrome/try:iphone-device,ipad-device > Cq-Include-Trybots: chrome/try:linux-chromeos-chrome > Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357413 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798480} TBR=thakis@chromium.org,hans@chromium.org,aeubanks@google.com Change-Id: Ifdc8d2aefe7c8750c9b11c97d17de59c363140df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358934 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
-
Naoki Fukino authored
This is a reland of 4de14608 The CL was reverted as a culprit of a compile error in v8 on win build. https://ci.chromium.org/p/chromium/builders/ci/win-official/356 However, this CL can not affect v8, and it is build only in Chrome OS. Original change's description: > [Files] Add file-type filter buttons in Recents view. > > This adds file-type filter buttons (Audio, Images, Videos) above the > file list only in the Recents view. > Expected behavior: > Users can toggle(enable/disable) file-type filters by clicking it. > Only one filter can be applied at the same time. > Active filter should be cleared when a user leaves Recents view. > > Bug: 1114721 > Test: Manually tested with flag #files-filters-in-recents > Change-Id: I50ecd9c1c2f9a587d63e6ae89f88d6b5fe0cba4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354115 > Commit-Queue: Naoki Fukino <fukino@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798490} TBR=noel@chromium.org Bug: 1114721 Change-Id: Iabaa6b34ec500d020023a77c33948cd683c5a311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358715Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798505}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7dff8b43..4ae1505c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie2e8d664815f2b0acbaf5ccb9d8b2fd7453097d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358953Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798504}
-
phillis authored
Add a CHECK for icon_manager_ before using it in |WebAppShortcutManager:: GetShortcutInfoForApp| to diagnose a crash in this function on MacOS. Bug: 1113276 Change-Id: I55a00abd394c4b3baf0759751b922d0ba2a81f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354906 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f93d7f924e80..384ea8475558 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ic8149d11c5258b8dfc098c5d7b375ad2c967ac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798502}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: Ie29e6422f28d70844351d16ed16237d5e2d6b7a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358032Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#798501}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3342c64d1ba14a2fbd52102162b338ffbcd86857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359361Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798500}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a008b0fa8bbb..7491e8b30f77 2020-08-16 herb@google.com inline routine small routines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I61d394b2b4abb7f808492d8c600f4d95e3c3d797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359360Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c1c3c6d70d32..a008b0fa8bbb 2020-08-16 johnstiles@google.com Enable ClangTidy check readability-redundant-smartptr-get. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: Ibaa795eeddef86731c71d41af568cce611f502c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359454Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, any Android payment app could be used on Chrome OS (when chrome://flags/#enable-web-payments-experimental-features flag was enabled). This patch adds a check that Chrome is running in TWA mode and one of the requested payment methods is supported by TWAs. After this patch, only TWA-specific payment method identifiers can be used with TWA payment apps on Chrome OS. Bug: 1061503 Change-Id: I48573e142d099546b93577e432346674932b3f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302310 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#798497}
-
Maciek Slusarczyk authored
New sync token has to be created on in-session password change. The token received from the sync token API is stored locally. Other user devices detect password update and send user through the online re-auth in order to sync the credentials. Bug: 1090341 Change-Id: I5212ac2094a549dd6ee5ac96aba5d0150781ab86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339977 Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#798496}
-
Peter Kasting authored
This makes it easier to track down and/or change types. Also renames CallbackList -> RepeatingCallbackList. Bug: 1113007 Change-Id: Ib934071a88a991178dee8a99f722770f4e3f3957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354614Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798495}
-
Findit authored
This reverts commit 4de14608. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 798490 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRkZTE0NjA4NGVmNzcyNzI1ZmI2MDRmNGM5MTkyMWM5ZWQ1YzZhY2MM Sample Failed Build: https://ci.chromium.org/b/8871798512306610112 Sample Failed Step: compile Original change's description: > [Files] Add file-type filter buttons in Recents view. > > This adds file-type filter buttons (Audio, Images, Videos) above the > file list only in the Recents view. > Expected behavior: > Users can toggle(enable/disable) file-type filters by clicking it. > Only one filter can be applied at the same time. > Active filter should be cleared when a user leaves Recents view. > > Bug: 1114721 > Test: Manually tested with flag #files-filters-in-recents > Change-Id: I50ecd9c1c2f9a587d63e6ae89f88d6b5fe0cba4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354115 > Commit-Queue: Naoki Fukino <fukino@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798490} Change-Id: I78ec51191bd1ce062f1a5cf06a74baf213a915fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359469 Cr-Commit-Position: refs/heads/master@{#798494}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f1b37b7a9dad..f93d7f924e80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4f8ead0786971feec69ce8e22c22cde45f0f504a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359428Reviewed-by:
-
Hitoshi Yoshida authored
Move definition of use_blink_v8_binding_new_idl_dictionary to t/b/r/config.gni and define a C++ definition. Bug: 839389 Change-Id: I8ebe279ad03af81ceb81a5856119eb3097a379b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358930 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798492}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597556507-5d0b6a058065c766d64fdd0bab871442eca481b8.profdata to chrome-mac-master-1597574780-11032f77f0853e1d71f33728c0242d630bf5af1f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4eeb49ee9b3621da9ffd3eb48169a91f82eb6d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359424Reviewed-by:
-
Naoki Fukino authored
This adds file-type filter buttons (Audio, Images, Videos) above the file list only in the Recents view. Expected behavior: Users can toggle(enable/disable) file-type filters by clicking it. Only one filter can be applied at the same time. Active filter should be cleared when a user leaves Recents view. Bug: 1114721 Test: Manually tested with flag #files-filters-in-recents Change-Id: I50ecd9c1c2f9a587d63e6ae89f88d6b5fe0cba4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354115 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c0263ae980bf..e4e6433497c5 2020-08-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I020aab369be1173dcc39a413406252ea63b07822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359420Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, the Android payment apps installed on Chrome OS would not be available in Web Payment. This patch queries the list of installed Android payment apps and returns all of them to Web Payment, if chrome://flags/#enable-web-payments-experimental-features is enabled. After this patch, the Android payment apps installed on Chrome OS are available in Web Payment. Bug: 1061503 Change-Id: Ifb11741377a0a21166d77c547dbbad21b6daffeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302269 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798488}
-
Matthias Körber authored
This CL grants precedence to the heuristic field type detection if a structured last name type is detected. Change-Id: Ic058b13b641328ed4bc583d786836f71d527dbe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353347 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#798487}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I602a5cb1022cc5aaaa2944833c09d2d53f49e289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359355Reviewed-by:
-
Viktor Semeniuk authored
This change adds default selection style to Password Check Details cell on Passwords screen and to Change password button on Passwords details screen. Bug: 1113816 Change-Id: I7ae74f009e62c9700c4a85480ddf416102e71d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353260Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#798485}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fa79253c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: If86799adfafb1bbd36a3d06b0f4536755fdecac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358575Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798484}
-
