GitLab

Replaces usages of java.net.URI with GURL.

Bug: 783819
Change-Id: I1fbcabd96afaa3b55165f1bcff926d9b31d6a3f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031559
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737377}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I0b52e557c30b657d17bebf51e106b2f1025b6998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031910Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737376}

https://android.googlesource.com/platform/external/perfetto.git/+log/631e93892acf..22ab8b24f234

git log 631e93892acf..22ab8b24f234 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 taylori@google.com Merge "perfetto-ui: Stop selection marker overflowing"

Created with:
  gclient setdep -r src/third_party/perfetto@22ab8b24f234

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I98ad0ac46313a6799b55fa3916256206fdcfe47c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033404Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737375}

The main thing here is to move get_parts into the parts.py.

Bug: 926234
Change-Id: Icf7d9129281ef45438d1dfa27c992c011d0306bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016972
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737374}

TBR=xidachen@chromium.org

Bug: 1047205
Change-Id: I67dac7a120396be9f1b260e1226cc202b9730d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033444Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737373}

Chrome attempts to fire the event on an ignored parent of the text,
and the method returns early. The event needs to be fired on
an unignored ancestor.

Bug: 1041290
Change-Id: I12cda65ec23c8ff3a771da3fe1c29ebf4b8cb0ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015606
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737372}

-Disable the Add button so the user can't save a printer if the
 Manufacturer or Model dropdowns have incorrect values.

Fixed: 950887
Change-Id: I533748488b777eca7ac2329d2cb2e5402cca72be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018093Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737371}

Pull in the latest BuildCompat implementation from androidx-master-dev
and include R in the version list.

Change-Id: I6c6242923d975538364ceb62962215d670902dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031433
Commit-Queue: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737370}

It is possible to now observe changes to content box and border box of
an element that is being observed. However, changes to an element's
content box without a change in its border box can not be observed yet,
and will be addressed in a subsequent change.

Bug: 1042537
Change-Id: I6415fc4f5cec783cc717051c11b2fdd95d3a28e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004051Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#737369}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2cf1247bee6..539e9740e1cd


Created with:
  gclient setdep -r src-internal@539e9740e1cd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1046782
Tbr: jbudorick@google.com
Change-Id: I5d7b964fe8ff296c18983c7fec370a663d6a3be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033121Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737368}

In particular, GUIDs are now validated against the client tag hash (if
available), and all sync metadata is thrown away in situations like
local bookmarks having duplicate GUIDs upon started (theoretically
unreachable).

In order to achieve this, the code is refactored to move some additional
logic into SyncedBookmarkTracker, in particular because the mapping from
local nodes to sync metadata entries must be available in order to
enforce more strict validation logic.

Change-Id: I0e084d2f53a4a5447192f9e3667b70df8630493e
Bug: 978430,1032052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029370
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737367}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/023284c1ce32..3c0114c6399a

git log 023284c1ce32..3c0114c6399a --date=short --first-parent --format='%ad %ae %s'
2020-01-31 robertma@chromium.org Declare tags in expectation files

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@3c0114c6399a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:986447
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iacb9a39d0c27615b18ac506b33d9bbe059274ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033122Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737366}

This change adds a hover button to the new transport selection sheet
that allows the native Windows API to be triggered. This change is
feature-flag protected behind WebAuthenticationPhoneSupport.

BUG=1002262

Change-Id: I709186edb1d73014155b180c5c10fa7d68e46a28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032013Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737365}

Bug: 1020746
Change-Id: I6744bfd35bef56b5edc3c8e0963e3fd8459e7bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032178
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737364}

and other embedders.

There doesn't appear to be any existing tests for this functionality
and I'm not sure how to easily test it.

Bug: 1025612
Change-Id: I81354ff16a6bb9c9bc3a9ada99018ad1e2c82031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959034Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737363}

We're going to 50% beta on this feature (changing the
default referrer policy to strict-origin-when-cross-origin)
so it's time to add a field trial testing config.

Also updates the following tests, which were failing with
the testing config enabled:
- ContextMenuBrowserTest.OpenInNewTabReferrer
- DownloadReferrerPolicyTest.DownloadCrossDomainReferrerPolicy


Bug: 1014207

Change-Id: Ic50657d9c2f642af8538fea47fe2263797d45018
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012087
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737362}

This reverts commit 2f4fb261.

Reason for revert: M80/M81 blocker. Bug 1046501.

Original change's description:
> Revert "Reland "media: use VEA SupportedProfile |min_resolution| for PeerConnection""
> 
> This reverts commit 49e19ab9.
> 
> Reason for revert: Landed without testing (No-Try: true). Will revert, enable tests and reland.
> 
> Original change's description:
> > Reland "media: use VEA SupportedProfile |min_resolution| for PeerConnection"
> > 
> > This reverts commit a629c52f.
> > 
> > Reason for revert: M80/81 blocker. Bug 1046501.
> > 
> > Original change's description:
> > > Revert "media: use VEA SupportedProfile |min_resolution| for PeerConnection"
> > > 
> > > This reverts commit 72037f82.
> > > 
> > > Reason for revert: M80 Stable blocker bug 1046501
> > > 
> > > Original change's description:
> > > > media: use VEA SupportedProfile |min_resolution| for PeerConnection
> > > > 
> > > > crrev.com/c/1828078 added and wired the video encode acceleration
> > > > minimum resolution; this CL uses this information from peerconnection's
> > > > rtc_video_encoder.cc and video_codec_factory.cc to avoid using a
> > > > hw accelerator for resolutions below the given one.
> > > > 
> > > > TEST=https://codepen.io/miguelao/full/jONQBYb on nocturne (pixel slate), then
> > > > inspecting chrome:webrtc-internals, verifying that resolutions below 321x241
> > > > are encoded using libvpx while larger ones are encoded using "ExternalEncoder",
> > > > i.e. the video encode accelerator in Chrome, in this case VA-API.
> > > > 
> > > > Bug: 1008491
> > > > Change-Id: Iccfe6be8811ca265d6dbc742beb3ec0901406a40
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848398
> > > > Commit-Queue: Miguel Casas <mcasas@chromium.org>
> > > > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > > > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#720981}
> > > 
> > > TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,guidou@chromium.org,ilnik@chromium.org
> > > 
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > 
> > > Bug: 1008491
> > > Change-Id: Ie7279fcc02e041f4e1a4a0ed0cef248aa24d472e
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028889
> > > Reviewed-by: Miguel Casas <mcasas@chromium.org>
> > > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > > Reviewed-by: Henrik Boström <hbos@chromium.org>
> > > Commit-Queue: Miguel Casas <mcasas@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#736904}
> > 
> > TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,hbos@chromium.org,guidou@chromium.org,ilnik@chromium.org,ssilkin@chromium.org
> > 
> > Change-Id: I92b4e10f9ef39d2c642a6c9ae4d3a1e3f0fbb609
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1008491
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033345
> > Commit-Queue: Miguel Casas <mcasas@chromium.org>
> > Reviewed-by: Miguel Casas <mcasas@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#737332}
> 
> TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,hbos@chromium.org,guidou@chromium.org,ilnik@chromium.org,ssilkin@chromium.org,ssilkin@google.com
> 
> Change-Id: I1cadec33578747fca04b44867a8951a9c69d3280
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1008491
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033348
> Commit-Queue: Ben Mason <benmason@chromium.org>
> Reviewed-by: Ben Mason <benmason@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737334}

TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,hbos@chromium.org,guidou@chromium.org,ilnik@chromium.org,ssilkin@chromium.org,ssilkin@google.com,benmason@chromium.org

Bug: 1008491
Change-Id: I4d44659b5bd9fb85cd3f1121a5633fb1b183424d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033257Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Sergey Silkin <ssilkin@google.com>
Cr-Commit-Position: refs/heads/master@{#737361}

We need some of these apps like Files app, and possibly in future the
settings app.

Bug: 1047211
Change-Id: I270e9bc86d849f76470e4befb49b2968fc87e3e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031027
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737360}

https://swiftshader.googlesource.com/SwiftShader.git/+log/79b36b640692..55890e1afe33

git log 79b36b640692..55890e1afe33 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 bclayton@google.com CMake: Add build rules for google benchmark.
2020-01-31 bclayton@google.com Add google benchmark submodule to third_party.

Created with:
  gclient setdep -r src/third_party/swiftshader@55890e1afe33

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ifc3caceaabda713568ed18d5316768951167f9af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033116Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737359}

LayerTree.getCompositingReasons was updated to return an array of compositingReasonIds. This CL updates the layer-compositing-reasons.js to match against the IDs instead of the messages.

Bug: 946860
Change-Id: I4de8a6da10cb14c4def1ad0a726c0d51e591c029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028690
Commit-Queue: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#737358}

A BookmarkNode's title can only be changed from the UI thread, but is
also read by the history backend thread via
HistoryBookmarkModel::GetBookmarks(). Hence, a lock must be acquired
before changing the title.

In practice, this race should be extremely unlikely (if not impossible)
since assignment of base::string16 may as well be atomic in practice.

Change-Id: I8b31b977efe8fdcb918be8692984b2eab9dd0411
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031041Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737357}

Bug: 1042063
Change-Id: Iae03f34cd256bce803bd4c7e215ea3f56def168b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016852Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737356}

The code in this component is unique to javascript dialogs, and does
not cover all app modals. Further, it has some view code that isn't
specifically for app modal javascript dialogs, but is re-used for tab
modals. Some tab modal code from //chrome will be moved here soon, so
rename from app_modal to javascript_dialogs. Class names reflect whether
their use is specific to the app modal control flow.

Also, rename some classes to better reflect their roles:

. JavaScriptDialogManager (implements content::JavaScriptDialogManager)
  => AppModalDialogManager

. JavaScriptAppModalDialog => AppModalDialogController

. NativeAppModalDialog => AppModalDialogView

etc.

Bug: 1025256
Change-Id: I0a1865ec71897ae6549184bc317ede29cc56438a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031936Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737355}

Replaces usages of java.net.URI with GURL.

GURL appends a trailing slash to pathless URIs to normalize them, which
java.net.URI does not do, so AndroidPaymentAppFinder has to normalize
URI methods in the same way Origins get normalized.

Bug: 783819
Change-Id: I0574ff318309642ce3220488ef7f5c08a389478a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031525Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737354}

Dramatis personae:
  CredentialLeakDialogView (CLDV): a DialogDelegateView, owned by Views
  CredentialLeakDialogController (CLDC): an abstract interface used by
    CLDV.
  CredentialLeakDialogControllerImpl (CLDCI): a CLDC instance - actually
    the only one used in production
  ManagePasswordsUIController (MPUIC): a WebContentsUserData that
    controls any password-related UI showing for a given WebContents.
    Owns at most one CLDC instance.

Right now, there are two ways that a CLDV can be closed: in response to
something that happens in the browser, or in response to the user
clicking one of the buttons on the CLDV. The former case looks like,
e.g.:

        MPUIC::OnChooseCredentials
  calls CLDCI::~CLDCI
  calls CLDV::ControllerGone
  calls Widget::Close
  calls NonClientView::CanClose
  calls DialogClientView::CanClose
  calls CLDV::Close
  calls CLDCI::OnCloseDialog
  calls MPUIC::OnLeakDialogHidden

and in MUPIC::OnLeakDialogHidden, dialog_controller_ is already null, so
the stack unwinds.

The *latter* case looks like this though:

        DialogClientView::ButtonPressed
  calls DialogClientView::AcceptWindow
  calls DialogDelegate::Accept [aka CLDV::Accept]
  calls CLDCI::OnAcceptDialog
  calls MPUIC::OnLeakDialogHidden
  calls CLDCI::~CLDCI
  calls CLDCI::ResetDialog
  calls CLDV::ControllerGone
  calls Widget::Close (!)
  calls NonClientView::CanClose
  calls DialogClientView::CanClose
  calls CLDV::Close
  calls CLDCI::OnCloseDialog
  calls MPUIC::OnLeakDialogHidden

at that point in MPUIC::OnLeakDialogHidden, dialog_controller_ is null
because of the previous call on the stack, so the stack unwinds.
However, note that the controller got notified of the closure twice -
once via OnAcceptDialog and once via OnCloseDialog.

To avoid that double notification in case 2, CredentialLeakDialogView
nulls out its own controller in {Accept,Cancel,Close}, with a scary
block comment about why this is done.

The actual issue, though, is the CLDCI::~CLDCI -> CLDV::ControllerGone
-> Widget::Close steps - in case 2, the Widget is *already* in the
process of closing, as soon as {Accept,Cancel,Close} return; it should
not re-enter Widget::Close at all!

In order to avoid that re-entry, this CL has CLDV only close itself if
the controller is still not null in ControllerGone(), so the logic in
the CLDV's accept/cancel/close callbacks that nulls the controller serves
to prevent a recursive close.

This allows dramatically simplifying the logic around closure in this
dialog, and using the "new" closure methods for dialogs.

Bug: 1011446
Change-Id: I60100a31614ba10c5e615b985ff3039a2bfbffe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028194
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737353}

Looks like all instances of the warning are fixed now.

Bug: 1035171
Change-Id: I1a790f9c483525a8b72bda70f7dc27950321bfdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031683
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737352}

This will fix e.g. src-internal autorolls that include an internal
chrome trybot via cq_include_trybots, but are unable to launch them:
https://chromium-review.googlesource.com/c/chromium/src/+/2032214

Note that it's silently failing to trigger for now, but a follow-up fix
will make it fail loud and clear.

Bug: 1047347
Change-Id: I74d6353fa30abfee3c5fbf65faf6dda4fa088fb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031972Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737351}

'gpu.decoder' is used in decoders and mismatches chrome://tracing UI.
Resulting in gpu.decoder always disabled.
Rename CL was:
https://chromium-review.googlesource.com/c/chromium/src/+/1334229

Expected behavior: when recording with gpu.decoder, gpu.device and
gpu.service, there should be slices with category
"disabled-by-default-gpu.decoder".

Change-Id: I074a938ce79e05da2b6f931dca35f8f6864fd0c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024070Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737350}

Apply
s/var /let /g

This is more dangerous than the no-var rule applied by Eslinter which tries to be conservative/safe.

For example,

try {
  let foo = 1;
}

if (foo == 1) {}

is an error since `let` scopes to local block while var scopes globally (or to local function). Eslinter would not replace in this case. Fix by declaring foo above the try.

The other variation of issues that cropped up was:

switch (...) {
  case 1: let foo = 1; break;
    case 2: let foo = 2; break;
}

causes an error because of the re-definition of `foo`. Explicitly scope them in a block (i.e. { let foo = 1; }).

Test: browser_tests pass.

Change-Id: Ib28758d6b723d43077410f60e112d21ecb526dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031529
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737349}

Register it in ChromePreferenceKeys and use SharedPreferencesManager
consistently instead of SharedPreferences directly.

Bug: 1022108
Change-Id: I9212d59d33d1eb65a84222db85a103ad2cf4d425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025934Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737348}

This class maintains an index of all registered service workers by
origin, querying the whole list on startup and observering additional
registrations during the browsing session.

This class is owned by IsolatedPrerenderService but isn't wired into
the triggering logic, yet.

Bug: 1023486
Change-Id: I077512366b85ebe20e87fe14bf2ea9088d611820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031527Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737347}

https://android.googlesource.com/platform/external/perfetto.git/+log/fe37d1fa52f1..631e93892acf

git log fe37d1fa52f1..631e93892acf --date=short --first-parent --format='%ad %ae %s'
2020-01-31 taylori@google.com Merge "perfetto-ui: Make track selection work with pinned tracks"
2020-01-31 fmayer@google.com Merge "Use correct self count for `objects`."
2020-01-31 lalitm@google.com Merge "tp: convert to index vector when filter is followed by sort"
2020-01-31 lalitm@google.com Merge "trace_processor: delete old table code"
2020-01-31 lalitm@google.com Merge "trace_processor: add benchmark for filter followed by sort"

Created with:
  gclient setdep -r src/third_party/perfetto@631e93892acf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I5728fdbc4ec945ed367fa8e1e876e4b9e0d4a39a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033118Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737346}

This patch just moves some code around so that it is a little better
organized. There are no behavior changes here, just some comments and
reoderdering.

This is split off from
https://chromium-review.googlesource.com/c/chromium/src/+/2028177

R=rakina@chromium.org, yosin@chromium.org

Change-Id: Ib4862e5a9baee36e295144a0af5a8b2120ac71cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032167Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737345}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6b7add10ae84..8b9cdcbe79ef

git log 6b7add10ae84..8b9cdcbe79ef --date=short --first-parent --format='%ad %ae %s'
2020-01-31 mmortensen@google.com Handle ninja logs properly when processing goma logs.
2020-01-30 gbiv@google.com scripts: add enumerate_hot_packages.py
2020-01-30 saklein@chromium.org cros deploy: Remove ignore-build-slot argument.
2020-01-30 bpastene@chromium.org cros_chrome_sdk: Don't add the toolchain dir to the compiler's cmd line.
2020-01-30 saklein@chromium.org cros build-ap: Add build code and config modules.

Created with:
  gclient setdep -r src/third_party/chromite@8b9cdcbe79ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I73243a8313dbf5d98a361982a310bacdb4388007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033113Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737344}

python client is being deprecated.

Bug: 984869
Change-Id: I43f7a74e1d5a108b378748a7a89f23ced37eb417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033005
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737343}

This reverts commit e84c5eea.

Reason for revert: landed a fix for devtools
(https://crrev.com/c/2033236)

Original change's description:
> Revert "[blinkpy] Integrate Typ's expectations_parser module into blinkpy"
> 
> This reverts commit 88fbf344.
> 
> Reason for revert: Breaks parsing of test expectations on the DevTools waterfall - https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/355
> 
> Original change's description:
> > [blinkpy] Integrate Typ's expectations_parser module into blinkpy
> > 
> > This CL will replace blinkpy's test expectations logic with typ's
> > expectations_parser module. This change will significantly reduce the
> > amount the code used for parsing and maintaining test expectations.
> > Typ's expectations_parser module also parses the new expectations
> > format.
> > 
> > Bug: 986447
> > Change-Id: I16842bb2fcbc8a75221f3f208ed1550523470716
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918294
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Reviewed-by: Robert Ma <robertma@chromium.org>
> > Reviewed-by: Luke Z <lpz@chromium.org>
> > Reviewed-by: John Chen <johnchen@chromium.org>
> > Commit-Queue: Rakib Hasan <rmhasan@google.com>
> > Cr-Commit-Position: refs/heads/master@{#737159}
> 
> TBR=lpz@chromium.org,johnchen@chromium.org,jbudorick@chromium.org,robertma@chromium.org,rmhasan@google.com
> 
> Change-Id: Id3b9bab45cae06dc21173d7d5fb99f294ec4e95f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 986447
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030956
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737277}

TBR=yangguo@chromium.org,lpz@chromium.org,johnchen@chromium.org,jbudorick@chromium.org,robertma@chromium.org,rmhasan@google.com

Change-Id: Ib16faa774386a1f85b28264433d6215625cde0bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033327Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737342}

This required some shuffling around to get things to work right.
In particular, prior to this patch I had restore triggered
from the browser_impl.cc's constructor. This proves problematic on
android now as tabs may be created synchronously. When BrowserImpl.java
calls to browser_impl.cc's constructor all the connections (clients)
haven't been set up (and BrowserImpl.java can't call to the native side,
because it's waiting for the return value from creation). This lead to
all sorts of crashes and what not.

The fix is to trigger restore later on, and specifically once everything
has been wired up, which is when setClient() is called.

BUG=1046406
TEST=BrowserFragmentLifecycleTest

Change-Id: Iee2dfcab5ab8b45371099b33b65aa35ffb458ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031594Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737341}

Bug: 1006150
Change-Id: Id5a3135c709b1785a323a66eb559464a967803c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033155
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737340}

TBR=ioanap@chromium.org
NOTRY=true

Bug: 1043480
Change-Id: I4394dec42a6ca2397c5d23da6f2e0c6636da7b6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033324Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737339}

This patch implements committed interstitials for safebrowsing
for subresources (as a follow-up to crrev.com/c/2003857).

In this patch:
- Make sure to only add safebrowsing navigation throttle for
  main frames when committed interstitials are enabled.
- Implement safe_browsing_subresource_helper and update
  safe_browsing_ui_manager to handle subresources (such as
  js files).
- Add a browsertest for testing safebrowsing interstitials
  for subresources (both with and without committed
  interstitials enabled).

BUG=1044593,1042662

Change-Id: I813e916aa27dcb262fcd39d9b20af0f6d5d41e1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030485
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737338}