- 03 Apr, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/039884bb8c63..b70ef7756a4d Created with: gclient setdep -r src-internal@b70ef7756a4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I702e2801916a5c3b956259c37c5b04f409edd4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135971Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756372}
-
Stephen McGruer authored
This rolls testharness.js, idlharness.js, and webidl2.js from the external copy in external/wpt/resources/ to the internal copy in resources/, bringing us up to WPT SHA e343467e. Note that the webidl2.js changes are just tab characters present in the original file that I accidentally cleaned into spaces in the previous roll. Bug: 1067618, 1066131 Change-Id: I1ccdf13418e10ace29564695d3dd20a738a7a3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135540Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#756371}
-
Domenic Denicola authored
This is a first pass at implementing a header-based version of origin isolation, alongside our existing origin policy-based one, per [1]. It does not yet parse the header, instead simply using its presence or absence. This CL includes browser tests only for now; web platform tests will be done in a follow-up. [1]: https://github.com/WICG/origin-isolation/commit/1c16647387b6be1bb170ed8ce24a5bd179abfa98 Bug: 1042415 Change-Id: Iaaa97a87e166aeedac2313f718322e5cdb7462e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113152 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#756370}
-
danakj authored
The network process crashes flakily in these tests on trying to read a file and being blocked: [217947:217958:0403/143350.056670:FATAL:url_loader.cc(1828)] Check failed: response_. #0 0x5604f137b829 base::debug::CollectStackTrace() #1 0x5604f12a3ae3 base::debug::StackTrace::StackTrace() #2 0x5604f12b9174 logging::LogMessage::~LogMessage() #3 0x5604f2afe5d7 network::URLLoader::CompleteBlockedResponse() #4 0x5604f2afcf29 network::URLLoader::OnReceivedRedirect() #5 0x5604f194d027 net::URLRequestJob::NotifyHeadersComplete() #6 0x5604f1950a04 net::URLRequestHttpJob::NotifyHeadersComplete() #7 0x5604f1952ec2 net::URLRequestHttpJob::SaveCookiesAndNotifyHeadersComplete() #8 0x5604f1951d28 net::URLRequestHttpJob::OnStartCompleted() #9 0x5604f186697c net::HttpCache::Transaction::DoLoop() #10 0x5604ee97ab9c base::internal::Invoker<>::Run() #11 0x5604f185fae3 net::HttpNetworkTransaction::DoCallback() #12 0x5604f1820853 net::HttpStreamParser::OnIOComplete() #13 0x5604ee97ab9c base::internal::Invoker<>::Run() #14 0x5604f18c8a69 net::TCPClientSocket::DidCompleteRead() #15 0x5604f1983a9c net::TCPSocketPosix::ReadCompleted() #16 0x5604f198526a base::internal::Invoker<>::RunOnce() #17 0x5604f1987137 net::SocketPosix::RetryRead() #18 0x5604f1987eff net::SocketPosix::ReadCompleted() #19 0x5604f1987c28 net::SocketPosix::OnFileCanReadWithoutBlocking() When that happens the StoragePartition's NetworkContext is recreated. WebTestContentBrowserClient was storing the NetworkContext* into a RepeatingCallback against the advice of the method returning it (ie StoragePartition::GetNetworkContext()), and then if the process crashed, the Callback would have a dead pointer bound. This changes the tests to grab the pointer when the callback is run instead. The WebTestClientImpl's cookie_manager_ will still become useless after the network service crashes, but these tests don't depend on that... and WebTestClientImpl is created per-renderer so it should not impact other tests. R=nasko@chromium.org Bug: 1067445 Change-Id: Ieeaca88e5baee9aa3f1bf969c1486503819dcdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135424Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756369}
-
Haiyang Pan authored
Bug: 1067673 Change-Id: I25b6cf86091568ca96e9dd53772b95e9f7d08dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135888 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#756368}
-
David Van Cleve authored
Previously, the Trust Tokens request helpers enforced a collection of uniform preconditions on their issuer and top frame origins via DCHECKs. These were both conceptually enforced at the level "immediately above" the factories (the request helper factory: crrev.com/c/2097057). This CL makes a couple changes: 1. it removes the top frame origin DCHECKs and enforces the top frame origins' constraints by requiring SuitableTrustTokenOrigin-typed top frame origins; the type itself enforces the preconditions. 2. it moves the issuer origin checks conceptually into the request helpers themselves, because the source of the issuer origin varies from operation to operation (for issuance and redemption, it's the request's destination URL; for signing, it's an additional parameter). R=csharrison Test: Expand unittests to cover unsuitable issuer origins. Bug: 1042962 Change-Id: I8f0125eb796c3421bf082ea22fb1fe5f0f85007e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134588 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#756367}
-
Owen Min authored
Disable org.chromium.chrome.browser.browsing_data. ClearBrowsingDataFragmentTest#testImportantSitesDialogNoopOnCancel It's flaky on android-marshmallow-arm64-rel Bug: 1067686 Change-Id: Ia9d878ee52ab649e5a7b4a3b8892335d7b571029 Tbr: msramek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136027 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#756366}
-
Owen Min authored
Disable SitePerProcessBrowserTest.ScrollBubblingFromNestedOOPIFTest because it's flaky on multiple release build. Bug: 1063045 Tbr: kenrb@chromium.org Change-Id: Ie731a5c72c39d890b639f7cc6a97562db6e025ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135890Reviewed-by:
-
Anastasia Helfinstein authored
Currently, the Switch Access back button is drawn by the extension, but in order to match the visual specification (see bug) the back button needs to be drawn using native views. This change creates a bubble controller for Switch Access and adds the ability to show the back button. This functionality is not yet used. Relnotes: N/A Bug: 973719 Change-Id: I6da3772e8183d0cdbd04b554a4764719d12b8e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124234 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#756364}
-
Chunbo Hua authored
The existing media foundation encoding path has been enabled by default for a long time. Remove the old switch in preparation for a new one which controls usage of the asynchronous MFT. Bug: 982799 Change-Id: I9456029bf38f5af3710b93d693876f20e69d2768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135313Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#756363}
-
Haiyang Pan authored
Bug: 1062838 Change-Id: I89022a61759a3f2b19650c4ee61d35df57d58f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135334 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
-
Rakesh Soma authored
that particular user sid. Note: Tested the changes locally on a VM instance. It works great ! Bug: 1045080 Change-Id: I3e05cbd8d6448a601109787f3de2a9a36236709e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135188 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#756361}
-
Julie Jeongeun Kim authored
This CL adds ListBoxOption role as an item for Group role in AXNode::SetRoleMatchesItemRole() since Group role could have ListBoxOption as an item[1]. With this change, when the parent of ListBoxOption is a group role, PosInSet and SetSize has proper values. [1]https://w3c.github.io/aria-practices/examples/listbox/listbox-grouped.html Bug: 1066632 Change-Id: I23cf0c34ee479d6e8ee33b3f9e327def820527e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134037 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756360}
-
Aaron Leventhal authored
Bug: 1065763 Change-Id: I154a3446d3893916831c66f6a5ecbd36d94b4f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127428 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Scott Violet authored
This is necessary in the short term because we dropped 82. BUG=1067701 TEST=none Change-Id: Iee16ec4083e53cfa532ea5b2bbeb1111453d45cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135338Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756358}
-
Rob Buis authored
Simplify fraction centering calculation by not computing content_inline_size, since this is equal to child_available_size.inline_size. Bug: 6606 Change-Id: If2c734f0ea644922d49e1527b1ac599df17bc7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134300Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#756357}
-
Kevin Babbitt authored
We observed an issue in Microsoft Edge where a certain printer driver was being called on two different threads simultaneously and reacted by making an unbalanced CoUninitialize() call on the browser UI thread. If this happens enough times, the CoInitialize() count of the UI thread will eventually drop to zero and cause problems when, for example, out-of-process accessibility clients attempt to access objects that are only safe to call on the UI thread - the COM marshaler will see that the UI thread is in the implicit MTA and assume that these objects can be called from any MTA thread. I haven't successfully reproduced the same issue in Chrome, but the threading pattern for printer driver calls is the same, so the potential for it to occur is there. Existing code comments document that some Windows printer drivers are only safe to call from the UI thread. Accordingly, this CL addresses the issue by moving work done by the local printer handler from a generic task runner thread to the browser UI thread on Windows. Bug: 1065145 Change-Id: Ic20872cb33bfb6c94381059578c2055cb1a9a1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135054 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756356}
-
Sam Bowen authored
Not done in this CL, but intended in the future: * Genre should be able to store multiple values. * TV episode images. * Play next episode. * Storage of the media feed items in media history. * End to end testing using a full JSON example. Change-Id: Ib4c6d9421c61ed98426aabc5b6056f0437195782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112957Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#756355}
-
Jeroen Dhollander authored
This class inherits from |AssistantInteractionSubscriber| and provides a dummy implementation of all the methods, so that test classes can derive from this and only implement what they need. It also adds a |mojom::Remote| that every test class needs. Bug: b/151800188 Change-Id: I1f06f180e2f99c76a09171122777e24561e0a562 Tests: Ran existing unittests Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128838Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#756354}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/16d0d371d549..f687d90f4219 git log 16d0d371d549..f687d90f4219 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ae03941a..9dce00d2 (756130:756252) Created with: gclient setdep -r src/third_party/webrtc@f687d90f4219 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ice387e71076029be8d4193d9464a2ce0503901af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756353}
-
Sinan Sahin authored
An integration test was failing on L bots because the hiding animation in the compositor wouldn't complete and the indicator would get stuck shown. Upon investigating, I discovered that this issue was not limited to tests and was reproducible on an emulator. The issue was that #onLayoutChanged would be called during the hide animation causing a wrong height value to be sent to the compositor as if it's being shown. A simple fix is to add a boolean to ignore #onLayoutChange calls when we no longer need them, and we're basically done once we get a height to run the show animation. Bug: 1059297 Change-Id: I943300ebc1e93172eec9311ec28c44172464ba4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130781 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756352}
-
Alison Maher authored
When the legend is larger than the fieldset border-top, the fieldset's border box gets pushed down. In the case of fragmentation, allow this adjustment if the legend fits inside the first fragment. Otherwise, don't adjust the fieldset border block-start offset. This is similar to how fragmentation was handled in the case where the legend is smaller than the border-top: https://chromium-review.googlesource.com/c/chromium/src/+/2125230 Tests were not added at this time for the following reasons: 1. It currently isn't possible to test where the fieldset border starts using unit tests. 2. Paint for legend fragmentation isn't currently working, so testing this via web tests was also not possible. Bug: 875235 Change-Id: I9594ab35bce23a4e9dd1a3aa2e7d913900ec14b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131348Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756351}
-
Wenyu Fu authored
Nightmode is not supported on Kitkat devices. Disable the test for now. Bug: 1067575 Change-Id: Ie81b15f55a3e17ed8b22b8e6866ebfe5ebf19921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135946 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
Wez authored
Package configurations do not change at run-time, so cache it the first time it is read, to avoid the cost of repeatedly re-reading it from the filesystem. Change-Id: I53c6ea55be5fca48bf3c81f189e251d8a11a55a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135607 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756349}
-
Daniel McArdle authored
Bug: 1052476 Change-Id: I5d453d31bfd96dddbf303b41fb9adc36110d9ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092159 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#756348}
-
Reilly Grant authored
As pointed out in [1] the style guide recommends against out parameters. This change rewrites most of the helper functions in UsbServiceWin to return their value directly, using an empty string or nullopt as a sentinel for failure. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2132532 Bug: 637404 Change-Id: I54b4b807fae95f9ff93e9a02546e2748cf00b9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135129 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756347}
-
Wez authored
Allow media playback in CastComponents to be controlled by the owning Agent. Bug: 879317 Change-Id: I6a744faa0b236f3a856d5c4aa0b9f0846f6970ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130546 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756346}
-
Becca Hughes authored
Add a histogram that records the size of the database in KB. BUG=1024362 Change-Id: I4fac8d7184b0c9e2c53554df0175512c0266a1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125269 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#756345}
-
Adam Langley authored
This shouldn't break the release builder because the native code will still be constant across release modes. BUG=1002262 Change-Id: I86db7fd5cc23c791012ac68afad2806ef35d44bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135872 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#756344}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e4aa679c5945..390ef29999bc git log e4aa679c5945..390ef29999bc --date=short --first-parent --format='%ad %ae %s' 2020-04-03 courtneygo@google.com Enable blob cache when debugging 2020-04-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 499f6df688c9..9a283ae3457f (7 commits) Created with: gclient setdep -r src/third_party/angle@390ef29999bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I8a2fc930db65ac3dd2c8097fd04e91fe22e7b285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135801Reviewed-by:
-
Evan Stade authored
MediaStreamDevicesController is moved from Chrome into //components/webrtc. There's a new delegate class MediaStreamDeviceEnumerator which removes the dependency on MediaCaptureDevicesDispatcher, and some Chrome-specific responsibilities are moved to PermissionBubbleMediaAccessHandler. The only interesting part of Chrome's MediaStreamDevicePermissionContext is policy handling code, which is not important for WebLayer, so it's not moved or copied. Some code for re-prompting for Android permissions is moved to the new android_permissions_util.cc, and some is moved to PermissionsClient. This is used by geolocation as well, so it obviates the need for a couple methods on the geolocation context delegate. Unlike Clank, which shows a system notification when streaming, WebLayer does not indicate when the microphone or camera is in use. TODO: tests TODO: show indication when streaming, if desired Bug: 1025622 Change-Id: Idf6c4a066ff75b581fe6df98c8b29dac9bfcc16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121426 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756342}
-
danakj authored
In order to incrementally split content/shell/renderer/web_test out of content_shell_lib, into web_test_renderer, we must split apart web_test_support. content_shell_lib must depend on the browser-side code in web_test_support, so we move that to web_test_support_browser. Then the dependency on web_test_support_renderer needs only be in the web_test_renderer target. Without this change, any dependency on content_shell_lib would also include web_test_support_renderer, but not web_test_renderer, which causes a build failure due to: 1) Circular includes between web_test_support_renderer and web_test_renderer 2) So web_test_renderer -> web_test_support_renderer 3) But web_test_support_renderer -/-> web_test_renderer 4) This means depending on web_test_support_renderer without going through web_test_renderer does not link. R=avi@chromium.org Bug: 866140 Change-Id: If3ae301f44bd2057fb196f39e7947607bb3da60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134858 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Anastasiia Nikolaienko authored
Bug: 1054798 Change-Id: I85aa420e6ef5f23cecaf1a8e8d035ee924d3ccac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134142Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#756340}
-
Andrew Grieve authored
Also fixes ability to run commands on apks not through wrapper scripts (must have broken a while ago). Tested with: build/android/apk_operations.py print-certs --apk-path AndroidWebview.apk --full-cert Bug: 1065270 Change-Id: I7aa047fd3570c46c1fde4f6f9e8de1895f10bae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135335 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#756339}
-
Tao Bai authored
Bounds are transformed to Android's coordinates with scroll offset. Bug: 1064420 Change-Id: I8149e45a4de72f660a52466b7f1ca0505266f3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133239Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#756338}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f5a94cc6837a..79679990ff54 git log f5a94cc6837a..79679990ff54 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 rslawik@google.com Merge "Create linux.system_info probe reporting CpuInfo" 2020-04-03 eseckler@google.com service: Remove some DCHECKs on writer {un,}registration (part 2). 2020-04-03 eseckler@google.com service: Remove some DCHECKs on writer {un,}registration. Created with: gclient setdep -r src/third_party/perfetto@79679990ff54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1067609 Tbr: perfetto-bugs@google.com Change-Id: I64954a1ecab133bc10f3f8a1a5ea09b89c2960b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135986Reviewed-by:
-
Owen Min authored
Disable the test as it's flaky a lot on WebKit Linux Leak. Bug: 1067650 Tbr: jarhar@chromium.org Change-Id: I7e97202eda9b35669151426530fea9accf33b704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134775 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#756336}
-
Etienne Bergeron authored
This is a step forward to remove the waitable event. This CL is removing the Waitable event member and reducing its scope only to the destructor (where it is used). R=gab@chromium.org Bug: 1065004 Change-Id: I7a813c09a52ccd428c64631bd81fc8a5d710c880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132766Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756335}
-
Alice Wang authored
This CL migrates the usage of AccountManagerFacadeProvider.overrideAccountManagerFacadeForTests to AccountManagerFacadeProvider.setInstanceForTests. Bug: 1063866 Change-Id: I089ae89158cfdfac92638c5a718a9faf2a53b9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129527Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756334}
-
Regan Hsu authored
* Moved the <iron-list> into the dropdown slot instead of being the slot because of margin and padding issues (<iron-list> secretly has hidden rows it 'hides'). * Stylize colors and edges to bridge search bar and dropdown more neatly * Decrease length of search bar to specified 480px * Extra padding within icons inside the cr_toolbar_search_field will be added in another CL. * |Narrow| interaction changes will be made in another CL. Mocks: https://carbon.googleplex.com/cros-ux/pages/search-bar/style Screenshots: https://screenshot.googleplex.com/6b8WsKBROdD (no focus) https://screenshot.googleplex.com/v7gu6fR3WLA (focused) https://screenshot.googleplex.com/EOG12tdPRrE (results) https://screenshot.googleplex.com/LeG0pbmy6n8 (results narrow) Bug: 1056909 Change-Id: I3931e3dd812ae2f627d6e5349de2141ddda7d2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131466Reviewed-by:
-
