- 19 Nov, 2020 40 commits
-
-
David Maunder authored
The TabState replacement CriticalPersistedTabData makes the assumption that it is called from the UI thread. This is not the case in for restoreTabs(false) which is explicitly called on the background thread and causes the new Tab persistence system to crash. After a deep dive, I determined that restoreTabs(false) is equivalent to loadNextTab() because all the code in restoreTabs is skipped except for loadNextTab() (since setActiveTab is false). After studying loadNextTab() I found that the 'heavy lifting code' (e.g saving, deletion) is explicitly called on the background thread so calling loadNextTab() or restoreTabs(false) from the background thread is not necessary. Calling loadNextTab or restoreTabs(false) from the UI thread will not cause a performance regression as the 'heavy lifting' code is already delegated to the background thread and in doing so will result in the correct consumption of CriticalPersistedTabData. Bug: 1148972 Change-Id: I15cfd90125039cf957b88148881765a59fda4556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548503Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#829318}
-
Sunny Sachanandani authored
Not resetting the |resource_changed_| flag will cause the same resource to be returned if multiple calls to PrepareTransferableResource() are made, and this triggers a DCHECK failure in TextureLayer. Bug: 1114952 Change-Id: I6b3b6ff00fd32316d67bee46f4e45f7bdd418a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548520Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#829317}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/test. Bug: 1113033 Change-Id: I2b1068f3b1709c27b3a9692f1f94430826cecac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547923 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#829316}
-
Frank Liberato authored
When checking for output buffers while a surface transition is pending, MCVD will choose to wait if there are still unrendered output buffers. However, once the last buffer is rendererd, MCVD didn't always realize to try again; it did so only if it ran the codec pump for some reason (e.g., a new DecoderBuffer or a new codec buffer became available). This CL causes it to try again whenever an output buffer is rendered, in case it can make progress because of it. Bug: 1148995 Change-Id: Ife1ba993424491af4a29c71a979e5bb0c7b79eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547227Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#829315}
-
Ian Clelland authored
Bug: 1150909 TBR: mahmadi@chromium.org Change-Id: I50809a7364240ebfb87d6da058f9548ab83461cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550244Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#829314}
-
Clark DuVall authored
I didn't realize arcore wasn't supported in ChromeModern, moved the arcore dep to where arcore is added for non-isolated split builds. Bug: 1149919, 1149022 Change-Id: I8d59852f2d861cc9c53914c691eea9239736218f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550365 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829313}
-
Lucas Radaelli authored
Test for a previously submitted fix for handling pages with out of process iframes. Bug: 1136541, fuchsia:63092 Change-Id: Id79d1794c555b7710304fd2ffb751fd99ae60e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547436Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Cr-Commit-Position: refs/heads/master@{#829312}
-
Abigail Klein authored
The following are metrics to track the Live Caption feature: - Accessibility.LiveCaption - Whether the Live Caption feature flag is enabled. Not modified by this CL. - Accessibility.LiveCaption.AudioPropertyChanged - Whether the sample rate or channel count of a Live Caption audio stream changed midstream. Not modified by this CL. - Accessibility.LiveCaption.EnableFromSettings - Whether the Live Caption feature was enabled in settings. Renamed in this CL to have consistent naming with the next metric. Since the feature has not launched yet, this rename is safe. - Accessibility.LiveCaption.EnableFromGlobalMediaControls - Whether the Live Caption feature was enabled in global media controls (Zenith). Introduced in this CL. - Accessibility.LiveCaption.ExpandBubble - Whether the Live Caption bubble was expanded or collapsed. Introduced in this CL. - Accessibility.LiveCaption.MediaSourceType - Whether the media source is audio or video. To be introduced in an upcoming CL. - Accessibility.LiveCaption.Session - Logs when the caption bubble was shown due to an audio stream starting, when the caption bubble was hidden due to an audio stream ending, and when the caption bubble was dismissed due to the user clicking the close button. Added new logs in this CL. - InProductHelp.ShouldTriggerHelpUI.IPH_LiveCaption - Whether the Live Caption in-product help UI was triggered. Not modified by this CL. Bug: 1055150 Change-Id: I7a53847cdee63ceedfe283bbdb368efdf80fd50c AX-Relnotes: N/A (Feature has not launched) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527779Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#829311}
-
Etienne Bergeron authored
This is fixing an useless directional marker added while eliding. I found this issue while re-implementing eliding during layout phase. The text direction needs an update after being cut. R=msw@chromium.org Bug: 1085014 Change-Id: I8574f5f70333c2ca6035a46ae9feabc22d9ca595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545443 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#829310}
-
Michael Hansen authored
A recent CL [1] fixed the possibility of a crash in the event that OnClose() is called multiple times. This removes logic where we clear the controller which no longer has an effect. 1) https://chromium-review.googlesource.com/c/chromium/src/+/2548373 Bug: 1150176 Change-Id: If1f650f41c42ed64961f6fa312c0eb755def4b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550528Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#829309}
-
Dominik Röttsches authored
After removing support for Mac OS 10.10, remove specific workaround to access a non-public font function. Fixed: 1150869 Cq-Include-Trybots: luci.chromium.try:mac11.0-blink-rel,mac10.15-blink-rel,mac10.14-blink-rel,mac10.13-blink-rel,mac10.12-blink-rel Change-Id: I41321d03bd97a42c53d8d6012b79ebdbe6ca1d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549953Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#829308}
-
Maciek Slusarczyk authored
If the password sync token API was not initialized (e.g. by in-session password change) token fetch on user online sign-in fails since the API returns an empty list of tokens. In order to fix this case we added token creation on first unsuccessful fetch attempt. As a result a valid token will be created on first password change or first online sign-in from any user device. Bug: b/173394869 Change-Id: Iacad53c1306a41f22749818ccd5d3d65b26e4d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547296Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Cr-Commit-Position: refs/heads/master@{#829307}
-
Hans Wennborg authored
Since crrev.com/824529, we're using /call-graph-profile-sort instead, which means the linker lays out the binary based on the PGO profile. Bug: 1077279 Change-Id: I0f6a72902dd211fd0000deef4b9c76909db9782a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550070 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829306}
-
Anqing Zhao authored
There are two kind of formats used in the crash logging file. - [CSV format] the old version to deprecate. - [JSON format] the new version with better extensibility. To decide the format of a specific log entry. We should make sure it is not only a JSON type, but also a JSON dictionary type. Otherwise the invalid CSV entry with single column will be wrongly treated as JSON format, then enter the parsing logic. It may cause unexpected crash. Bug: 1142529 Change-Id: I899940eece378b0359188dc14d617fb0570dedfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538216Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#829305}
-
Stefan Zager authored
Previously, when a throttled iframe skipped pre-paint, we would unconditionally mark the iframe's parent document for paint invalidation when the iframe became unthrottled. This will cause over-invalidation if the iframe contents don't need paint invalidation. With this change, we only mark the parent document for paint invalidation if the iframe contents actually need it. Change-Id: I7872ce2d85c3eb3035fa4e14c55ac2ffc9ec2466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548761Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#829304}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: Ic1edc36432453f728457edd648838ed4e98c0a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550205 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#829303}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47d4ef3f..94b2c943 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1172cb6f37646d67529eeb37ebf8448e3a6c4655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550363Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829302}
-
cfredric authored
initializer. Deleting the default ctor disallows default aggregate-initialization. Defining our own ctor ensures that aggregate-initialization must provide a value for all members initialized by the ctor, in the same order as the ctor. Thus if a new field is added to the struct and initialized by the ctor, compilation will fail until callsites are appropriately updated. This is a contrast to aggregate-initialization when there is no ctor defined; in such a case, members are initialized in the order they are defined in the struct, and *any number* of members may be initialized. Change-Id: Ib683a6ed6c1380977620fcc873c7fd1edd443803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549686Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#829301}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/75ae8fcc319e..753e7983e04e 2020-11-19 kjlubick@google.com [infra] Remove deleted taskdriver 2020-11-19 adlai@google.com Revert "Remove GrDrawingManager::fActiveOpsTask ivar" 2020-11-19 jvanverth@google.com Update docs for iOS deployment 2020-11-19 kjlubick@google.com update infra repo 2020-11-19 johnstiles@google.com Update DeviceSpaceEffect and ColorSpaceXform to return half4s. 2020-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2ffff6d024c7 to 8b76d37f9f9a (13 revisions) 2020-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bb96f79d0e15 to 060020166679 (4 revisions) 2020-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from a0758a1aef12 to ce207be41fd6 (4 revisions) 2020-11-19 michaelludwig@google.com Move clip operations on SkDevices into a helper macro 2020-11-18 robertphillips@google.com Update GrTTopoSort to use pre-existing memory ... 2020-11-18 michaelludwig@google.com Simplify internal logic in androidFramework_setDeviceClipRestriction 2020-11-18 johnstiles@google.com Add fix for fuzzer-discovered crash with negated constructors. 2020-11-18 brianosman@google.com Always enable SkSL's ByteCodeGenerator, disable interpreter in Google3 2020-11-18 jvanverth@google.com Add ios_min_target. 2020-11-18 jvanverth@google.com Fix typo in gn/ios.gni. 2020-11-18 johnstiles@google.com Add fix for fuzzer-discovered crash at oss-fuzz:27614. 2020-11-18 michaelludwig@google.com Hide SkCanvas::AutoValidateClip in cpp file 2020-11-18 michaelludwig@google.com Fix SkRegion::setPath to respect inverse fills when path isn't finite 2020-11-18 michaelludwig@google.com Rename fDeviceClipBounds to fQuickRejectBounds 2020-11-18 bsalomon@google.com Remove unused macros from GrGLConfig.h, GrGLConfig_chrome.h, and scripts 2020-11-18 michaelludwig@google.com Track AA-ness and rect-ness in SkConservativeClip 2020-11-18 mtklein@google.com allow JIT on ARM Mac 2020-11-18 johnstiles@google.com Fix worklist files with skslc. 2020-11-18 adlai@google.com Remove GrDrawingManager::fActiveOpsTask ivar 2020-11-18 fmalita@chromium.org [skottie] More robust font style parsing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Ic856b21f450b350756a8f6ad3395b5f0191d4016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829300}
-
Eugene But authored
14.3 has high volume crash with no known fix. Disabling HeapProfiling feature until we understand the reason of the crash. Fix is disabled on all OSes to avoid unexpected breakages in minor iOS releases during the holidays. Bug: 1150599 Change-Id: I5f8627f95ddae013b880194fe9510a87ed9225da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548369 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#829299}
-
Aaron Leventhal authored
Slider thumb is a mock object that was not used in any platform API, and although exposed in automation, is not used by ChromeVox. TBR=mkwst@chromium.org Bug: None Change-Id: I4e43e86882429641c14b75469bdd5b7f1d0bc0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548465Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#829298}
-
Alex Newcomer authored
Move the deactivation of ClipboardImageModelFactory closer to the paste. This ensures all paths to a paste deactivate the factory. Bug: 1148077 Change-Id: I8afdc90a3d4d0f6d4a47f7b8f57457d47e96ff59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548212 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829297}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=bsep@chromium.org Bug: 1145565 Change-Id: Idda03ba1fa22200f7637e542e9bca67abc246dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548022 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#829296}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605765502-3ccba7e07e5cf94b5756f4641a727d60a578a62b.profdata to chrome-win64-master-1605776317-40958ff5156f07254d2cc2984d12fc2fc0f55b26.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7c17d2fc584c8e81a2b90aeaf576625fd4771e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549153Reviewed-by:
-
Nate Chapin authored
NavigatorBase is a newly-added base class for Navigator and WorkerNavigator. Making LockManager a Supplement of NavigatorBase allows a single class to handle all of the work of exposing the navigator.locks getter for both windows and workers, and greatly reduces boilerplate. Bug: 1147612 Change-Id: I2eea54d27af56ed1ede3e9f07c2346bffe0796ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545578 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829294}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/f9e6f257d1a0..3ac0b060c794 2020-11-19 thakis@chromium.org Stop accepting mac_xcode_version as a gclient gn var. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147839 Tbr: mseaborn@chromium.org Change-Id: I3ea20e483b1c4b2e1da7f15a53383acd22cc9af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550225Reviewed-by:
-
Renato Silva authored
Prepare parts of the code to work with the HTMLImports polyfill by removing some global definitions usage in cr_ui.js and explicitly making oobe_types.js a dependency of security_token_pin_browsertest. Bug: 1111387 Change-Id: Ifbd2374fc7117f2cefa76c1baa3f96ec813a57a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550221Reviewed-by:
-
Yusuf Sengul authored
Bug: 1148565 Change-Id: I72a19753fe0ebf3ff770ae1753b946d89c1ed59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536098 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#829291}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=felt@chromium.org Bug: 1145565 Change-Id: I7cc9a4f07f542eebb584138cb673fcbca89131ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547886 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829290}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 1145565 Change-Id: Iaa725d308af52140f8eaf080ca66b71d6aecba78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547887 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#829289}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was created by git cl split. Bug: 1145565 Change-Id: I1480c826c9a9176d6489c4aa36672844cdb290a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550222Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829288}
-
Dave Tapuska authored
Collapse into a single implementation. BUG=1097816 Change-Id: Idae56771c51bc475aef708a7cfe616cd5598540e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543688 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a3db6c585a2b..9c260034ecc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC iclelland@google.com,mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131897 Tbr: iclelland@google.com,mkwst@google.com Change-Id: I0b7bc364d478395025a9dd1a30720f5007b6b1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550167Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829286}
-
Peter McNeeley authored
Overlay prioritization solves the problem of selecting the best overlay candidate for hardware overlay promotion. The best candidate is defined as the selection that minimizes power and maximizes performance. Power is the primary concern with the exceptions being low latency rendering and protected content. Prioritization operates at an inter-strategy level so the key changes here operate as a function of the overlay processor. The strategies propose candidates and the prioritization scheme merely sorts them. This sort is of two types. The first pass is a thresholding phase where candidates that do not meet a criteria are discarded. The second pass is a real sort that simply arranges the remaining candidates into best priority order. It should be noted that significant care was made in this change to reduce risk. The older strategy code and the newer prioritization code sit side by side and can be enabled/disabled via a feature flag. The rational for these changes and the heuristic sort can be found in original design document: https://docs.google.com/document/ d/1lFVQeHkCz1UOwtVTf_wTI2twsn48iNbS4UY4srZ0BhE/ The power model for overlays is based on arguments found in this design document: https://docs.google.com/document/ d/1IYcEkbJvH70wh3YUayci9yUx9dFR4j4joIX0kauiOtA/edit?usp=sharing Bug: 1113306,1143937 Change-Id: I01146513b68503c10853998a1d351d2c175e9b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426723 Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#829285}
-
Dave Tapuska authored
Move the two implementations into one common one in the base. BUG=1097816 Change-Id: Ia4187c07676256e62e8d019e90f79b4acc24f97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542596 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ic93a11bc58041721e14781f31d8f4b9bc590f9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544854Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#829283}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4d79f96b5ec9..20cc9eb2a7f5 2020-11-19 aerotwist@chromium.org TypeScriptify HeapProfileView.js 2020-11-19 sadym@chromium.org Fix node screenshot. Part 2. DevTools. 2020-11-19 yangguo@chromium.org [ts] Typecheck SourceCodeDiff.js 2020-11-19 janscheffler@chromium.org [Recorder] Add recording to DevTools 2020-11-19 patrick.brosset@microsoft.com Flex: Draw the hatching pattern in empty space of the flex overlay If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1003629,chromium:1011811,chromium:1139949,chromium:1144127 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4d3fcd7a8e913281e7a2c2a0494a84aede7cc88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550165Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dad44f4d824e..1a14e7e02441 2020-11-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 46d9c7745efa to 36d9a061c847 (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Idf57d4542ee09737c5cf255acdaf39b8adbdcd8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550174Reviewed-by:
-
Jack Franklin authored
https://crrev.com/c/2544131 renamed the method to remove the underscore but shipped both names in order to avoid layout test breakages. Once that's landed, we can land this change, and then remove the old `_linkInfo` method as it will then be entirely unused. Bug: 1149403 Change-Id: I21bcf71fb8e87fe4202d07ee83b3bbf481905f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546760 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#829280}
-
Kelvin Jiang authored
This CL releases an extension's allocation when it is unloaded for the following reasons: - when it's blocklisted - when it's disabled by policy - when it's disabled for malware Rationale on why certain UnloadedExtensionReason/DisableReason will cause the allocation to be released (or not) are detailed in the doc (internal): docs.google.com/document/d/1oGpntLGf9myZ6lI4XWJNMPaZX1_zooJni6ROsqidC6A Bug: 983299 Change-Id: I2523ee9794a24bd1ffa320b04ff7941842781969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545735Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829279}
-
