- 10 Mar, 2020 40 commits
-
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: I87a7166d964b3229661b125e71288e9bf0eec6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095397Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748712}
-
Bruce Dawson authored
When building the 'chrome' target Mojo generates about 680 .cc files that contain no actual code. Due to the includes that are stamped out these files collectively take a non-trivial amount of time to compile. Detecting these files and deleting the #includes saves about ~1,200 to ~2,100 CPU seconds. The no-code detection doesn't work generically, but it handles the code which mojo generates. Bug: 1054626 Change-Id: Icb2feaa0021332e0a6d4c9e5cac314824578cd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093881Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#748711}
-
Maggie Chen authored
Bug:949839 Change-Id: Id84825c9b13a800c80a22ed3bf42b4056bc16343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084718 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748710}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: I426f0455d698715bfdc9b256f3de6cb5492f640e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095198Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748709}
-
Bo Liu authored
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1960465 With change above and with virtual context enabled, it is fairly likely that when a context is lost, the new context is created before the old context is destroyed. Since GpuChannelManager keeps using the same GLShareGroup, the new context will end up in the same share group as the old context. Avoid this by creating a new GLShareGroup in LoseAllContexts. Bug: 1059286,1052485 Change-Id: I1d60578fa6359329406d634fe04c7f242314839a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090137 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#748708}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ For these flags, ownership was claimed, but no expiration milestone was given. This CL attempts to act as a forcing function for owners to choose an expiration milestone. This CL sets M85 as the default expiry milestone for every flag in this CL. All owners have been responded with an LGTM or with a comment to change the expiry. Bug: 1058614 Change-Id: I40b40103f6a74aab185e8c7cebeceeb183476bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094238Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748707}
-
Andy Paicu authored
TBR=olka@chromium.org Bug: 1060165 Change-Id: I0f96c85b400ea05dd0bfbd9852d99b029cfdec02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096758Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748706}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/391bb28f91a4..e1f6408da19a Created with: gclient setdep -r src-internal@e1f6408da19a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I28d0b7b85a80967148d6411b0a943edd083192b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096086Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748705}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I87da77e5966845dcf4c8e44c6fd54aac6c0f77d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748704}
-
Eugene But authored
DownloadManagerCoordinatorTest.CloseInProgressDownload test fails, because dispatchInstallationNotifierBlock schedules a delayed block execution and that block expect proper setup of WebThread. The expectation flakily fails if tests tear down WebThread environment. The expectation to have WebThread set up is incorrect for delayed block of code in tests and production, because WebThread can be legitimately torn down. This CL removes that DCHECK, but keeps all other DCHECKs that are still active as long as InstallationNotifier object is alive. Bug: 1059885 Change-Id: I9b4b257a5b654923d52840bb314d36ff243269e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095349 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#748703}
-
Dominik Inführ authored
TBR: ssid@chromium.org Change-Id: I4bc532216b495b9975aded3e3ccf62d71596ff6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096735 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748702}
-
Finnur Thorarinsson authored
The SeekBar and RemaininTime need to be marked as clickable for TalkBack to recognize them properly. Setting the ImportantForAccessibility flag is not enough. Bug: 895776, 656015 Change-Id: Ifa923c460c16a88ce1bb2a479c5c623604bb55ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095592 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#748701}
-
Becca Hughes authored
Media feeds are announced to the browser by adding a <link> element in the <head> of the document. This adds a method to fetch them from the renderer and store them in the database. BUG=1058142 Change-Id: I5efa854e72c8dc9d977efe0245f070b9334758a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085734Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#748700}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2663ead23f9a..3ddc82494f77 git log 2663ead23f9a..3ddc82494f77 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 treehugger-gerrit@google.com Merge changes I34fe91e2,Ia93e6d60 2020-03-10 treehugger-gerrit@google.com Merge "processor: TrackEvent: Don't log success statuses as errors :)" Created with: gclient setdep -r src/third_party/perfetto@3ddc82494f77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iecc4a1d1922ef11e2d4b38fb7bcdd49b62d4f957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096085Reviewed-by:
-
Raymond Toy authored
The length attribute was defined as a long instead of unsigned long. We also note that channelIndex for getChannelData(), copyFromChannel(), and copyToChannel() was declared to be a long instead of unsigned long. Fix those too. Bug: 1059305 Change-Id: Ia57fc606e8943de56bb2943b00e19b8beaeb9642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095212Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#748698}
-
Daniel Cheng authored
Bug: 1059157 Change-Id: Ic6d20bad1f0827e3e3e715a6309ab2932307a7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090981Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Spec: the sixth item of https://mikewest.github.io/corpp/#integration-html Fix stale implementation, and add reporting. - Run CORP on redirects. - Use the parent COEP instead of the response COEP value. - Add reporting plumbing. Bug: 887967, 1052764 Change-Id: I3723e671fb7d571dcce741f859d8d831ae7c584e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089183 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#748696}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aafa9b5c733c..bf9df5292254 git log aafa9b5c733c..bf9df5292254 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 jacktfranklin@chromium.org Move utilities test to being built with Ninja 2020-03-10 jacktfranklin@chromium.org Move StringUtilities test into Ninja/TS land. 2020-03-10 szuend@chromium.org [utilities] Remove Array#remove
🎉 2020-03-10 szuend@chromium.org [cleanup] Use Map + Set instead of Object + Array in CSSModel 2020-03-10 szuend@chromium.org [utilities] Remove Map#remove Created with: gclient setdep -r src/third_party/devtools-frontend/src@bf9df5292254 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I22cf8ef2cd65c0059fe1a77eea8c97ee9f199e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096088Reviewed-by: -
Daniel Cheng authored
Bug: none Change-Id: I9691adc8e1a1e652e3f5c9b54746bd358b91ad5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096105 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#748694}
-
Michael Ershov authored
This file is not used anymore after migrating its content into paltform_keys_service.h. Bug: 1045895 Change-Id: I6e2918f9ccc7a8383651eee82b44b514270cb402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096638Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#748693}
-
Side Yilmaz authored
|ProfileKey#getLastUsedProfileKey| always returns regular profile key. Hence, to reduce misconceptions when profiles are used in incognito sessions, |ProfileKey#getLastUsedProfileKey| function is renamed to |ProfileKey#getLastUsedRegularProfileKey|. Bug: 1041781 Change-Id: If945d58c8d8251e965c5c9d5eac7fb2d4744a47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083486Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748692}
-
Jonathan Backer authored
Bug: 1019787 Change-Id: I39ee5bf184349d5511095e1064fe99b38c3136d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095204 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#748691}
-
Jonathan Freed authored
Change-Id: Iaa8b1a6b66ab3d1d10c8c5544a0df1083a959281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092126 Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#748690}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4df814181ef866f68a2242e3e375ace7a6c4d818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096087Reviewed-by:
-
David Roger authored
This function was just a straight wrapper around the SigninErrorControllerFactory but is not defined on ChromeOS. This does not seem very valuable. Moreover, it was only used from AvatarButtonErrorController. And since AvatarButtonErrorController will be needed on ChromeOS, there is no point in keeping this wrapper. Bug: 1041472 Change-Id: If6f7e84dc9250e3d542206022a20620235eb885a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093597Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#748688}
-
Ali Juma authored
This adds an OWNERS file to this recently-added directory. Change-Id: I3ffd7971c195b73a713b518aec4756f6c6d9778a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096776Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#748687}
-
Fredrik Söderquist authored
This is one of those "we're only in it for the ComputedStyle (and notifications)" LayoutObject, so inheriting via LayoutSVGHiddenContainer only adds overhead. Inherit directly from LayoutObject instead. While doing this also rename to LayoutSVGFilterPrimitive to avoid any confusion with LayoutObjects for actual resources. Change-Id: Icfc293d3ece94d56cc2136975f49bd21e7e8d32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094304 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#748686}
-
ckitagawa authored
Fix an issue where TabService attempted to proceed to write the proto even if there was an error. Change-Id: I5734921cd77baa026cc47e47d2656b87f672aa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095012Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#748685}
-
kylechar authored
SkTraceMemoryDump provides Skia a way to produce Chrome memory dumps. The dumpStringValue() function had an empty implementation however. Bug: 1043676 Change-Id: I915ccbcb21ba4462bbb6ade1e66f64df322427ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064820Reviewed-by:
Brian Osman <brianosman@google.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#748684}
-
Mark Cogan authored
Refactors the AppUrlLoadingService to get a Browser from its delegate and not care about TabModel. There should be no functional changes. Also : - Updates TestAppUrlLoadingService to use correct variable naming. Bug: 1046373 Change-Id: I1da8a1033b0bf26972f07908bbe815c6b9d8f4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094308 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748683}
-
Jan Wilken Dörrie authored
This change adds a preference to remember the last time a Bulk Check ran to completion and sets the elapsed_time_since_last_check field on CompromisedCredentialsInfo appropriately. Bug: 1047726 Change-Id: I2115cb582c3edbedd3b1d82df8db362353a286d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095100Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748682}
-
henrika authored
Ensures that style is consistent. Goal is to fix these details before M82 cut. Tbr: olka Bug: 1017219 Change-Id: I69d00b614ec0c1b35464be1ea22f3f79273c473c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089897Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#748681}
-
Nazerke authored
This CL modernizes the ChromeActivityOverlayCoordinator to use |browser| in the initializer. This includes updates in corresponding table view controllers and unittests. Bug: 1029346, 1048395 Change-Id: I8f1a642d1c9d4c1daf67c2fedf554fdde969e0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089830 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#748680}
-
Rainhard Findling authored
* Safety check status-changed events will all contain a display string in the future (see https://crrev.com/c/2089868). This allows for better string customization with pluralization, links, etc. * This CL prepares the remaining two safety check UI elements to expect those strings in state-changed events, and makes them populate the UI from those strings. Bug: 1015841 Change-Id: I6a47829d766b40c29fe504aee2df01174536a318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095074 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#748679}
-
Christian Dullweber authored
Swap the cookies section and the permissions section to have permissions close to the site settings button. Screenshot: https://crbug.com/1040091#c26 Bug: 1040091 Change-Id: If8fb0bb256caa47c05e4c4829763b8c81b73900b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095723Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#748678}
-
David Van Cleve authored
Trust Tokens key commitment responses are served during the issuance and redemption steps of the Trust Tokens (Privacy Pass) protocol. As part of implementing Trust Tokens, we need to fetch and parse these responses during the "issuance" and "redemption" protocol steps, triggered by requests' having been tagged with the corresponding fetch flags. For the preliminary version, these key commitment responses' contents are specified in the design doc: https://docs.google.com/document/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit#bookmark=id.6wh9crbxdizi This CL adds parsing code; a concurrent change adds a flow for requesting these records from issuers' key commitment endpoints. New code: - KeyCommitmentResult describes the information we get from a key commitment response; - key_commitment_parsing.* implement logic and tests for parsing the commitments. We try to err on the side of being very strict, rejecting outright many messages that have any part malformed (for instance, if a record contains three keys and one is bad, the entire message gets thrown out). Bug: 1042962 Change-Id: I3b3d9b0b71bc74f80839b0f14309b990bcbe5a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029292 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#748677}
-
Sorin Jianu authored
ref_counted.h is only needed for defining or instantiating ref counted classes. Change-Id: I9250c12fbd8362aa66861c7cde7fa5a257da3ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094623 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#748676}
-
Mikel Astiz authored
This patch refactors the SyncedBookmarkTracker API to make it less sync-ID-centric (aka server IDs). Instead, entity pointers are proposed (const SyncedBookmarkTracker::Entity*) as handles, following the design principle in BookmarkModel and const BookmarkNode*. This spares a few lookups but otherwise introduces no behavioral changes. Change-Id: Idfcaff7dfc268a29ca3f52e68b54ae11a51c6c71 Bug: 1032052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094982Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748675}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a2cb93d8b965..c782263e5f19 git log a2cb93d8b965..c782263e5f19 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 mbonadei@webrtc.org Whitespace change to kick bots. 2020-03-10 nisse@webrtc.org Delete ACMVADCallback Created with: gclient setdep -r src/third_party/webrtc@c782263e5f19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia61e116d981d45b4e5b10e7a382f3320f73adc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096083Reviewed-by:
-
Guido Urdaneta authored
Adds Origin Trial entry and feature counters for WebRTC Insertable Streams. Intent to experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Oy84pXDhajI Bug: 1052765 Change-Id: I8514438339bb57b3dab07beebde3333b4e0c68f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094123 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#748673}
-
