GitLab

BUG=371824
TBR=blundell

Review URL: https://codereview.chromium.org/315563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274514 0039d316-1c4b-4281-b951-d872f2087c98

BufferedDataSource should accept the 'url' and the 'CORS mode' parameters
in the constructor instead via the initialize() method. This patch makes
this change and now only the 'initializeCallBack' is passed to initialize()
method. Also now the WebMediaPlayerImpl directly queries the BufferedDataSource
whether the resource is local or not, instead of finding it out itself.

Review URL: https://codereview.chromium.org/306953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274513 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/313503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274512 0039d316-1c4b-4281-b951-d872f2087c98

A optionally larger number of buffers makes recording audio in a pnacl module
more reliable when latency is not an issue.

BUG=330851

Review URL: https://codereview.chromium.org/290993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274511 0039d316-1c4b-4281-b951-d872f2087c98

The InfoBarManager::Observer() is used instead.

GoogleURLTrackerMapEntry now makes actual calls on the InfoBarManager (to
register and unregister as an observer). This has some consequences:
- the |infobar_manager_| pointer is no longer const
- the unittest has to create actual instances of InfoBarManager instead of
using placeholder integers.

BUG=373243

Review URL: https://codereview.chromium.org/290453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274510 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379574

Review URL: https://codereview.chromium.org/302293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274509 0039d316-1c4b-4281-b951-d872f2087c98

Mock: https://folio.googleplex.com/chrome-ux/mocks/064-chrome-away-from-chrome/supervised/mirror#%2FPlaypen_210514_mirror-05.png

BUG=372812, 310640

Review URL: https://codereview.chromium.org/297193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274508 0039d316-1c4b-4281-b951-d872f2087c98

PreloadAddressValidator implements the same interface as Chromium's
current AddressValidator but calls libaddressinput AddressValidator to
perform the actual work, to simplify switching Chromium Autofill over to
using libaddressinput. All existing test cases are ported.

The suggestions functionality is currently stubbed out.

R=rouslan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/292313008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274507 0039d316-1c4b-4281-b951-d872f2087c98

This CL do followings to ensure to update thumbnails after the app saves images.

* Add '?nocache=xxx' to FileEntry's URL to ignore browser caches.
* Stop to use drive thumbnails for files that are on the drive but cached
  locally. These files may be edited locally and be out of sync with the local
  cache.
* Specify the current time as modificationTime of the metadata that is
  dispatched when the edited file is saved.

BUG=378648
TEST=manually

Review URL: https://codereview.chromium.org/310433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274506 0039d316-1c4b-4281-b951-d872f2087c98

Previously this had the default app icon (rounded rectangle).

In future we may show the icon of the specific apps that are running.

BUG=333429

Review URL: https://codereview.chromium.org/316503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274505 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378865

Review URL: https://codereview.chromium.org/309533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274504 0039d316-1c4b-4281-b951-d872f2087c98

The test PlatformAppBrowserTest.AppWindowAdjustBounds... is flaky on
the Linux ChromeOS ASan LSan bot. This adds some temporary loggin' to get
some information on where it is hanging.

BUG=377754

Review URL: https://codereview.chromium.org/309223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274503 0039d316-1c4b-4281-b951-d872f2087c98

Issue occurs due to speed switching of focus.

BUG=378765

Review URL: https://codereview.chromium.org/304743007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274502 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358657

Review URL: https://codereview.chromium.org/307223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274501 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the ability to supply CalculateKMeanColorOfPNG with a lower
and upper HSL bound which will be used to select the dominant color.

This CL also adds CalculateKMeanColorOfPNG with only a PNG param as a
convenience method, using sane defaults and a utility function
IsWithinHSLRange for checking whether a given HSL is within the given
HSL range.

BUG=376613
TBR=benwells@chromium.org, estade@chromium.org

Review URL: https://codereview.chromium.org/289283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274500 0039d316-1c4b-4281-b951-d872f2087c98

Fails flakily.

BUG=379170
TBR=finnur
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/311843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274499 0039d316-1c4b-4281-b951-d872f2087c98

The once-off creation logic is no longer needed as app
shortcuts have been enabled by default for a while.

This replaces kAppShortcutsHaveBeenCreated with
kAppShortcutsVersion and allows us to trigger a rebuild
of all app shortcuts. This is only implemented for Mac.

BUG=266725

Review URL: https://codereview.chromium.org/263403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274498 0039d316-1c4b-4281-b951-d872f2087c98

At most of the places default_url was changed to destination_url, however, it was missed at some places.
This patch changes the remaining default_url(s) to destination_url.

BUG=378737

Review URL: https://codereview.chromium.org/301933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274497 0039d316-1c4b-4281-b951-d872f2087c98

Previously, there would be a brief moment where the last two icons of
the centered app list (--enable-centered-app-list) were not visible.
Use the correct number of cols/rows instead of assuming 4x4.

BUG=380015
TEST=With --enable-centered-app-list, click the app launcher button
*immediately* after logging in. Should not be able to see missing icons
(pay attention to the last two icons).

Review URL: https://codereview.chromium.org/311753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274496 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ajuma
NOTRY=True
cq failures are unrelated to this CL

Review URL: https://codereview.chromium.org/314563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274495 0039d316-1c4b-4281-b951-d872f2087c98

Fails flakily.

BUG=377636
TBR=yoshiki
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/314603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274494 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scherkus@chromium.org

Review URL: https://codereview.chromium.org/310743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=scottmg@chromium.org
TBR=satorux@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/301233007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274491 0039d316-1c4b-4281-b951-d872f2087c98

This should be safe to use now that our ashmem implementation
of discardable memory handles high memory usage properly.

BUG=330041
TBR=jamesr

Review URL: https://codereview.chromium.org/261663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274490 0039d316-1c4b-4281-b951-d872f2087c98

Fails flakily.

BUG=359204
NOTRY=true
NOTREECHECKS=true
TBR=dmazzoni

Review URL: https://codereview.chromium.org/315583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274489 0039d316-1c4b-4281-b951-d872f2087c98

The viewport tag makes the test fail for unknown reasons on just one
bot: win7-nvidia-release.

BUG=368495

Review URL: https://codereview.chromium.org/313513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274488 0039d316-1c4b-4281-b951-d872f2087c98

Resized the icon in the Uninstall dialog to be 64x64 px instead of
69x69px, so that it matches the icon in the App Info dialog where
it can be launched. This also removes fuzzing effects on icons
that have to be resized from 64x64 icons.
Also fixed the duplication of this constant by letting the view
resize the icon it receives, rather than having it request one size of
icon and then resize it a second time.

[Mac] XIB change:
  - Resized the icon in the Install dialogs from 69x69 to 64x64

Screenshots on bug.

BUG=379613

Review URL: https://codereview.chromium.org/301063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274487 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=378588

Review URL: https://codereview.chromium.org/309443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274486 0039d316-1c4b-4281-b951-d872f2087c98

The existing implementation in fact does not check whether the file is
writable or not (see below for the detail.)
Since the current behavior itself is fine for the use cases,
this CL renames the relevant functions, and refactors the implementation
so that the intent is clearer.

Existing implementation tries to open a file with CREATE|READ|WRITE flags
and verifies that the result is either FILE_OK or ALREADY_EXISTS.

This _succeeds_ when read-only file already existed at the location
because ALREADY_EXISTS error precedes write failure.
Considering the fact, it is essentially equivalent to open with OPEN_ALWAYS|READ
and comparing the result just against FILE_OK.

BUG=367028

Review URL: https://codereview.chromium.org/306073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274485 0039d316-1c4b-4281-b951-d872f2087c98

Did not see any problems running these two tests locally for a few
hours.

BUG=355952
TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/302313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379037

Review URL: https://codereview.chromium.org/307943009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274483 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 6cff678a.

The tests should have been fixed with these CLs:
https://codereview.chromium.org/310493002/
https://codereview.chromium.org/302153003/

BUG=chromium:379140
NOTRY=true
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/304153017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274482 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds browser tests for the new gallery.
The tests are run in the Gallery extension directly as following steps.

1. The test extension contains test cases are loaded by C++.
2. The test extension send a message to the Gallery.app.
3. Gallery.app loads a test from the test extension.

BUG=374709
TEST=run the added test.

Review URL: https://codereview.chromium.org/304683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274481 0039d316-1c4b-4281-b951-d872f2087c98

[IME] Remove the flag g_use_wrapped_extension_keyboard_layouts, and clean up the scattered & hard-coded extension IDs.

BUG=379437,379449
TEST=None

Review URL: https://codereview.chromium.org/309623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274480 0039d316-1c4b-4281-b951-d872f2087c98

Fragments (e.g. "#hoge") in document url should be stripped before it's passed
to the SW because it's not necessary to match registrations.


BUG=379048
TEST=manual (open a controlled page whose URL contains fragments)

Review URL: https://codereview.chromium.org/308053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274479 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354046

Review URL: https://codereview.chromium.org/306053013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274478 0039d316-1c4b-4281-b951-d872f2087c98

ServiceWorkerDispatcher used to mint new WebServiceWorkerImpl
instances every time it was passed a representation of a Service
Worker. Ultimately, this causes user script to see distinct objects
representing the same Service Worker, which is Confusing and
Wrong. This patch makes ServiceWorkerDispatcher use its table of
existing WebServiceWorkerImpls to consistently represent a
ServiceWorker with the same object.

A chunk of this patch is concerned with making it explicit when a
ServiceWorkerHandleReference, which a WebServiceWorkerImpl wraps, is
being created in the renderer (and should send an add-ref message to
the browser) versus being adopted in the renderer.

BUG=361907
TEST=ServiceWorker*

Review URL: https://codereview.chromium.org/309503014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378338

Review URL: https://codereview.chromium.org/301353008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274476 0039d316-1c4b-4281-b951-d872f2087c98

1) Fix Namespace comment in admin_policy.h
2) Mark explicit to single-argument constructors in file_highlighter.h
   and test_extensions_browser_client.h
3) Use CHECK_GT instead of CHECK in process_manager.cc

BUG=

Review URL: https://codereview.chromium.org/308913006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274475 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369703

Review URL: https://codereview.chromium.org/301353011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274474 0039d316-1c4b-4281-b951-d872f2087c98