GitLab

R=phajdan.jr@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/543323002

Cr-Commit-Position: refs/heads/master@{#293982}

BUG=402081
R=gab@chromium.org

Review URL: https://codereview.chromium.org/553053002

Cr-Commit-Position: refs/heads/master@{#293981}

Slice up the tiled image just like CursorLoaderX11 does and pass it on
to CursorFactory as a vector, hotspot, and frame delay.

Also add stub implementation for BitmapCursorFactoryOzone that just
creates a static cursor with the initial frame.

R=sky
BUG=343245
TEST=viewed css "wait" cursor on cros link_freon

Review URL: https://codereview.chromium.org/543823002

Cr-Commit-Position: refs/heads/master@{#293980}

GetAllFoldersWithDepth is used to get all folders under which users are able to move their own bookmarks. Mobile, other, root node and managed folder are not included in the returned result.

BUG=386785

Review URL: https://codereview.chromium.org/506353003

Cr-Commit-Position: refs/heads/master@{#293979}

BUG=407376
TEST=no visible change

Review URL: https://codereview.chromium.org/545963003

Cr-Commit-Position: refs/heads/master@{#293978}

Some packages used in linux builds are not used on CrOS, and
indeed are not even installed in the CrOS build chroot. Exclude
them so that the GN build doesn't try to run pkg-config on
packages that aren't installed.

BUG=388412
TEST=Create a target that builds //mojo/public, build with os==chromeos
R=brettw

Review URL: https://codereview.chromium.org/556733002

Cr-Commit-Position: refs/heads/master@{#293977}

https://skia.googlesource.com/skia/+log/90dc6412b46fa0bcf01ce45feeb4934fb774e7eb..32673b99a4fb5d798206eb7665b730ed0b4597a0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/554293004

Cr-Commit-Position: refs/heads/master@{#293976}

Modify the createSession() call to use the new version (0 parameters)
and call generateRequest() once it is available.

BUG=358271
TEST=EME browser_tests pass with and without generateRequest() changes

Review URL: https://codereview.chromium.org/544283002

Cr-Commit-Position: refs/heads/master@{#293975}

Review URL: https://codereview.chromium.org/559583004

Cr-Commit-Position: refs/heads/master@{#293974}

This allows us to get rid of the page_set dependency in discover.py,
since it eliminates the last call to IsPageSetFile.

BUG=

Review URL: https://codereview.chromium.org/551883003

Cr-Commit-Position: refs/heads/master@{#293973}

GLRenderer already can handle blend modes, so it should be handled for
SoftwareRenderer too.
Blending layers get their own rendering surface for the time being,
so blending should be applied only on render pass quads.

BUG=314865

Review URL: https://codereview.chromium.org/532003003

Cr-Commit-Position: refs/heads/master@{#293972}

BUG=

Review URL: https://codereview.chromium.org/554753003

Cr-Commit-Position: refs/heads/master@{#293971}

https://chromium.googlesource.com/chromium/blink/+log/9f1c0c1143fb771cb53750d5d0b7913a95f84b8b..8c33177074ab109238d17fd4559691dcabe2a46d
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/555903002

Cr-Commit-Position: refs/heads/master@{#293970}

Otherwise when opening a new window (and initially drawing it), the button
will not take the auth error icon's size in consideration.

BUG=411962

Review URL: https://codereview.chromium.org/555923002

Cr-Commit-Position: refs/heads/master@{#293969}

Suppress most deprecated warnings except for imports.

BUG=398669

Review URL: https://codereview.chromium.org/555113002

Cr-Commit-Position: refs/heads/master@{#293968}

Use a base::CallbackList<void(HistoryService*, const std::set<GURL>&) to
register and notify objects interested in change to favicon urls. The
callback will be sent at the point the notification would have been called.

Refactor HistoryBackend and HistoryService to change how the notification
is forwarded (remove the notification and introduce explicit methods).

Change how notification are forwared on android from a pair of vector of
notification type and notification detail to a list of callbacks.

BUG=373320

Review URL: https://codereview.chromium.org/484213002

Cr-Commit-Position: refs/heads/master@{#293967}

This is a step to unifying different domains handling and using
code generation later.

BUG=none

Review URL: https://codereview.chromium.org/558613002

Cr-Commit-Position: refs/heads/master@{#293966}

BUG=411178

Review URL: https://codereview.chromium.org/545953002

Cr-Commit-Position: refs/heads/master@{#293965}

build/config/linux/BUILD.gn:
* Usage of generate_library_loader for libbrlapi was incorrect; there
* was nothing provided for "functions". This is now an empty list.

chrome/chrome_common.gypi
chrome/common/BUILD.gn
* Reference to a removed file, chrome_version_info_linux.cc

chromeos/BUILD.gn
components/pairing/BUILD.gn
* Usage of removed proto_{in,out}_dir in proto_library rules.

content/gpu/BUILD.gn
* Typo in reference to third_party/libva:libva_config

ui/views/BUILD.gn
* Attempt to filter source files out of
* gypi_values.views_unittests_sources by subdirectory path. Fortunately
* that variable already doesn't include the files that were supposed
* to be filtered out, so the rule is simply removed.

BUG=388412
TEST=Create a target that builds //mojo/public, build with os==chromeos

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/550423002

Cr-Commit-Position: refs/heads/master@{#293964}

edbf8a Convert GN visibility to be a list
1efeee Merge performance fix for cmsDupToneCurve
4cf369 Compat bugfix

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/551923005

Cr-Commit-Position: refs/heads/master@{#293963}

The original test failed on XP:
manage_passwords_bubble_view_browsertest.cc(68): error: Value of: ManagePasswordsBubbleView::manage_password_bubble()-> IsFadingAway()
Actual: false
Expected: true

BUG=412340

Review URL: https://codereview.chromium.org/556793004

Cr-Commit-Position: refs/heads/master@{#293962}

Remove WebViewFocusHelper; r287082 had object lifetime issues.

Fix Issue 368691 with a WebDialogWebContentsDelegate instead:
Remove CreateConstrainedWebDialog's |tab_delegate| parameter.
Delete the custom PrintPreviewWebContentDelegate subclass.
Add a consolidated WebDialogWebContentsDelegateViews instead.
(ensures WebView focus and forwards dialog shortcut keys)

TODO(followup): Additional WebUI dialog creation cleanup.

BUG=410158,368691
TEST="Show as tab" doesn't crash popups with print dialogs. Focusing print dialog <-> omnibox works.
R=ben@chromium.org

Review URL: https://codereview.chromium.org/538203002

Cr-Commit-Position: refs/heads/master@{#293961}

With commit 2148b92f, ui_unittests is now in
ui/base/ui_base_tests.gyp.

To mirror this change in GN, we moved the unittests target into
ui/base/BUILD.gn

BUG=331829,373148,299841,103304
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn ui/base:unittests
R=brettw@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/553693002

Cr-Commit-Position: refs/heads/master@{#293960}

BUG=115472

Review URL: https://codereview.chromium.org/551093003

Cr-Commit-Position: refs/heads/master@{#293959}

Rework strings in the keyboard overlay so they'll fit inside
of the keys. Omitting some repetition, the changes are:

  Activate last launcher item -> Last shelf item
  Activate last tab -> Last tab
  Activate launcher item 1 -> Shelf item 1
  Activate next tab -> Next tab
  Activate tab 1 -> Tab 1
  Bookmark current page -> Add bookmark
  Cycle through input methods -> Next input method
  Find text again -> Find again
  Focus address bar in search mode -> Focus address bar for search
  Focus launcher -> Focus shelf
  Focus next pane -> Next pane
  Lock screen or power off -> Lock / power
  Magnifier decrease zoom -> Demagnify
  Magnifier increase zoom -> Magnify
  Maximize window -> Maximize
  Minimize window -> Minimize
  Open address in new tab -> Open in new tab
  Open file manager -> File manager
  Open Google Cloud Print -> Google Cloud Print
  Reload current page -> Reload
  Select previous input method -> Previous input method
  Show the Chrome menu -> Show Chrome menu
  Show message center -> Message center
  Show status menu -> Status menu
  Take screenshot -> Screenshot
  Toggle bookmark bar -> Bookmark bar
  Toggle caps lock -> Caps Lock
  Toggle Chromevox (spoken feedback) -> ChromeVox (spoken feedback)
  Toggle projection touch HUD -> Projection touch HUD
  Toggle speech input -> Speech input
  View keyboard overlay -> Keyboard overlay

Also update more "launcher" references to instead be
"shelf".

BUG=248353,412132
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/550373002

Cr-Commit-Position: refs/heads/master@{#293958}

r1974: Changes ninja generator to only output empty names if not already output
r1973: Changes the ninja generator to output phony targets for uninteresting targets

BUG=410410
TEST=none
R=thakis@chromium.org
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/555853003

Cr-Commit-Position: refs/heads/master@{#293957}

Original CL: https://codereview.chromium.org/522463005

TBR=kenrb@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/554083002

Cr-Commit-Position: refs/heads/master@{#293956}

BUG=266484
TBR=mcasas@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/554323002

Cr-Commit-Position: refs/heads/master@{#293955}

Fixes webrtc/ Debug build with libc++ which failed to link std::getline
as this is defined in <istream>. <iostream> causes static initializers
and shouldn't be necessary.

Also adds to README.chromium that the overrides are used too get rid of
static initializers and to build on libc++.

R=thakis@chromium.org
TBR=ronghuawu@chromium.org
BUG=webrtc:3739

Review URL: https://codereview.chromium.org/552013004

Cr-Commit-Position: refs/heads/master@{#293954}

BUG=412367

Review URL: https://codereview.chromium.org/552983002

Cr-Commit-Position: refs/heads/master@{#293953}

NOTRY=true

Review URL: https://codereview.chromium.org/551703002

Cr-Commit-Position: refs/heads/master@{#293952}

Bug was introduced in https://codereview.chromium.org/485083002 .

BUG=410537

Review URL: https://codereview.chromium.org/559543002

Cr-Commit-Position: refs/heads/master@{#293951}

https://skia.googlesource.com/skia/+log/87c4138fae37ba6b7e4de7acc3fce19524d726ea..90dc6412b46fa0bcf01ce45feeb4934fb774e7eb

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/559563003

Cr-Commit-Position: refs/heads/master@{#293950}

Visibility tracks whether the view itself is visible and drawn whether
all the views ancestors are visible and connected to the root.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/557573002

Cr-Commit-Position: refs/heads/master@{#293949}

Bug was introduced in https://codereview.chromium.org/421113002 .

BUG=

Review URL: https://codereview.chromium.org/552353002

Cr-Commit-Position: refs/heads/master@{#293948}

1. Previously, we didn't animate the browser actions
   container when the visible count changed, because we set
   the width prior to calling animate. Fix it by animating to
   the desired width.
2. There was a bug where we would improperly hide an extension
   upon loading another, because we wouldn't account for the
   chevron width. Fix this, and add a test.

BUG=410348
BUG=410361

Review URL: https://codereview.chromium.org/539543002

Cr-Commit-Position: refs/heads/master@{#293947}

It was running in Chrome's unit_tests suite for historical reasons.

BUG=397164
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/554963002

Cr-Commit-Position: refs/heads/master@{#293946}

BUG=391488

Review URL: https://codereview.chromium.org/556863004

Cr-Commit-Position: refs/heads/master@{#293945}

__get_item__ enumerates ExtensionBackendList, and when it discovers
a matching index, it access ExtensionBackendList at that index. However,
ExtensionBackendList.__get_item__ calls Update, which can invalidate index.

BUG=411612
TEST=extension_unittest

Review URL: https://codereview.chromium.org/555823002

Cr-Commit-Position: refs/heads/master@{#293944}

This CL adds a BASE_EXPORT to EnabledStateObserver class. This CL is a
part of the effort to get NetLog data into tracing. Since
EnabledStateObserver is not base exported, we would like it to be so
that we can use it outside base.

BUG=399701

Review URL: https://codereview.chromium.org/551333003

Cr-Commit-Position: refs/heads/master@{#293943}