- 12 Jun, 2017 40 commits
- 
- 
Mike Dougherty authoredTo adhere to Coding Guidelines for Cocoa, rename this method to |webState:didPruneNavigationItemsWithCount:|. Bug: Change-Id: Ibc07ab7012e1490b03e2e5ff814270ce4186ab11 Reviewed-on: https://chromium-review.googlesource.com/531464Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#478822} 
- 
Scott Graham authoredBug: 707029, 706592 Change-Id: I08963922fd177c0023e9be1f6eb82491b4f33dcb Reviewed-on: https://chromium-review.googlesource.com/531658Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#478821} 
- 
alokp authoredReland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2926143002/ ) Reason for revert: Fixed failing tests. Original issue's description: > Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ ) > > Reason for revert: > Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530. > > Original issue's description: > > Moves mojo_js_integration_tests into blink. > > > > BUG=699569 > > > > Review-Url: https://codereview.chromium.org/2734783008 > > Cr-Commit-Position: refs/heads/master@{#477549} > > Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e > > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=699569 > > Review-Url: https://codereview.chromium.org/2926143002 > Cr-Commit-Position: refs/heads/master@{#477653} > Committed: https://chromium.googlesource.com/chromium/src/+/6536a56d25c245bd109e32ed49240bfc04f8890f TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699569 Review-Url: https://codereview.chromium.org/2920383004 Cr-Commit-Position: refs/heads/master@{#478820} 
- 
Thiago Farina authoredHeader files should be listed in the sources list, so gn analyze can work. https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0 https://groups.google.com/a/chromium.org/d/topic/chromium-dev/1kK45mVemBc/discussion BUG=661774 TBR=jamescook@chromium.org Change-Id: I68020668044858be898ce6d18392ee8610cf22f4 Reviewed-on: https://chromium-review.googlesource.com/531030 Commit-Queue: Thiago Farina <tfarina@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#478819} 
- 
Philip Rogers authoredThis patch removes orientation() and scroll_element_id() from ScrollbarLayerInterface as these are not used. The corresponding getters/setters on ScrollbarLayerImplBase are needed but the Layer interface is only used to pass these values along. BUG: 723263 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4631dc469b1f6776f3e6d4246bed39d94316822f Reviewed-on: https://chromium-review.googlesource.com/530490Reviewed-by: Chris harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#478818} 
- 
sadrul authoredThis hooks up the ozone code so it can deal with --use-gl=swiftshader flag correctly. BUG=704285 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2926423002 Cr-Commit-Position: refs/heads/master@{#478817} 
- 
Victor Costan authoredBUG=644725 Change-Id: I37cefb2eedbf8d1771413eb0b5f70370ed7de9dd Reviewed-on: https://chromium-review.googlesource.com/531671Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#478816} 
- 
warx authoredR=xiyuan@chromium.org BUG=730037 TEST=tested that enabling the new launcher with --enable-features=EnableFullscreenAppList, search box will show "Search your Chromebook, apps, web..." hint text; disabling the flag falls to current behavior. Review-Url: https://codereview.chromium.org/2934883002 Cr-Commit-Position: refs/heads/master@{#478815} 
- 
schenney authoredWalk up the layer tree from a layer that needs an AncestorChildClippingMaskLayer to find all border radius clips to apply. Several auxiliary changes were required. The code in CLM for determining if a mask layer is needed has also been reworked to test against all clips. Make LayerClipRecorder::CollectRoundedRectClips a public static member so that CLM can use it to determine if the mask layer is required. Also expand the conditions in which LayerClipRecorder uses the method to catch all cases where masks need rounded clips. Make several PaintLayer methods const, because they can be and we need them so. New tests for various cases of border radius where not just the parent layer needs checking, or where we need to skip over the parent layer and still check. R=chrishtr@chromium.org BUG=672561 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2923683002 Cr-Commit-Position: refs/heads/master@{#478814} 
- 
Xianzhu Wang authoredThe optimization reduces the cost of the invocation path from ObjectPaintInvalidator to CC layer for rectangles covered by parent objects. However, the optimization is not applicable to SPv2 causing some text-based-repaint tests producing different results. To reduce differences, for SPv1, still track the optimized rectangle but the rectangle won't affect any other functionality including raster-under-invalidation checking. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8642470dd8058dcde25ae6b5392c6ed572ba405f Reviewed-on: https://chromium-review.googlesource.com/529525 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#478813} 
- 
dougarnett authoredBackground: the original client-based preview fallback support that existed in RenderFrameImpl::SendDidCommitProvisionalLoad for main frame responses was removed in CL 2856223008. This CL now adds fallback support back in at the same call site but introduces a helper method to better isolate the (now more complicated) logic with unittests. This CL also adds integration tests that cover ECT header test coverage requested in bug 691135. BUG=701802,691135 Review-Url: https://codereview.chromium.org/2910783002 Cr-Commit-Position: refs/heads/master@{#478812} 
- 
Quinten Yearsley authoredChange-Id: I5f27a3208aa76435c126ce7b1f041d5739fd64d6 Reviewed-on: https://chromium-review.googlesource.com/530037 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#478811} 
- 
jialiul authored(Client side malware detection is already enabled on https). BUG=730895 Review-Url: https://codereview.chromium.org/2927123004 Cr-Commit-Position: refs/heads/master@{#478810} 
- 
Andrey Kosyakov authoredThis is a follow-up https://codereview.chromium.org/2883143003 that brings back tracking of timelines started with page reload (the meaning of which is somewhat different now). Change-Id: I8cde7aba72290dd99b42ddb36d2b1f3a989d0a9c Reviewed-on: https://chromium-review.googlesource.com/531875Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#478809} 
- 
Matthew Jones authoredThis change adds another variation to the swipe logic experiment; enabling swipe on the expand button. This change also generalizes the allowed swipe range to work with or without the experiments enabled. - "restrict-area" will only work if there is no expand button. - "button-only" will only work if the expand button is enabled. BUG=731288 Change-Id: I04f7479c91827bb0bc1019d0e86c7b75588c7c00 Reviewed-on: https://chromium-review.googlesource.com/530094 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#478808} 
- 
ccameron authoredRemove windows-specific baselines, since they now match all other platforms. BUG=731153 TBR=qyearsley Review-Url: https://codereview.chromium.org/2940433002 Cr-Commit-Position: refs/heads/master@{#478807} 
- 
erg authoredBUG=732060 Review-Url: https://codereview.chromium.org/2933893002 Cr-Commit-Position: refs/heads/master@{#478806} 
- 
rlanday authoredOn most platforms, right-clicking a misspelled word only selects it and shows suggestions in the context menu if you right-clik in the interior of the word. In https://codereview.chromium.org/2925363002, I modified some of the spellcheck code (specifically, the method that replaces the misspelled word) to support the case where we have a caret selection immediately before or after a word, since tapping at a word boundary should open the spellcheck menu on Android (this feature is still in progress, but this is the behavior for a native EditText widget, so we're trying to match it.) This CL adds a test case to verify we don't accidentally change the behavior for other platforms. BUG=715365 Review-Url: https://codereview.chromium.org/2932123002 Cr-Commit-Position: refs/heads/master@{#478805} 
- 
ryansturm authoredThis behavior is no longer supported. BUG=731922 Review-Url: https://codereview.chromium.org/2934663002 Cr-Commit-Position: refs/heads/master@{#478804} 
- 
jschuh authoredBUG=672489 Review-Url: https://codereview.chromium.org/2931323002 Cr-Commit-Position: refs/heads/master@{#478803} 
- 
Fernando Serboncini authoredCurrently only being used on FontCache, to be used on other Font-related classes. Bug: 730692 Change-Id: I58f66d6cf59dca83be5133fc273136ce408e5b2e Reviewed-on: https://chromium-review.googlesource.com/531753 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#478802} 
- 
tommycli authoredBUG=729197 TBR=groby@chromium.org Review-Url: https://codereview.chromium.org/2927193002 Cr-Commit-Position: refs/heads/master@{#478801} 
- 
wychen authoredBUG=661774 Review-Url: https://codereview.chromium.org/2936433002 Cr-Commit-Position: refs/heads/master@{#478800} 
- 
David Benjamin authoredBUG=none Change-Id: Ic4359354e152c4af266554252a3728af1efd0e02 Reviewed-on: https://chromium-review.googlesource.com/529584 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#478799} 
- 
jameswest authoredUse RepeatingCallback for BindingSet connection error handlers because the error handlers can be called for each entry in the set. BUG=NONE TEST=mojo_public_bindings_unittests Review-Url: https://codereview.chromium.org/2932193002 Cr-Commit-Position: refs/heads/master@{#478798} 
- 
kristipark authoredScreenshot of the change in the bug. Since the entry response time is given as an internal UTC format, I added wrapper methods to Time.h to convert it to standard UTC format. BUG=727922 Review-Url: https://codereview.chromium.org/2928833002 Cr-Commit-Position: refs/heads/master@{#478797} 
- 
catapult-deps-roller@chromium.org authoredhttps://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7ba431f75da5..e663166b9cf3 $ git log 7ba431f75..e663166b9 --date=short --no-merges --format='%ad %ae %s' 2017-06-12 benjhayden Fix histogram-span for Histograms with a single sample with diagnostics. 2017-06-12 charliea Move myself to tracing/ OWNERS emeriti 2017-06-12 phsilva Remove left-over file from story runner unittests 2017-06-12 xunjieli Add initial web-page-replay-go code 2017-06-12 benjhayden Replace some single quotes in value/ui/ with double-quotes for consistency. 2017-06-12 benjhayden Add instantiation tests for date-range-span. 2017-06-12 charliea Stops the BattOr shell after receiving an invalid git hash 2017-06-12 kraynov Android systrace: Graphics memory reporting in atrace_helper. 2017-06-12 simonhatch Telemetry - Generate TagMap diagnostic in benchmark and attach to results. 2017-06-12 benjhayden Fix polymer_postload in tracing/ui. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I38b0071240ac342bf1da9d5cf5d6f2855f9cbb3b Reviewed-on: https://chromium-review.googlesource.com/531784 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478796} 
- 
Matthew Jones authoredIf the bottom_sheet_snackbar_container is the last view in the coordinator layout, the margin property is not respected. This change moves the empty_container_stub to be the last item since order for this item is not particularly important. BUG=732222 Change-Id: I5eb506cf0da38a252f579b4d2d11d82794b6b71d Reviewed-on: https://chromium-review.googlesource.com/531803Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#478795} 
- 
jbauman authoredDirectCompositionSurfaceWin remains as the host of the DCLayerTree, while DirectCompositionChildSurfaceWin handles drawing to the IDCompositionSurface itself. This will allow us to have more Surfaces in the layer tree in the future. BUG=726957 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2926763002 Cr-Commit-Position: refs/heads/master@{#478794} 
- 
Justin DeWitt authoredAdds an OfflineEventLogger to PrefetchDispatcher. GCM message handler now notifies the dispatcher when a message arrives. Bug: 701939 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I02de62ca3fd4eb7ca9fa98aff8431a37861cb361 Reviewed-on: https://chromium-review.googlesource.com/523163 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dmitry Titov <dimich@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#478793} 
- 
mmenke authoredIt subclasses ProfileIOData, which always makes and sets a CTVerifier for the MainURLRequestContext, but the OffTheRecordProfileIOData was replacing the pointer with on to the system context's CTVerifier. Both verifiers are created with the same arguments, so this doesn't seem to server any useful purpose. The CTVerifier created by ProfileIOData contains no reference to outside data, other than CTLogs and as an STH Observers, so it should be fine to use for Incognito mode (Also note that it is not shared between Incognito and non-Incognito). BUG=732537 Review-Url: https://codereview.chromium.org/2936643004 Cr-Commit-Position: refs/heads/master@{#478792} 
- 
Ken Rockot authoredImplements two new public C API calls: MojoCreateMessage and MojoGetMessageContext. This constitutes the bulk of what's needed to support basic lazy message serialization as described in the proposal[1]. Follow-up CLs will introduce additional API surface - namely MojoSerializeMessage and MojoGetSerializedMessageContents -- and rename or rework existing APIs to match the details of the proposal. [1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/4CA0Ip56lgA BUG=725321 Change-Id: Ifdd0ee9ed69ab49c6324ea3f02e1efab74ea5175 Reviewed-on: https://chromium-review.googlesource.com/527556 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#478791} 
- 
Antoine Labour authoredSimply reuses the existing command buffer fuzzer, but with a SwiftShader backend. Bug: swiftshader:51 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I40f595c830f82c791033383d68f4b2802a35b8b2 Reviewed-on: https://chromium-review.googlesource.com/514246Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#478790} 
- 
Robert Liao authoredThis allows other callers to use it without including iat_patch_function.h. Principally, this will be used for the upcoming CoCreateInstance DCHECK. BUG=708303 TBR=gab@chromium.org Refactor. No impact to running code. Change-Id: Ibd25de76a2e9bf858619c6fccc18a46704237067 Reviewed-on: https://chromium-review.googlesource.com/531668 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#478789} 
- 
yuweih authoredThis CL adds a template for building CRD iOS target so that we can easily implement the production target by adding new sources or deps. Eventually logic for authentication and settings menu will be moved out of the template. BUG=731851 Review-Url: https://codereview.chromium.org/2934593002 Cr-Commit-Position: refs/heads/master@{#478788} 
- 
thildebr authoredIt's possible for us to get a null icon from getInstantAppLaunchData, so perform a null check before using the icon in InfoBarLayout. BUG=731801 Review-Url: https://codereview.chromium.org/2936703002 Cr-Commit-Position: refs/heads/master@{#478787} 
- 
bnc authoredAlso, on an unrelated note, change BidirectionalStreamTest base class from TestWithParam<> to Test, since no parameters are used. Review-Url: https://codereview.chromium.org/2936663002 Cr-Commit-Position: refs/heads/master@{#478786} 
- 
Mike Baxley authoredAPI change to pass GURL by reference. Bug: 646586 Change-Id: I993cd98e3c8f17ac9fb85c632dcc0d253fcf358a Reviewed-on: https://chromium-review.googlesource.com/531739Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#478785} 
- 
danakj authoredNow that we have no DisplayItems and DisplayItemList is holding a PaintOpBuffer, there are no consumers of cc::ContiguousContainer. The PaintOpBuffer does a similar job for PaintOps. So we can remove this class from the codebase. R=weiliangc@chromium.org Bug: 671433 Change-Id: Id11741b42bb0a75ab4a6c6db11779773741df2fd Reviewed-on: https://chromium-review.googlesource.com/531669Reviewed-by: Weiliang Chen <weiliangc@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#478784} 
- 
justincohen authoredThis reverts commit 1c7e3e09. Breaks PhoneSimulator and TabletSimulator bots: Failed steps failed ios_chrome_integration_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_settings_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_ui_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed ios_internal_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed failure reason [0612/124347.435892:FATAL:browser_view_controller.mm(995)] Check failed: _isShutdown. -shutdown must be called before dealloc. TBR=sdefresne@chromium.org BUG= Review-Url: https://codereview.chromium.org/2930363003 Cr-Commit-Position: refs/heads/master@{#478783} 
 
-