- 28 Sep, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601272286-d5061451d97ba33a632a304f531ce91f70d7428a.profdata to chrome-mac-master-1601294375-805284c073a4c807365387c8b737f70c270f4966.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id9156081c22a3a4e13f1fc038634c63f4941747d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811226}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d2f6cc6f606c..059781eddd4e 2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 7f9879b1b1fa to e1ba543c6789 (1 revision) 2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 9e17b9d07a25 to 4b07d50cd9a0 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I65dc84f58b6d2acca645cea0b4e972b0e59acbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435258Reviewed-by:
-
Viktor Semeniuk authored
This change adds possibility to edit username in Settings > Passwords. If edited username is already used for the same website error message is shown. Bug: 377410 Change-Id: Ifbd45f459e2d6731f8e5fd6bf7df069efd6999ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424315 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#811224}
-
Saurabh Nijhara authored
Currently we are only reporting metrics when force installed extensions either fail installation or ExtensionRegistry's OnExtensionLoaded (...) event is received. This CL reports the time elapsed for enterprise policy forced extensions to become ready for use by reporting statistics when force installed extensions either fail installation or ExtensionRegistry's OnExtensionReady(...) event is received. These statistics are being collected as part of the effort to improve force installed extensions reliability. Following histogram is added: Extensions.ForceInstalledReadyTime Bug: 1131418 Change-Id: Ief524819deb8cca81231765439700c265d9e7b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424286Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#811223}
-
Caitlin Fischer authored
The switch appears to be unused. Bug: 1126640 Change-Id: I07728ca316e91051c349615b49304e27c3e81ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427074Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#811222}
-
Adam Rice authored
Change the expectations for the web test fast/dom/Window/window-postmessage-clone-deep-array.html so that it no longer produces "unexpected pass" messages. The test still fails, but this is handled by an -expected.txt file only, without an entry in TestExpectations. Change-Id: Icfb89c4942cc9147fa3d24972464d5f2eeda31aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432704Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#811221}
-
Maksim Sisov authored
RGBX_8888 shall be used as buffer format with images without alpha. However, Chromium doesn't allow it to use for scanout in some parts of the code, and allows to use in other. Thus, temporarily disable usage of RGBX_8888 and always use either RGBA or BGRA_8888 for images with alpha and no alpha. Bug: 1128997 Change-Id: I4a3a8ad102d46d6dc12ccaba4cbade41432d6b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434928 Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811220}
-
Maxim Kolosovskiy authored
has_script is going to be divided into |has_script| and |has_auto_change_button|. It will be done in several steps for easier reviewing: 1. The existing |has_script| will be renamed to |has_auto_change_button| 2. A "new" |has_script| will be introduced, where |has_script|== |has_auto_change_button| (this CL). 3. Implement special logic for the new |has_script|. Bug: 1132230 Change-Id: I71dd73842b406fd9c82f4f11e57b7631febfcb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431925Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#811219}
-
Yunke Zhou authored
Bug: 1131570 Change-Id: Ibf136d963c183d40a87968e483bb01baac9fec67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435348Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#811218}
-
Omar Morsi authored
This CL removes PermissionsForExtension class from KeyPermissionsService* and converts it into a service (ExtensionKeyPermissionsService). With this CL, only service operations in the context of a profile should be handled by KeyPermissionsService and only service operations in the context of a (profile, extension) pair should be handled by ExtensionKeyPermissionsService. Bug: 1127284 Change-Id: I54acf3af8d234129c070a3342b9e90e447c6982c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429064 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811217}
-
David Grogan authored
ComputeMinMaxSizes needs a ConstraintSpace when the child is not in a parallel writing mode. Flex wasn't providing one when it retrieved a table's intrinsic min size. Before this bug was introduced, flex was calling ComputeMinAndMaxContentContribution(..., table, ...) instead of table.ComputeMinMaxSizes(...). ComputeMinAndMaxContentContribution builds its own ConstraintSpace for ortho items, so flex didn't need to provide one. We originally switched from ComputeMinAndMaxContentContribution to table.ComputeMinMaxSizes because: * One input to the flex algorithm is the item's used min-width (for a row flexbox). The flex algorithm will never assign a flex item a width smaller than its used min-width. For most elements, we get this value via ResolveMinInlineLength(..., style.LogicalMinWidth(), ...). * But table's used min-width is defined specially to be "the greater of the resolved min-width, CAPMIN, and GRIDMIN". So to get the table-as-flex-item's used min-width, we need to retrieve max(CAPMIN, GRIDMIN) in addition to resolving style.LogicalMinWidth from the above step. * ComputeMinAndMaxContentContribution(table).min returns max(CAPMIN, GRIDMIN, style.LogicalWidth()). I.e. it obeys any specified width on the table. * But table.ComputeMinMaxSizes().min returns only max(CAPMIN, GRIDMIN)[1], which is what we want. In the example below, the flexbox will try to shrink the table's width to 75px. Using ComputeMinAndMaxContentContribution for the table's min-width computation would result in the table being 100px wide. Using table.ComputeMinMaxSizes would make it 75px wide. 75px is correct. <div style="display: flex; width: 75px;"> <table style="width: 100px; min-width: 0px;"> <td> <div style="float: left; width:50px"></div> <div style="float: left; width:50px"></div> </td> </table> </div> https://jsfiddle.net/dgrogan/gwu4ac82/3/ [1] This is actually not true today but is true for TablesNG. Switching to table.ComputeMinMaxSizes gets us closer. Bug: 1128262 Fixed: 1131890 Change-Id: Ie5a4eac97e4a6a2e96104397bd5c5ec483d40e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433594 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#811216}
-
Stephen McGruer authored
This rolls up to sha e7928355119c150c784d2d32da699717f61ed346 This brings in the async_test return-value change, as well as some changes to testdriver. Bug: None Change-Id: I49022e105c8ea6070eeee7031b3002eefbdb0d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432628Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#811215}
-
Stephen McGruer authored
Bug: None Change-Id: I8dcbf7f1e583df2f20560a6f6dc2337847c42805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432629Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ed2b465f8607..145f115c5496 2020-09-28 cwallez@chromium.org SerialQueue/Map: Take the serial type as type paramater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8ccb9e1ebf00cdb56fc02e1ea592c41a00f42530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435260Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ae0cd6c31b5..ba3d5932bb28 2020-09-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-28 jacktfranklin@chromium.org Migrate TimelineFrameModel to TypeScript 2020-09-28 jacktfranklin@chromium.org Fix rendering of NodeText in LayoutPane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1129881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic99bc19475684eb7b8e5b8f263a1a98800fddcda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435261Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601078369-47e552b1186c97497a87b26292e838c6fba2ff82.profdata to chrome-win32-master-1601098956-d2e0aa4048f1f94bf1822bc14b11121ebd74fc3b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia8b69f87d028ed46ab1484c0b5607cdfe6df17d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433076Reviewed-by:
-
Omar Morsi authored
This CL removes the static function KeyPermissionsService::IsCorporateKeyForProfile because it does not account for device-wide keys which are currently always "corporate". KeyPermissionsService::IsCorporateKey can be used instead. Bug: 1127326 Change-Id: I927611abe296f710c6b7d2187cd1c6c6b5ae47e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426607 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e79440e7..667efcdc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I779461b9fc9e5586ed436ec8574b0b3a0be95769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434907Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811209}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1601066350-377534304780c9dba5c0cc3dbbf14390e280f62b.profdata to chrome-win64-master-1601098956-2811654f54d3946c8e0477e7d77d36d5dbdfab8f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6a98bd2a6c84555c59eeb9d9d2730e9d1f555146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433263Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/111de34102c7..55c178693cdc 2020-09-28 eshr@google.com Add support for NV12 frame generation for tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie04a2193ac57197b157072f2b66884227e6ca16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435257Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e4f36ef0. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id114ec1b4e10541007ad67112c91b4e93d698ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434906Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811206}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1fb6b3e1b5c0..5ae0cd6c31b5 2020-09-28 tvanderlippe@chromium.org Remove one gradient from iPhone5 device emulator images 2020-09-28 mathias@chromium.org Migrate ChangesView to TypeScript 2020-09-28 jacktfranklin@chromium.org Migrate diff/DiffWrapper to TypeScript 2020-09-28 wolfi@chromium.org Fix focus ring when tabbing through service worker details If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1130980 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8b217d17ab60c10d759e0c869c49609562c981bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435256Reviewed-by:
-
Anton Ohontsev authored
At some point we have lost update the label text. When we create it hung_pages_table_model_->RowCount () == 0 but suppose to be equal to 1. This happens cause we counting hung pages after setting label text. So a plural form of text is "Exit pages" instead of "Exit page". The bug is not so terrible in Eng locale. But for other languages (ex. Russian) plural form of zero pages invoke eyes bleeding. Bug: 1132338 Change-Id: I8ba0f2e36404323d862ff6967e6a7127dd80939b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431965 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Auto-Submit: Anton Okhontsev <movax01h@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#811204}
-
Mark Cogan authored
The Discover help bubble hits DCHECKs on (at least) iPads, creating a crash loop on canary. This CL disables it until a proper fix can be made. Bug: 1132757 Change-Id: I7e4dc0dc9cf2fbc46e600ff00581979710697652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434927Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#811203}
-
Reda Tawfik authored
This CL changes the text of "User other password" to "User other username" if the user is about to fill a username field. Skips the warning dialog and show the bottom sheet immediately if the user is about to fill a username field. Bug: 1104132 Change-Id: Ife3c835cc9a7742c862bd4d71942472cc4686a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425051 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#811202}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icfc6153b5ea7b86b7f61bcce2e32260912fd91a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433907Reviewed-by:
-
Olivier Robin authored
If the RL view is in background scene when the model is modified, reloadData is called, and the number of items is updated, but rendering is postponed until the screen is displayed. If the model is modified again before that, it is possible that the view access items that have been deleted since. Bug: 1097027 Change-Id: Ibbd4d19700cf86bfda9db4ddb4d2285203f5ce0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428966Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811200}
-
Antonio Sartori authored
The WP test content-security-policy/embedded-enforcement/required_csp-header-crlf.html has been marked as flaky lately on Mac because it was incurring in the timeout (see https://crbug.com/1091896). Since the test opens and navigates several iframes, this is understandable, so let's increase the timeout. Bug: 1091896 Change-Id: Ibdc05589eed0188a4782f45693963aa15cfb671a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435347Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811199}
-
Rohit Agarwal authored
The code which should close the regular tab was behind an assert and assertion check gets removed in release build which effectively made the code of closing the regular tab non-existent in release build. TabModelImpl#closeTab returns a boolean indicating whether the tab was found which is ambiguous on whether the tab was closed. Hence the assertion on "found the tab" may be misleading for "closed the tab". Bug: 1132000 Change-Id: I15eba93453a58beaa32770017545f045b5b310e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435085Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811198}
-
Omar Morsi authored
This CL changes KeyPermissionsService interface such that no key locations arguments are expected and all functions are async. KeyPermissionsService now identifies key locations itself, which is why it also gets a dependency on PlatformKeysService. Making the functions asynchronous will also be helpful in a follow-up where setting/getting corporate flag will require a call to chaps. Bug: 1130479 Change-Id: Idfb3d36283d22b90109c74a664d4aca60b0f6168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421704 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
-
Pavol Drotar authored
A WebApk checks for this category to display a site settings shortcut. This category is therefore a switch to turn site settings on/off. Bug: 1128985 Change-Id: Id2678b957bd3f21e8cafa47ca2c10a2b269b3621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434326 Commit-Queue: Pavol Drotár <pavoldrotar@google.com> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811196}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I726c9e62ea49fad1f992f184841a3f15b1f6f16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435146Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#811195}
-
John Lee authored
Fixed: 1131152 Change-Id: Idb6b22c002b87748da4a9248b54bb5d288de75f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429226Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#811194}
-
Matt Falkenhagen authored
Change-Id: I348e13cf443af481479000d0b15874bb9a8f2dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425931 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#811193}
-
arthursonzogni authored
We know the navigation's can have an initiator_routing_id, but with no corresponding RenderFrameHost, even at the beginning of the navigation. We know this is true, but it turns out this isn't covered. This is shown by this tryjob: https://chromium-review.googlesource.com/c/chromium/src/+/2413265/3 This patch adds it. Bug: 1059959 Change-Id: I0bf0e4d86ffd056b00e647a8c01c9ec3710e26f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414172 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#811192}
-
Swapnil authored
This is a reland of 7ff62f12 Original change's description: > Report installation stages in increasing order > > This CL reports the installation stages for force installed extensions > in an increasing order. This is done in order to investigate > the extensions stuck in CREATED stage. > > Bug: 989526 > Change-Id: I82e07f30c6768c7bde30a76b61b9987173f76fbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421375 > Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> > Reviewed-by: Oleg Davydov <burunduk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809777} Bug: 989526 Change-Id: Ic101b2deea496c86b6618f13466b5381e6369c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426592 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
-
Morten Stenshorne authored
When a float in an inline formatting context fragments (or just gets pushed to the next fragmentainer), it won't become a fragment item there, but rather a regular box fragment child. See crrev.com/2264367 This fix allows us to remove a DCHECK that would otherwise cause the following tests to fail: * virtual/layout_ng_block_frag/fast/multicol/float-big-line.html * virtual/layout_ng_block_frag/fast/multicol/vertical-lr/float-big-line.html * virtual/layout_ng_block_frag/fast/multicol/vertical-rl/float-big-line.html Bug: 1132619 Change-Id: I86268da4c146dba89bd7ec36df166ad90b2b5f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433926Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#811190}
-
Dana Fried authored
This has been a feature request from a number of people for a long time and was fairly simple to implement. Change-Id: I7d25a563f654b3fd07f1d4c15cd274dcac65236b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430766 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#811189}
-
Tal Pressman authored
Flows that were previously handled via `RenderThread::Get()` are now handled by the AgentSchedulingGroup (which, for now, just forwards them to the RenderThread). Bug: 1111231 Change-Id: I64957c18ca2ea07580cdaa45e76e8b8e1a9edfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377177 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811188}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/131d306fc1d9..1fb6b3e1b5c0 2020-09-28 szuend@chromium.org [ts] Type-check devices/DevicesView.js with TypeScript 2020-09-28 patrick.brosset@microsoft.com Guard against malformed URIs when creating a binding for a resource If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1132305 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87d87f6372df95f4fee0f7e9b239e7eeca6d68fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435255Reviewed-by:
-
