- 23 Feb, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 90990b60. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: msisov@igalia.com: external/wpt/webvtt NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0f2c5df583c7a99bae2fc4c8e53d9f68e4b06cb8 Reviewed-on: https://chromium-review.googlesource.com/c/1485116Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634967}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/72f6f044cc73..12f1fecea947 git log 72f6f044cc73..12f1fecea947 --date=short --no-merges --format='%ad %ae %s' 2019-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f78131dac076..c63d95525cde (1 commits) Created with: gclient setdep -r src/third_party/skia@12f1fecea947 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I51747b3fbfaedfa2a20398363ff8019dda324881 Reviewed-on: https://chromium-review.googlesource.com/c/1485115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634966}
-
Hiroshige Hayashizaki authored
- Moves {referrer-policy,mixed-content}/generic/common.js (which have been already the same) to common/security-features/resources/common.js and removes a TODO comment about moving/merging common.js. - Add common/security-features/README.md. - Rename paths mechanically (mostly by the generators). Bug: 906850 Change-Id: I3d60bffa5b230c04257f66b49717d5861accb979 Reviewed-on: https://chromium-review.googlesource.com/c/1476192 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#634965}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5cf3bf8f345..3cce0f215a41 Created with: gclient setdep -r src-internal@3cce0f215a41 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibedc6e4c5945311631e4e40fb3fec99cde12bbfb Reviewed-on: https://chromium-review.googlesource.com/c/1485114Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634964}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c38434481cae..c5cf3bf8f345 Created with: gclient setdep -r src-internal@c5cf3bf8f345 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:932622 TBR=mmoss@chromium.org Change-Id: I53ea3cf05c5f04c2048986cd4732c9c62e2f4458 Reviewed-on: https://chromium-review.googlesource.com/c/1485112Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 15f51e3e. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ibe7a613f442842d014b6757190e878d8b7886128 Reviewed-on: https://chromium-review.googlesource.com/c/1485111Reviewed-by:
-
Clemens Arbesser authored
Before: https://screenshot.googleplex.com/fjPBfRZ60vm.png After: https://screenshot.googleplex.com/KJr3uAbraJM.png Bug: 806868 Change-Id: If050ab6c36203b000b0103958f08ce30f46f22b1 Reviewed-on: https://chromium-review.googlesource.com/c/1482979Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#634961}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca69efadc6d9..c38434481cae Created with: gclient setdep -r src-internal@c38434481cae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If952d873435f4625135a1413aa41db57c183b069 Reviewed-on: https://chromium-review.googlesource.com/c/1485024Reviewed-by:
-
Abhishek Bhardwaj authored
This change adds a class that makes the wake up alarm D-Bus API on Chrome OS easy to use by clients. The D-Bus API was merged in aec92f8b. BUG=chromium:913318 TEST=Unit tests and end-to-end alarms via ARC++ applications. Change-Id: I045af2c6ffbf93b3d44ac09ca217159fcdae18fe Reviewed-on: https://chromium-review.googlesource.com/c/1372848 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#634959}
-
Naoki Fukino authored
This adds an integration test to check that DocumentsProvider implementation correctly interact with ARC-related services in Chrome side by marking ARC as available for testing and mocking FileSystemInstance (Mojo interface to interact with ARC container). Bug: 923991 Test: Run browset_tests --gtest_filter=QuickView/FilesAppBrowserTest.Test/openQuickView* Change-Id: I72cf99449880aea0acc33cc7f679656ea4e396f8 Reviewed-on: https://chromium-review.googlesource.com/c/1483697 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634958}
-
Hirokazu Honda authored
VaapiVideoDecodeAccelerator doesn't propagate profile change in a video stream to driver. Rockchip and Intel driver apparently handles the profile change inside of the drivers, while AMD driver doesn't. This casues video corruption in some sites on AMD device. This is the workaround for the issue. MojoVideoDecoderService calls Initialize() if profile change is detected, but VdaVideoDecoder doesn't support reinitialization as a VideoDecodeAccelerator doesn't. This change enables VdaVideoDecoder to re-initialize by destroying currently using VideoDecodeAccelerator and creating a new one. This reinitialization is triggered only if profile changes for performance and VideoDecodeAccelerator is VaapiVideoDecodeAccelerator for safety. Bug: 929565 Test: no video corruption on some issued sites on grunt and eve Change-Id: Ic6f75809fce6db08965cf0554e7d989d635d3f54 Reviewed-on: https://chromium-review.googlesource.com/c/1482357 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#634957}
-
David Trainor authored
Add safety checks to the following classes to make sure they work better during destroy: - ThumbnailProviderImpl - Cancel all requests after destroy and do not use any results given. - BitmapCache - Do not add bitmaps to the cache after destroy (real exception). - ThumbnailDiskStorage - Do not take requests after destroy and do not return results after destroy. Bug: 934515 Change-Id: Id2bbac832fd4b9c81ae81ee806f66494eda59e16 Reviewed-on: https://chromium-review.googlesource.com/c/1482590 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Joonghun Park authored
https://www.w3.org/TR/css-values-4/#calc-type-checking spec says that calc() function that resolve to <number> can be used in any place that only accepts <integer>. This change makes calc() function's behavior to comply with the spec. Bug: 931216 Change-Id: Iac9ad21d664bb60538d40ab42cbb8153de6db89f Reviewed-on: https://chromium-review.googlesource.com/c/1478852Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#634955}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b99086fcf5e..72f6f044cc73 git log 5b99086fcf5e..72f6f044cc73 --date=short --no-merges --format='%ad %ae %s' 2019-02-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@72f6f044cc73 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I65c6666594b174e077b1d4bcdd563510f24b24f8 Reviewed-on: https://chromium-review.googlesource.com/c/1485025Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6b0fdfce..2f408608 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib5c144e841c841c0842fbdf9af11f7ecaccc6472 Reviewed-on: https://chromium-review.googlesource.com/c/1485023Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634953}
-
Maggie Chen authored
This optimization reduces the damage rect size when the current damage rect doesn't cover the video quad. For example, the video is paused or no video change in this frame. Because the overlay image is missing in gl composition, there might be corruption if the old overlay needs to be redrawn in gl composition but the damage rect doesn't cover it. Although sometimes it's needed to add the overlay damage rect from the previous frame. It might increase the damage rect than necessary when overlay is the same. The unioned overlay quad size of the previous frame was always added to the damage rect of the next frame before calling the overlay processor. This CL optimizes the damage rect by handling the overlay damage rect in DCLayerOverlayProcessor(). The other change of this CL is to move overlay and underlay validation code into one function. This makes it easier to read and makes sure there is no validation failures after the damage rect has changed. BUG=868561 Change-Id: Ia66b950d5f010cb4b65288276cb9486e0d3d7709 Reviewed-on: https://chromium-review.googlesource.com/c/1472190 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634952}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24f380e7ef9a..5b99086fcf5e git log 24f380e7ef9a..5b99086fcf5e --date=short --no-merges --format='%ad %ae %s' 2019-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d2452555986f..7c33e88eebb5 (1 commits) 2019-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cf9b2853a7e7..f78131dac076 (3 commits) Created with: gclient setdep -r src/third_party/skia@5b99086fcf5e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I52aefb9e132965ea88b05f0614ff7af9f1affc6c Reviewed-on: https://chromium-review.googlesource.com/c/1484980Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/487c09bb73c1..8721bb30d86d git log 487c09bb73c1..8721bb30d86d --date=short --no-merges --format='%ad %ae %s' 2019-02-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e7ecd1bf..95a23eca (634731:634895) 2019-02-23 amithi@webrtc.org Removing non-const RtpSenderInterface::GetParameters(). 2019-02-22 mellem@webrtc.org Add an OpenChannel method to MediaTransportInterface and call it whenever PeerConnection opens a new data channel. 2019-02-22 jeroendb@webrtc.org Map clat devices to cellular on Android 2019-02-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a77f654a..e7ecd1bf (634608:634731) Created with: gclient setdep -r src/third_party/webrtc@8721bb30d86d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9060c258c731ffd0c74c7947e2e2654e459f530e Reviewed-on: https://chromium-review.googlesource.com/c/1484977Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d456e7bc01cf..ca69efadc6d9 Created with: gclient setdep -r src-internal@ca69efadc6d9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I13f8281c1ee71c72de5631f4874954a306aa69ab Reviewed-on: https://chromium-review.googlesource.com/c/1484979Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d2452555986f..7c33e88eebb5 git log d2452555986f..7c33e88eebb5 --date=short --no-merges --format='%ad %ae %s' 2019-02-23 chrisforbes@google.com Set render targets correctly when drawing Created with: gclient setdep -r src/third_party/swiftshader@7c33e88eebb5 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124177079 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I9c1420bed9f424563cdad2f89d6ea63eab0a5681 Reviewed-on: https://chromium-review.googlesource.com/c/1484978Reviewed-by:
-
Zhenyao Mo authored
In --url mode, we zip telemetry_gpu_integration_test_scripts_only target and copy it over to target machine to test against external websites. That target doesn't include the data folder /media/test/data that's required for built-in power measurement video tests, but not required in --url mode. BUG=867155 TEST=manual R=kbr@chromium.org,magchen@chromium.org Change-Id: If64402f90001880039f053a5a62d6780c8478932 Reviewed-on: https://chromium-review.googlesource.com/c/1484972 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634947}
-
Xianzhu Wang authored
Bug: 919789 Change-Id: Ib608c65039661778affb35bb1d892b7a62bf81aa Reviewed-on: https://chromium-review.googlesource.com/c/1485021Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634946}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8546335d2d40..24f380e7ef9a git log 8546335d2d40..24f380e7ef9a --date=short --no-merges --format='%ad %ae %s' 2019-02-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-22 fmalita@chromium.org [sksg] Use luminance coefficients from SkColorData.h 2019-02-22 fmalita@chromium.org Reland "[skottie] Add tritone layer effect support" 2019-02-22 jvanverth@google.com Disable fontscaler GM on Intel Vulkan 2019-02-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e53533d6fdf9..d2452555986f (2 commits) 2019-02-22 reed@google.com add gm to test backdrop blurs and clipping/hintrects 2019-02-22 herb@google.com Change SDFT to use a bulk api for the callback 2019-02-22 fmalita@chromium.org Revert "[skottie] Add tritone layer effect support" 2019-02-22 fmalita@chromium.org [skottie] Add tritone layer effect support 2019-02-22 halcanary@google.com SkShaper/public.bzl fix 2019-02-22 bungeman@google.com Compare to the correct hinting. 2019-02-22 halcanary@google.com tools: bin/sync just alias for git-sync-deps now 2019-02-22 jvanverth@google.com Disable tests on more Vulkan bots 2019-02-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8a718cb58343..e53533d6fdf9 (2 commits) 2019-02-22 halcanary@google.com ICU: fix windows: dll to dat Created with: gclient setdep -r src/third_party/skia@24f380e7ef9a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:933137 TBR=jvanverth@chromium.org Change-Id: I972e29908964d69528a88969881fd4dae19fa9b2 Reviewed-on: https://chromium-review.googlesource.com/c/1484935Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95d566bd360a..d456e7bc01cf Created with: gclient setdep -r src-internal@d456e7bc01cf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3089e0b4d3ccafa413a1e2a992547fe4a280a62f Reviewed-on: https://chromium-review.googlesource.com/c/1484976Reviewed-by:
-
Xianzhu Wang authored
This reverts commit 2ba4b0c6. Reason for revert: new flakiness dashboard results show that the tests are not actually slow. They are just occasionally stuck. Original change's description: > Mark paint/invalidation/window-resize slow > > They occasionally timeout (1/10 ~ 1/20) on the bots, perhaps because of > the multiple synchronized window resizes. > > Bug: 919789 > Change-Id: I748b7362172b0ac407242e8236ae3ef937384f07 > Reviewed-on: https://chromium-review.googlesource.com/c/1484732 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634900} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ic9d1d868a23f62339e9c965d2a03b49fb2e5b531 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919789 Reviewed-on: https://chromium-review.googlesource.com/c/1485020Reviewed-by:
-
Nico Weber authored
Reland "Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled." This is a reland of 5b911be8 Original change's description: > Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled. > > Only enables the warning for chromium_code.n > > Also fix the last few -Wextra-semi instances in sanitizer and linux/ozone builds. > > Getting to this state required fixing > 3000 unique warnings in 15+ different > repositories. If this breaks some internal-only build somewhere, either consider > using no_chromium_code for your internal code, or fix the warnings -- it's > pretty easy. (Build with treat_warnings_as_errors=false, then open the error log > in vim, run `:%g/warning:/t$` to copy the warnings to the end of the buffer, > remove all but just those lines, run `:sort u` to get uniques, then save as > `tmp.txt` and run `:cf %` and then use something like `:map m :w<cr>:cn<cr>` > to go through them quickly.) > > TBR=rsesek > > Bug: 926235 > Change-Id: Ica629737523ff6bbd756edc44d182f35ff6cf8ac > Reviewed-on: https://chromium-review.googlesource.com/c/1483396 > Reviewed-by: Scott Violet <sky@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634826} TBR=rsesek Bug: 926235, 935033 Change-Id: Ia49d6e341ddf64b0816a67ba3de1478ee2985bac Reviewed-on: https://chromium-review.googlesource.com/c/1485012 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634942}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ieeb4cf28aa346f5f738635946d010c4737dee738 Reviewed-on: https://chromium-review.googlesource.com/c/1484829Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#634941}
-
Devon O'Brien authored
Google Xenon2019, 2020, 2021, 2022 CT Logs have all passed their monitoring period and are being added to the list of Qualified Logs in Chrome. Bug: 833350 Change-Id: I1215184564eb08a573f7091d26b7f532d93ddba5 Reviewed-on: https://chromium-review.googlesource.com/c/1485017 Commit-Queue: Devon O'Brien <asymmetric@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#634940}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e4abf4c59be6..a4323c9b818b git log e4abf4c59be6..a4323c9b818b --date=short --no-merges --format='%ad %ae %s' 2019-02-22 benjhayden@chromium.org Split Histogram.statistics_scalars into statistics_names, GetStatisticScalar. 2019-02-22 benjhayden@chromium.org Merge deploy_v2spa into dashboard/bin/deploy 2019-02-22 benjhayden@chromium.org Serialize DiagnosticMap 2019-02-22 bsheedy@chromium.org Remove old VR aliases 2019-02-22 simonhatch@chromium.org Pinpoint - Retry frozen jobs 2019-02-22 benjhayden@chromium.org Fix references to /api/existing_bug. 2019-02-22 benjhayden@chromium.org Deserialize DiagnosticMap. 2019-02-22 perezju@chromium.org [Telemetry] Use ExtractTimelineMarkers for cache_temperature unittests Created with: gclient setdep -r src/third_party/catapult@a4323c9b818b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918208,chromium:918193,chromium:918208,chromium:884259,chromium:899671,chromium:918193,chromium:918208,chromium:933343 TBR=sullivan@chromium.org Change-Id: I99aa7be0539da05d7db6a14a9b327783e67b9682 Reviewed-on: https://chromium-review.googlesource.com/c/1484614Reviewed-by:
-
Wez authored
ScopedTaskEnvironment would previously LOG(FATAL) on Run() timeout, causing the calling process to crash, preventing tests scheduled later in the same batch from being run. ScopedTaskEnvironment now uses MakeExpectedNotRunClosure() as the Run() timeout callback, allowing test batches to run to completion. Bug: 918724 Change-Id: I23269ee9d9e2c55108a57d4081f62a7769b1f44b Reviewed-on: https://chromium-review.googlesource.com/c/1481655 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#634938}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d7f7a3eb92a4..5585c87a78b7 git log d7f7a3eb92a4..5585c87a78b7 --date=short --no-merges --format='%ad %ae %s' 2019-02-23 tandrii@chromium.org Revert "Pass target branch from tryserver in bot_update module" 2019-02-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@5585c87a78b7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I3a6e3e76fd0241297acfe3343adadc800d567008 Reviewed-on: https://chromium-review.googlesource.com/c/1484934Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e53533d6fdf9..d2452555986f git log e53533d6fdf9..d2452555986f --date=short --no-merges --format='%ad %ae %s' 2019-02-22 chrisforbes@google.com Wire up cull mode handling to Vulkan pipeline 2019-02-22 bclayton@google.com Kokoro: Run unit tests. Created with: gclient setdep -r src/third_party/swiftshader@d2452555986f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124177079 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I28040d1032e29bf2f2e6ca52e45876ac8b14d113 Reviewed-on: https://chromium-review.googlesource.com/c/1483829Reviewed-by:
-
Khushal authored
CURRENT CODE: The current flow of animations initiated by the ImageAnimationController is as follows: 1) Each time a pending tree is updated, which is when animated images from display lists would have been registered with the controller, we compute the earliest time the next animation update will be needed and schedule a delayed task to trigger an invalidation. 2) The delayed task triggers an invalidation, which update the frame on the sync tree created as a result. And schedules the next invalidation if needed. THE BUG: In the steps above, first for progressing the animation on the sync tree and for scheduling the delayed task, we use the frame_time from the BeginFrameArgs of the current frame as the "now" time. This resulted in 2 bugs: 1) Since the delayed task could be scheduled at any time within the impl frame, using the frame_time from BeginFrameArgs as now was incorrect and the delayed task would run at an unexpected time. 2) When the task did run at the correct time, resulting in an invalidation, the pending tree would not be updated if the frame times of the animation did not align with the BeginFrame frame times. For instance, if the frame time is 0ms and the animation wants to run at 8ms. Even if the invalidation runs at 8ms, the "now" time would be the BeginFrame frame_time, which is 0ms and earlier than when the animation wants to run. This would create wasted pending trees. FIX: This patch fixes the above by changing some fundamental aspects of how image animations are progressed. 1) Instead of respecting the frame durations associated with the animated image completely, snap them to frame boundaries. This ensures that the animation always starts at the beginning of the frame in which the desired time lies. This is also the optimal time to start the work for the frame in which the animation wants to update. 2) Instead of always requesting an invalidation at the time for the next animation update, request an impl frame instead. At the beginning of the impl frame, upgrade it to an invalidation request if the frame_time for that impl frame ensures that the animation will be updated. This avoids a race between triggering an invalidation and receiving the target BeginFrame in the renderer. R=enne@chromium.org,sunnyps@chromium.org Change-Id: Iffcaafc3dd72f7649ada1eceea2835054c44e911 Reviewed-on: https://chromium-review.googlesource.com/c/1464972 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#634935}
-
Khushal authored
Currently we playback an op on the analysis canvas after serializing this op, with the assumption that the state change made on the canvas through this playback should only affect ops executed after this op. This assumption holds true in most cases, since most state changing ops don't perform any draws of their own. The special case here is the SaveLayerOp which has a paint including filters that will finally be used when drawing the offscreen layer created by the op. The filter for this layer is serialized with the SaveLayerOp and we should have the correct raster transform for this filter at serialization time. SkCanvas modifies this transform when executing the saveLayer if the filter can not process the current CTM, which we assume is the raster transform. But the analysis code misses this change right now since we playback the op after serializing it. Switch the order to ensure we include this modification to get the correct raster transform for the filter. R=enne@chromium.org Bug: 931065 Change-Id: Iec04702f0aae5e2bd2fe73c40d12bbd1612f5c0f Reviewed-on: https://chromium-review.googlesource.com/c/1479425 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
sczs authored
The Modal Infobar is the expanded version of a Banner Infobar. This CL creates the foundation to make this possible by creating: - An ExpandBannerAnimator which animates the transition between a Banner and Modal Infobars. - A ModalPresentationController that defines the size and position of the Modal ViewController. - A ModalViewController, which is the ModalVC itself that will be presented by the previous two classes. - A ModalDelegate that works as a communication channel between the ViewController and its Coordinator. Each specific InfobarCoordinator will configure and set up the Modal presentation. For the time being all the animation and presentation code is temporary and will be polished/enhanced in future CL's. Video: https://drive.google.com/open?id=1Sv2YP45fivSmERqVLq0OZBNHNVedJa-z Bug: 911864 Change-Id: Iee8c70ef37f33f22efa1e16a7d32ae91806b79f5 Reviewed-on: https://chromium-review.googlesource.com/c/1481749 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#634933}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d09546e1ec90..f78131dac076 git log d09546e1ec90..f78131dac076 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 syoussefi@chromium.org Suppress WebGL CopyTexSubImage2D on D3D9.3 everywhere 2019-02-22 timvp@google.com Vulkan: Free semaphores with other in flight resources Created with: gclient setdep -r src/third_party/angle@f78131dac076 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I8d787bf6080dd1f0633ec4c42aa8579e032b8c2e Reviewed-on: https://chromium-review.googlesource.com/c/1484130Reviewed-by:
-
Kenneth Russell authored
Too flaky to continue to run. conformance/extensions/oes-vertex-array-object.html conformance2/vertex_arrays/vertex-array-object.html Bug: 932794, 920265 Change-Id: I0b12b32ddc3067d1ae000f7f883c4f2b7203ec8b Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1484823Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634931}
-
chrome://offline-internalsIan Wells authored
Replaces "enable"/"disable" buttons on chrome://offline-internals with checkboxes. Bug: 925549 Change-Id: I2ce57f41bd715608e548beaf5f37287111b4df67 Reviewed-on: https://chromium-review.googlesource.com/c/1437776Reviewed-by:
Dan H <harringtond@google.com> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#634930}
-
Nico Weber authored
Bug: 926235 Change-Id: I5e8279232a4e77f537259b5135083a19cdba8509 Reviewed-on: https://chromium-review.googlesource.com/c/1483391Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634929}
-
Nico Weber authored
Bug: 926235 Change-Id: Ie09ab129d102672a4d0de8ee2d80d2b5dd7b371e Reviewed-on: https://chromium-review.googlesource.com/c/1483256 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
