GitLab

ObjectTemplateBuilder (and Wrappable) allow setting functions that are
exposed in JS and then forwarded to the type in C++. If these are C++
member functions, the context object is retrieved by looking at the
this-object in JavaScript, and trying to convert that to the underlying
C++ type (which will succeed if it was called on the V8 object created
by the Wrappable).

However, these member functions will fail if the JS function is called
on an improper this-object (including null and undefined). This means
that doing things like:

var obj = getObj();  // Some object from a Wrappable
var doFoo = obj.doFoo;
doFoo();

will fail because it's applied on an invalid this-object (undefined),
and the conversion will fail. This makes sense, but unfortunatley the
error gin throws in this case is unhelpful:
"Uncaught TypeError: Error processing argument at index -1, conversion
failure from undefined"

Instead, allow Wrappables and ObjectTemplateBuilders to specify a type
name, which will be surfaced in these errors to provide guidance to
developers. Update the error message to either include the type name or
to match the error message used in similar circumstances in blink
("Illegal invocation").

The new error messages will only be shown for failures in converting to
the context object, not for failure to convert subsequent arguments.

Bug: <File One>

Change-Id: I515a17e92992bfcb709b97455b9167b350e931f2
Reviewed-on: https://chromium-review.googlesource.com/987304
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549219}

Add some additional trace methods for when mojo input is received.

Bug: None
Change-Id: I84e78ffaac21995894f20f6778e83ba1213c8d06
Reviewed-on: https://chromium-review.googlesource.com/998672Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549218}

USM accounts should be treated as child accounts in Chrome. Design doc:
go/usm-accounts-chrome (sorry, internal only).

Bug: 826299
Change-Id: I935a0de549d38674af8ce27a8a9a853ec1e8fa76
Reviewed-on: https://chromium-review.googlesource.com/998632Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549217}

Bug: none
Change-Id: Ic29c5c2938e3d395fec9f9eb9097128770f5dc9d
Reviewed-on: https://chromium-review.googlesource.com/1002990Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549216}

When the notification is
* in notification center (not popup)
* pinned
then, we should not show close button on mouse hover.

TEST=manual
BUG=829582

Change-Id: Idcd6cbe70fe880ddabc6d90bdd0a9f764a01295d
Reviewed-on: https://chromium-review.googlesource.com/1000653Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549215}

Also enable the test when the network service is enabled.

Content Shell sends a different content-encoding with the network
service enabled and disabled, due to Brotli only being enabled on one
path.  While I plan to enable Brotli in both cases, it also seems like
a good idea to remove this dependency.

Bug: 825687
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9c768099dfd6a876f7650088118de4582ec1ca46
Reviewed-on: https://chromium-review.googlesource.com/998756Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549214}

R=thestig
TBR=thakis
BUG=800977

Change-Id: I1147d171fee32e8ce51c08449a1a50144d5e051b
Reviewed-on: https://chromium-review.googlesource.com/1002986Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549213}

BUG=none
TEST=none

Change-Id: I387c43f58eaf7bf3a1f2dd01c40c9fd6974b3413
Reviewed-on: https://chromium-review.googlesource.com/1002953Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549212}

This CL changes the distance between controls and UI edges.
Specs: https://goto.google.com/ios-chrome-download-manager-specs

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibabcc6f7b0626814ce15e8e3da67e3f630feb3c8
Reviewed-on: https://chromium-review.googlesource.com/999046
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549211}

Updates the links used for the WebVR motion to photon latency tests to
be more similar to the ones used for the WebVR Telemetry tests.

Change-Id: I0830eaa9d2a5cd2f79fbed71fe013de3092cc815
Reviewed-on: https://chromium-review.googlesource.com/1000729Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549210}

Wait for the print ticket item change event before validating UI. We
already do this in the new system_dialog_browsertest.js tests. Try
doing this in the old tests also, to see if it will help with a test
flake.

Bug: 829265
Change-Id: I12062efa3e3fd29b4c2e000fd6e240fcdb140ca6
Reviewed-on: https://chromium-review.googlesource.com/998441Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549209}

The trigger now listens to page load events, suspicious site list
hits, and a report delay callback. A simple state model reconciles
these events and creates reports at the right time.

Also some basic unit tests.

This is a no-op since the trigger is disabled by default.
Next CL will add metrics to the trigger and more tests.

Bug: 817377
Change-Id: Ica12e87debf39fb4f2e47a4e92d1f9cf1d40491e
Reviewed-on: https://chromium-review.googlesource.com/998532
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549208}

Inline settings work fine for the MD notifications, but the handler
doesn't implement OpenSettings() for non-MD notifications, nor has
something sensible to do there. Instead, don't display the button.

Bug: 828346
Change-Id: I3a57f940be773e40e4994e4e6e1920f0c83ca3ec
Reviewed-on: https://chromium-review.googlesource.com/1002812Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549207}

It seems that locking the hardware canvas and drawing view into that
has stopped crashing on P, so we should use it as it's *way* faster than
the software canvas.

Revert this CL if Chrome starts crashing when viewing Android UI in VR.

Change-Id: If63ff109548d54c4315945e55520e6278951c17d
Reviewed-on: https://chromium-review.googlesource.com/1000150Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549206}

Wait for stable recycler view.

Bug: 829377
Change-Id: I42c5e5fef4383344f25f79520e81c0822e1e9cde
Reviewed-on: https://chromium-review.googlesource.com/1000771Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549205}

This fix race condition when settings are driven by mojo instance
creation for intent helper and onArcInitialStart is called due the
communication via auth mojom. That leads to case when onArcInitialStart
is not called for arc settings and these settings are not applied on
Android side.

Bug: 822459
Test: Unit tests added. Manually on device. Simulate race condition,
observer that all consumers of onArcInitialStart are called. Only
settings component has such race. Other consumers are created on
session start and do not have this race.

Change-Id: Iab0a5fe53d55c3e84fbe532cf7c8d5b720e67bcb
Reviewed-on: https://chromium-review.googlesource.com/967069
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549204}

For the experiment TurnOff2DAndOpacityCompositorAnimations, we have the
experimental feature setup on the content and blink side, but we have
not yet bridge these two sides, which requires to add 2 lines of code
in content/child/runtime_features.cc. This CL does the bridging.

Bug: 754471
Change-Id: I84b85fadb68a2cebc0f642b3814fe9448bdfe3f3
Reviewed-on: https://chromium-review.googlesource.com/1002882Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549203}

This CL appends a suffix containing the device model (i.e., vid:pid)
for USB audio devices in device enumeration results on Windows.
The (vid:pid) suffix is already available on video device enumerations.

Bug: 780492
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id8a7cbd75dd8a0fb9f70827015d2920ac088adfa
Reviewed-on: https://chromium-review.googlesource.com/995537
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549202}

This ships:
- RTCPeerConnection.getStats(optional MediaStreamTrack? selector = null)
- RTCRtpSender.getStats()
- RTCRtpReceiver.getStats()

Spec:
https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm

Design doc:
https://docs.google.com/document/d/18BywbtXgHCjsbR5nWBedpzqDjAfXrFSTJNiADnzoK0w/edit?usp=sharing

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/2mGY257k4-M

Bug: 680172
Change-Id: I63c7991270489434cf67c9ebf7794a2648ceb6b8
Reviewed-on: https://chromium-review.googlesource.com/997554
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549201}

This should fix the root issue found when trying to add pixel tests for
SkiaRenderer. This CL puts DrawRPDQParams as nested classes into each
renderer.

Bug: 826970
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If387abd00afdb19e9498fea843438da8e94aa31b
Reviewed-on: https://chromium-review.googlesource.com/1000543Reviewed-by: enne <enne@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549200}

This change allows the bottom sheet to remain open while a tab
is being opened in the background. In practice, this means allowing
the bottom sheet to show in the SimpleAnimationLayout.

Bug: 829572
Change-Id: I27228e64636cd4e50c56ad9fff24867321147c16
Reviewed-on: https://chromium-review.googlesource.com/1000547
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549199}

This patch fixes some broken assumptions with the triggering logic for
onSheetOpened and onSheetClosed. Now the checks for the current state
explicitly check if the state is considered opened or closed.

Change-Id: I86be48e93450074ed5171a9d1919dc973451d20b
Reviewed-on: https://chromium-review.googlesource.com/998519Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549198}

On Windows, Chrome can ask setup.exe to store a device management (DM)
token in the Windows registry. The token is just a binary blob and
should be stored as-is, but we should still check to ensure that the
specified token has a reasonable size.

Bug: 829671
Change-Id: I62402a8c56aedeb6b8a4a9ee0d98e23e586daa4e
Reviewed-on: https://chromium-review.googlesource.com/999302Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Ali Tofigh <alito@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549197}

Because paint fragments store a pointer to the physical fragment,
and because CachedFragment returns a cloned fragment, we need to
reset the paint fragment so that it points to the correct
physical fragment.

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5ce3be8f391e436b0777417ca9410e11050a11a9
Reviewed-on: https://chromium-review.googlesource.com/1001721
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549196}

When computing the tail time for a BiquadFilterNode, we forgot to take
the absolute value of the largest root when computing the tail.  For
the test case from the bug, the root with the larger magnitude was
negative.

Also, the computation of the larger root was incorrect; fix that.  And
the comments for the real root case was incorrect and wrote "r" when
it should have been "r1".

Manually verified that the test file causes a DCHECK failure in a
debug build without this CL.

Bug: 829349
Test: webaudio/BiquadFilter/biquad-829349.html
Change-Id: I028331670a61da22a6f42bb7213869dc4cacf8ad
Reviewed-on: https://chromium-review.googlesource.com/998518
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549195}

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' extensions`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

Bug: 755727
Change-Id: I28ad1f38f58669b14b5dde345cf84249e79ad9b8
Reviewed-on: https://chromium-review.googlesource.com/1000427Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549194}

This CL logs the histogram Signin.SigninStartedAccessPoint and
Signin.SigninStartedAccessPoint.{NewAccount|NotDefault|WithDefault} when the
user enables sync from a DICE promo.

Note that it always logs histogram Signin.SigninStartedAccessPoint.NewAccount for
the cases when the user enables sync from the settings promos as this requires
additional piping of the default account information from the settings WebUI.

Change-Id: If13d59e5ff49b38de216b58afca086025c513d62
Reviewed-on: https://chromium-review.googlesource.com/986141Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549193}

Report events for UI peeked, UI opened, UI closed (via close button),
suggestion downloaded and suggestion clicked to the
ContextualSuggestionsBridge.

BUG=822947

Change-Id: I913678193bb83ec46d29e9f9d58d89e771725a18
Reviewed-on: https://chromium-review.googlesource.com/998824
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549192}

This is done in preparation for supporting different builds of the framework
with different features included. The generated header will include only the
headers whose features are supported.

This will allow us to have only one umbrella header AND not expose any of the
build flags in public headers.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I21d390942c195e872ed8e5b6e3949194ef6b71f3
Reviewed-on: https://chromium-review.googlesource.com/993695Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549191}

Change-Id: I1023c48c0215c96e5c8f759d7b06ba420a4b2d20
Reviewed-on: https://chromium-review.googlesource.com/1001898Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549190}

This CL adds a small, temporary workaround to a bug introduced by
the migration of AsyncFileUtil to OnceCallback in crrev.com/r/985343 .

I should have caught this during review. I will followup with a long-term
solution.

Change-Id: I16038b17c2eb67cf3efc8e3305bc0bbf5985d95f
Reviewed-on: https://chromium-review.googlesource.com/996912Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549189}

Skia is deprecating the GrBackendObject since it isn't typesafe. This sets
the stage for removing it.

This must land before the Skia CL: https://skia-review.googlesource.com/c/skia/+/119140 (Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS) to preserve Chrome's current behavior.

Change-Id: I3f89a79f4e24fe18a9be16712f022ff2b6ed80ed
Reviewed-on: https://chromium-review.googlesource.com/999796Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#549188}

Error-specific messages are produced for:
* Feature not available.
* Bad parameters (max size too small, too big, etc.)
* Bad state (already logging, unknown peer connection, etc.)

A generic error is produced for:
* Incognito mode.
* File system errors.
* Too many pending logs.
* Too many active logs.

The purpose of using generic errors, is to not expose sensitive
information, neither explicitly (specific-error) nor implicitly,
which would be the case if, for example, only incognito mode
could produce the generic error.

Bug: 775415, 827191
Change-Id: I10c12d1a0fc7ad4476511fc5d6383c1cd5e9d512
Reviewed-on: https://chromium-review.googlesource.com/986575
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549187}

s/Download sucessfully finished/Download finished

Bug: 821188
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4b5bb837ed2c228b8b173010489d0db0b9251516
Reviewed-on: https://chromium-review.googlesource.com/1000100Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549186}

This CL cuts unnecessary work from our tree walks where we can.

Bug: 828684,828688,828687
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3706deec5adeae6b4c4d186d45187854e79a840f
Reviewed-on: https://chromium-review.googlesource.com/1000430Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549185}

This CL changes the Dice accounts submenu
positioning on Mac to be right aligned,
as is the case on Windows and Linux.

Screenshot before:
https://drive.google.com/file/d/15M0bFasjm_TrRJkSPZUwzXj6X8N77I2e/view?usp=sharing

Screenshot after:
https://drive.google.com/file/d/1TLyEvugA1yzyYekp3F4e7aa_hFtErtBv/view?usp=sharing

Bug: 813805
Change-Id: I9bfee4eacae496a26bc304f4b0ef5f9b87c4d25f
Reviewed-on: https://chromium-review.googlesource.com/999514Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549184}

ARC windows were the only one kind of clients, but it changed.
We have to check an application id to distinguish ARC windows and
other exo windows.

Bug: 829383
Test: Manual. Confirm that input is still working on Linux apps after
      opening Android apps with a text input.

Change-Id: Ib58a6e5b41cdd2a3c68d76b3baacd93f11602f70
Reviewed-on: https://chromium-review.googlesource.com/1001086
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549183}

Following bot results are included.
4613 4616 4628 4630 4636 4639 4640 4645 4646 4647 4651 4652 4653
4654 4655 4656 4660 4661 4662 4668

19 lines were removed and 5 lines were deflaked by consecutive
results since 4573.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I0f9bf7aa4c11fb799c530bb51e0981bd166a1329
Reviewed-on: https://chromium-review.googlesource.com/999552
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549182}

The build.ninja file generated by ninja has changed and now
include a "ninja_required_version" statement. To keep the
rule to generate the build.ninja file, all the line up to
the third blank line should be kept (this is what "gn clean"
does).

Bug: 830627
Change-Id: I493cc39f484c6da8a0784d9cf2b45337cb4672d3
Reviewed-on: https://chromium-review.googlesource.com/1001902Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549181}

Add missing information during token enrollment flow (OS platform and
version) and fix a crash following the first policy fectch after the
registration.

Bug: 812641
Change-Id: I29a98dc5bdabaf61b0373595a28ce5576433784d
Reviewed-on: https://chromium-review.googlesource.com/998417
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549180}