- 19 Oct, 2017 40 commits
-
-
Ramin Halavati authored
Updated traffic annotation auditor to have more debug data. Bug:656607 Change-Id: I5503d2be4c38b6b24f3d300dfb618ffab75d38ea TBR=dpranke Change-Id: I5503d2be4c38b6b24f3d300dfb618ffab75d38ea Reviewed-on: https://chromium-review.googlesource.com/727759 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#510018}
-
Joel Kitching authored
BUG=b:64195183 TEST=./validate_format.py && ./pretty_print.py CQ-DEPEND=CL:697486 Change-Id: Ic1533ceb25f4b733c81612919b1dd08af6d989ab Reviewed-on: https://chromium-review.googlesource.com/725005Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Joel Kitching <kitching@chromium.org> Cr-Commit-Position: refs/heads/master@{#510017}
-
Ben Chan authored
Bug: 755727 Change-Id: Ib1224db452ea366eac2d5dd4d940b26fd5c1b035 Reviewed-on: https://chromium-review.googlesource.com/727374Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510016}
-
Han Leon authored
The notable thing of this CL is that it tied the lifetime of content::WebServiceWorkerRegistrationImpl with content::ServiceWorkerRegistrationHandle in the browser process, so that they have a real 1:1 correspondence with the key registration handle id. BUG=769236 Change-Id: I2773706a8c506bb0523e0e1960abecd65c4cc077 Reviewed-on: https://chromium-review.googlesource.com/686557Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#510015}
-
Sergey Ulanov authored
Moved VolumeControl from backend/alsa to backend directory. To remove ALSA dependency added SystemVolumeControl interface that abstracts functionaly implemented in AlsaVolumeControl. Bug: 772488 Change-Id: I40575d873df00829b445dc8309ad0a61038009c8 Reviewed-on: https://chromium-review.googlesource.com/720076 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#510014}
-
Shanmuga Pandi M authored
Bug: 771800 Change-Id: I15d2a3ecbbb331fe47e9d031712a99f998782e56 Reviewed-on: https://chromium-review.googlesource.com/720723Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#510013}
-
Hajime Hoshi authored
This CL changes how to manage observers of NetworkStateNotifier to use handles in RAII way. Before this CL, we depended on the fact that WebTaskRunner objects returned from TaskRunnerHelper::Get were always same for the same execution context. Now we are trying to change the fact and WebTaskRunnerImpl will always be created for each call. This is part of the big CL for changing WebFrameSchedulerImpl:: *TaskRunner() to create WebTaskRunnerImpl anytime: https://chromium-review.googlesource.com/c/chromium/src/+/704459 Bug: 762453 Change-Id: I5308e7cb0493d84c25e4da7f3562cd0fcff0f3af Reviewed-on: https://chromium-review.googlesource.com/722859 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#510012}
-
Sergey Ulanov authored
All tests that were executed in cast_alsa_cma_backed_unittests are now built as cast_audio_backend_unittest. Updated all buildbot configs to run the new test binary and removed the old one. Bug: 772488 Change-Id: I8339687c082c8ffb828e9676700cd6f7e39ecfe9 Reviewed-on: https://chromium-review.googlesource.com/719726 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#510011}
-
Findit authored
This reverts commit d7b19dd0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 510005 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q3YjE5ZGQwYmU1ZDNjNTUzOGRmYTcxYzkxMDgxMzllYTIxY2UwMGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac%20Builder/223434 Original change's description: > Refer to ui::ResourceBundle with namespace. > > ResourceBundle became ui::ResourceBundle in r72038 but many callers > still refer to it without the namespace. > > TBR=jamescook@chromium.org,treib@chromium.org > > Change-Id: Ic0b7116beabc945ea4ac27cf4d65dc177274cc85 > Reviewed-on: https://chromium-review.googlesource.com/696139 > Commit-Queue: Lei Zhang <thestig@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510005} Change-Id: Ia38bdfba8d2468977ed81c3e8b7122430b4435a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/727078 Cr-Commit-Position: refs/heads/master@{#510010}
-
Trent Apted authored
This reverts commit d7b19dd0. Reason for revert: widespread compile failures, e.g. ../../ui/base/resource/resource_bundle_ios.mm:93:10: error: use of undeclared identifier 'sequence_checker_' DCHECK(sequence_checker_.CalledOnValidSequence()); Original change's description: > Refer to ui::ResourceBundle with namespace. > > ResourceBundle became ui::ResourceBundle in r72038 but many callers > still refer to it without the namespace. > > TBR=jamescook@chromium.org,treib@chromium.org > > Change-Id: Ic0b7116beabc945ea4ac27cf4d65dc177274cc85 > Reviewed-on: https://chromium-review.googlesource.com/696139 > Commit-Queue: Lei Zhang <thestig@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510005} TBR=jamescook@chromium.org,sadrul@chromium.org,ben@chromium.org,thestig@chromium.org,treib@chromium.org Change-Id: Ib4428ba90efe811331e8190c9d22608d94d51cd6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/727442Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#510009}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6e0641b1536..037f9b80bbd8 $ git log e6e0641b1..037f9b80b --date=short --no-merges --format='%ad %ae %s' 2017-10-18 hinoka bot_update recipe: Upload source manifest Created with: roll-dep src/third_party/depot_tools Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=phajdan.jr@chromium.org Change-Id: Icf4107434c7ad220202d3c8f284d18d8c27a9fcf Reviewed-on: https://chromium-review.googlesource.com/727123Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510008}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/aa5c70636f61..95c5e3392f3a $ git log aa5c70636..95c5e3392 --date=short --no-merges --format='%ad %ae %s' 2017-10-19 angle-deps-roller Roll skia/third_party/externals/angle2/ 23e028432..082e70060 (1 commit) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I46207e4de591598eb08bbe852dbdf1ddb95d5abf Reviewed-on: https://chromium-review.googlesource.com/727256Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510007}
-
David Tseng authored
TBR=dtseng@chromium.org Bug: 773866 Original change Reviewed-on: https://chromium-review.googlesource.com/723606 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509911} Change-Id: I74c39f7d8372b623a827dff89cc20b25f6485a2f Reviewed-on: https://chromium-review.googlesource.com/727122Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#510006}
-
Lei Zhang authored
ResourceBundle became ui::ResourceBundle in r72038 but many callers still refer to it without the namespace. TBR=jamescook@chromium.org,treib@chromium.org Change-Id: Ic0b7116beabc945ea4ac27cf4d65dc177274cc85 Reviewed-on: https://chromium-review.googlesource.com/696139 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#510005}
-
Sergey Ulanov authored
Previously all files used to build CMA backend on desktop builds of cast_shell had "_default" suffix and were in the common backend directory. Moved them to a separate directory and renamed them to use "_desktop" suffix. Change-Id: I26cb1791f3a9b8dfd8c133f1ff84739f79df5a6c Reviewed-on: https://chromium-review.googlesource.com/717721 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#510004}
-
Tien-Ren Chen authored
Previously we create a child containment layer sized by LayoutRect::InfiniteIntRect() when a layer has CSS clip-path. This is because we used object.HasClipRelatedProperty() as the criteria, but the layer only applies CSS clip and overflow clip. This confuses foreground layer geometry computation, and resulted in an oversized foreground layer. This CL does the following things: 1. Change the criteria so that child containment layer is only created when either CSS clip or overflow clip is present. 2. Simplify foreground layer and child containment layer geometry computation, so that subpixel accumulation handling is more correct, and also infer parameters from the parent graphics layer so the formula is consistent for different layer hierarchy configuration. BUG=773536 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic8074ef54270cdd2f628bc73f3bcb6fa929d8881 Reviewed-on: https://chromium-review.googlesource.com/722259 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#510003}
-
Becky Zhou authored
Create a dialog class that is managed by JavaScriptDialogTabHelper for Android and show dummy "app modal" AlertDialog for now. Bug: 687010 Change-Id: Iea8a5ff759f5975db4d67c1090082cfbe341c0bc Reviewed-on: https://chromium-review.googlesource.com/702925 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#510002}
-
Koji Ishii authored
Following bot results are included. 1734 1735 1737 1742 1747 1750 1754 1758 1759 1762 1765 1768 1769 1771 0 lines were removed by consecutive passes since 1720. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I2ab352f0846b5ae31b7834ab9634326580fe3488 Reviewed-on: https://chromium-review.googlesource.com/727486 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#510001}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b85708fb..43e99bf7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ied6d94e837e851282fbfa8280f3d86e3097694a2 Reviewed-on: https://chromium-review.googlesource.com/727623Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#510000}
-
Xianzhu Wang authored
Previously some composited layers are not painted because of wrong offset of cull rect. With this patch, 62 layout tests under compositing/ and paint/invalidation/ now pass, with --enable-slimming-paint-v175, but it doesn't fix all such failures. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7c1502d3e466a8e4bd9f411a59c4faec6d72df31 Reviewed-on: https://chromium-review.googlesource.com/724173Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#509999}
-
Yafei Duan authored
Separating the feature flag tests from the model tests, in order to make unit tests for model more slim and reasonable. Bug: NONE Change-Id: I5a58e49cb3b76a427eded26818485da18c2e237a Reviewed-on: https://chromium-review.googlesource.com/727568Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#509998}
-
Peiyong Lin authored
This patch introduces mojo interface for each existing coordination unit, defines and implements the APIs for sending signals to coordination unit. This patch is part of the progress to make sure coordination unit in resource_coordinator/ strongly typed. See https://chromium-review.googlesource.com/c/chromium/src/+/719516 for a fully working prototype. BUG=775691 Change-Id: I2677920f07dafe3334a09a945e0d4e19266de319 Reviewed-on: https://chromium-review.googlesource.com/724186 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#509997}
-
Yoshifumi Inoue authored
This patch makes |LayoutSelectionTest.TraverseLayoutObjectCrossingShadowBoundary| simpler for improving code health. Change-Id: Ic56df2cea300977358843e27f6838856548382cb Reviewed-on: https://chromium-review.googlesource.com/702077Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#509996}
-
Koji Ishii authored
This patch changes LayoutNGPaintFragments to be enabled only for blocks with inline children. NGPaintFragment is generated only for where NGBlockFlowPainter should be used, and producing its descendants stops at the block layout boundary. BoxType() is re-worked to set from NGFragmentBuilder because kOldLayoutRoot is not computable from LayoutObject. Bug: 636993, 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5d46167ddf53ffdde591035829ef0d4b8d3d79c5 Reviewed-on: https://chromium-review.googlesource.com/725008 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#509995}
-
Reilly Grant authored
This change removes the additional "context enabled" feature for the MojoJSTest bindings and instead simply modifies the base class for all WebUI browser tests to add a command line flag enabling these bindings. This enables the bindings in all renderers launched by such tests but that is okay. Bug: 775760 Change-Id: I36ec28aed07ff9bcf46228f9828e157c96222723 Reviewed-on: https://chromium-review.googlesource.com/727477Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509994}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/eac03014e564..aa5c70636f61 $ git log eac03014e..aa5c70636 --date=short --no-merges --format='%ad %ae %s' 2017-10-18 angle-deps-roller Roll skia/third_party/externals/angle2/ d0ef13a25..23e028432 (1 commit) Created with: roll-dep src/third_party/skia BUG=765919 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ide992249b98f15365bde945b35d0da5c595a721c Reviewed-on: https://chromium-review.googlesource.com/726824Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509993}
-
Wez authored
This reverts commit c2a865c7. Reason for revert: This causes some IPC and Mojo tests to start failing (see crbug.com/776242). Original change's description: > [fuchsia][mojo/edk] Clone FD if transfer fails > > When trying to send a platform handle represented as a file descriptor > cross-process on Fuchsia, we attempt to transfer the FD in-place which > is more efficient than the usual clone + send + close pattern. In some > cases the transfer operation fails, however, so we have to make a fresh > clone to transfer. > > Bug: 776163 > Change-Id: I6d25e19ee7fef194261f5d1e624a4d8de291d6b3 > Reviewed-on: https://chromium-review.googlesource.com/727121 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509951} TBR=wez@chromium.org,jamesr@chromium.org Change-Id: Icd42bdf3e3d7438b486fd24d4aee5b7d25be32b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 776163, 776242 Reviewed-on: https://chromium-review.googlesource.com/727027Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#509992}
-
Lei Zhang authored
It does not need both a bool success value and an error base::Value. base: :Value can already represent a none type on its own. Change-Id: Ie329126ae026a2b489552efac2f5c56ba181055d Reviewed-on: https://chromium-review.googlesource.com/703864Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#509991}
-
Joel Einbinder authored
Puppeteer issue: https://github.com/GoogleChrome/puppeteer/issues/777 Bug: none Change-Id: Ib823af902263c7993978498174348fff28b47e1e Reviewed-on: https://chromium-review.googlesource.com/714280Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#509990}
-
Lei Zhang authored
The existing implementation took a raw base::Value* pointer and depended on a comment to explain ownership semantics. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I79aeea59537056350bb87f37ca2f458b28f46484 Reviewed-on: https://chromium-review.googlesource.com/722352 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509989}
-
Ella Ge authored
In this patch, we remove truncation in WebInputEvent builder. Use gfx::pointF in GetScreenLocation from ui::LocatedEvent to get fractional PositionInScreen. Add float coordinates conversions. Includes conversions in ui/ash part. (they are override functions of virtual function in screen_position_client.h) This CL doesn't expose the fractions to the web because of truncation in later stages in event pipeline. Bug: 456625 Change-Id: Ie1573cc8c059542f3fe07ce9c88b8c12c657ff96 Reviewed-on: https://chromium-review.googlesource.com/691338Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#509988}
-
Evan Stade authored
{Profile}NotifierGroup had one purpose, which was to separate notification settings from different profiles on Win-ash. ChromeOS doesn't mix notification settings from different profiles and only shows those from the active user, so they're not needed. MessageCenterSettingsController is only used by NotifierSettingsView, which now only compiles on ash/. Hence it can be ChromeOS only now (although it's still difficult to move to ash/). This class gets a lot simpler. Other random cleanups: - move more code into NotifierController - cut NotificationUiManager out of the settings provider initialization loop; instead set it directly on MessageCenter. Change-Id: Ib9a60e0eb3c167513eba555938369bad3f9d4634 Bug: 755413 Reviewed-on: https://chromium-review.googlesource.com/685986 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#509987}
-
Alexey Kozyatinskiy authored
R=lushnikov@chromium.org Bug: chromium:470899 Change-Id: If32e72208a2ccc6a0471a9e38e4f8a50b4eecfc0 Reviewed-on: https://chromium-review.googlesource.com/726386 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#509986}
-
Yuri Wiitala authored
Fixes a number of existing bugs when requesting scaling of a subset of the entire output (e.g., when the output rect does not have an origin of 0,0): 1) Corrected overscan calculations; 2) Math fixes, including proper accounting for vertical flipping; 3) Cleaned-up some confusing variable naming. Added a plethora of unit testing for use of: 1) the source texture re-positioning offset; and 2) output rects with non-0,0 origins. TODO: Currently, scaling using a source texture re-positioning offset having non-whole-numbered coordinates is broken. This is documented and guarded with DCHECKs for safety. There is not yet a use case for this, but the issues will be addressed in a later change. Bug: 775740 Change-Id: Iaa783a5e9efa37f16abbf2a4a8660cf843efb5c7 Reviewed-on: https://chromium-review.googlesource.com/724426Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#509985}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: I5f737c0e1b218d68c4ec3d2b75e1770655844208 Reviewed-on: https://chromium-review.googlesource.com/727621Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#509984}
-
Benjamin Pastene authored
build-side change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/724164 Bug: 773872 Change-Id: Ie8bb990b3b6969cc245120bc8b3bdd0dac852c95 Reviewed-on: https://chromium-review.googlesource.com/724176Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#509983}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9614d686..b85708fb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Icb78fe6b676cb28e0b978f3d6dc02e28ef023810 Reviewed-on: https://chromium-review.googlesource.com/727159Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#509982}
-
Scott Kirkwood authored
TBR: pkotwicz@chromium.org Bug: 776097 Change-Id: I99b137a8a1024c3f352a2ef3a8cd2c6dbb8e17c0 Reviewed-on: https://chromium-review.googlesource.com/727565Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#509981}
-
Jennifer Apacible authored
Add a custom WidgetDelegate for OverlayWindowViews. This is used to control more of the behaviour of OverlayWindow. This also adds a placeholder window title string. Non-trivial beheaviour will be added with more guidance from UX. Bug: 726621 Change-Id: I7d6eae901248f90d8cbebc9bc4bd6e52aa7f714d Reviewed-on: https://chromium-review.googlesource.com/722453 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#509980}
-
Qiang Xu authored
1-pager: go/tablet-mode-screenshot-hotkey changes: - add UMA recording user action of taking screenshot by power button screenshot accel. - add UMA recording the delay between power button pressed and volume down key pressed, which will help us determine the best delay time for users. Bug: 712072 Test: device test with chrome://histograms and chrome://user-actions Change-Id: Ibce1c238ada747ca0400dbad3429b1e74722390c Reviewed-on: https://chromium-review.googlesource.com/725220Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#509979}
-