GitLab

The setting is not used anymore.
Remove it.

Review-Url: https://codereview.chromium.org/2576473002
Cr-Commit-Position: refs/heads/master@{#438171}

Internal types, no good reason to expose these to the outside.

R=
BUG=673645

Review-Url: https://codereview.chromium.org/2573783002
Cr-Commit-Position: refs/heads/master@{#438170}

Re-enable SSLUITest.TestGoodFrameNavigation since it's no longer flaky as of revision 2677ed35

BUG=668360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=agl@chromium.org

Review-Url: https://codereview.chromium.org/2569813002
Cr-Commit-Position: refs/heads/master@{#438169}

Also cleaned up the code a bit.

R=peria
BUG=673213

Review-Url: https://codereview.chromium.org/2568863003
Cr-Commit-Position: refs/heads/master@{#438168}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2569713003
Cr-Commit-Position: refs/heads/master@{#438167}

BUG=672999
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=kbr@chromium.org,zmo@chromium.org

Review-Url: https://codereview.chromium.org/2569013005
Cr-Commit-Position: refs/heads/master@{#438166}

BUG=643746, 604369
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2
Review-Url: https://codereview.chromium.org/2555693005
Cr-Original-Commit-Position: refs/heads/master@{#437771}
Cr-Commit-Position: refs/heads/master@{#438165}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2566993002
Cr-Commit-Position: refs/heads/master@{#438164}

https://skia.googlesource.com/skia.git/+log/b399e38518c7..3b3bdafa8e3a

$ git log b399e3851..3b3bdafa8 --date=short --no-merges --format='%ad %ae %s'
2016-12-12 borenet Delete swarm_trigger recipe

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2566283005
Cr-Commit-Position: refs/heads/master@{#438163}

We've reverted the bad rebaseline for this test, but still need to
update the results for SK_ANALYTIC_AA.

BUG=669643
TBR=liyuqian@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2571803002
Cr-Commit-Position: refs/heads/master@{#438162}

https://chromium.googlesource.com/angle/angle.git/+log/d023939..c31b741

BUG=308366, 672380, 668028, 668223, angleproject:1523, angleproject:523

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2567173003
Cr-Commit-Position: refs/heads/master@{#438161}

In particular the session code going to ash isn't really wired up
correctly. As we don't plan on using this soon I'm going to remove it
for now. We can bring back when necessary.

R=ben@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2569953002
Cr-Commit-Position: refs/heads/master@{#438160}

Reland of https://codereview.chromium.org/2569713002/ that was reverted
with https://codereview.chromium.org/2567203002/ but turned out to not
be the reason for the failures.

Original CL description:

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2569213002
Cr-Commit-Position: refs/heads/master@{#438159}

BUG=673729
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2572753002
Cr-Commit-Position: refs/heads/master@{#438158}

The goal is to compare usage patterns between the different days of the week.

BUG=665873

Review-Url: https://codereview.chromium.org/2563443004
Cr-Commit-Position: refs/heads/master@{#438157}

To move ImageResource out of core/fetch, remove unexpected dependencies
from ResourceFetcher to ImageResource.

BUG=655920

Review-Url: https://codereview.chromium.org/2510883003
Cr-Commit-Position: refs/heads/master@{#438156}

We're deprecating DOMWindowProperty, which is equivalent to ContextLifecycleObserver.
This CL does the replacement for Performance.

BUG=610176

Review-Url: https://codereview.chromium.org/2569153002
Cr-Commit-Position: refs/heads/master@{#438155}

BUG=658305
R=fs@opera.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2567113004
Cr-Commit-Position: refs/heads/master@{#438154}

Disable flaky test org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testPreventHandlingCurrentSelectionModification.

TBR=twellington@chromium.org

BUG=673684

Review-Url: https://codereview.chromium.org/2573793002
Cr-Commit-Position: refs/heads/master@{#438153}

This patch implements a runtime headless mode (i.e., a
--headless command line switch) that makes it possible to
use a regular Chrome binary as a headless. When the binary
is launched with this switch, the main entrypoint calls
into the Headless Shell entrypoint, effectively starting
that shell instead of Chrome.

To make this possible we must remove the dependency from
Headless to Ozone, because Ozone is a build-time feature
which is generally not enabled for regular Chrome builds.
In practice this means implementing a new headless-specific
WindowTreeHost and modifying various graphics and input
entrypoints to do something appropriate in headless mode.

Since many of the modifications are in platform-specific
code, this initial patch only adds headless support in Linux.
Other platforms will be added later.

Design doc: https://docs.google.com/document/d/1aIJUzQr3eougZQp90bp4mqGr5gY6hdUice8UPa-Ys90/edit#

BUG=612904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1991953002
Cr-Commit-Position: refs/heads/master@{#438152}

Semi-auto generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2568143002
Cr-Commit-Position: refs/heads/master@{#438151}

Revert of Do not generate a microdump if there are no webview pointers on the stack. (patchset #6 id:100001 of https://codereview.chromium.org/2552753002/ )

Reason for revert:
Revert in preparation for modifying breakpad to infer the interest
region from mappings rather than being explicitly informed.

Linux ld.so refuses to relocate absolutely addressed symbols at offset 0,
causing the use of __executable_start to fail at load time on that platform.
We will need to find a better way to determine the extent of the text
section.

Original issue's description:
> Do not generate a microdump if there are no webview pointers on the stack.
>
> To determine the webview text section address range, we use the linker
> defines symbols __executable_start and __etext. These are passed to
> breakpad in the microdump extra info struct, causing it to not generate
> a microdump if the stack of the crashing thread does not contain a
> pointer into this region.
>
> BUG=664460
>
> Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2
> Committed: https://crrev.com/aca68a011a9fd116972e329871f67c73ca8ca389
> Cr-Original-Commit-Position: refs/heads/master@{#437003}
> Cr-Commit-Position: refs/heads/master@{#437234}

TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664460

Review-Url: https://codereview.chromium.org/2565353004
Cr-Commit-Position: refs/heads/master@{#438150}

The decorator was applied to a base class which doesn't
actually cause anything to be disabled.

BUG=catapult#:3088

Review-Url: https://codereview.chromium.org/2575513002
Cr-Commit-Position: refs/heads/master@{#438149}

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2557533005
Cr-Commit-Position: refs/heads/master@{#438148}

Revert of Set user_gesture bit at NavigationHandle creation time. (patchset #19 id:350001 of https://codereview.chromium.org/2499313003/ )

Reason for revert:
This patch broke UrlOverridingTest#testOpenWindowFromUserGesture. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.externalnav.UrlOverridingTest%23testOpenWindowFromUserGesture

Original issue's description:
> Set user_gesture bit at NavigationHandle creation time.
>
> Previously, the user_gesture bit was set at different places and could be
> updated during the lifetime of a navigation, such as in WillStartNavigation
> and at commit time. In practice, whether a navigation was initiated by
> user gesture is known at the time a NavigationHandle is created.
> This change makes has_user_gesture_ a const member of NavigationHandleImpl,
> and sets it once at construction time.
>
> clamy suggested that we could set the user gesture bit at NavHandle
> construction time in the following places:
> - PlzNavigate: we have it when we create the handle.
> - Regular navs: we add the parameter to DidStartProvisionalLoad.
> - same-page navs: we create the NavigationHandle in DidCommitProvisionalLoad,
>   where we have the information.
>
> This patch makes the following changes:
> - adds a gesture param to NavigationHandleImpl::Create
> - adds a gesture boolean param to FrameHostMsg_DidStartProvisionalLoad,
>   which is passed to RenderFrameHostImpl::OnDidStartProvisionalLoad
> - removes the has_user_gesture boolean param from
>   NavigationHandleImpl::WillStartRequest
>
> For the time being, we continue to update the gesture_ value at commit time.
> Once crbug.com/667572 is addressed, gesture_ can be made a const member and
> we can stop updating it at commit time.
>
> BUG=665952
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/318ecffe833701cfd6db2ac43491ace0a68e18af
> Cr-Commit-Position: refs/heads/master@{#435354}

TBR=bauerb@chromium.org,clamy@chromium.org,michaelbai@chromium.org,rdevlin.cronin@chromium.org,tsepez@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2557233002
Cr-Commit-Position: refs/heads/master@{#438147}

Implementations of WorkerLoaderProxyProvider::postTaskToLoader have used
ExecutionContext::postTask to post tasks to the main thread. However,
the posted tasks are unexpectedly throttled, and that delays the startup
time of service workers.
This CL replaces ExecutionContext::postTask there with ParentFrameTaskRunners
and WebTaskRunner::postTask, so that the posted task is routed to suitable
task runners.

BUG=667310, 671084

Review-Url: https://codereview.chromium.org/2574703002
Cr-Commit-Position: refs/heads/master@{#438146}

BUG=630728

Review-Url: https://codereview.chromium.org/2568283002
Cr-Commit-Position: refs/heads/master@{#438145}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/642e2c87..d654057e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2573443003
Cr-Commit-Position: refs/heads/master@{#438144}

This is suspected to cause flaky failure of telemetry_unitests

BUG=661434

Review-Url: https://codereview.chromium.org/2564413002
Cr-Commit-Position: refs/heads/master@{#438143}

BUG=668714
TBR=jochen
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2572453002
Cr-Commit-Position: refs/heads/master@{#438142}

Change "Read" header to a phrase in reading to be clearer in all languages.

BUG=673335

Review-Url: https://codereview.chromium.org/2568163002
Cr-Commit-Position: refs/heads/master@{#438141}

This CL updates the FlagExpectations file for layout tests for the flag
--enable-browser-side-navigation (aka PlzNavigate).

BUG=576261

Review-Url: https://codereview.chromium.org/2568873002
Cr-Commit-Position: refs/heads/master@{#438140}

http://chromium.googlesource.com/chromium/deps/icu.git/+log/73e24736..9cd28287

One change in the range: deprecation warning suppresion for non-clang.

BUG=21515,637001

Review-Url: https://codereview.chromium.org/2575433002
Cr-Commit-Position: refs/heads/master@{#438139}

This CL is partial revert of
https://codereview.chromium.org/1682173005

BUG=671380
TEST=translate.py resumes working as expected.
TBR=flackr

Review-Url: https://codereview.chromium.org/2570003002
Cr-Commit-Position: refs/heads/master@{#438138}

Per discussion in https://bugs.chromium.org/p/chromium/issues/detail?id=615589#c113.

BUG=615589,663546

Review-Url: https://codereview.chromium.org/2569183002
Cr-Commit-Position: refs/heads/master@{#438137}

The registration of the finalization callback now happens under-the-hood
and automatically.

R=haraken
BUG=673645

Review-Url: https://codereview.chromium.org/2570463005
Cr-Commit-Position: refs/heads/master@{#438136}

Also, define how initialization of nodes works, by adding an init()
method that is called after creating a node.

Initialization now happens after the full tree structure has been
created, and recursively processes all nodes in the tree. Subtrees that
are added later use the same pattern; InnerNode now has helper methods
for this.

BUG=616090

Review-Url: https://codereview.chromium.org/2513453004
Cr-Commit-Position: refs/heads/master@{#438135}

The test is essentially flaky and we are unable to fix it.

BUG=518988, 143475
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2570503004
Cr-Commit-Position: refs/heads/master@{#438134}

If VideoFrameQualityValidator cannot get a decoder, the
TestSimpleEncode test would abort without destroying the
encoder first and thus causes a crash. This change makes
the test to fail properly.

BUG=672403
TEST=Run VEA unittest built for external chromium on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2573733002
Cr-Commit-Position: refs/heads/master@{#438133}

This cl fixes calculations done with offset value.
Offset value must be added to a raw value and only then multiplied
by a scaling value.
The formula is the following:
processed value = (raw + offset) * scale

BUG=661478

Review-Url: https://codereview.chromium.org/2570693004
Cr-Commit-Position: refs/heads/master@{#438132}