GitLab

BUG=405869
TBR=ygorshenin@chromium.org

Review URL: https://codereview.chromium.org/625453003

Cr-Commit-Position: refs/heads/master@{#297779}

Revert of Add --output-dir flag for page_runner.py. (patchset #2 id:40001 of https://codereview.chromium.org/616063004/)

Reason for revert:
Failing on all perf bots in generate_telemetry_profiles:

Traceback (most recent call last):
  <module> at tools/perf/generate_profile:13
    sys.exit(profile_generator.Main())
  Main at tools/telemetry/telemetry/page/profile_generator.py:145
    AddCommandLineArgs(parser)
  AddCommandLineArgs at tools/telemetry/telemetry/page/profile_generator.py:115
    help='Generated profile is placed in this directory.')
  add_option at /usr/lib/python2.7/optparse.py:1020
    self._check_conflict(option)
  _check_conflict at /usr/lib/python2.7/optparse.py:995
    option)
OptionConflictError: option --output-dir: conflicting option string(s): --output-dir

Locals:
  co            : ('--output-dir', <Option at 0x2b074d0: --output-dir>)
  conflict_opts : [('--output-dir', <Option at 0x2b074d0: --output-dir>)]
  handler       : 'error'
  opt           : '--output-dir'
  option        : <Option at 0x2b08290: --output-dir>

Original issue's description:
> Add --output-dir flag for page_runner.py to specify a custom directory for
> output profiling and results data.
>
> Motivation behind this flag: I've run into a bug where a run on a local device
> and a run on the try bots are showing different versions of the page. I wanted
> to use the android_screen_recorder_profiler.py to record the try bot version
> and see what it is actually showing. However, it currently tries to output the
> video to a temporary directory in /tmp (which I do not have permission to write
> to).
>
> BUG=
>
> Committed: https://crrev.com/2a859c8f48b40d7bc443812e6cf760f10e0d22ba
> Cr-Commit-Position: refs/heads/master@{#297740}

TBR=tonyg@chromium.org,nednguyen@google.com,ariblue@google.com
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/616953005

Cr-Commit-Position: refs/heads/master@{#297778}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f08ac8f..d8126c1

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/616953004

Cr-Commit-Position: refs/heads/master@{#297777}

QuicServerInfo.

BUG=417835
R=rch@chromium.org, asvitkine@chromium.org

Review URL: https://codereview.chromium.org/618083003

Cr-Commit-Position: refs/heads/master@{#297776}

Without a message, you can't identify where the assertion was triggered,
except via the javascript console.

BUG=397019

Review URL: https://codereview.chromium.org/620913003

Cr-Commit-Position: refs/heads/master@{#297775}

This eliminates the need for callers to do explicit conversions, and also
ensures callers don't try to implement pickling of a size_t using a 32-bit type,
leading to truncation on 64-bit targets.  The pickle layer will ensure 64-bit
types are always used.

I'll be changing other callsites to use this in future patches.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/601563003

Cr-Commit-Position: refs/heads/master@{#297774}

in which we would consider the mapping to be missing even if
the probability was such that we would not honor the advertisement.

BUG=

Review URL: https://codereview.chromium.org/620753007

Cr-Commit-Position: refs/heads/master@{#297773}

NSS upstream patches:
https://hg.mozilla.org/projects/nss/rev/2cb5c73ac307
https://hg.mozilla.org/projects/nss/rev/544eb0f50d40

R=agl@chromium.org
BUG=416841

Review URL: https://codereview.chromium.org/595823003

Cr-Commit-Position: refs/heads/master@{#297772}

Currently GestureNav/horizontal overscroll is enabled on all Aura builds. However to engage GestureNav you either need a touch screen or a 2-finger gesture support for the touchpad. This means we are paying the cost of screenshotting for every navigation on some machines where you won't ever be able to experience GestureNav.

BUG=398516

Review URL: https://codereview.chromium.org/617543002

Cr-Commit-Position: refs/heads/master@{#297771}

MSVC is somewhat pickier about casting things to bool.

BUG=338884

Review URL: https://codereview.chromium.org/618123007

Cr-Commit-Position: refs/heads/master@{#297770}

BUG=419556
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/622713002

Cr-Commit-Position: refs/heads/master@{#297769}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/16c9ae4..f08ac8f

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/617263005

Cr-Commit-Position: refs/heads/master@{#297768}

BUG=414340

Remove

Review URL: https://codereview.chromium.org/621763003

Cr-Commit-Position: refs/heads/master@{#297767}

BUG=418656

Review URL: https://codereview.chromium.org/620673002

Cr-Commit-Position: refs/heads/master@{#297766}

For function call arguments:
- if all arguments plus ')' fit at current point, insert
- if all arguments fit at current, one per line
- otherwise at minimum of current and margin+4, one per line, recurse into children. Similar for binary expressions so that "a + b" can wrap.

Also, add basic output of AccessorNode + test.

(not as fancy as clang-format, but there's not that many long
function calls in .gn files.)

R=brettw@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/607243002

Cr-Commit-Position: refs/heads/master@{#297765}

It's no longer flaky since the underlying bug was fixed in crrev.com/615633003.

BUG=415792

Review URL: https://codereview.chromium.org/619683002

Cr-Commit-Position: refs/heads/master@{#297764}

BUG=402005,413370

Review URL: https://codereview.chromium.org/583883002

Cr-Commit-Position: refs/heads/master@{#297763}

BUG=

Review URL: https://codereview.chromium.org/430473011

Cr-Commit-Position: refs/heads/master@{#297762}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/39f31c6..b77955e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/623613003

Cr-Commit-Position: refs/heads/master@{#297761}

https://chromium.googlesource.com/angle/angle/+log/57f20894aee71ca9f78803f5a7545a86fd880ddb..b4fd0c96d21ff1534e1d6db40dcf142eeebda0d0?pretty=full

BUG=
TEST=bots
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/618243003

Cr-Commit-Position: refs/heads/master@{#297760}

BUG=

Review URL: https://codereview.chromium.org/614053002

Cr-Commit-Position: refs/heads/master@{#297759}

BUG=414808
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/623433005

Cr-Commit-Position: refs/heads/master@{#297758}

The "title" provides useful information in debugging.

R=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/616263002

Cr-Commit-Position: refs/heads/master@{#297757}

Refactor the IOSurface drawing code because it can now safely assume
that the texture it needs to draw is exactly the size of the CALayer.

Delete unused and redundant IOSurface code.

This should have almost no functional change.

BUG=

Review URL: https://codereview.chromium.org/623563003

Cr-Commit-Position: refs/heads/master@{#297756}

This is never used now that aura is enabled.

Review URL: https://codereview.chromium.org/621883004

Cr-Commit-Position: refs/heads/master@{#297755}

This is required to workaround typo in the guard macro of secmod.h. See details in bug.

BUG=415498

Review URL: https://codereview.chromium.org/582403002

Cr-Commit-Position: refs/heads/master@{#297754}

BUG=413790

Review URL: https://codereview.chromium.org/568873002

Cr-Commit-Position: refs/heads/master@{#297753}

Added checks for correct translation:
  * Error.Failed
  * Error.ReadNotPermitted
  * Error.WriteNotPermitted
  * Error.NotSupported

Error.InProgress tested via new SetExtraProcessing
Error.NotAuthorized tested via new SetAuthorized
Error.NotPaired tested via new SetAuthenticated

BUG=377232

Review URL: https://codereview.chromium.org/619973002

Cr-Commit-Position: refs/heads/master@{#297752}

This CL introduces an internal destroyGuest API, and enables preservation of
guests when display:none is set.

This patch is also a big step towards guest teleportation.

BUG=419020, 330264
TBR=kenrb@chromium.org for browser_plugin_messages.h IPC removal, asvitkine@chromium.org for histograms.xml

Review URL: https://codereview.chromium.org/618823002

Cr-Commit-Position: refs/heads/master@{#297751}

Revert of Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize() (patchset #3 id:120001 of https://codereview.chromium.org/613563002/)

Reason for revert:
Suspected for failures on Linux ChromiumOS Tests (dbg)(1)
link:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/32143

browser_test LoginWebDialogTest.CannotMinimize failing with:
[12496:12496:1001/170357:FATAL:login_web_dialog.cc(148)] Check failed: false.
#2 0x0000026179dd chromeos::LoginWebDialog::OnCloseContents()
#3 0x7f542cba9b00 views::WebDialogView::OnCloseContents()
/* snip */
#24 0x7f5422726679 aura::Window::~Window()
#25 0x7f54244db0f8 ash::RootWindowController::CloseChildWindows()
#26 0x7f5424444bad ash::DisplayController::CloseChildWindows()
#27 0x7f542452db9b ash::Shell::~Shell()
#28 0x7f542452e869 ash::Shell::~Shell()
#29 0x7f542452a16f ash::Shell::DeleteInstance()
#30 0x000002dac13b chrome::CloseAsh()
#31 0x000002a0e111 ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun()

Original issue's description:
> Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize()
>
> This has the side effect of disallowing minimizing bubbles (e.g. the bookmark
> bubble) via a gesture
>
> BUG=328241
> TEST=Manual, see bug
>
> Committed: https://crrev.com/ffacfd8c2841480e1e5775c124b63b351bddca69
> Cr-Commit-Position: refs/heads/master@{#297732}

TBR=oshima@chromium.org,sky@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=328241

Review URL: https://codereview.chromium.org/623613004

Cr-Commit-Position: refs/heads/master@{#297750}

BUG=333023

Review URL: https://codereview.chromium.org/621983003

Cr-Commit-Position: refs/heads/master@{#297749}

BUG=414808
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/612423007

Cr-Commit-Position: refs/heads/master@{#297748}

ThreadWacther (for example, WatchDog thread is not started in Debug
mode - CL: https://codereview.chromium.org/573683003/).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/622683002

Cr-Commit-Position: refs/heads/master@{#297747}

Review URL: https://codereview.chromium.org/619993002

Cr-Commit-Position: refs/heads/master@{#297746}

The roll contains changes necessary to compile usrsctp for NaCl.

BUG=402993
TBR=lally@chromium.com

Review URL: https://codereview.chromium.org/621983002

Cr-Commit-Position: refs/heads/master@{#297745}

BUG=419407

Review URL: https://codereview.chromium.org/621953002

Cr-Commit-Position: refs/heads/master@{#297744}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d07271f..16c9ae4

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/618383002

Cr-Commit-Position: refs/heads/master@{#297743}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e946f71..39f31c6

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/619933005

Cr-Commit-Position: refs/heads/master@{#297742}

Also removes the retry limit so that it will retry on failures until the test framework stops the test.

BUG=418952

Review URL: https://codereview.chromium.org/614423002

Cr-Commit-Position: refs/heads/master@{#297741}

output profiling and results data.

Motivation behind this flag: I've run into a bug where a run on a local device
and a run on the try bots are showing different versions of the page. I wanted
to use the android_screen_recorder_profiler.py to record the try bot version
and see what it is actually showing. However, it currently tries to output the
video to a temporary directory in /tmp (which I do not have permission to write
to).

BUG=

Review URL: https://codereview.chromium.org/616063004

Cr-Commit-Position: refs/heads/master@{#297740}