- 01 Oct, 2020 40 commits
-
-
David Dorwin authored
Addresses post-commit feedback in https://crrev.com/c/2430302. Bug: 1104369 Change-Id: Id4024d55445a10e9b5cf1770ffd71829ecb7833b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436381Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812852}
-
Lei Zhang authored
Do not take an accessibility snapshot if the RenderFrame is gone. Bug: 1133983 Change-Id: I612cc72936a1dcedc5180c24eae067e47237b09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442375Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#812851}
-
Ahmed Fakhry authored
This reverts commit 6a5d7abc. Reason for revert: HashAffiliationFetcherTest.BuildQueryURL fails consistently on linux-chromeos-chrome BUG=1134278 Original change's description: > Add HashAffiliationFetcher skeleton to retrieve affiliations by hash prefix. > > This change creates HashAffiliationFetcher skeleton that extends AffiliationFetcherBase. > This fetcher will provide additional privacy layer as it will request affiliations for a larger group of facets by passing only the prefixes of hashed URLs. > > Bug: 1108279 > Change-Id: I4a2b09aa7d8c3c51f4b30ba966a17ba5afb9b09b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423883 > Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812653} TBR=vasilii@chromium.org,jdoerrie@chromium.org,nelakaczmarek@google.com Change-Id: I8636d3cdd74f75de4ce4be9d2f76f18d3ada2f83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441379Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812850}
-
Shakti Sahu authored
This CL adds an activity to show the list of video tutorials. UX : https://docs.google.com/presentation/d/1jszfqrCLufu0mskWls6unqilpmG3PoHKdySsf4uF-eo/edit#slide=id.g95aea48d7d_0_128 Bug: 1130256 Change-Id: Ie35538f0d1ee582a61c4b04a755e3af46680b87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420530Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812849}
-
Tomasz Wiszkowski authored
The typo suggests that the omnibox would have only one suggestion to show. Skipping the screenshot check as the corresponding screenshot is already submitted. Skip-Translation-Screenshots-Check: True Bug: 1106109 Change-Id: Iccf8e9f595ed6b2dcebd83dad1dcf176e40923a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442771 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#812848}
-
Ionel Popescu authored
As discussed on the security review this CL adds the following mitigations: - require a transient user activation on the browser side, and consume it when showing the eye dropper for the renderer (this will prevent a compromised renderer to repeatedly ask for a color) - require the eye dropper UI to be visible for a minimum amount of time before color selection is allowed in order to ensure the user has a chance to see the UI. There is also a fix for the popup not correctly updating the user activation state. This happens because it is using a EmptyLocalFrameClient and its frame is not related to the owner element's frame. Bug: 992297 Change-Id: Ia5d2aead0be153ce4b49048552062de3a6c72e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442132Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#812847}
-
David Dorwin authored
Also remove the copy of the LICENSE file and an obsolete SDK path in third_party/.gitignore. Change-Id: Id67cb2bfec128572f23f8dcdccc08b54a2601338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427964Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812846}
-
David Black authored
The label is being given only enough height for a single line of text despite being a multiline line label with max of 2 lines. Bug: b:169806293 Change-Id: I8d9374270dff1a0aa43c6b397aea0462474efe2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441685Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#812845}
-
Ahmed Fakhry authored
This reverts commit d30e1594. Reason for revert: NewTabPageModulesShoppingTasksModuleTest.All fails consistently on linux-chromeos-chrome BUG=1134274 Original change's description: > WebUI Modules: shopping tasks, hide elements that do not fit > > Bug: 1132424 > Change-Id: I1b56fdec5c37d81a4939e986b3282af4585772ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440970 > Commit-Queue: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812569} TBR=tiborg@chromium.org,aee@chromium.org Change-Id: Ia0be2a22e0ffa23c22a18adc78f26de5eb729e48 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443277Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3211fba0. With Chromium commits locally applied on WPT: 8ee75745 "[layout] Track inflow-bounds within box fragment builder." 3ed38849 "[COOP] access reporting: expose "type" to ReportingObserver." a94d6a18 "[LayoutNG] Don't prevent column breaks before a spanner." 3211fba0 "Launch fontBoundingBoxAscent/Descent" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id78d620f526bddc12ffbb0115f30cc219d4392d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440240Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812843}
-
Rayan Kanso authored
WebAPKs using the new minting mechanism, identified by their package name, should have a separate latency histogram to track if overall latency will be affected. Bug: 1134173 Change-Id: Ib75ec57828c1df1f038c2a1bf383a52cc602647f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443011Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#812842}
-
Roman Aleksandrov authored
Fixed: 1117091, 1117092, 1117093 Change-Id: I5d495e7bd95c591ba2281429106e87caa0a9a3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440628 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#812841}
-
Xiaohui Chen authored
These tests rely on automatically view layout scheduling, which seems unreliable. Now force explicit re-layout. Bug: b:169442907 Test: run ash_unittests Change-Id: I5287ba293eba77b820d8e59b456feb32fb71a920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442640Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812840}
-
Lambros Lambrou authored
This adds a FileOperations implementation which can send the host's RTC event log as if it were a regular file. It runs on the same network thread that gathers the RTC event log and sends file-transfer data, so on Windows it should work inside the network process without any need for IPC. Bug: 1122798 Change-Id: I6b4484caa70804e0091e7a747ebf9ff60fe71b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441449 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#812839}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8b462fcdef40..ca55b2704b0f 2020-10-01 btolsch@chromium.org Fix boringssl error message reporting If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I9bd4351bd29dddc779d7be67611512e2946fc6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443040Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812838}
-
wutao authored
With more requested photos, it will reduce the possibility of duplicates. Bug: b/169433880 Test: manual Change-Id: Ie1042b4f47a97b776d63d2d198fecf8c01ce357f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442487Reviewed-by:
-
wutao authored
Bug: b/169101566 Test: manual Change-Id: I103126a74a88f834bf12ce5dcf133f20217bcd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442481Reviewed-by:
-
Rafael Cintron authored
To reduce the number of texture copies in camera and XR scenarios, we need to be able to share textures between processes using Windows handle objects. To facilitate this, we implement the overload of SharedImageBackingFactoryD3D::CreateSharedImage which accepts a gfx::GpuMemoryBufferHandle. Bug: 1131616 Change-Id: I9561229b7631d0a89a7ced4ee6fc0de43c029d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438649 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#812835}
-
Sebastien Marchand authored
Bug: 1088935 Change-Id: Ie9298e2dd0e57f1859918ce0a1dfd6bb39d0465c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441267Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#812834}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601286022-benchmark-87.0.4277.0-r1 to 87-4265.0-1601286022-benchmark-87.0.4278.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie58473349601a82b11b2d426cf5d0f7794e5edc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443356Reviewed-by:
-
Yuheng Huang authored
Change-Id: I99d1da75f3f57500b517909b94f00ebbefbac118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443529 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#812832}
-
David Bokan authored
This test is currently running in the main-thread scrolling path only. This CL modernizes the test to ensure it runs in both main and compositor threaded modes. Bug: 915926 Change-Id: Ia58cd94f5e6bcdd8b55fc2282f7d009936f034ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442104Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812831}
-
David Bokan authored
The behavior in this test differs based on main thread and compositor thread scrolling. On the compositor thread, only the direct-most hit scroller is targeted for autoscrolling but the main thread will bubble up to the first scroller that can consume the scroll. See the autoscroll-related comment in LayerTreeHostImpl::FindNodeToLatch. The compositor behavior is the intended one, see https://crrev.com/c/1743028 which implemented this behavior on both threads and added a test that was unfortunately removed in https://crrev.com/c/2111831. The test in this CL covers this case just as well so we just move it to fast/scrolling to ensure it gets coverage on both compositor and main threads. Bug: 915926,1112183 Change-Id: I2dcc4e83d30dbc222cefc1781b5ecf46b20a3f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441941Reviewed-by:
-
Mehran Mahmoudi authored
This CL automatically removes the paint preview when the live tab is ready. It also dispalys a toast message. Bug: 1131497 Change-Id: I6c6437fccc5f05fdbcc7afad6e34668a908729c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442155 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#812829}
-
Friedrich Horschig authored
Show an In-Product Help bubble to let the users know when suggestions can be revealed by swiping the keyboard accessory bar. The IPH only triggers if all conditions are met: - at least one suggestion is not fully rendered - the IPH explaining what chips do in general has been shown already IDS_IPH_KEYBOARD_ACCESSORY_SWIPE_FOR_MORE.png: https://storage.cloud.google.com/chromium-translation-screenshots/af6ea41db50ee56da277563b7dc173b869e19089 Bug: 1124713 Change-Id: I7112ca0ed0adbbffb45604b9c584b041831b0b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428334Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#812828}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Id133ab0b0744c07405d0ed69eb9774b27b5c09f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442540 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601289755-benchmark-87.0.4277.0-r1 to 87-4265.0-1601289755-benchmark-87.0.4278.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia705a8f0f5e4466ebe4a74a7671ce39ef4955b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443355Reviewed-by:
-
zhaoyangli authored
These run on Xcode 12.2 and should use 14.2 simulator runtime. Bug: 1132967 Change-Id: I344e4bd651da37792cf156e95cd55efafa68d816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440201Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812825}
-
Jesse Schettler authored
Since there's no benefit to passing uuid and device_name by value in LorgnetteManagerClientImpl, pass them by const reference. Bug: None Change-Id: I7594cc938d2c1180eeb172b8c71ac0ee967f1d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442501 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812824}
-
Xi Han authored
In this CL, Feeds articles are opened as a Tab instead of CCT from the StartSurface. When back button is pressed from the Tab, it will return to the original Feed articles on the StartSurface. Also support to open the Feeds articles in incognito tab. Demo: https://drive.google.com/file/d/1r3H3_S8EZms33vspI_IarE4NH3Eh9aI3/view?usp=sharing Bug: 1108451 Change-Id: I651b2378970f0ed53d2b663cdd97fd2872057ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424639 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812823}
-
Bailey Berro authored
Allows clients to implement the BatteryHealthObserver interface and register themselves as an observer in order to receive periodic updates about the battery health. Bug: 1128204 Change-Id: Ib4ffc60ec5fd30bda37c255bd17b669eaa4b9f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438474 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812822}
-
adamta authored
The IPH bubble for the Discover feed should only be shown if the NTP has been created with the Discover feed. This can be determined by checking if the named guide for the Discover feed menu button has been created. Bug: 1132757 Change-Id: I0bbf35fba8fb49fcb080ce581f3bf953d56ce0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434910 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812821}
-
Brandon Wylie authored
CustomTabCompositorContentInitializer relies on ChromeActivity to initialize compositor content. This method is part of ChromeActivity's interface, so removing the dependency is difficult. Moving the #initializeCompositorContent behind an interface and injecting that into CustomTabCompositorContentInitializer to decouple the two. This change is meant to be an example on how to handle this case. Bug: 1123209 Change-Id: I8ba93cd80074c8935bd07428327f74ca2973eb19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429870Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
-
Jacobo Aragunde Pérez authored
The kAlert accessible event was explicitly produced in several places, causing duplication. There are two places where the event must be produced for all the alert bubbles to work properly: * BubbleDialogDelegateView::AddedToWidget for the session crashed bubble * BubbleDialogDelegate::OnBubbleWidgetVisibilityChanged for the rest of them This is still causing duplication for the save password bubble, we leave it reported with a TODO in its test. Bug: 1082217 Change-Id: I29af53794823ff115767077a8824fdc6795dbe4e AX-relnotes: prevent redundant alert events. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394695 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812819}
-
Owen Min authored
The following policies can never be supported from cloud. The tag only works as a hint to the server team but not changing any browser behavior. UserDataDir CloudPolicyOverridesPlatformPolicy MachineLevelUserCloudPolicyEnrollmentToken CloudManagementEnrollmentToken CloudManagementEnrollmentMandatory CCTToSDialogEnabled Change-Id: Ibb661edc76b587ebd8f40090312ed0f06df079e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441742Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812818}
-
Leonard Grey authored
Command string constants often have ampersands embedded in them for display in Windows menus. These need to be stripped out for display in commander. Bug: 1014639 Change-Id: I37e87013fd0eb4a18eb796b8870768c9794c1aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440308Reviewed-by:
-
Nate Chapin authored
Change-Id: Ie26ffe4038baa99cca2942440df3cbddfea29069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436681 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#812816}
-
Caleb Raitto authored
We're only adding use counters for these methods. Bug: 973801 Change-Id: Id87584bb501f7ccd7cb98c0c3ce2d7500763bb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438755 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
-
Prashant Nevase authored
The dark mode settings were tightly coupled to blink settings. As per usage those don't change until chrome is relaunched or webview's lifetime. This patch cleans up dark mode settings and new behavior is - blink settings is used for enabling/disabling dark mode while dark mode settings are used to configure dark mode filter. Decoupling settings will help create DarkModeFilter without blink settings. This is needed for raster side dark mode for images. Bug: 1082339 Change-Id: I763ea3f0f05e43b4ea30926817f3aca06bf5f84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390588 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Gil Dekel authored
As of today, all ChromeOS releases utilize kernels that robustly support universal planes. This makes the need to accommodate for non-supporting code paths obsolete. This CL removes this code. Bug: 1129546 Change-Id: I2df722646cb85b3b4cdf04354941824e72aa15e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413407 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#812813}
-
