- 15 Feb, 2018 40 commits
-
-
https://chromium.googlesource.com/angle/angle.git/+log/f3803d4f74a5..710aa5c7040b $ git log f3803d4f7..710aa5c70 --date=short --no-merges --format='%ad %ae %s' 2018-02-08 lfy GLES1: Mat4 transform library Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: If83ba652e14b38c50582f529e2246d8208e8ef9f Reviewed-on: https://chromium-review.googlesource.com/920750Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536976}
-
Kent Tamura authored
<template>'s extra cloning step [1] needs "clone children flag." So this CL adds it to CloneDataFromElement() and CopyNonAttributePropertiesFromElement(). This CL has no behavior changes. [1] https://html.spec.whatwg.org/multipage/scripting.html#the-template-element:concept-node-clone-ext Bug: 812089 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If87da26b9ef46f18d69129ee5b956159d392c471 Reviewed-on: https://chromium-review.googlesource.com/920942Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#536975}
-
Hikaru Nishida authored
This patch removes declaration of RootEditableElementOf which is not used at all and has no definition to improve readability. TEST: No change in behavior. Change-Id: I0dd1fce23a2cad0939e205bc67ef61ea2540f104 Reviewed-on: https://chromium-review.googlesource.com/920567Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Christos Froussios authored
The "busy exporting" dialog is shown for at least 2 seconds, to avoid flashing when exporting happens fast. We reduce this time to 1 seconds, as suggested by UX. Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibeb1c3736d914ee1d83814dfdc9d3a902fed1796 Reviewed-on: https://chromium-review.googlesource.com/918562Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#536973}
-
Yuichiro Hanada authored
To use the same value as used in Android side. Bug: 807545 Test: Manual on a device. Added unit tests. Change-Id: I04c54e047884a42b019e2d1de69343ce2b89ce60 Reviewed-on: https://chromium-review.googlesource.com/895127 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#536972}
-
Mostyn Bramley-Moore authored
Fixes jumbo builds after https://chromium-review.googlesource.com/c/chromium/src/+/919199 Change-Id: I350604ae19b68859b622568b0d1ac78b223900a5 Reviewed-on: https://chromium-review.googlesource.com/920982Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#536971}
-
Xiaocheng Hu authored
This patch allows dumping LayoutObject to ostream to ease debugging. Change-Id: I4cf438808b503503ad12055dac6610d2c794739c Reviewed-on: https://chromium-review.googlesource.com/920884Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Currently, TranslateHelper caputres page innerText to decide the page language. The text capturing is done in RenderFrame::DidMeaningfulLayout(), in which we normally have the clean layout, which is necessary for computing innerText. However, due to some layout bug [1], we don't always have clean layout at the call site. As fixing the layout bug is hard, this patch changes the text capture algorithm to return a string similar to textContent [2] instead, which doesn't require clean layout. The difference between the new and old text capture is subtle: - textContent may include invisible text nodes, while innerText never does that. However, this patch uses a slightly modified textContent that doesn't include text nodes in STYLE or SCRIPT elements. Other invisible text may still be included. - textContent is a simple concatenation of all text nodes. innerText does some "formatting" by inserting/deleting some whitespace characters, including: - Insertion of '\n' between blocks of text (e.g., between <div>) - Insertion of '\t' between table cells - This patch uses a custom dump algorithm that still collapses consecutive whitespaces; however, the collapsing happens regardless of style [1] crbug.com/803403 and crbug.com/585164. The crash happens in the wild, but we haven't even found a stable repro case yet. Bug: 803403 Change-Id: I7e108d368cbcaccbbb60582323a9e9e041d95269 Reviewed-on: https://chromium-review.googlesource.com/891582Reviewed-by:Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#536969}
-
Peter Kasting authored
The ownership wrappers (Owned, Passed, etc.) move from bind_helpers.h to bind.h. Most other content of bind_helpers.h was really only necessary to implement the code in bind_internals.h, and moves there. BUG=717138 TEST=none TBR=jri Change-Id: Ib6d468e58930529dbee587d331b177b93da2f13a Reviewed-on: https://chromium-review.googlesource.com/915282 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jana Iyengar <jri@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#536968}
-
Yutaka Hirano authored
Requests with keepalive set (including requests initiated by sendBeacon()) are leaky by design; they are kept alive even when the frame is detached. This change makes it explicit in LeakExpectations. Bug: 755625 Change-Id: I9c708e7f492bb2859bad007faa201e79517f03a2 Reviewed-on: https://chromium-review.googlesource.com/920123 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536967}
-
Naina Raisinghani authored
We used to have some inline style map layout tests for a subset of properties. This patch moves them to WPT using the new test harness. Properties added: - white-space - vertical-align - visibility - z-index Bug: 774887 Change-Id: Icce056c4d7f56eed3da05834b1c561fddec53a15 Reviewed-on: https://chromium-review.googlesource.com/918203 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#536966}
-
Gauthier Ambard authored
This CL adds Earl Grey tests for the adaptive toolbar, testing the different buttons displayed in the toolbars. Bug: 804726 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If878383cfe8847bddaab251716680bd1d1f9ac6b Reviewed-on: https://chromium-review.googlesource.com/915347 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536965}
-
Xiaocheng Hu authored
We should implement operator(ostream, Node) with Node::ToString(), but are doing the reverse way. This patch swaps their implementation to make the implementation order correct. Change-Id: Ifeea2608b2e94758de1e82ea39dbe6d6155dcdd1 Reviewed-on: https://chromium-review.googlesource.com/920776 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Ken Rockot authored
Wires up URLLoaderFactory proxying support for content embedders and uses this in Chrome to hook in a proxying URLLoaderFactory implementation provided by the WebRequest API implementation. This provides basic support for *non-blocking* WebRequest event listeners, satisfying a subset of practical use cases. Some new browser_tests pass as a result. Bug: 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9f15d474fc952deddd1c8fe422065b5b63249a1c Reviewed-on: https://chromium-review.googlesource.com/911872 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#536963}
-
Patti authored
When positioning its internal ImageSkia for painting, CENTER-aligned ImageViews currently assume that any insets it may have are symmetrical (i.e. the left and right or top and bottom insets are the same value). This causes the image to be drawn in the incorrect position (e.g. it may cross the boundaries set by the ImageView insets) when the insets are not symmetrical. Fix by accounting for the inset width and height during positioning. Bug: 801583 Change-Id: I65766fbea4c088ca45781a6a69cbae7b52178625 Reviewed-on: https://chromium-review.googlesource.com/917843 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#536962}
-
Gauthier Ambard authored
This CL adds an util to know when the toolbar is split. Bug: 804748 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7d6accb32de848ff2b3e0ff8aef68d7c278aeb9a Reviewed-on: https://chromium-review.googlesource.com/916194Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#536961}
-
Koji Ishii authored
Following bot results are included. 3759 3760 3761 3763 3770 50 lines were removed and 72 lines were deflaked by consecutive results since 3723. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ifce72d0c37323b2fcd22713b5e8e1414493967a7 Reviewed-on: https://chromium-review.googlesource.com/919641 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Christopher Cameron authored
It is necessary to be precise about the ScreenInfo that is to be sent to a RenderWidget, because failing to be consistent will result in violations of surface invarients (size and scale factor of the surface). The RenderWidgetHostView is the source of truth about the surface id and size, but it is not consistently the source of truth about the device scale factor. The device scale factor comes from the ScreenInfo which comes from RenderWidgetHostDelegate->WebContentsImpl->WebContentsView, which may or may not match the RenderWidgetHostView surface info. Remove the GetScreenInfo method from WebContents and WebContentsView, and restore RenderWidgetHostView as the one true source of ScreenInfo. Bug: 805774 Change-Id: Id0d962a49ceb9ad91de783faf3fb1215c1333083 Reviewed-on: https://chromium-review.googlesource.com/917202Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#536959}
-
Kunihiko Sakamoto authored
This introduces LinkLoadParameters, which is a parameter object for LinkLoader::LoadLink() and groups the parameters originated from a <link> element or a Link: header. Pure refactoring, no behavioral changes. Change-Id: I32c86f5b7097f3f0540ae84906614ff8d30199ee Reviewed-on: https://chromium-review.googlesource.com/918224Reviewed-by:
-
wutao authored
Overview mode is one of the complex areas for improving animation speed. This cl implements a new proposal to tone down the animations. Changes: 1. Enter animation: only animate currently visible windows and put the rest of the windows in place. 2. Exit animation: animate all of the Most Recently Used (MRU) windows up to and including the MRU maximized/fullscreen window, with the other windows behind not moving until the maximized/fullscreen window finishes animation. Bug: 801465, 795988 Test: Tested new animations in different modes: normal, tablet, and splitview. Change-Id: Ia7046c670bb484447752b8e5545fa81e981256d2 Reviewed-on: https://chromium-review.googlesource.com/882008 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima (In Tokyo) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#536957}
-
Mohsen Izadi authored
Simplified UI is approved to be the default UI for gesture nav. This CL also cleans up the code to check overscroll history navigation flag value. BUG=787607 TEST=manual Change-Id: I7f08534239ac988560892d3f44d056e5be865826 Reviewed-on: https://chromium-review.googlesource.com/907426Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#536956}
-
Jungshik Shin authored
U+014B (ŋ) => n U+1004 (င) => c U+100c (ဌ) => g U+1042 (၂) => j U+1054 (ၔ) => e Bug: 811117,808316 Test: components_unittests -gtest_filter=*IDN* Change-Id: I29f73c48d665bd9070050bd7f0080563635b9c63 Reviewed-on: https://chromium-review.googlesource.com/919423Reviewed-by:
-
Pavel Feldman authored
Change-Id: I4db6b3d75d349071025bb481982370d7e139de32 Reviewed-on: https://chromium-review.googlesource.com/920541 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#536954}
-
Xianzhu Wang authored
Previously all FragmentClips under a fragmented subtree were at the same level below the parent clip state of the top-level fragmented object. A FragmentClip was used in a chunk property state only if the chunk had no other clips under the parent clip state of the top- level fragmented object, causing FragmentClip was not applied in some cases. Now let Fragments be in clip tree hierarchy. When we create a new tree builder context for a fragment, we need to try to find the parent context from which to inherit the paint properties: 1. For a new LayoutFlowThread: a) if it's the top level, use the first (and only) parent context; b) otherwise, convert logical_top_in_flow_thread in itself to logical top in the parent flow thread which is used to match the parent context. 2. For an object which has column-span:all or is out-of-flow positioned, skip matching against parent contexts because the fragment is definitely (column-span:all) or probably (out-of-flow) not the child of any fragment of the parent fragments. 3. Otherwise, match the parent context using logical_top_in_flow_thread. If the above algorithm matches a parent context, make a copy the parent context as the new context, and overwrite fragment_clip and logical_top_in_flow_thread. Otherwise, we'll use the first parent fragment as if it were the parent fragment, but traverse up the Container tree (which includes all containing flow threads) to find the correct clip state. Bug: 803649 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I42e84263b709e184dde92b972c74da96becd8a23 Reviewed-on: https://chromium-review.googlesource.com/912551 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#536953}
-
wutao authored
This cl adds a horizontal line class to separate item views in Keyboard Shortcut Viewer (KSV). Bug: 768932 Test: Manually test that the separator line is correctly created. Change-Id: Ia09d52ad120bc4d2ba9d36eef4fce27225ecfedb Reviewed-on: https://chromium-review.googlesource.com/911980Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536952}
-
Takayoshi Kochi authored
This is a reland of 391d909b. This was once reverted due to potential cause for Mac bot's flakiness: crbug.com/805383 Original change's description: > Remove dead code after multiple shadow removal [4/5] > > Remove ShadowRoot::{Younger,Older}ShadowRoot > > Bug: 795221 > Change-Id: Ib4754de2184d08db9bb5fc35379f27dea5ef2997 > Reviewed-on: https://chromium-review.googlesource.com/831810 > Commit-Queue: Takayoshi Kochi <kochi@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531478} TBR=hayato@chromium.org, futhark@chromium.org Bug: 795221 Change-Id: I61a8c2d7b39398fc676515f67a7c0d0a9536da22 Reviewed-on: https://chromium-review.googlesource.com/920941Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536951}
-
Wenzhao Zang authored
The old wallpaper picker must generate and save a thumbnail for each custom wallpaper, so that they can persist even after the original image file is deleted. This is not needed for the new picker: the thumbnails under 'My Photos' section are real-time representation of the files under Downloads. We do not want to cache or save them since the files may change all the time. Therefore, to simplify the logic, we only need to read the image data, and then use CSS to resize the image to display as the thumbnail (the same with backdrop wallpapers for consistency). The new wallpaper picker doesn't display the thumbnail of the history custom wallpaper like the old picker. So basically the 'generate and save thumbnail' code path can be deprecated in the future. Bug: 809793 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibf00bec636a52081c77cd7cf1b94e934fd97b11c Reviewed-on: https://chromium-review.googlesource.com/912282Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#536950}
-
wutao authored
This cl adds a '+' icon between the bubble views of modifiers and key in the Keyboard Shortcut Viewer (KSV). Changes: 1. ui::VKEY_UNKNOWN is used as a separator indicator and will be shown as a highlighted "+" icon. 2. Insert the ui::VKEY_UNKNOWN into |shortcut_key_codes| as the separator. 3. Replace the separator with '+' icon when creating KeyboardShortcutItemView. Bug: 768932 Test: Manually test that the separator icon is correctly created. Change-Id: I2d01beb3f4c4b69a18cbb4820afc024f92679dc3 Reviewed-on: https://chromium-review.googlesource.com/912135Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/ea86bb74fc81..ae8a90a1d4db $ git log ea86bb74f..ae8a90a1d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id3ebac3930b5b1ee90734f2d5b973bfbd8febe24 Reviewed-on: https://chromium-review.googlesource.com/920744Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536948}
-
Takeshi Yoshino authored
Change-Id: I6e59596d70954af52806f1cb5d5ea4867a53d420 Reviewed-on: https://chromium-review.googlesource.com/920562Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#536947}
-
Randy Smith authored
Bug: None Change-Id: I4098f2da62665acb63d868f3dc4a4001f44a9ae9 Reviewed-on: https://chromium-review.googlesource.com/920681Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#536946}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/62d82cfd..12457874 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If3c89bc9d82728c4dc662e0784ac5b11c8cf3457 Reviewed-on: https://chromium-review.googlesource.com/920703Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#536945}
-
Victor Costan authored
This CL aligns CookieManager's interface for listening to cookie changes (observer pattern) with the proposed addition to RestrictedCookieManager, which will be used by the Async Cookies API. Bug: 729800 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0464b0d1d0388279e549d19c5dbeea2d0342cc60 Reviewed-on: https://chromium-review.googlesource.com/913151Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=anantha@chromium.org Change-Id: I6d5289a138617312e09d7eded0d95c7266727045 Reviewed-on: https://chromium-review.googlesource.com/920827Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#536943}
-
sczs authored
-Creates ChromeTableViewController with basic unittests. -Implements basic UITableViewDataSource methods. Bug: 805136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idbc59f0c0b71c01b9c8513e8bd7907b0f9713971 Reviewed-on: https://chromium-review.googlesource.com/915261 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536942}
-
Jaebaek Seo authored
This is a reland of 4c50e3e1. It is reverted as shown in crrev.com/c/920222, because of a compile error. blink::WebInputEvent::kTimeStampForTesting is moved to blink::WebInputEvent::GetStaticTimeStampForTests(). This CL fixes the compile error. TEST=content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF on NEXUS 5X. Original change's description: > Adjust location and size of TapDisambiguator > > As shown in crbug.com/737777#c72, the location and size of Android tab > disambiguator is not correct when --use-zoom-for-dsf is enabled. It is because > RenderViewImpl::DidTapMultipleTargets() assumes |touch_rect| is in DIPs while it > is in physical pixels when --use-zoom-for-dsf is enabled. This CL solves this > problem. > > TEST=Android Chrome with production code on NEXUS 5X, > content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF > on NEXUS 5X, NEXUS 4, NEXUS 9 (w/ and w/o this change). > > Bug: 737777 > Change-Id: I64ca0b9b76fcfc3798036a80c9213973de8f3f77 > Reviewed-on: https://chromium-review.googlesource.com/898824 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536868} Bug: 737777 Change-Id: Id21123049c71d49460f1f428f6baafb9807084a4 Reviewed-on: https://chromium-review.googlesource.com/920801Reviewed-by:
-
Ashley Enstad authored
Comment added to benchmark sharding map file causes a crash while loading the benchmark sharding map. This change allows the code to ignore the comment at the start of the map and continue running the script. Bug: 758630 Change-Id: Ia0617a53fb6f5b43c9f22288ca916218e8472d37 Reviewed-on: https://chromium-review.googlesource.com/916891Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#536940}
-
Aaron Leventhal authored
Accessibility checks require all views, even in content shell, to have a name. Bug: None Change-Id: I6a4d4c7ff826cbd48fc0b91f7173dd2e93862412 Reviewed-on: https://chromium-review.googlesource.com/919305Reviewed-by:
-
Christopher Thompson authored
This fixes an a11y regression in the page info button label under the experimental conditions of the HTTPS Indicator UI Study (https://crbug.com/803501), where only the green lock icon would be shown but no explanatory label would be included for screen readers. This modifies the accessibility label under these conditions for both views and cocoa UI to make sure that secure connections are always labeled as such. On Windows/Linux/ChromeOS (Views), this appends a new String Attribute to the description in the AXNodeData. On Mac (Cocoa), this prepends the "Secure" text to the beginning of the Accessibility Label. Bug: 812034 Change-Id: I1fe2e6d1afa7110d445154da682846fd82738939 Reviewed-on: https://chromium-review.googlesource.com/917282 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
-
Peter Collingbourne authored
Before duplicating this bot's configuration to create a new bot, let's see how many of these exceptions are legitimate. Bug: 810907 Change-Id: I87d0607394af6ce9dbdd1932a240bcea7cbc9e1b Reviewed-on: https://chromium-review.googlesource.com/920321Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#536937}
-
