GitLab

Sets the origin for a value when the value is dereferenced. Previously if you did
  foo = 6
  deps = [ foo ]
You would get the message:
  ERROR at //BUILD.gn:15:9: This is not a string.
    foo = 6
          ^
Which in this case is pretty confusing since that's obviously the case, and you really want to know where it was dereferenced.

With this patch the message is:
  ERROR at //BUILD.gn:21:5: This is not a string.
      foo,
      ^--
  Instead I see a integer = 6
which is more actionable.

R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/439513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288131 0039d316-1c4b-4281-b951-d872f2087c98

Using bindService() with implicit intents is unsafe, and will be
prohibited in L once the targetSdkVersion gets bumped.

Also check that the intent resolves before using it, to avoid
crashing the app.

BUG=399418
TEST=Pressing the FEEDBACK button shows Feedback screen.

Review URL: https://codereview.chromium.org/451543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288130 0039d316-1c4b-4281-b951-d872f2087c98

operator delete apparently isn't throw() with msvs (at least in
_HAS_EXCEPTIONS=0 builds like ours). This fixes the two remaining
warnings in this file:

..\..\base\allocator/generic_allocators.cc(31,6) :  warning(clang): function previously declared with an implicit exception specification redeclared with an explicit exception specification [-Wimplicit-exception-spec-mismatch]
void operator delete(void* p) throw() {
     ^
E:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\new(52,16) :  note(clang): previous declaration is here
void __CRTDECL operator delete(void *) _THROW0();
               ^
In file included from ..\..\base\allocator\allocator_shim.cc:334:
..\..\base\allocator/generic_allocators.cc(39,6) :  warning(clang): function previously declared with an implicit exception specification redeclared with an explicit exception specification [-Wimplicit-exception-spec-mismatch]
void operator delete[](void* p) throw() {
     ^
E:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\crtdbg.h(1054,16) :  note(clang): previous declaration is here
void __CRTDECL operator delete[](void *);
               ^
2 warnings generated.

There also wasn't a std::nothrow overload for delete, so add that for
completeness while here. (For C++14, we might have to add sized
overloads too at some point.)

BUG=82385
NOTRY=true

Review URL: https://codereview.chromium.org/447513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288129 0039d316-1c4b-4281-b951-d872f2087c98

tasks on each SequencedTaskRunner.

By using a nestable task the RundownTaskCounter was guaranteed that the task would START after current
tasks had also STARTED but not necessarily COMPLETED..!

BUG=386126

Review URL: https://codereview.chromium.org/440893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400861

Review URL: https://codereview.chromium.org/430703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288127 0039d316-1c4b-4281-b951-d872f2087c98

crbug/397634 describes crashes that occur occasionally in the crazy linker
when loading the browser shared library.  These crashes have been observed
only in the M37 beta.

The current theory is that part of the address range that the crazy linker
must map with MAP_FIXED for shared RELRO to work may, on occasions,
already be mapped.  If it is mapped then the crazy linker's MAP_FIXED
to reserve space will overwrite it, with unpleasant results.  The crazy
linker tries to use a range of addresses that is 'safe' from use by the
system, but it may not be watertight.

This fix should work round the problem by removing the MAP_FIXED from
the mmap that reserves space, so that if any part of the range is already
occupied then the mmap returns a valid mapping, just not at the requested
address.  If that happens the fixed address load fails, and the
ChildProcessService retries with a non-fixed address.

This is mildly suboptimal since it loses the gain from shared RELRO, but
the library will still load and run.  Occurrences of this in the M37
beta suggest that it will be a relatively rare event.

So far the bug reported by the beta has not shown up in testing, but
something a little similar can be simulated by deliberately moving the
crazy linker's wanted address to around the heap.  With this perturbation
in place and without this fix, the browser crashes.  When this fix is
added the browser/renderer library loads and runs, and correctly reports
back-out and retry in logcat.

BUG=397634

Review URL: https://codereview.chromium.org/443393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288126 0039d316-1c4b-4281-b951-d872f2087c98

This functions is not called anymore in Blink and thus it has no effect
here in Chromium. So no need to keep overriding it.

This also deletes web_solid_color_layer_impl.* because it becomes unused with this change.

BUG=None
TEST=None
R=enne@chromium.org

Review URL: https://codereview.chromium.org/431273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288125 0039d316-1c4b-4281-b951-d872f2087c98

I can't repro locally. I tried with a release/debug build and with
full/light.

BUG=400495
TEST=none
R=zhaoqin@chromium.org
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/447953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288124 0039d316-1c4b-4281-b951-d872f2087c98

When signing in from the new avatar bubble, since the inline template has no "choose what to sync" link, thus Chrome shows an inline confirmation in the avatar bubble upon signin completes and blocks sync until the bubble is closed.

However, when some modal warnings show up before signin completes, they steal the focus thus the avatar bubble wont be able to show confirmation for sync settings and sync will be blocked infinitely.

A temporary workaround is to just start sync immediately if a modal warning is shown, since in all cases the dialog mentions that user data will be synced.

I will add a sync settings link to all modal dialogs later so that user could configure sync settings before sync starts.

BUG=435423005

Review URL: https://codereview.chromium.org/447883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288122 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394434

Review URL: https://codereview.chromium.org/440293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288118 0039d316-1c4b-4281-b951-d872f2087c98

The histograms don't seem to be used anymore (do not show up in UMA). The
hang-detector and about:profiler produce relevant useful data for detecting jank.

BUG=none

Review URL: https://codereview.chromium.org/435603011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288117 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288116 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179700:179716&mode=html
TBR=jbroman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/450723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288115 0039d316-1c4b-4281-b951-d872f2087c98

record & replay to work with AGSA

BUG=396157

Review URL: https://codereview.chromium.org/423213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/449043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288112 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/441883003/ and an additional
downstream patch

BUG=400694

Review URL: https://codereview.chromium.org/440123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288111 0039d316-1c4b-4281-b951-d872f2087c98

When finding a dependency chain, the header check will now prefer chains which
forward direct-dependent configs if the target which provides a header has
one. Previously an error would be produced because the chain which was found
did not forward configs, even though another chain did.

A breadth-first search is used instead of a depth-first search because short
chains are more likely to be intended by the author, and make for both less
work and clearer diagnostic messages.

This reduces the size of 'gn check' output on the chromium tree and the time
to execute. (Output directed to 'wc -l' and /dev/null, respectively.)

  Before: 104685 lines, 542.36s user, 35.573s total
  After: 36977 lines, 7.10s user, 1.526s total

Manual inspection reveals that the line reduction appears to be from the
removal of spurious errors when IsDependencyOf selected an indirect chain
which does not forward direct-dependent configs, even though a direct
dependency existed. (About 7 cases were examined manually; sheer volume makes
full manual verification infeasible.)

BUG=391505
TEST=HeaderCheckerTest, manual

Review URL: https://codereview.chromium.org/424133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288110 0039d316-1c4b-4281-b951-d872f2087c98

Additionally, promotes the API to dev channel since it is appropriately
restricted.

BUG=400436

Review URL: https://codereview.chromium.org/439393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288109 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288107 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288106 0039d316-1c4b-4281-b951-d872f2087c98

> Set the web content's initial size only if the tab isn't selected in session restore.
> 
> BUG=378924
> 
> Review URL: https://codereview.chromium.org/392293002

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/451703006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288100 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky

Review URL: https://codereview.chromium.org/451763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288099 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398337
NOTRY=true
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/449103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288098 0039d316-1c4b-4281-b951-d872f2087c98

It uses the //net stack, ergo it needs to have a MessageLoop

BUG=395356

Review URL: https://codereview.chromium.org/444333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288097 0039d316-1c4b-4281-b951-d872f2087c98

This makes SkPicture::clone() a cheap ref, meaning impl-side painting will render
tiles concurrently from the same source SkPicture rather than from clones.

After testing for a few months in Skia, we believe SkPicture is thread safe enough
to try this out on the Chrome bots.  Please revert this at the slightest sign of
crash, flaky drawing, etc.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel

BUG=

Review URL: https://codereview.chromium.org/445373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288096 0039d316-1c4b-4281-b951-d872f2087c98

Introduce a SystemUIResourceManager class for loading and providing access to
shared UIResourceId's.  Wire this class to the existing OverscrollGlow effect,
using the shared id's with a UIResourceLayer for both glow and edge layers.

This patch is a subset of powei@'s original SystemUIResource patch found at
https://codereview.chromium.org/377013002/.

BUG=326326

Review URL: https://codereview.chromium.org/422013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398888

Review URL: https://codereview.chromium.org/448443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288094 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky

Review URL: https://codereview.chromium.org/445373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288093 0039d316-1c4b-4281-b951-d872f2087c98

> Reland r285211: "Debugging RawChannelWin: replace DCHECK with CHECK and record write stats."
> 
> But clang-formatted (and after the changed files were clang-formatted).
> This should be reverted on the same schedule as the original change (no
> later than August 1, 2014).
> 
> > Debugging RawChannelWin: replace DCHECK with CHECK and record write stats.
> >
> > This is a temp change for debugging purpose. It should be reverted once
> > we fix the issue or find out the change doesn't reveal anything. (No later than Aug 1, 2014.)
> >
> > BUG=385795
> > TEST=None
> 
> BUG=385795
> TBR=yzshen@chromium.org
> 
> Review URL: https://codereview.chromium.org/430473004

TBR=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/449063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288092 0039d316-1c4b-4281-b951-d872f2087c98

See VLOG(1) and VLOG(2) logging:
TEST=adb shell setprop log.tag.ChromiumNetwork VERBOSE

See VLOG(1) logging:
TEST=adb shell setprop log.tag.ChromiumNetwork DEBUG

See NO (only FATAL) logging:
TEST=adb shell setprop log.tag.ChromiumNetwork NONE

BUG=400956

Review URL: https://codereview.chromium.org/447653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288088 0039d316-1c4b-4281-b951-d872f2087c98

There is only one user of this class. The new implementation is in
base/files/scoped_file.h

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/444083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288087 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/448013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288086 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky

Review URL: https://codereview.chromium.org/448853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288085 0039d316-1c4b-4281-b951-d872f2087c98

These were only used by one test file, so I moved the implementation there. I
considered updating the test, but the way the test uses wstrings seems
reasonable.

R=rvargas@chromium.org, rvargas

Review URL: https://codereview.chromium.org/448763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288084 0039d316-1c4b-4281-b951-d872f2087c98

This CL includes following changes.
- Use system default header, rather than customized Maximize/Minimize/Close buttons.
- Current location is displayed on the left side of toolbar.
- Only the selected file's information is displayed on the preview panel.
- Change-view button is moved from gear menu to the right side of toolbar.
- Search button is placed on toolbar as a button. It expands on click.

BUG=397222,308445
TEST=run browser_tests, manually tested

Review URL: https://codereview.chromium.org/443333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288082 0039d316-1c4b-4281-b951-d872f2087c98

Stop honoring the Finch enable/disable groups, but still honor explicit flips
of the flags in chrome://flags.

BUG=383169

Review URL: https://codereview.chromium.org/442913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288081 0039d316-1c4b-4281-b951-d872f2087c98

There is a "FIXME: Remove once calls on the Chromium-side have been
removed" for volume() in WebMediaPlayerClient.h. preload() is
similarly strange layering-wise, so get rid of that as well.

Simply store the values when they cannot immediately be forwarded to
the internal object.

In the case of WebMediaPlayerImpl::setVolume(), the value can always
be used immediately, so the setVolume() in DoLoad() appears to simply
have been unnecessary.

BUG=401415

Review URL: https://codereview.chromium.org/443393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401501

Review URL: https://codereview.chromium.org/448153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288079 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/449053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288078 0039d316-1c4b-4281-b951-d872f2087c98

This should prevent problems such as described in

  [chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_*
                 compile errors in blink_platform_impl.cc

Depends on https://codereview.chromium.org/431883002

BUG=400860
TBR=brettw

Review URL: https://codereview.chromium.org/430083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288077 0039d316-1c4b-4281-b951-d872f2087c98