- 02 Aug, 2018 40 commits
-
-
Jérôme Lebel authored
The account cell and Google services cell are moved into the account section. The changes is visible when the user is signed out, the Google services cell doesn't share anymore the same section than the sign-in promo. When signed out: Before: https://drive.google.com/open?id=15Y-rwBi292Ii8mNm0x6E0mRWl1sQN-Gd After: https://drive.google.com/open?id=17WgNeKqKzZPe0PcGhmY2832L44eoRekD Mock: https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5b2bed3b#slide=id.g3ae6bac383_31_11 When signed-in: Before: https://drive.google.com/open?id=18qP0MZSMwlJZkXBTUq9cvt6q7tbaslaR After: https://drive.google.com/open?id=16yaGI24UmZ3ufb3lrnfbxW91C7SEre7L Mock: https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5b2bed3b#slide=id.g3ae6bac383_31_43 Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I163053b2355947df67c2df7d8305a4e07ecb39b8 Reviewed-on: https://chromium-review.googlesource.com/1158506Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580132}
-
Boris Sazonov authored
This CL implements ConsentBumpFragment - a SigninFragmentBase subclass that provides an easy option to enable all features gated by unified consent. This CL also modifies SigninActivity to use it as a container for this fragment. Bug: 869426 Change-Id: Ibbe64a674aad4ac2a05afca83424449f52f9a683 Reviewed-on: https://chromium-review.googlesource.com/1159068Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#580131}
-
Antonio Gomes authored
This CL allows SimpleURLLoader's to successfully load file:// URLs, ie when using FileURLLoaderFactory. Prior to this CL, even on the file specified in the file:// URL is written successfully, the URLLoaderCompletionStatus instance is passed to the URLLoaderClient from FileURLLoader::OnFileWritten, had only with the |error_code| set. SimpleURLLoader checks other URLLoaderCompletionStatus class members, (eg |decoded_body_length|) in order to consider the load actually successful. BUG=773295,844928 Change-Id: I1040775fad2af7f0eb88f81e48bb355d48e5fc31 Reviewed-on: https://chromium-review.googlesource.com/1159042Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#580130}
-
Matt Menke authored
The tests were waiting for a request to receive headers, but then assuming that the request had in fact completed receiving the entire response, including the body. Bug: 869551 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2771bb0f786dd18e74423941364d51607fb8b7f8 Reviewed-on: https://chromium-review.googlesource.com/1159587Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#580129}
-
Matt Menke authored
These tests were set cookie settings on a CookieManager interface, and then sending out a network request on a URLLoaderFactory interface. Since Mojo events aren't ordered, there's no guarantee that the request will be sent after the new settings are set. This CL fixes that issue by flushing the CookieManager interface after updating the cookie settings. Bug: None Change-Id: I1d355a81f935f40a8e1270ca49234bc6b5eb4a86 Reviewed-on: https://chromium-review.googlesource.com/1159192Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Matt Menke authored
The test wasn't waiting for the secondary NetworkContext to be created, so it could end up that the secondary NetworkContext was created only after the primary one was destroyed. Bug: 869551 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iaefbb98553175cf4e3784017adafe227888c588b Reviewed-on: https://chromium-review.googlesource.com/1159588Reviewed-by:
-
Jinho Bang authored
This patch only includs an implementation of PaymentResponse.retry() in renderer and mojo side. We should implement UI in browser side in follow up CLs. Once this patch is applied, most test cases will be passed except when the UI is required. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wayZGnuBkrI Test: //components/payments/core/payments_validators_unittest.cc //third_party/blink/renderer/modules/payments/payments_validators_test.cc https://github.com/web-platform-tests/wpt/pull/11101 Bug: 861704 Change-Id: I8a644a32ed589a2292ad021f5699105482ad9dd1 Reviewed-on: https://chromium-review.googlesource.com/1142045Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#580126}
-
Javier Ernesto Flores Robles authored
To organize a little bit more, this CL starts moving relevant code to the ui folder. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I357b8d453fb6e284d3a3bdf706511e6ec7234dc2 Reviewed-on: https://chromium-review.googlesource.com/1149000Reviewed-by:
-
Ramin Halavati authored
Preferences related to SignIn are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I03fbc9c62227ca1cbb3b58b9ee2f9ad90df9b586 Reviewed-on: https://chromium-review.googlesource.com/1159367Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#580124}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c17b12c1. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22255 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I8ca5fd48a3fbe71c8dafc3dcd7735e0ca83df5c1 Reviewed-on: https://chromium-review.googlesource.com/1159994 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580123}
-
Dominik Röttsches authored
Add a Mojo service to RenderProcessHost for renderers being able to connect to the FontUniqueNameLookup implementation on Android when the feature is enabled. Preparation for Blink performing font-face { src: local() } lookups correctly. I have not found a good way to test this service on its own. Instead, I aim to test font lookup through a browsertest once the font lookup is hooked up in Blink. This would test the chain end to end. The FontUniqueNameLookup implementation itself is tested extensively with unit tests. Bug: 868366 Change-Id: Ie4f4cca88d6e98efdecfee04221cdb11d5b3c302 Reviewed-on: https://chromium-review.googlesource.com/1152970Reviewed-by:Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#580122}
-
Elodie Banel authored
This reverts commit 1e910c7f. Reason for revert: Breaks ios_internal_chrome_external_url_egtests (see example failure here https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fipad10-simulator%2F13834%2F%2B%2Frecipes%2Fsteps%2Fios_internal_chrome_external_url_egtests__iPad_Retina_iOS_10.2__on_Mac%2F0%2Flogs%2FExternalURLGWSTestCase__x2f_testGWSHistoryAutosuggest%2F0 ) Original change's description: > [iOS] Accessibility adjustments > > This CL adds a delay for the voice over announcement of the InProduct > Help tips. This delay is added to prevent the announcement to be > cancelled by the element being focused, when the tab is presented. > It also adds an accessibility label to the empty space where the omnibox > should be if the toolbar was visible. > > Bug: 866936 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ia75dd56772203e39b8d0bf1e94bef9cfacd87fdd > Reviewed-on: https://chromium-review.googlesource.com/1158236 > Commit-Queue: edchin <edchin@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579886} TBR=edchin@chromium.org,gambard@chromium.org Change-Id: I172a7e67b8ef5d4b4a2008f0f95ef99d7c0152e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866936 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1160281Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#580121}
-
Colin Blundell authored
There are three sections of AccountTracker unittests: - Primary account only - Secondary accounts - Interaction between primary and secondary accounts In each of these sections, non-ChromeOS tests were scattered throughout. This CL consolidates the non-ChromeOS tests so that there is one set of non-ChromeOS tests at the end of each section. Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1148200. Change-Id: I5e89a78a1d493ecd25b75d495969dda68f2b136e Reviewed-on: https://chromium-review.googlesource.com/1158830 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580120}
-
Gauthier Ambard authored
This CL creates the personalization view displayed when the user taps for more options in the ConsentBump. For now, this CL is only adding the ScrollView, images and labels. The settings will be added later. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icce065f189b2f0047a5caba7b4630255693d3589 Reviewed-on: https://chromium-review.googlesource.com/1158575 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580119}
-
Ramin Halavati authored
Preferences related to Supervised Users are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I74259a24fa1747298f80a627247f5777fad163f4 Reviewed-on: https://chromium-review.googlesource.com/1159365Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#580118}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e43024a5bab7..64cc576b1fa7 git log e43024a5bab7..64cc576b1fa7 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 stephana@google.com [infra] Make GS buckets for images and hash file URL configurable Created with: gclient setdep -r src/third_party/skia@64cc576b1fa7 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I7c699afd0360be8226d0155d8dd7c2217b1b37d2 Reviewed-on: https://chromium-review.googlesource.com/1159784Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580117}
-
Alexander Hendrich authored
This CL implements the UI changes for the new AllowOnlyPolicyNetworksToConnectIfAvailable policy in chrome settings. Bug: 848719 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I41c9b935f291e2cdfb95c6ef52b216b2a268af43 Reviewed-on: https://chromium-review.googlesource.com/1124448 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580116}
-
Christos Froussios authored
This reverts commit 323e8611. Reason for revert: Disabled non-offending test Original change's description: > Disable CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget on linux-chromeos-rel > > It is flaking. > > TBR=sky@chromium.org > > Bug: 869830 > Change-Id: Id455349e683f1adda690457faffc40d12c977d38 > Reviewed-on: https://chromium-review.googlesource.com/1158584 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579789} TBR=cfroussios@chromium.org Change-Id: I1904d3f8febf2d9c0fcac0032e2622df2bdb009d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869830 Reviewed-on: https://chromium-review.googlesource.com/1160222Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#580115}
-
Oscar Johansson authored
Without jumbo, omnibox takes around 3 CPU minutes to build which is around 0.5 % of the total build time. This commit enables jumbo support in components/omnibox. Bug: 869381 Change-Id: Ifb51dab5a6b034a384c6bf07ee2f5b8c17b952a7 Reviewed-on: https://chromium-review.googlesource.com/1156593Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#580114}
-
Martin Robinson authored
This will make it easier to catch new ones. Change-Id: I468c496b547d6042b6ca45b888a15ca4b9917dd3 Reviewed-on: https://chromium-review.googlesource.com/1157004 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580113}
-
stkhapugin@chromium.org authored
Removes the omnibox_popup_row.h header left for downstream compilation. Bug: 814732 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic7eb3c6f6d2b72496998ce58d7a81fc63614be69 Reviewed-on: https://chromium-review.googlesource.com/1158576Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580112}
-
Markus Heintz authored
TBR=alemate@chromium.org Bug: 865902 Change-Id: I4ea0613be8db3bb2120d1be9c5137ca81ecd54f4 Reviewed-on: https://chromium-review.googlesource.com/1145318 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580111}
-
yoshiki iguchi authored
- message_center::UiController -> ash::MessageCenterUiCiontroller - message_center::UiDelegate -> ash::MessageCenterUiDelegate These CL moves these classes into ash/, since they are used only from ash. Bug: 869278 Test: trybot passes Change-Id: I15390ba972f5c522c5a95bad8c2e1b6281ee8d24 Reviewed-on: https://chromium-review.googlesource.com/1152756Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#580110}
-
yoshiki iguchi authored
- NotificationViewMDTest.TestClick - NotificationViewMDTest.TestClickExpanded I found the tests were missing during working around here. Bug: 869278 Test: trybots pass Change-Id: Ieb428fa8884755ed63ea2fe6d1c346629ab35ed8 Reviewed-on: https://chromium-review.googlesource.com/1158448Reviewed-by:
-
Ross Mcilroy authored
BUG=v8:7786 Change-Id: I2325c003da6db08a72eb442ea4f9641ca62d78ad Reviewed-on: https://chromium-review.googlesource.com/1159071Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580108}
-
Olli Etuaho authored
The ANGLE_multiview extension was erroneously enabled by default if available in the GPU passthrough command buffer. This was visible as the GL_OVR_multiview preprocessor macro being defined in shaders even if the WEBGL_multiview extension was not enabled. This is now fixed so that the extension is only enabled when requested. BUG=864524 TEST=WebGL conformance tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie6e684fb91af4bb50aac7027ee9f85cd4420fe37 Reviewed-on: https://chromium-review.googlesource.com/1158569Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Cr-Commit-Position: refs/heads/master@{#580107}
-
Christos Froussios authored
This reverts commit 20f64257. Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg) Original change's description: > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors > > This change implements obtainining Remote Gatt Descriptors for WinRT by > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore, > appropriate tests are enabled. > > Bug: 821766 > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676 > Reviewed-on: https://chromium-review.googlesource.com/1156392 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579830} TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766, 870208 Reviewed-on: https://chromium-review.googlesource.com/1159943Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I255165c5a91fc2b49962b5cd940d68c78a77502e Reviewed-on: https://chromium-review.googlesource.com/1159997Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580105}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3a995feda7bb..c988ddf7b193 git log 3a995feda7bb..c988ddf7b193 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 nednguyen@google.com Update chrome reference builds Created with: gclient setdep -r src/third_party/catapult@c988ddf7b193 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:868675 TBR=sullivan@chromium.org Change-Id: I575647f62ecf7212efab0ce3e9ab910405def5ea Reviewed-on: https://chromium-review.googlesource.com/1159882Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580104}
-
Tetsui Ohkubo authored
We need a way to let users know that notifications are hidden in lock screen. Similar message was preaviously shown on NotificationTray in lock screen. Screenshot: http://screen/BNWeniKkuR5 TEST=manual BUG=864964 Change-Id: If7fa3bf1e61b1bce77b355c907a4dfef254a8601 Reviewed-on: https://chromium-review.googlesource.com/1156203 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#580103}
-
Matt Falkenhagen authored
ServiceWorkerContextCore owns provider hosts, and stores them in a map from <process id, provider id> to host. But precreated hosts are created before the process id is known. So the hosts are first stored in <-1, provider id> before being moved to <process id, provider id>. That complicates adding a Mojo error connection handler to the host, which tries to call RemoveProviderHost(process_id, provider_id). Fortunately, precreated hosts have a unique provider id anyway, so the process id isn't needed. This CL makes it so precreated hosts always live in <-1, provider id>, so a Mojo error connection handler can be added to them immediately. Note that we can't easily make renderer-assigned provider ids unique since they are generated by each renderer process on its own. But eventually the renderer-created providers will go away anyway, since they aren't used since PlzNavigate except for non-S13nServiceWorker shared worker. Some more design at: https://docs.google.com/document/d/1FDaAwQ9O1Z2am1XEMPiEsVzWXgqCkT1ZqpVlcGmBve4/edit This will allow fixing the linked bug, by the next CL: https://chromium-review.googlesource.com/c/chromium/src/+/1159544 Bug: 854993 Change-Id: I3f638496e0e7436e484c956531709ff6931418ff Reviewed-on: https://chromium-review.googlesource.com/1159542 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580102}
-
Colin Blundell authored
This CL completes the conversion of GCM's production code to talk to IdentityManager rather than legacy signin classes by converting AccountTracker. The GCMAccountTracker unittest remains to be fully converted away from the legacy signin classes; this will be done in a followup CL. TBR=rohitrao@chromium.org, rockot@chromium.org Bug: 809923 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1513b33850f52b532d83ac389a78464b68ed1a45 Reviewed-on: https://chromium-review.googlesource.com/1148200Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Robert Ogden authored
Currently not used anywhere, but will be in the near future as more code for this feature is added. Bug: 870045 Change-Id: I9d8beafcfd99098889fa1e200379ebd59aa90450 Reviewed-on: https://chromium-review.googlesource.com/1157546Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580100}
-
Matt Falkenhagen authored
Including: - std::move() when appropriate. - Change diagnostic CHECKs to DCHECKs. - |self| doesn't seem like Chromium style. - Don't repeat base class documentation in overrides. Bug: 866353 Change-Id: I9d7d3653cd801770251936bcae330bf1610d0fdb Reviewed-on: https://chromium-review.googlesource.com/1159933Reviewed-by:
-
Kinuko Yasuda authored
TBR=chaopeng Bug: 841567 Change-Id: I824e726b2399870b6ba821b2c79adbd3673b7b31 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1160063Reviewed-by:
-
Marc Treib authored
This removes some unnecessary "virtual"s, and adds "Virtual for testing" comments to the remaining ones. (Many of those are questionable, but that's out of scope for this CL.) Bug: none Change-Id: I6b742769ef256416fd737f2c16b0379c359bdd6c Reviewed-on: https://chromium-review.googlesource.com/1148056Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580097}
-
mrefaat authored
AppLauncherAbuseDetector & AppLaunchingState classes were on ios/chrome/browser/web. But they are not related to web. Moving these classes put togather all app launching logic on the same place, and also breaks app_launcher target dependency on ios/chrome/browser/web:web_internal which can be a reason for cyclic dependency for targets that depend on AppLauncherTabHelper. Bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I743c9add64b939430c287b6fddd9cd77c082d697 Reviewed-on: https://chromium-review.googlesource.com/1158125 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#580096}
-
Findit authored
This reverts commit 0ea2267a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 580029 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzBlYTIyNjdhN2NlZmE0OWZmZDNmMzA4MGRjZWEyNDFkOWJiY2RmZDcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/9359 Sample Failed Step: not_site_per_process_browser_tests Original change's description: > Fix crash when right clicking link in CastUI > > This CL adds a null check to RenderViewContextMenu::AppendLinkItems() > ensuring we have an associated Browser before attempting to use it. > > Bug: 869280 > Change-Id: Ib1ffecd9dfbe27fb4fc6f6c77762c6337c36d4d4 > Reviewed-on: https://chromium-review.googlesource.com/1158110 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580029} Change-Id: Ie3a0067047c42fc8682ca8663eede8f1195afaed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869280 Reviewed-on: https://chromium-review.googlesource.com/1159804 Cr-Commit-Position: refs/heads/master@{#580095}
-
Joel Hockey authored
Perform sshfs mount to termina/penguin immediately when container starts. Mounting code has moved from the chrome.fileManagerPrivate extension functions into CrostiniManager. This change will make FilesApp more responsive to users who are likely to use terminal or some other crostini app before using FilesApp. Bug: 846917 Change-Id: I9fc246e45e54390e7a75f15a5571a24218cf2d5c Reviewed-on: https://chromium-review.googlesource.com/1158317Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#580094}
-
Sergey Ulanov authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic382e5fc990c6cd94bb43aca18104901ee0595eb Reviewed-on: https://chromium-review.googlesource.com/1158722Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
