GitLab

This CL adds WPT tests for:

- Cross-origin importScripts() from classic service workers
- Cross-origin static imports from module workers
- Redirecting static imports from module workers
    - Failing on service workers on Chromium, while
      redirecting importScripts() also fails on Chromium
      due to https://crbug.com/889798.

Bug: 1136767, 889798
Change-Id: I318275c7772ab2854c972774f5ba49ca22f0018a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463046
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827534}

This reverts commit c8c22806.

Reason for revert: crbug.com/1144660

Original change's description:
> gpu: Disable SurfaceControl on Samsung devices running Q.
>
> A platform bug can result in transaction acks getting dropped which
> stalls all rendering. A fix for this will be released in an R update
> soon so this changes disables using this API in Q.
>
> This also reverts an earlier workaround which was added for samsung dex
> mode since its not necessary after this change.
>
> TBR=skyostil@chromium.org
>
> Bug: 1131081
> Change-Id: I8d053f160fd8ad5bf6ce47d5e6e295c322bace69
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491401
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Auto-Submit: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820511}

TBR=nyquist@chromium.org,boliu@chromium.org,khushalsagar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1131081
Change-Id: I55a3a9e8329b062ffbd506650fd7aca483172908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538417
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827533}

- -Wfinal-dtor-non-final-class warns on classes with final dtors but
  not final classes.
- Error messages are better when the class is marked final.
- Fix existing issues in code base and remove warning exemption

Bug: 999886
Test: no errors building
Change-Id: I0814e4c543eb7f6d25bb0dfc1990b30e0b0c2f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468299
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827532}

The nacl_test_data targets don't like deps on //base, so had to remove
the #include from //base in pm_exit_status_test.cc.

Bug: 949535
Change-Id: I9cbdd63dca2eb1147013d6747c265f3f3fe9916a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538042
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827531}

This is a reland of 858c31cc

Pinpoint run: https://pinpoint-dot-chromeperf.appspot.com/job/17304503520000

Original change's description:
> Use weblayerStartupMetric for system_health.weblayer_startup
>
> The metric was split out of the WebView version, so we should use this
> now for WebLayer startup tests.
>
> Pinpoint job running:
> https://pinpoint-dot-chromeperf.appspot.com/job/104b30a9520000
>
> Bug: 1146438
> Change-Id: I9938614b94740a3222fb832ab994427b136bf1d8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536797
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827339}

Bug: 1146438
Change-Id: Ib12e05489961e32ecdaef110db3e0cbbea9294a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538252Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827530}

Bug: 1137941
Change-Id: I1d9f7291f8ca5388667687d4bc2e5839837d3c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530199
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827529}

This CL uses the feature added in Issue 1109612 to change all Updater
COM Classes to have dynamic guids.

Bug: 1148167
Change-Id: I8026a251e5cdc51692b4b37f76407c2fa67bd33a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533865
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827528}

Bug: 1121427
Change-Id: I1860284851bc2bfbb42cb3ab3501580a0bdc1c9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537813
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827527}

* Explicit deletion of copy constructors not necessary when move
  constructors are given.
* No way to check if the runner had a closure inside.
* RunAndReset() crashed if called with no closure inside.
* operator=() failed to run the outgoing closure.

Bug: none
Change-Id: I8c92dfaca95619fe6661af10c018a75dae7e25ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537787
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827526}

Fixed: 1141167

Change-Id: Ib0cd134262647014ebed61d8e1f3cbba675fa673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512786Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827525}

Renames:
* onCompleteCalled -> onCompleteHandled
* onCompleteReplied -> onCompleteHandled

Bug: 1131059

Change-Id: Id7093bff854e59fe73fdcf6a68a8ec1a582f8550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536052
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827524}

Bug: 1146458
Change-Id: I8289fe25d2b9b52687ae03e9308474f4ce9d2943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534399Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Vincent Boisselle <vincb@google.com>
Cr-Commit-Position: refs/heads/master@{#827523}

Move the implementation into the base class. The browser only
sends this for non-main frame (subframe) widgets.

Remove SetRemoteViewportIntersection it was just an alternate signature
of SetViewportIntersection for tests.

BUG=1097816

Change-Id: I97ec9776f2bb7852e5e3a564dc706f403f3e38cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537572Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827522}

Fixed: 1143328
Change-Id: I624e23cf4092a58eb61715ba3baa98a3c23186e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534781
Commit-Queue: Javier Flores <javierrobles@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827521}

This patch adds the support of forcing enabling and disabling Dawn
Toggles through command line parameters "--enable-dawn-features"
and "--disable-dawn-features". Each toggles are separated by ",".

e.g.
--enable-dawn-features=use_d3d12_render_pass,disable_robustness
--disable-dawn-features=lazy_clear_resource_on_first_use

This patch also removes the support of the command line parameter
"--disable-dawn-robustness" as now its functionality can be replaced by
"--enable-dawn-features=disable_robustness".

BUG=dawn:480

Change-Id: If8c4fcc7d29f83c5c583b285439e4df73e714764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529009Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Cr-Commit-Position: refs/heads/master@{#827520}

Change-Id: I68593bcfa600391e4cccbd26af5d471a2e48dddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533582
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827519}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07569638a739..01909e016604

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC sclittle@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1106950,chromium:1138706
Tbr: sclittle@google.com
Change-Id: I600c52a209a8d1ed79d0fe444de2a682bf729509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537126Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827518}

Change-Id: Ic34794a5840051626ca81514c9ccf7bcef74d17f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538422
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827517}

http://screen/BZqwCuid794nPCD

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnostisApp*
Change-Id: I39737c28cdb4c3f12dddcf31e29823fb15f187df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536931
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827516}

Use testdriver Action API to simulate mouse actions in
uievents/order-of-events/focus-events/focus.html.

This test now matches major browser implementations that "focus"
preceeds "focusin", and "blur" preceeds "focusout".  See:
    https://github.com/w3c/uievents/issues/276.

Bug: 1145677
Change-Id: I9e5965c90a18560cce560b73a3df88d0e840473d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519193Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827515}

This reverts commit c7a74ee0.

Reason for revert: manifest entries missing for DFMs, see crbug.com/1149022

Original change's description:
> Enable isolated splits in canary and dev
>
> All major crashes have been fixed and numbers look good. M88 branch was
> just cut, so should be safe to enable now.
>
> Bug: 1126301
> Change-Id: I351d565e68f14af2411c71fa80f34852bab5455a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529729
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827387}

TBR=agrieve@chromium.org,cduvall@chromium.org

Change-Id: I44601726754ab4c7d46f35f0d21be9482dd058b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1126301, 1149022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538519Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827514}

This class aligns the naming of the OmniboxSuggestion to match its
native counterpart (AutocompleteMatch) and relocates both
AutocompleteMatch and AutocompleteResult to the
components/omnibox/browser package.

The relocation is required so that we can call the java methods
(eg. to create or update) from native code without introducing
strange build dependency.

This is part of the effort to reconcile the suggestion pools.

Bug: 1138587
Change-Id: I27c0c991b47b22acca6d2de04e5e20dd34daea88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533207
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827513}

We found that the clock exposed by TaskEnvironment differs from
base::Time::Now(), leading to confusing results in tests. This
CL removes injected clocks, preferring to use base::Time::Now()
and base::TimeTicks::Now().

I found that precise time equality was difficult to get for some
tests with this approach, so I opted to add a new EXPECT_TIME_EQ
macro when testing time values.

Change-Id: I554a9075ce8db4950bea1c4ba0f23195ad5b58ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538414
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827512}

Store the GUID as a base::GUID instead of a std::string. Change the
constructor of BookmarkNode to take a base::GUID. Modify the code
around callers to make them compatible with the new API.

BookmarkNode::guid() still returns a std::string(). It will be changed
to return a base::GUID() in a follow-up.

Bug: 1026195
Change-Id: I7837de1a641bf946065f9eca67f0646ee50ee6c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522162Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Angela Yoeurng <yoangela@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827511}

Technically it was "whitelsited_url", but definitely still not inclusive.

Bug: 842296
Change-Id: I559972553b49e09423f40f59492b9c43f0faa1fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538269
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827510}

This is the list of directories excluded from presubmit checks
for base::Bind, base::Closure, and base::Callback.

Change-Id: I9e169427760a90ed06adb83b32a6a9cadc35bd88
Bug: 1007805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538038Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827509}

This CL adds a MediaLog to VideoEncoder and uses it to surface basic
properties. For now, it uses the VideoDecoder MediaLog properties to
surface encoder name, because changes to the Devtools code would and
the creation of new properties would be required to surface it as
an encoder.

Bug: 1148576
Change-Id: Ib9b0188421b08071672f49aead4cc87bd7d55d69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535561Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827508}

This CL splits CPRService#complete() into the common part and the
chrome-specific part and it moves the common part into
PRService#complete().

Bug: 1131059

Change-Id: Id861b023078e11da00ae80764d3d51475078d027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535651
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827507}

NavigatorBase is a newly-added base class for Navigator and
WorkerNavigator. Making USB a Supplement of NavigatorBase allows
a single class to handle all of the work of exposing the
navigator.usb getter for both windows and workers, and greatly
reduces boilerplate.

Bug: 1147612
Change-Id: I4d13bf6948301b65663a48fd34d4410c9596b21b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536387
Commit-Queue: Nate Chapin <japhet@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827506}

Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`."

This reverts commit 114bc6ab.

Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel:

https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850

Original change's description:
> Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.
>
> 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.
> 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered.
> 3. Set `hide_scrollbars` to avoid artificial scrollbars.
> 4. Set `record_whole_document` to force the whole page to be rendered.
> 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight".
>
> Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37
>
> Screenshots:
>
> - Before: https://i.imgur.com/yt6WZRx.png
> - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars.
> - Patchset #3:
>   * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view.
>   * https://imgur.com/MXpgHOl
>   * https://imgur.com/haxemcr - not aligned with the node.
>   * https://imgur.com/RbdlYVT
> - Patchset #18:
>   * https://imgur.com/EWUmn0O
>   * https://imgur.com/DUrQ1yF
>   * https://imgur.com/cT5oBSi - perfectly aligned.
>   * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended).
>
> Bug: 1003629
> Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876
> Commit-Queue: Maksim Sadym <sadym@chromium.org>
> Auto-Submit: Maksim Sadym <sadym@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827440}

TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sigurds@chromium.org,sadym@chromium.org

Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1003629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827505}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/be466dc7ac2c..d347b31c0e2e

2020-11-13 alexrudenko@chromium.org Enable TypeScript for toolbox_bootstrap.js

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I080013fcfc6c41f2c96aa38924631ef01c68d030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537121Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827504}

This sandbox flag was removed, so this is dead code.

Fixed: 1145605
Change-Id: Ibb7fb072f57da918f80644ffc80ae15334b02c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537702
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827503}

This is towards deleting StaticBitmapImage::CopyToByteArray and
other helpers.

The function ExtractImageData:
- Allocates a temporary surface with SkSurface::MakeRaster.
- Draws the image into that surface.
- Allocates output ArrayBufferContents.
- Make a copy of the SkSurface's contents using
  SkSurface::makeImageSnapshot.
- Copy the aforementioned copy to the output ArrayBufferContents using
  StaticBitmapImage::CopyToByteArray, which may do some sort of
  color conversion during the copy.

Change the function to:
- Allocate output ArrayBufferContents and point a surface directly
  at those pixels using SkSurface::MakeRasterDirect.
- Draw into the pixels, converting to the desired format on the fly.

Bug: 1115317
Change-Id: I656c1ed701c7bafade694d7dfad38dbb0bc74564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533289Reviewed-by: enne <enne@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827502}

NavigatorBase is a newly-added base class for Navigator and
WorkerNavigator. Making Serial a Supplement of NavigatorBase
allows a single class to handle all of the work of exposing the
navigator.serial getter for both windows and workers, and
greatly reduces boilerplate.

Bug: 1147612
Change-Id: If8bb50bdb9729b106be20f0ee228233560f09511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537920
Commit-Queue: Nate Chapin <japhet@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827501}

Narrator table with `Ctrl+Alt+(left/right/up/down)` was not supported
in Views. According to UIA API, the `GetItem` was not implemented
in Chromium.
https://docs.microsoft.com/en-us/dotnet/api/system.windows.automation.provider.itableprovider

Looking in the Chromium Accessibility Core, that gets translated
to the cross-plat `GetTableCell` which requires `GetCellId` to be
implemented. In this case the ViewAccessibility's platform node,
wasn't.

The approach taken was to reuse the existing internal method in
`TableView::GetVirtualAccessibilityCell` to get the node id for the
AXNode.

AX-Relnotes: Cells in TableView are navigable in UIA.
Bug: 1148097
Change-Id: I2257862bbe01d15fc7591bfeb9952ca2d8b143c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533837Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Mohamed Mansour <mmansour@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#827500}

Previous cleanup CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2520476

- app_type() and app_type_ is always kExtension.
- Exclude from_bookmark() extensions.

Bug: 1065748
Change-Id: I39301a2537c2e77633ef85067f6bd81f9adacecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522831
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827499}

Roll Chrome Win32 PGO profile from chrome-win32-master-1605214676-c85e88d2c252aa731add321a6482c347ea572e8a.profdata to chrome-win32-master-1605278951-6acf5f1c81bf8e5b853d44ef9575d8aab067a4b3.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I80835c86d3b275e178faea1c9655453f3a6a6b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536991Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827498}

This test is broken and doesn't actually test what it intends to. See
bug for details.

Bug: 1148855
Change-Id: Ife41243c4beaf992543f817c693151f5821bf5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537136
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827497}

To prepare for enabling debug logs by default for Googlers, this shows
the debug toggle by default. This does NOT enable the debug logs, but
this only shows the debug log toggle which only Googlers can see and
toggle the debug log on or off manually.

Bug: b:172273364
Change-Id: I01461177fc75d556a5d0786dcd3eb3a5a7325215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536849Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827496}

CL to add tester to recipe: crrev.com/c/2536808

Bug: 1147595
Change-Id: I4a140af01a025e1455b71b7ac50b834e5f5bf68e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538355Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Anjali Doneria <adoneria@google.com>
Cr-Commit-Position: refs/heads/master@{#827495}