- 17 Aug, 2020 40 commits
-
-
Takashi Toyoshima authored
Bug: 1116928 Change-Id: I9403fedea04ae67280d77d33beed399a69a77cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360091 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798895}
-
Nathan Zabriskie authored
With OOPR Canvas we need to be explicit about how SkImages will be used in the renderer process. In OOPR mode, SkImages must be software backed because we can no longer use GrContext in the renderer. This change updates callsites of PaintImage::GetSkImage to specify what kind of SkImage is required with the new GetSwSkImage and GetAcceleratedSkImage APIs. Follow up CLs will cleanup remaining callsites of GetSkImage until we can completely remove the function. Bug: 1018894 Change-Id: I69f7247e36c7cbb5d30f444f1255dd84af968df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350027 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798894}
-
Devlin Cronin authored
s/drew/devlin Bug: 1117280 Change-Id: I4ef12d12f3f5c58c62257a86ae8e07aceb55f6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356166 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798893}
-
Sebastien Lalancette authored
Updated the string as per UX's guidance. Bug: 1093302 Change-Id: Ia179f7e4d069d63cd84b25381f513e46c75f84b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360326Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#798892}
-
bttk authored
This field was being set in initializeToolbar() and used in initFindToolbarManager(). onInflationComplete() calls these methods in a reverse order. Bug: 1116924 Change-Id: I1899db0c9b572f3386cfe3ac480111b673c1c28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360573 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798891}
-
Lukasz Anforowicz authored
This CL adds a NOTREACHED assertion to the InitiatorLockCompatibility::kNoLock case in CorsURLLoaderFactory::IsValidRequest (in preparation for calling mojo::ReportBadMessage and returning false in a follow-up CL). Presence of the new NOTREACHED assertion requires fixing unit tests, so that they more accurately simulate the behavior of the product code. In particular: - A DCHECK has been added to CorsURLLoaderTest::ResetFactory to help ensure that all tests use a non-nullopt |request_initiator_site_lock| when simulating a renderer-side factory. - CorsURLLoaderTest::SetUp started passing non-null default initiator to CorsURLLoaderTest::ResetFactory. https://example.com was chosen as the default, because it is the most commonly used URL in other tests. This necessitated changing some tests to use the matching scheme (https rather than http). - Some tests were forced to specify a non-nullopt network::ResourceRequest::request_initiator (this is no longer okay, because if kNoLock case cannot be reached after this CL, then kNoInitiator case would crash the test). - Tests that really had to use a nullopt |request_initiator| were switched to simulating a browser-side factory (one with a nullopt |request_initiator_site_lock| and with kBrowserProcessId). Fixed: 1115222 Change-Id: I8c6e6603ba4626cf5c306ae5ca286fe1f1fb48e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350232 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#798890}
-
Jae Hoon Kim authored
CQ is facing flakes from time to time where DBus method calls into dlcservice is returning |org.freedesktop.DBus.Error.NoReply|. This logging will help narrow down if service availability is the cause as Chrome is frequently restarted during tast test runs. BUG=b:164310699 TEST=unit_tests Change-Id: Iebca6437c9407ea74c3dca06dddfb998733afae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358132 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#798889}
-
sczs authored
DiscoverFeedConfiguration will make any future changes much easier (even for potential cherrypicks), and its needed so the provider can read a PrefValue indicating the last time browsing data was cleared. Bug: 1085419 Change-Id: I8324eadac2f4c0113cc707ac9b84cd84e0336ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359399 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#798888}
-
Karandeep Bhatia authored
Currently we auto-generate code for types exposed through extension APIs, functions, events and properties. However, the manifest key schemas are not auto-generated. This means that each ManifestHandler has to individually parse the manifest keys resulting in verbose code which is often incomplete and where we don’t consistently validate all the types. This also means that we are not able to auto-generate documentation for manifest key schemas and have to explicitly describe it in API introduction templates. To fix this, add support to JSON and IDL schemas to auto-generate types required for manifest parsing. Changes: - ParseFromDictionary methods is generated for such types to aid in manifest parsing. Also, constants are generated for keys used in such types. - Currently, only the list, bool, double, int64, int, object, and string types are supported to be used in manifest keys. - Also convert declarativeNetRequest code to support this new way of manifest parsing to document how this will be used. More manifest handlers will be converted subsequently. Follow ups: - A subsequent CL will add support for enums. More complex types (any, choices etc.) can be supported subsequently if need be. - Exclude manifest-only types from generated schema strings which are sent to renderer. - Support a key called "from_manifest_keys" which types can use to denote that ParseFromManifest method should be supported. Generally, most types won't need to explicitly specify this, however this will be necessary when referencing types from a different namespace. - Support a key called "is_manifest_data" which types can use to denote that the type should inherit from Extension::ManifestData. This will be useful for cases where the type can directly be stored as part of the manifest data. Doc: https://docs.google.com/document/d/1ssw82MePGVQuVha9U5MXVTm9jpK4nPftWQD5Dm0fK1c/edit?usp=sharing (Internal only) Generated code snippets: declarativeNetRequest: - header: https://paste.googleplex.com/5109785672286208 - cc: https://paste.googleplex.com/5700852025131008 simple_api: - header: https://paste.googleplex.com/5197970343460864 - cc: https://paste.googleplex.com/5480262504808448 BUG=1113513 Change-Id: I2e21d293c8e83aa301cc04ee0ac39280cf9cdf70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337954 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798887}
-
Jao-ke Chin-Lee authored
Add basic VP9 decoding for an IVF video stream, with functionality to save the last decoded frame as PNG. BUG=crbug:1062407 Change-Id: I0e9272a50e269af658a9427e8b01548443dd467d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296872Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#798886}
-
Andre Le authored
Screenshots: https://screenshot.googleplex.com/3eeab29d-1b19-4345-a222-42703cee174b https://screenshot.googleplex.com/567b0132-f7a6-4a59-8c61-3a9a7d6cbba1 https://screenshot.googleplex.com/dfb161aa-99c4-4ac4-9fbd-b06c4d01e50e https://screenshot.googleplex.com/95a48208-ffc9-4f43-8993-1f0425b884bb BUG=1114949 Change-Id: I326e13b202b315ca8548bda03acb4a9ff53577de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353174Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#798885}
-
Brian Malcolm authored
BUG=chromium:1105185 Change-Id: Ia6a7d87f4151b259552e609bc5c4c46f4470037e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355001Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#798884}
-
Aaron Colwell authored
Adding more logging information to make it easier to determine why the RenderProcessHostImpl is still alive. All the new values are related to the various early return paths in RPHI::Cleanup() that cause destruction to get deferred. Bug: 1113159 Change-Id: I6dbf6966ca91681aed0c853605f1be9d736b80a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360473 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#798883}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22e7f7a0d7d7..f926b0866fe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5d81573e79447a05bd05b0236741a712f85bef01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798882}
-
Michael Bai authored
- This will give the consumer the ability to discard the old content ASAP. - Also change the test to make it pass on BFCache feature. Bug: 1115234 Change-Id: Ib41f5642018e6e11c919100b29bf7fb10e2f91b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350126Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#798881}
-
Nigel Tao authored
Change-Id: Ibcb2d27f41d129fafaeec8509a7c53d44180c1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359653Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798880}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/699711c7e3cd..f926b0866fe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idb41e200c262b4ddcc84dddd83871597853206e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358601Reviewed-by:
-
Fred Mello authored
https://docs.google.com/document/d/1gpfB_4Ars3BflCquzXQ3eYL8UEShTPTw4CJ6DNEgGoI Bug: 1112872 Change-Id: I6db23b082c05b83b43a7b9b47ed2f98dabc76200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359563 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
-
Mehrdad Hessar authored
Bug: 1116626 Change-Id: I3b0542f0b9a670c797e6e61329864f2fb9a8abff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358059Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Mehrdad Hessar <mehrdadh@google.com> Cr-Commit-Position: refs/heads/master@{#798877}
-
Liquan (Max) Gu authored
Change: * Add null-check for PRImpl's "WebContentsStatics.fromRenderFrameHost(renderFrameHost)". And move it to CPRImpl. * JourneyLogger's instantiation is moved from PRImpl's construction to before CPRImpl's construction. Moving it earlier is because JourneyLogger's role includes logging the error before CPRImpl's construction. * BrowserPaymentRequest's creation is no longer done in CPRImpl's construction. This is because BrowserPaymentRequest's constructor calls CPRImpl which is still partially initiated. * The null-checks of client, methodData, details are moved from CPRImpl#initAndValidate() to CPRImpl#createIfParamsValid(), because we don't bother to create CPRImpl if render data is invalid. Acronym: CPRImpl = ComponentPaymentRequestImpl PRImpl = PaymentRequestImpl Bug: 1102522 Change-Id: I0faf70fe6a73b13858b30d1dadb30cf25857eda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357090 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798876}
-
Dominic Farolino authored
R=asvitkine@chromium.org, jbroman@chromium.org Bug: 1053702 Change-Id: Ibe268bd3930582fa1a366419806e71bf87ef9cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360550 Commit-Queue: Dominic Farolino <dom@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Dominic Farolino <dom@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#798875}
-
Dana Fried authored
Chrome now has a visible caption bar in tablet mode above the toolbar/ tabstrip that behaves like most other Windows apps (explorer, console, etc.) When maximized in non-split-screen mode: - Caption bar is thin. - Restore caption button is present but disabled (greyed out, won't highlight). Note that this is an improvement on Windows apps which display a non-disabled button that doesn't do anything. - User can pull down on the caption bar to move the window and go into split-screen mode. When in split-screen mode: - Caption bar and buttons are default size. - Maximize caption button is present but disabled (see note above). - User can pull down on the caption bar to move the window in and out of split-screen mode, etc. This change also makes it much easier for users to generate touch gestures that clearly show intent to either move the window or open the tabstrip shade, by dragging on the caption bar vs. the toolbar. The general accuracy of drag/swipe gestures on the toolbar seems to be very much improved by this change. Known issue: when in split-screen Windows sometimes (but not always) cuts off the top few pixels of a window. This happens to native/first- party Windows apps the same as Chrome, so is not a Chrome bug, and because it is intermittent we can't compensate for it except to use a taller caption bar in this mode (which is also consistent with other Windows first-party applications). Note: the ability of the caption button container to be torn out and moved to the tabstrip container, which was previously required in order for us to hide the caption buttons and show them when the tabstrip tray was opened, will be removed in a follow-up CL. Bug: 1116651 Change-Id: I09ca9381f2add1198a680d9ef6f45cedd7916bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358249Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#798874}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3f714d9026a2..03f545114e8e 2020-08-17 wenbinzhang@google.com [benchmarking] Fit GetPcSystemType for win platform backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114681,chromium:1115156 Tbr: rmhasan@google.com Change-Id: I2938f283fce864de2969b51394cc38d874060c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360226Reviewed-by:
-
Andrew Comminos authored
To prevent attributing events to subframes with |pointer-events: none|, avoid setting this on layers generated from the subframe. Replaces frame_element_id with visible_frame_element_id. Bug: 910421 Change-Id: If0f709b210781c13444b71937d2b6225b3494d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353545 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798872}
-
Dan Harrington authored
Scroll restore didn't work when: - the feed is being restored in async, so scrolling must happen later, - And the item at the top of the NTP was a header, present before the feed is loaded. This CL stores the last visible item index in the scroll state, and waits until the right number of items are added to the recycler adapter. Bug: 1115488 Change-Id: Iac489572da73659261231a002e2c2a66591234af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360311Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#798871}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c8ac35879c9d..2549f174b533 2020-08-17 danilchap@webrtc.org Remove RTPFragmentationHeader creation and propagation through webrtc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieac912a0f4401836f2118735f0879e2dff7d5dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359286Reviewed-by:
-
Jinsuk Kim authored
This CL lets RootUiCoordinator create and provide BrowserControlsManager to other classes. Chrome*Activity still has #getBrowserControlsManager which now just defers the call to RootUiCoordinator. This makes |createComponent| and |createRootUiCoordinator| in ChromeActivity#performPreInflationStartup form dependencies on each other for CCT/Webapp. This was broken by creating RootUiCoordinator first and having some components be passed to it as a supplier instead. Bug: 966272 Change-Id: Ic89fdb77d0886d448033599c9e20128c96f071c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327351 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#798869}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1045266 Change-Id: Ie8faf5986af1f0564f20cf5aa5b8cc6beea9a135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358597Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#798868}
-
Thomas Anderson authored
This reverts commit 065ade05. Reason for revert: Suspected cause of All/OobeInteractiveUITest.SimpleEndToEnd/9 failure on Builder linux-chromeos-rel Build 40523: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/40523 Original change's description: > Reland "LoginScreen: Show TPM lock status." > > This is a reland of 67a4df6f > CL was reverted cause of failing > chromeos-betty-pi-arc-cfi-thin-lto-chrome due to reaching deadline > on one of the tests. This is gonna be fixed by increasing time limit. > See details here: https://crbug.com/1116379 > > Original change's description: > > LoginScreen: Show TPM lock status. > > > > If TPM is locked show banner with steps on how to fix this issue. > > > > Bug: 1114656 > > Change-Id: I85dab0f4ce003ac3dad61c318efb3333457993ac > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346266 > > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > > Cr-Commit-Position: refs/heads/master@{#797992} > > Bug: 1114656 > Change-Id: Iba50daf1d1b892539e00d9be04fc2b8c0a5a279e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359992 > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#798698} TBR=tbarzic@chromium.org,antrim@chromium.org,raleksandrov@google.com Change-Id: I55fca0fb2f7fdbdacf1de9d7122571a888b89d11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358906 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798867}
-
Thomas Anderson authored
This reverts commit 5e960b15. Reason for revert: Nothing actually wrong with this CL! But we need to revert a separate CL (https://chromium-review.googlesource.com/c/chromium/src/+/2358906) and this CL introduced merge conflicts. Sorry for creating extra work for the reland :( Original change's description: > CrOS - Login Screen - Minor cleanup > > Rename AnimationState to UiState and use it to determine the > visibility of elements. Remove multiple variables in favor of > UiState. > > Bug: 1075994 > Change-Id: I0d7413fb173dadbff22cde0eb3af6f43586bdee2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352883 > Commit-Queue: Renato Silva <rrsilva@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798780} TBR=antrim@chromium.org,raleksandrov@google.com,tellier@google.com,rrsilva@google.com Change-Id: Id0637f3c2491612b22a7630194a1377d9e4b7b34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360699Reviewed-by:
-
Hui Yingst authored
Add message handler HandleSaveAttachmentMessage() for downloading PDF attachments. As the caller of PDFiumEngine::GetAttachmentData(), HandleSaveAttachmentMessage() validates the attachment's index, readability and whether the size is non-zero before calling, and checks whether the returned attachment's size matches the stored attachment size in |doc_attachment_info_list_|. After calling GetAttachmentData() to fetch the attachment's data, HandleSaveAttachmentMessage() posts a reply to save the data to disk. Bug: 177188 Change-Id: I34ad386447cdcb4025d0f545e4ff8b9d3b818659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295998 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798865}
-
Josh Simmons authored
Two unit tests were still calling the (removed) set_uri() method instead of the (new) SetUri() method. Updated the tests. Bug: 1113983 Test: autoninja -C out_${BOARD}/Release unit_tests builds without errors Change-Id: Ibd45ff3729d3b5a076913ccd7408402154785d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342424Reviewed-by:Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#798864}
-
Becca Hughes authored
Adds a dedicated KaleidoscopeNTPDataProvider that provides the methods that are needed by the NTP. BUG=1114862 Change-Id: I29c182f5c032f8dc0553bbe14b405f228942d3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357521Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#798863}
-
Michael Thiessen authored
Introduce CriteriaHelper#pollUiThreadNested This change adds an assertion that pollUiThread is not called from the UI thread, which is equivalent to calling sleep(), and won't actually run any UI thread tasks. In the few cases where polling the UI Thread from the UI thread is necessary, I introduce CriteriaHelper#pollUiThreadNested, which nests the looper in order to continue running UI tasks. Bug: 1115220 Change-Id: I9338a607590e8ee0a22bc32477f02867c6e37271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357289Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#798862}
-
John Williams authored
Bug: b/161367720 Change-Id: If21e72031c20b6e5da11fc477cf108145776a5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346970Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#798861}
-
Sahel Sharify authored
Attempting to show an error message in payment request dialog view after PaymentRequestDialogView::OnDialogClosed() call causes a crash. This is because PaymentRequestDialogView::ShowErrorMessage() creates an error view and adds it to the view stack[1] while the stack view gets destroyed upon PaymentRequestDialogView::OnDialogClosed() call. [1]https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/payments/payment_request_dialog_view.cc;l=123 This cl fixes the crash by early-returning from PaymentRequestDialogView::ShowErrorMessage() when the dialog is getting closed (i.e after PaymentRequestDialogView::OnDialogClosed() has been called.) The screencast of the fix is already attached to the bug. Bug: 1114556 Change-Id: I10d9478a83913a167e52ed558a6a09cf18fcd6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359562Reviewed-by:
-
rbpotter authored
Add document outline view by porting the bookmarks list to the sidenav from the viewer toolbar. Bug: 1116574 Change-Id: I571dc8e6f6f7288debff5a9abcdc4e2f93877366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357673 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#798859}
-
Vikas Soni authored
Add about:flags to enable/disable AImageReader. This will help in debug on production builds. Bug: 1114874 Change-Id: Ib6216e4b594f59a46890f43640a25154711da351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360113 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#798858}
-
Mark Mentovai authored
New packages are provided for both Xcode 11.2.1 11B53 and 12b4 12A8179i, identical to the old packages with the inclusion of atos after 955c73fb. Bug: 1113466 Change-Id: If8c18cc0881526d006cad35a6f45f2aa2af2d611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360324 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#798857}
-
Owen Min authored
The CommandLinePolicyProvider will be addded on Android device for Canary, Dev amd trunk channel. Unless the CommandLineOnNonRooted feature is enabled. Test locally with following command: out/Release/bin/chrome_apk run --args='--policy="{\"BrowserSignin\":0}"' And here is the screenshot of chrome://policy page: https://drive.google.com/file/d/1wp2nlPpgbMrOWFXigqYjgshjH5E7ZrrT/view?usp=sharing Bug: 1113792 Change-Id: I11f5d00a68a2f2a852eff1dc02ed6d1e653ff506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357459 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#798856}
-
