- 23 Jul, 2019 40 commits
-
-
Dominik Laskowski authored
Content protection would be reported as enabled while mirroring to an external display with an unsecure (e.g. analog) connection type. Bug: 929449 Test: display_unittests Change-Id: I4929ff4fa591616f27eaed01875455c86504e91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674404 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#680038}
-
Matt Menke authored
Currently, nothing passes in anything other than a default constructed one. Consumers will be updated one-at-a-time in followup CLs, and the default empty NetworkIsolationKey will be removed from method declarations. Bug: 966896 Change-Id: If5cc69299de2b0fc6886c304710ffa40423f9536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672147 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680037}
-
Matt Falkenhagen authored
This aligns PlzWorker to be more like PlzNavigate for service worker related objects. This will allow moving service worker to the UI thread by allowing PlzWorker to use ServiceWorkerNavigationLoaderInterceptor like navigations do. Previously, navigations stored ServiceWorkerProviderHost info in ServiceWorkerNavigationHandle, while PlzWorker did it itself: WorkerScriptFetchInitiator::CreateScriptLoaderOnIO created the provider host and passed the host to WorkerScriptLoaderFactory, and eventually WorkerScriptLoader::CommitCompleted called host->CompleteWebWorkerPreparation. The host's info was passed to WorkerScriptFetchInitiator::Start's callback, so the caller could pass it to the worker in the renderer. Now, DedicatedWorkerHost or SharedWorkerHost hold the handle and take the info from it to pass to the renderer on commit. WorkerScriptLoader::CommitCompleted gets a pointer to the handle and calls CompleteWebWorkerPreparation on its host. Refactoring-only. As a result of the refactoring, we no longer make a ServiceWorkerProviderHost for workers whose URL is not a service worker supported scheme (essentially https or chrome-extension). Previously we would make the host but it wouldn't be used because it would have a blank URL as UpdateUrls() was never called on it by the interceptor. Bug: 985259 Change-Id: I999c69f0cb3bc6f37ef854c96322b0774ec84a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712510Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#680036}
-
Clark DuVall authored
This was causing users to be in the ForcedOff finch group. See bug for more details. Bug: 985362 Change-Id: I0dfba2f062f51d61bf93d1920931bfeb0a79b639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715424Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#680035}
-
Shivani Sharma authored
This CL adds frame origin to the network isolation key created for a navigation resource. Includes tests that enable the feature kAppendFrameOriginToNetworkIsolationKey to test the changes. This also includes a fix that FollowRedirect with a non-empty new_url should use that to create the NIK. Also added a test for that. For this change to be tested properly, it has to be in network_context_unittests rather than url_loader_unittests. Moved all the existing tests to network_context_unittests as well. Bug: 984130 Change-Id: I842ce4b172c0b43bcbe0e5479abe35318437d436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699374 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680034}
-
Jared Saul authored
Bug: 986495 Change-Id: I7dd05b34559aee36129a813993854cda37c54870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713944Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#680033}
-
Shakti Sahu authored
This CL adds special handling for .ogg files to be shown in the audio section on download home. Bug: 982090 Change-Id: I10c09f799ea196044f5dfcac31445d3076750dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713870Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680032}
-
Lan Wei authored
In ExecutePerformActions function, we have checked if all the coordinates stored in input_state for all pointers are integers. Right now, we did not clear the states from the previous session, which makes this check fail for some wpt pointerevent tests. https://wpt.fyi/results/pointerevents/ pointerevent_touch-action-keyboard.html?label=master&label=experimental We will add it back once we have added the ExecuteReleaseActions function after running each test in wpt serve. Bug: 606367 Change-Id: Ifda3d57fd8cc0506f713ee26984eb2cbceff02ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713249Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#680031}
-
Richard Knoll authored
The small icon of notifications on L+ are not colored by default. Bug: 986848 Change-Id: If03bfa76c6c389fbdbc07015462638ee4867978f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715184 Commit-Queue: Richard Knoll <knollr@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#680030}
-
rajendrant authored
Bug: 985857 Change-Id: I405e210985953effd5b258a1de2c1ce560e2e2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714211 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#680029}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/ad0248681e65..0b5bfaebe8ba $ git log ad0248681..0b5bfaebe --date=short --no-merges --format='%ad %ae %s' 2019-07-22 quiche-dev gfe-relnote: Initialize uninitialized private member variable QuicSpdyClientBase::max_allowed_push_id_ 2019-07-22 bnc Fix includes in quic_spdy_stream_body_buffer.{h,cc}. 2019-07-22 renjietang Modify push_promise related methods to prepare for H3 push promise. 2019-07-22 renjietang Clean up build dependency for Qpack streams. 2019-07-22 bnc Split out QuicSendControlStream from quic_spdy_session_lib build target. 2019-07-22 quiche-dev Internal QUICHE change 2019-07-21 vasilvv Hex encode the path challenge buffer. 2019-07-21 dschinazi Fix logging of QuicNewTokenFrame 2019-07-21 bnc Use HttpFrameType instead of int literals in HttpDecoder. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: I824d34ea12cdc6ef8dbe7501e4d67203ea85b596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714627 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#680028}
-
Yasmin authored
Bug: 986269 Change-Id: Icf37fa45253e876d4b720547f9706e0af302b97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712874Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680027}
-
Gauthier Ambard authored
The ReadingList cells used to have two "Delete" custom accessibility actions: one from UIKit because it is possible to swipe-to-delete, the other from the custome action set on the cell directly. This CL removes the one set from the code, leaving only the UIKit one. Bug: 985746 Change-Id: I873703cd65d09dfe8e2779ed4760f81c22812ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715346 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680026}
-
Will Harris authored
This reverts commit 384ba48b. Reason for revert: This might not be needed. Original change's description: > --no-sandbox is added for Windows ASAN. > > As sandbox is not yet supported by ASAN in Windows, it's better to add > --no-sandbox there. > > Change-Id: I38430c95b4a0f5cfeee3ab389ddcb3e78721c027 > Reviewed-on: https://chromium-review.googlesource.com/968421 > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544765} TBR=dpranke@chromium.org,voodoo@yandex-team.ru # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4cf38262948857daddbd4498745181c733607136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711897Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680025}
-
Sky Malice authored
Bug: 979368 Change-Id: If2a7475777492908021758a6699c5a28905e235c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688165Reviewed-by:
Ender <ender@google.com> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#680024}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e557c49c. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9d1be80dec15189de19b2c6e3bec838132bef9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714984Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680023}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/61689ab0630a..cfefa0aef329 git log 61689ab0630a..cfefa0aef329 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 mbonadei@webrtc.org Revert "Record audio/video bytes sent in analyzer stream stats." Created with: gclient setdep -r src/third_party/webrtc@cfefa0aef329 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ib1b6f35b43dfa109e6d2193a80e90a3d428287eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714339Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680022}
-
Antoine Labour authored
This CL ensures: - VideoFrame mailboxes are imported using the CreateAndTexStorage2DSharedImage API if they are shared images, and that the Begin/EndSharedImageAccessDirect scope are properly used. - Intermediate copies are allocated as shared images instead of internally to skia. The cache is modified to track the mailbox for the source texture, rather than a SkImage, to be able to import it into multiple contexts. Also the cached shared image is reused if possible (same context provider, same size) to reflect equivalent skia optimizations (SkImage pooling). Note: this CL doesn't cover PrepareVideoFrameForWebGL, used for the (still experimental) WEBGL_video_texture extension, which requires a fairly significant refactoring all the way to WebGL bindings to support shared image. Bug: 882547 Change-Id: I77b374526f3617db0fd936ffa5b71885e2c8fab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616978 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680021}
-
Mugdha Lakhani authored
Log important Periodic Background Sync events to DevTools to help with debuggability. Bug: 925297 Change-Id: If3d4be914e4516ffbf125f81ba0babd1da94eea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710569 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#680020}
-
Evan Stade authored
NOTIFICATION_TAB_ADDED and NOTIFICATION_BROWSER_OPENED are migrated to OnTabStripModelChanged and OnBrowserAdded respectively. Bug: 268984 Change-Id: Ic22cf9e28fdb45ba9f8c10c61e47e52102224793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710727 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#680019}
-
Mugdha Lakhani authored
Add logic to track origins whose periodic Background Sync registrations have been suspended due to the users engagement with their site falling to zero. This will be used to revive the origins we care about. Bug: 925297, 982378 Change-Id: I04c2644feeab77092435d0db223ca3cee841e406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710548 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Varun Khaneja authored
Also remove SafeBrowsing.V4DatabaseOpen.Time since it isn't very useful now. R=drubery Bug: 976028, 975741, 975712 Change-Id: I7fc82b6f027cd70533696ff817bf785892ba4c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705137 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680017}
-
stkhapugin authored
The width constraints for the omnibox and the Cancel button seem to be ambiguous. This CL sets the Cancel button's horizontal hugging to 1000, so it won't be able to expand too wide anymore. Bug: 978856 Change-Id: I9453bf88f48e07cc0ab817bec891fdabb014ec05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692924 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#680016}
-
Javier Ernesto Flores Robles authored
Add background assets for dark mode. Remove dupe images between incognito and not incognito. Prefer to tint the asset for the favicon. Change text and icon color for the inactive state. Bug: 976817 Change-Id: I284cc4af88f3edae9a08a3693b459107928fd5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712664 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#680015}
-
Philip Rogers authored
donot-compute-non-fast-scrollable-region-for-hidden-frames.html did not use "t.step" which made the test difficult to debug if there were failures, so "t.step" has been added. This test has also been changed to print the actual region instead of just the count. plugin-with-wheel-handler.html has also been changed to print the actual region instead of just the count. This required using "setPrintTestResultsLazily" to prevent cross-platform differences due to text height. Bug: 864567 Change-Id: Ibf19cd12d4f40a14a037d72eb076b50ff7aa3f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711489 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680014}
-
David Jean authored
Moves minimum deployment target from iOS11 to iOS12. Bug: 976348 Change-Id: Ie49c322e42837350fed9b08b54086ea0e790ea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706506Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
[Native File System] Make sure usage indicator doesn't show same directory as readable and writable. Bug: 985982 Change-Id: Ib1b04538e06523e38b885033b1f47ad9cdfc91a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713031Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#680012}
-
Alex Chau authored
Bug: 974816 Change-Id: I0375b88459de729de40d13e96a80caa159d5b5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710570Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#680011}
-
Jeffrey Cohen authored
Bug: 985972 Change-Id: Ic1455724636fadb0374fd43bb4e5ae8907315481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713239Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#680010}
-
Huanzhong Huang authored
Current implementation of the cache counter has a stability issue that might crash the app due to certain timing of events. This is an attempt to fix the issue. Bug: 963006 Change-Id: I9da00ee138196286863a51d6d695c5434aa6f69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698540Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5207f35f33b1..21a940d42fee git log 5207f35f33b1..21a940d42fee --date=short --no-merges --format='%ad %ae %s' 2019-07-23 reed@google.com refactor paragraph samples 2019-07-23 bsalomon@google.com Add driver workaround to avoid noperspective on QC with ver 3.1 or earlier 2019-07-23 reed@google.com remove default looper flag, rely on clients to opt-in 2019-07-23 fmalita@chromium.org [sksg] Fix setVisible() invalidation 2019-07-23 bsalomon@google.com Lift GrRenderTargetContext::rescale to GrSufaceContext 2019-07-23 brianosman@google.com Fix a couple potential bugs when adding sampler info to a program key 2019-07-23 bsalomon@google.com Remove sample count from GrSurfaceDesc. Created with: gclient setdep -r src/third_party/skia@21a940d42fee The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: chromium:986581 Change-Id: I32b65bc06ee0b851fbd1e404b7c2cd201d73f7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714918Reviewed-by:
-
Mario Sanchez Prada authored
This class is now only used from blink::SurroundingTextImpl, so we can move it down into renderer/core/editing and remove it from the public API. Also, make the most of this move to make the new blink::SurroundingText class use internal Blink types (i.e. WTF::String, LocalFrame) instead of the public Web* types (i.e. WebString, WebLocalFrame), which will allow migrating blink::EditingImpl away from WebLocalFrame on a follow-up CL. Bug: 980151, 919392 Change-Id: I2a6ba1aa9e00603d40b4ccb9acb69f46baf5931b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699608 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/12c06467..a2f0a34a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib1196a951e44b3f9e93501e02a66dfdbe51d22d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713152Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680006}
-
Leonard Grey authored
Bug: 969105 Change-Id: I01ac278560bb29b708fa79927a0bb026d8a34d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709782Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#680005}
-
John Delaney authored
This CL adds the PeakWindowedUsage metric to AdFrameLoad UKM. This can be used alongside the existing CpuTime metrics to better determine the type of ads with high CPU usage. Bug: 978030 Change-Id: I4175c87d149003b040260a837c2a5de3e2ca1633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653390Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
-
Jihwan Marc Kim authored
No longer pursuing an intervention with the 1050 KB threshold. Remove the associated metrics and code. Bug: 962616 Change-Id: Id4e199dfc398b10121d4bbcea3102e94d0af4a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686971Reviewed-by:
-
Joe Mason authored
timeSinceLastEngagement_shouldReportElapsedTimeBetweenTimestamps gets the current time twice. If the system time ticks over between calls it will register 1 ms more than the test expects. R=yusufo@chromium.org Bug: 947572 Change-Id: Ic5b1bcda2300e217b66567ba54a9ccaa5e515374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708844 Auto-Submit: Joe Mason <joenotcharles@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#680002}
-
Egor Pasko authored
While reworking ChromiumAndroidLinker.{BrowserStates,RendererStates} I noticed that "RelinkerFallbackCount" is not recorded in renderers. This is also observable on the UMA dashboard: for my time interval I see these sample counts: ChromiumAndroidLinker.RendererLoadTime: N samples ChromiumAndroidLinker.BrowserLoadTime: (0.8 * N) samples ChromiumAndroidLinker.RelinkerFallbackCount: only about N samples, but expected to be closer to 2 * N. I *think* that "RelinkerFallbackCount" is the only renderer-side histogram that is recorded with CachedMetrics currently, and in my rough testing this change helps recording more samples. Removing this histogram to re-introduce it as part of another metric. Tests TBD as part of another change where the new histogram is introduced. There is a way to call commitCachedMetrics() for the browser process as well, but I'd like to postpone it now because it may significantly affect a number of metrics (see https://crbug.com/986796). Bug: 981599 Change-Id: I69799f96278fe5c6ea8661055aa153a8b7f4fb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713535Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50d644e41333..0ecadc16190a Created with: gclient setdep -r src-internal@0ecadc16190a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: If8e8b0ca29321b378ab6a9c81371fd08374e58c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714917Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680000}
-
Yoshifumi Inoue authored
This patch makes |LayoutText::GetTextBoxInfo()| to handle truncated text, e.g. "overflow-x: hidden", by using "hidden-for-paint" fragments[1]. Before this patch, we attempt to handle ellipsis character as part of DOM text then we produce wrong value or crash. [1] http://crrev.com/c/1678915 [LayoutNG] Keep truncated fragments for `text-overflow: ellipsis` Bug: 985488 Change-Id: If0287a6dd6db8f8b9022bedd5ef8d207db524f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714394 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#679999}
-
