- 17 Feb, 2018 40 commits
-
-
Steven Bennetts authored
i18n() asserts if any unsafe tags are passed to it. We need to HTMLEscape any network names passed to i18n(). Includes fix for browser tests. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/920903 Bug: 811562 TBR: tbarzic@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7762ac9309b812358799c7eb885b1b4d29f9ec7f Reviewed-on: https://chromium-review.googlesource.com/924655Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#537518}
-
Joe Downing authored
We are seeing a crash in M65 where the Heartbeat sender attempts to resend a heartbeat after a timeout and the iq_sender_ member is null. The SendHeartbeat call is being triggered via a callback and that only occurs when the previous heartbeat times out. This is odd because the code which resets the iq_sender_ member also stops the timer. After some digging, I *think* what is happening is that timer_.Stop() does not clear any pending tasks if they have already been posted. In this case the timer is stopped but the posted task runs shortly afterwards with iq_sender_ being null and it crashes. I only have access to the minidump for the crash so this is the most likely scenario I can think of. To address this, I have done two things: - I've updated the Stop calls to use AbandonAndStop (this will clear any posted tasks) - I've added a null check for iq_sender_ The second step may not be required but I don't want to find out in M67 that the Abandon and stop change was not enough : P Note: I also cleaned up some old coding conventions around callback use in the file. If they are too distracting I can make a follow-up CL. BUG=812261 Change-Id: I742d6ce27bc4a83ea42520c5cd8a14e911fc90e2 Reviewed-on: https://chromium-review.googlesource.com/924590Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#537517}
-
Alexei Svitkine authored
CHECK() produces crashes and sometimes these are prevalent enough for crash triagers to file and ping crbugs about, which just wastes everyone's time. This changes the CHECKs to a printed message via puts and an exit() call. Differentiates between invalid variation ids coming from command line vs. those from about:flags and uses a NOTREACHED in the latter case. Also, cleans up the code a bit by changing the APIs around passing additional variation ids - making the param const and making a helper function private. Also fixes some lint errors around includes and header guards. BUG=812164 TBR=sky@chromium.org,rohitrao@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id765738791ada14540ff51fe5f6fc837dd42e7c7 Reviewed-on: https://chromium-review.googlesource.com/919194Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#537516}
-
Francois Doray authored
Bug: 796981 Change-Id: I27809072f7d22cccec8977de71ec2312b16def4d Reviewed-on: https://chromium-review.googlesource.com/923567Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#537515}
-
Nasko Oskov authored
Currently, these two histograms are only recorded for back/forward navigations. In order to have more complete picture of navigation performance, these should be recorded for all successful, non-same document navigations. Bug: 808114 Change-Id: Ifecd66ad82fc0f495e918edf21865a2a61a32939 Reviewed-on: https://chromium-review.googlesource.com/924457 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#537514}
-
rbpotter authored
Add cloud print interface, enable sign in and account selection in destinations dialog, add capability to print to cloud printers. Bug: 773928, 812093 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7195700506da79f33fc10bc8bdebc5f24ff2d776 Reviewed-on: https://chromium-review.googlesource.com/917220 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#537513}
-
Dave Tapuska authored
Despite the name, Linux/X11 systems map the PrintScreen key to XK_Print rather than XK_KEY_3270_PrintScreen. We map both to DOM 'PrintScreen' to match user expectations, and the behaviour of other browsers, and Chrome on other platforms. BUG=683097 Change-Id: If2d4f78ef191d51544f0eee64098a7348e60fa37 Reviewed-on: https://chromium-review.googlesource.com/921921 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#537512}
-
wutao authored
This cl adds a new flag to turn on/off the new overview animations. Bug: 801465, 795988 Test: Tested on device can turn on/off the new animations. Change-Id: I17570006e7d495fad1079e8bf7d9f39a454e24cb Reviewed-on: https://chromium-review.googlesource.com/924249 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#537511}
-
Aaron Schulman authored
This fixes a long running problem with BattOr on Mac where the StopTracing command fails due to repeated loss of a few bytes. It addresses this issue by switching to requesting each sample frame individually. When bytes are lost and a frame is corrupted, the broken frame will be requested again before downloading the rest of the buffer. Bug: 780907 Change-Id: Ie773405530a76454b30564ec35ceee87a61446da Reviewed-on: https://chromium-review.googlesource.com/908252 Commit-Queue: Aaron Schulman <aschulman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#537510}
-
edchin authored
Bug: 804496 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifed54179a9f9ffb5e61f270664af35a3f86c9deb Reviewed-on: https://chromium-review.googlesource.com/924532Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537509}
-
Dave Schuyler authored
TBR=erikchen@chromium.org Bug: 813117 Change-Id: I08b627b284d88cc6b50b96cfb75f9399fb8a67f7 Reviewed-on: https://chromium-review.googlesource.com/924758Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#537508}
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I11b27ea0e279709382adc4e685cda2bc52c9eb79 Reviewed-on: https://chromium-review.googlesource.com/923413Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#537507}
-
Pavel Feldman authored
Bug: 812975 Change-Id: I764431a476df8205cace5f1cd2ef4f9e8e42ef28 Reviewed-on: https://chromium-review.googlesource.com/923705 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#537506}
-
https://chromium.googlesource.com/catapult.git/+log/e7298f36f791..4aa92ef01607 $ git log e7298f36f..4aa92ef01 --date=short --no-merges --format='%ad %ae %s' 2018-02-16 dtu [pinpoint] Use app_identity instead of os.environ for getting the hostname. 2018-02-16 jbudorick Add a close() method to LogcatMonitor. 2018-02-15 spelchat Use signature algorithm from the wpr-go root cert. 2018-02-16 dtu [dashboard] Cache ServiceAccountHttp() in memcache. 2018-02-16 ashleymarie Revert "[Telemetry] Remove FailureValue from the value system" 2018-02-15 dtu [pinpoint] Remove and rename fields in new job dialog. 2018-02-16 charliea Ignore story name length check for story names containing '.html' 2018-02-16 nednguyen Revert "devil: Add USB port number field to device_status dump." 2018-02-15 dtu Remove extra / in commits.py. 2018-02-14 dtu [pinpoint] Fix for index error when checking questionable significance level. 2018-02-14 dtu [pinpoint] Increase request timeout and retry on InternalTransientError. 2018-02-15 nednguyen Bump up wpr startup timeout to 120s 2018-02-14 dproy Rename top level scheduler task 2018-02-14 simonhatch Pinpoint - Send extra_test_args as a json list. 2018-02-14 eakuefner [Telemetry] Remove FailureValue from the value system 2018-02-14 eakuefner [Dashboard] Prevent creating old-style rows for cronet_perf_tests 2018-02-14 simonhatch Pinpoint - Fix auto_explore for re-run jobs. 2018-02-13 simonhatch Pinpoint - Look for DiagnosticRef's when parsing histogram data. 2018-02-14 nednguyen Add mips wpr-go binary 2018-02-14 perezju [Telemetry] Move cache clearing code to possible_browser 2018-02-12 carmenjackson Update output filename from systrace --from_file 2018-02-09 simonhatch Dashboard - Purge bin diagnostic_maps in /add_histograms 2018-02-13 perezju [Telemetry] Clarify FindExistingBrowser docstring 2018-02-09 simonhatch Dashboard - Force commit positions to be integers. 2018-02-09 simonhatch Dashboard - Validate data a bit in /add_point. 2018-02-12 djordje.golubovic Add MIPS wpr_go binary support. 2018-02-12 dtu [pinpoint] Auto-explore fix. 2018-02-12 eakuefner [Telemetry] Remove TODO in GtestProgressReporter 2018-02-12 bpastene devil: Add USB port number field to device_status dump. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ied5ae71d03f61b985572f480a0b6afdc68edcdbc Reviewed-on: https://chromium-review.googlesource.com/924762Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537505}
-
Xing Liu authored
This CL polishes InMemoryDownload and adds ResponseWriter to support download pause and resume API. Also avoid an unneccessary data copy from URLFetcher to InMemoryDownload that the default StringWriter must copy out the data. Bug: 809674 Change-Id: Ic86ce2a35109c21951c42d9e759b980eb116a42c Reviewed-on: https://chromium-review.googlesource.com/918061Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537504}
-
Ian Kilpatrick authored
Reverts part of https://chromium-review.googlesource.com/c/chromium/src/+/920326 If TypedOM doesn't ship in 66 this means that we won't break paint worklet. (We still need to expose these two classes). Bug: 812432 Change-Id: I358d49fecdf2169911c72dac758a745067dd5c96 Reviewed-on: https://chromium-review.googlesource.com/924604 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537503}
-
Rintaro Kuroiwa authored
- D3D11CdmProxy allows injecting stream type GUID, protocol, function IDs for possible different implementations that use D3D11. - D3D11 mocks for testing. Bug: 787656 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id491699da9a03ab279f8cbc860007bc0ddc94695 Reviewed-on: https://chromium-review.googlesource.com/792590 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#537502}
-
Aleks Totic authored
Implements https://quirks.spec.whatwg.org/#the-html-element-fills-the-viewport-quirk It computes percentage resolution size, and minimum size for HTML/BODY. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie8cd0ed44df10e753d8658bbe3f4a253d9d4c9f4 Reviewed-on: https://chromium-review.googlesource.com/912609 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#537501}
-
https://pdfium.googlesource.com/pdfium.git/+log/53279b1dcaba..f51cdbd2bddd $ git log 53279b1dc..f51cdbd2b --date=short --no-merges --format='%ad %ae %s' 2018-02-16 hnakashima Reland "Actually enable -Wimplicit-fallthrough for pdfium." 2018-02-16 rharrison Correct mapping text to characters for characters missing from font 2018-02-16 hnakashima Fix more fallthroughs before reenabling -Wimplicit-fallthrough. 2018-02-16 hnakashima Fix mouse pointer in XFA forms. 2018-02-16 thestig Roll DEPS for clang to a695c30c. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I31876b61beaf64714b0894852ed6a0631312ec66 Reviewed-on: https://chromium-review.googlesource.com/924612Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537500}
-
Ryan Landay authored
This change makes the Memex button (which replaces the tab switcher button if a flag is enabled) open the Memex UI in a new tab if it's not currently open (to avoid clobbering the current tab), or if a Memex tab is already open, switch to that tab. Change-Id: I71056e004bea7ad998d418d056aad298d71ba5b2 Reviewed-on: https://chromium-review.googlesource.com/922460Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#537499}
-
Victor Costan authored
ChromeBrowsingDataRemoverDelegateTest.RemoveSafeBrowsingCookie* are flaking due to errors in the cookie store. It seems like the cookie store is initialized incorrectly. Disabling until we can investigate whether the problem is in the test setup or in the cookie store initialization sequence. TBR=msramek@chromium.org Bug: 812589 Change-Id: I174790c0ed3518b88eca3e45304015113d5a5ba8 Reviewed-on: https://chromium-review.googlesource.com/924761Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#537498}
-
Siddhartha authored
The test produces too much output due to leaks in html parser. https://crbug.com/804853 BUG=806988 TBR=bsep@chromium.org Change-Id: I12b45a16bd25e320021dc495e6031924ba1ac3a5 Reviewed-on: https://chromium-review.googlesource.com/924462 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#537497}
-
Dave Schuyler authored
DomSerializerTests.SerializeHTMLDOMWithMultipleMetaCharsetInOriginalDoc TBR=jam@chromium.org Bug: 812904 Change-Id: Id1cc947c0135536229de1e73d595cdd4323a0759 Reviewed-on: https://chromium-review.googlesource.com/924686 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#537496}
-
Kenneth Russell authored
Until a pyobjc wheel can be provided in Chrome Infra's vpython environment, which will require a few more steps, manually run this test with the system Python which has pyobjc built in. This will allow vpython-as-python to be deployed everywhere, and then more changes to be made on top. TBR=ccameron@chromium.org Bug: 776804, 804174, 812693 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib6a3a19ff30f2ecb72f51a23ffa028b6789f3ddb Reviewed-on: https://chromium-review.googlesource.com/924614 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537495}
-
Ryan Hamilton authored
outparam and compute the HTTP/2 weight in addition to the parent stream ID, and exclusive bool so that callers do not need to. Change-Id: I13ebd842f86b5aed9e517a0dc94612c8007af33f Reviewed-on: https://chromium-review.googlesource.com/915108 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#537494}
-
James West authored
Allow CastWebView to be created and WebContents retrieved so that a WebContentsObserver can be added before navigating to the URL. Bug: internal b/73180315 Test: cast_shell_internal_browsertests Change-Id: I0c47b5f3c1dca4fe9384c6675b3edf6acd51c793 Reviewed-on: https://chromium-review.googlesource.com/923714Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: James West <jameswest@chromium.org> Cr-Commit-Position: refs/heads/master@{#537493}
-
John Budorick authored
Bug: 755920 Change-Id: I00b0b7c195c94f2c8e967d4c85c8155073b9256e Reviewed-on: https://chromium-review.googlesource.com/879177Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#537492}
-
Daniele Castagna authored
When HardwareDisplayController::RemoveCrtc is called, planes in old_plane_list, that is the list of planes last committed for scanout, should be disabled. Before this patch the planes would not be disabled and would unexpectedly show up on displays where the old crtc would get reassigned. Bug: b/72749390 Test: plugged in a secondary monitor while an overlay is displayed on the primary. Change-Id: I76675a765d0ed9572baaf457060c2d7dac619614 Reviewed-on: https://chromium-review.googlesource.com/924347 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#537491}
-
Robert Sesek authored
A TYPE_DEFAULT MessageLoop was previously backed by a native MessagePump, but switched to a MessagePumpDefault in 8e6fc5fe. Bug: 812572, 753544 Change-Id: I49c53766067fb69642d5835668c066861d21803f Reviewed-on: https://chromium-review.googlesource.com/923584Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#537490}
-
https://webrtc.googlesource.com/src.git/+log/1c9aa1ea6693..85904f4ee8b4 $ git log 1c9aa1ea6..85904f4ee --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I786b446201064f03ba687cad3780813359320e34 Reviewed-on: https://chromium-review.googlesource.com/924631 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537489}
-
Xiaocheng Hu authored
For normal boxes, self hit test is done when HitTestAction is kHitTestForeground. However, for blocks, it's done only when HitTestAction is kHitTestBlockBackground or kHitTestChildBlockBackground (see LayoutBlock::IsInSelfHitTestingPhase()). Our NG hit test implementation doesn't consider the latter case, which is fixed in this patch. This patch adds 200+ passes to NG layout test. Bug: 812470 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I03f92444eb431151942eb582305ef63419090a35 Reviewed-on: https://chromium-review.googlesource.com/920687 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#537488}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/455a5336..22ef1d88 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia31dc0be73fe985fd872d800cf2abe160c49c16b Reviewed-on: https://chromium-review.googlesource.com/924343Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#537487}
-
Stefan Zager authored
This is a performance optimization in the same vein as PaintLayer (https://chromium-review.googlesource.com/854628). Since EmbeddedContentView::FrameRect() now has to compute its location, this patch tries to minimize the number of calls, in particular when only the size of the frame rect is needed. BUG=811457 R=chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8285b91519d461ae5230796f4355e8b814f756cb Reviewed-on: https://chromium-review.googlesource.com/923427Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#537486}
-
edchin authored
Bug: 804496, 804497 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I05b6627c4eb9ab6ae33e337631b7f1e70466730c Reviewed-on: https://chromium-review.googlesource.com/924650 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#537485}
-
Alexander Alekseev authored
This reverts commit ef052a2f. Reason for revert: this (with the previous CL 648979) brpoke builds for devices that do not have CUPS. Original change's description: > Add support for OOPIF printing in renderer > > These mainly include painting placeholders for cross process subframes, > sending messages to browser to inform printing such subframes, > serialization and deserialization of printed content, and compositing > these contents into the final result. > > The high level design doc is at goo.gl/CF1RUy, and browser side change > is at https:/crrev.com/c/822155. > > BUG=455764 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I15066f46da41d416356cad7392efb669b5f9f024 > Reviewed-on: https://chromium-review.googlesource.com/838512 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Commit-Queue: Wei Li <weili@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537243} TBR=dcheng@chromium.org,thestig@chromium.org,weili@chromium.org,vmpstr@chromium.org,alexmos@chromium.org,khushalsagar@chromium.org Change-Id: I58a03469bf216957f190e23a3795de472ca58402 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 455764, 813246 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/924486Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#537484}
-
Tom Anderson authored
dbus_unittests relies on the presence of /usr/bin/dbus-launch, which is provided by the dbus-x11 package. The absence of this package is currently causing dbus_unittests to fail on the Linux Xenial bot. BUG=789768 R=dpranke NOTRY=true Change-Id: Ic844648f3651e518e276c1fb764849b09145b34b Reviewed-on: https://chromium-review.googlesource.com/924693 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#537483}
-
Ryan Hamilton authored
Change-Id: Ia357ad7fcc51722ad6e2106d74bfaac569e94f13 Reviewed-on: https://chromium-review.googlesource.com/924652 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Cr-Commit-Position: refs/heads/master@{#537482}
-
Mike Wittman authored
Really fixes the Android test failure this time, by delaying the DCHECK on process type until after we've considered whether the OS is supported by the profiler. This has been validated by running the test on Android hardware. The suspected issue is that Android test is not setting the process type command line switch, which is being DCHECKed in the profiler code. This is a reland of 106dd071. Original change's description: > Second reland of "Encapsulate Chrome thread profiling setup into a single class" > > Fixes Android test failure by avoiding implicit creation of the render > thread. Also moves the decision on whether to profile extension processes into > the StackSamplingConfiguration, and cleans up comments. > > This is a reland of f8ad6e3e. > > Original change's description: > > Reland "Encapsulate Chrome thread profiling setup into a single class" > > > > This is a reland of aa63fc1d. > > > > Original change's description: > > > Encapsulate Chrome thread profiling setup into a single class > > > > > > Creates a simple abstraction around the fairly complex profiling setup. > > > This CL switches over the GPU and renderer process usage to this class. > > > The browser process usage will be converted to use this class after it > > > is extended to support periodic profiling (in a follow-on CL). > > > > > > Bug: 808588 > > > Change-Id: I6195571bf3ddd08291f288f475569bd9a88795ef > > > Reviewed-on: https://chromium-review.googlesource.com/905451 > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > > Commit-Queue: Mike Wittman <wittman@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#535125} > > > > TBR=sky > > > > Bug: 808588 > > Change-Id: I34f1910116c4e7a500e353c27b85bf7534be43c7 > > Reviewed-on: https://chromium-review.googlesource.com/907508 > > Reviewed-by: Mike Wittman <wittman@chromium.org> > > Commit-Queue: Mike Wittman <wittman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#535170} > > Bug: 808588 > Change-Id: Id34e6a3e57c144697413ecced43146bf3e6521e9 > Reviewed-on: https://chromium-review.googlesource.com/917197 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537023} Bug: 808588 Change-Id: Id93da3a3699b364e3d592823d4326b903b0c5a40 Reviewed-on: https://chromium-review.googlesource.com/923217Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#537481}
-
Mike Wasserman authored
This was added to support closing the app list bubble on Windows. At the time, Windows bubbles were constructed of two nested HWNDs. The app list bubble no longer exists and bubbles are now one HWND. Bug: 189112 Test: No Min/Max/Restore/Close windows system command behavior changes. Change-Id: I0a3ead068a54cb7c2a3ba44c4b7af7e38bcba2a7 Reviewed-on: https://chromium-review.googlesource.com/924315Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#537480}
-
Samuel Huang authored
_AddNmAliases() updates raw_symbols by adding symbols that have the same address as existing ones, but with different names. For example, let raw_symbols be: [A1, X, B1, B2, B3, Y, C1, C2], and suppose X can be replaced with [X1, X2, X3] and Y with [Y1, Y2]. The old code modifies raw_symbols in place by adding gaps first: [A1, X, B1, B2, B3, Y, C1, C2, ?, ?, ?], then move elements to gaps (! are overwritable, including Y): [A1, X, B1, B2, B3, !, !, !, ?, C1 ,C2], then writes the new symbols in reverse order: [A1, X, B1, B2, B3, !, !, Y2, Y1, C1 ,C2]. Repeating (X writable): [A1, !, !, !, B1, B2, B3, Y2, Y1, C1 ,C2], [A1, X3, X2, X1, B1, B2, B3, Y2, Y1, C1 ,C2]. The code works but is rather complex, and it reverses the order of new symbols inserted. This CL simplifies the code by allocating a new array, and insert new symbols in order (of whatever |names_by_address| returns). The obtained result for the example would now be: [A1, X1, X2, X3, B1, B2, B3, Y1, Y2, C1 ,C2]. Note the change of new elements' order. As a result, this CL affects patch content, and requires change in test data. The computation time of _AddMnAliases() is negligible (~0.1s). Change-Id: I5bfb7cceb9e1ebbdf493cea55c92144581721b40 Reviewed-on: https://chromium-review.googlesource.com/922986Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#537479}
-