- 12 Nov, 2020 40 commits
-
-
evliu authored
This CL updates the SODA components to use the local state (AKA global prefs) instead of profile prefs to keep track of the SODA file paths. Bug: 1147587 Change-Id: Ic6039558eeee07f07aa3509b2f6fd9d48d4e9ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530590Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#826912}
-
Anne Lim authored
Bug: 1135847 Change-Id: I8e378bcdfed0446abcf89731b1b32959e52b980d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531359 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826911}
-
Domenic Denicola authored
Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI Further work on removing origin trial code and the flags is tracked in https://crbug.com/1148056 and https://crbug.com/1148057. Bug: 1042415 Change-Id: Icbeecd0b592c76d36e2111b8e4d8fe30dbb63343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533145 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#826910}
-
Jazz Xu authored
Remove artist visibility change in OnNewMediaSession since artist visibility is set in SetArtist(). Change-Id: I455c0a169b06e320db3a0f758dd5b48d59881a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533283 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Auto-Submit: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#826909}
-
Fabrice de Gans-Riberi authored
Bug: 1147941 Change-Id: Id88d06e4be726d745ced8a0944b0cfbf9241d42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532861 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826908}
-
Nektarios Paisios authored
What is considered a document object had two different definitions in accessibility. This patch switches to using one source of truth in ax_role_properties which has a slightly more expanded definition. The only affected code path is in the use of ISimpleDocument, a deprecated accessibility interface. An upcoming patch should remove the kDocument role from ui::IsDocument and rename that method to IsWebRoot. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ifae5f3d879c5ef2cbe708d3d64e9fde41c56858f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532667 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#826907}
-
Ramin Halavati authored
|Profile::IsSystemProfile| returns true for both regular and off-the-record profile of a system profile. Therefore for any p of class Profile, we have: p.IsSystemProfile() == p.GetOriginalProfile()->IsSystemProfile() This CL removes the unnecessary calls to |GetOriginalProfile| and is not expected to make any functionality change. Bug: 1142370 Change-Id: I75d3d520042dfcead682fd5b1b2947830d56de28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523171Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Owen Min authored
The feature is also behind the policy that is controlled by an admin console's experimental. Change the flag to default on to simplify the rollout. Bug: 1137964 Change-Id: Ic2d02caad8b3ae9b314cbe7c06c6f74a967a8be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532992 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826905}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2089adc62a67..01e969da3318 2020-11-12 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 0573714bfd0f to 1995ddf876ef (19 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I9cbf9a6f7a28c96b5f9cc486de679fb4e353ed80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826904}
-
Julian Pastarmov authored
This change moves migrating of renamed policies from the PolicyHandler to a PolicyMigrator that happens right after the PolicyMerger has run. This guarantees that list policies can be properly merged between sources even if different sources provide different naming. BUG=1138572 TEST=browser_tests:PolicyPrefsTest.PolicyToPrefsMapping Change-Id: Ibe335176ef52dabbe09c076ba57ae04d1c67c1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507771 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#826903}
-
Michael Hansen authored
This reduces the height of the onboarding dialog, and updates spacing between other elements to fit the new height as well as to come inline with the spec. Screenshots: https://screenshot.googleplex.com/4KC2SMGEsQDDcZZ.png https://screenshot.googleplex.com/8wWbvuyZS5iS5YJ.png https://screenshot.googleplex.com/8v8wrjAfj2cMH5M.png Spec: https://carbon.googleplex.com/cros-ux/pages/nearby-share/onboarding-flow Bug: b:168841167 Change-Id: I311ca41b8c9269ba1c66ea1f86147894329e09d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530284 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#826902}
-
Nico Weber authored
This is a reland of 3aed6673 The change seems to make ld64 segfault sometimes. It's not clear why, but I'm guessing it's related to how we passed the filelist to ld64 previously, but now we hand the rspfile to clang which reads it and then re-writes it as rspfile internally. This reland only relands the bit for "alink", which calls libtool directly and doesn't involve either clang nor ld64. This part is hopefully safe to land. Original change's description: > Reland "mac/ios: Use real response files instead of -filelist." > > This is a reland of 5e46febb > > Original change's description: > > mac/ios: Use real response files instead of -filelist. > > > > Xcode 12 added support for real response files, so let's use them. > > Allows making response file contents more like on other systems > > (libs, solibs, frameworks, swiftmodules now go in the rsp file too), > > and makes it theoretically possible to have object files with spaces > > in their name. > > > > No intentional behavior change. > > > > Bug: none > > Change-Id: I8c2d6ff1abd47261bf7674dc7bf4506814681ad4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527621 > > Auto-Submit: Nico Weber <thakis@chromium.org> > > Commit-Queue: Brett Wilson <brettw@chromium.org> > > Reviewed-by: Brett Wilson <brettw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825480} > > Bug: none > Change-Id: Ib355508d2d45ab3ddf9ece76b6e95106c784fde9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530350 > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826282} Bug: 1147968 Change-Id: I0d077355924569ef537da7e66c4d346ec5fc6eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533546 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#826901}
-
Alex Newcomer authored
Before it was not getting hit on all code paths. Bug: 1148396 Change-Id: I95c3d4a2a63f167dfc3d7bb94fc3dbc4af0bd132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535214Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#826900}
-
Brandon Wylie authored
TBR=boliu@chromium.org Bug: 1148388 Change-Id: I8558ea2d31d30aad96755d18bed3a2f728895174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534695Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#826899}
-
Mike Dougherty authored
Messaging from chrome url pages was broken when the page was loaded by navigating from chrome://chrome-urls because the webUI object was being cleared in |CRWWKNavigationHandler webView:didStartProvisionalNavigation|. Navigating to an app specific URL is only allowed in certain situations, one of which is when the page is loaded by clicking a link on another app specific URL. So, update the logic to handle this scenario. Bug: 1140780 Change-Id: I9fbdca65487ce7c3e287922f1c98fa11da1c2d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518192 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826898}
-
Gang Wu authored
Bug: 1145671 Change-Id: I17ea9d42403b106a9f8ca00646e78c67ac3d1eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521165 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#826897}
-
Adam Norberg authored
This follows up on CL feedback from Robert Sesek on https://chromium-review.googlesource.com/c/chromium/src/+/2453800 which arrived after I already submitted the CL. Bug: 1135692 Change-Id: I868fbfe366a08d27263a313afa698bdcebe9c151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508325Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Cattalyya Nuengsigkapian authored
- Add a feature flag for desks-restore. - Store a primary user active desk in user prefs and restore it after a crash and a logging out. # TODOs - crbug.com/1143997 : secondary users should restore to a default active desk when the crash happened in their sessions. - crbug.com/1145404 : consider adding an UMA metric for restoring desks. Bug: 996999 Test: Manual test, ash_unittests --gtest_filter=DesksRestoreMultiUserTest.DesksRestoredFromPrimaryUserPrefsOnly Change-Id: I301b394b147468474233af507a263a2d9d38fe53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507399Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#826895}
-
Katie Dillon authored
Change-Id: Ia274d2e51503514c3fc98420fa4eee5eb040e1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490782 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#826894}
-
Laís Minchillo authored
Add a method in AwDebug to set CPU affinity to little cores in WebView. Bug: 1111789 Change-Id: Iece9bd27d60ec0338da88abf6a69c59dc4268e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521612Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#826893}
-
Owen Min authored
Disable AwSettingsTest#testTextZoomAutosizingWithTwoViews due to flaky. Bug: 1147937 Tbr: boliu@chromium.org Change-Id: Ia3f0cdcbe10717ee2eec415a6da6cb1b74d32996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534402Reviewed-by:
-
Rushan Suleymanov authored
Clients will send the flag which will indicate that the client is not aware of any other clients. This is useful to prevent trying to send invalidations from the server. The single client flag is calculated based on known device infos. Devices which don't have recent enough updates are considered non-active. Bug: 1145942 Change-Id: Ia24cb880e361b65796ea8c516ef38c1bfed58b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533775 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/fcafd5b49266..e258cf5e7aa9 2020-11-12 dneto@google.com Roll back googletest to earlier version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Idaadbe9ec81d212caf9c2978891d0050b5615e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534623Reviewed-by:
-
Morten Stenshorne authored
The main motivation behind this change is to get the code out of the way when interrupted by spanners. In such cases there may be space left in the fragmentainer when finishing the fragment before the spanner (i.e. the last piece of column content before the spanner), but this should neither be part of the fragment nor consumed block-size. We used to include the remaining space of the column interrupted by a spanner in consumed block-size, so that a node with fixed block-size would have this subtracted when generating fragments after the spanner (causing us to use less space on the node than we should). Bug: 829028 Change-Id: I7990532474b45ef20900455da75b8337d08c62fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532467Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#826889}
-
Trevor Perrier authored
This CL removes two things related to native resources not loading with an override locale. - First, logging on ResourceBundle paths is removed. - Second, a call to SplitCompat.installActivity that was added to try to fix the issue but did not work is removed. Bug: 1143026 Change-Id: I4136be98ca5103d91cc1340fd6252b513ab63e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531661 Auto-Submit: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Clark DuVall authored
This required moving ChunkedByteBuffer to //components/speech to be shared between //chrome and //content. Bug: 949535 Change-Id: I0c58762bd4c47123f9c36778c3d02b8d2da65564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533854Reviewed-by:
Evan Liu <evliu@google.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826887}
-
Gordon Seto authored
Add UI with mock data for the eSIM Profile discovery page. Screenshots: https://screenshot.googleplex.com/6APFxT6GKtLqNNd.png https://screenshot.googleplex.com/AMcw2z4myKRKQTs.png Bug: 1093185 Change-Id: I5216bb2f91b58578bbf4f2918ab21f9a78727324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523521 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826886}
-
Brandon Wylie authored
TBR=wychen@chromium.org Bug: 1148365 Change-Id: Ic52c628790c9d7fc7673b5ba83185af6cafe1a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535014Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a feature flag to control reparsing server predictions following dynamic form changes. Bug: 1140480 Change-Id: Ic0520f197d766fedab96c5c30d089bba49ef3e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534857Reviewed-by:
Maria Kazinova <kazinova@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#826884}
-
ckitagawa authored
When under memory pressure, we need to make sure all objects exist and that the callback is the last thing resolved. Otherwise `this` might be gone. Bug: 1148268 Change-Id: I0bc7c5ec29b4189f19b7936b20fc7cd6b8489d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533900 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826883}
-
Brandon Wylie authored
TBR=fhorschig@chromium.org Bug: 1148376 Change-Id: I6f97f5934b0196c8e6aa92db9f17b5598f49ddec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535015Reviewed-by:
-
Matthias Körber authored
The features in the removed experiment have all been enabled by default. Change-Id: Ia80687aa8c68f560b4c4810136769fea195bf602 Bug: 1076175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521731 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#826881}
-
Ben Pastene authored
Appears to be causing shard #2 to timeout consistently. Bug: 1147992 Change-Id: I3e680dc18499c261b013f8b2cb04911e7eee5daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533202Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#826880}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/7b750dc7337d..1980095da7f4 2020-11-12 rharrison@chromium.org [inspector] Convert GetRemapped to be a pass through 2020-11-12 dsinclair@chromium.org [spirv-writer] Revert change to entry point name. 2020-11-11 rharrison@chromium.org [inspector] Add better support for remapped entry point names 2020-11-11 bclayton@google.com writer/spirv: Further reduce test boilerplate 2020-11-11 bclayton@google.com writer/spirv: Reduce test boilerplate 2020-11-11 bclayton@google.com wsgl parser: support multiple error messages 2020-11-11 sarahmashay@google.com remove redundant std::move to fix clang errors 2020-11-11 dsinclair@chromium.org Remove unused function 2020-11-11 dneto@google.com ast: intrinsic spelling matches the spec 2020-11-11 sarahmashay@google.com [validation] Update entry points validation v-0020 2020-11-11 bclayton@google.com wsgl parser: Tweak top-level unexpected token error message 2020-11-11 bclayton@google.com wsgl parser: Fix tests that have multiple errors 2020-11-11 bclayton@google.com wsgl parser: refactor statements() 2020-11-11 bclayton@google.com wsgl parser: add expect_lt_gt_block(), use it 2020-11-11 dneto@google.com spirv-reader: support OpDot, OpOuterProduct 2020-11-11 dsinclair@chromium.org [docs] Expand OpImageType documentation 2020-11-11 dsinclair@chromium.org [msl-writer] Emit texture types 2020-11-10 rharrison@chromium.org [inspector] Extract Sampled Texture data 2020-11-10 dsinclair@chromium.org [hlsl-writer] Emit texture types 2020-11-10 dsinclair@chromium.org [spirv-writer] Hash names 2020-11-09 bclayton@google.com wsgl parser: Have Expect & Maybe operator-> deref 2020-11-09 bclayton@google.com wsgl parser: Add ParserImpl::Maybe<T> 2020-11-09 bclayton@google.com wsgl parser: Add ParserImpl::Expect<T> 2020-11-09 bclayton@google.com wsgl parser: Migrate more code to use expect & match 2020-11-09 bclayton@google.com wsgl parser: expect for storage_class 2020-11-09 bclayton@google.com wsgl parser: expect for variable_ident_decl 2020-11-09 sarahmashay@google.com [validation] relax rule v-0002: return is mandatory for non-void functions 2020-11-09 bclayton@google.com wsgl parser: Remove pointless nullptr checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC sarahmashay@google.com,dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com,dsinclair@google.com Change-Id: Ibe39ff2a3c3c4ea40f737ce8289bab2ae0f6b71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534621Reviewed-by:
-
Viktor Semeniuk authored
This change replaces usage of AffiliationFetcher to HashAffiliationFetcher depending on the feature state. Bug: 1108279 Change-Id: I2398fc91ce14af80ef28a1e48dad61c60690366a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529109 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826878}
-
Guido Urdaneta authored
Prior to this CL, explicit max frame rates were not enforced if the configured frame rate for the source was less than or equal to the requested max frame rate. This has led to problems with webcams that produce a higher frame rate than configured. This CL changes the VideoTrackAdapter so that frame rate adjustments are disabled only for tracks that do not explicitly request a maximum frame rate. Bug: 1133796 Change-Id: I2e3769493449b552f9440c2a809b512bf9e3690c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534952 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#826877}
-
Joon Ahn authored
http://screen/Be2cQHGk3cZmE5f Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I6f6ef200659fdcd7e72a56d1d87328c72342ccb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530750 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#826876}
-
Dave Tapuska authored
In https://crrev.com/4bb0db09 I removed an early return for MainFrameImpl being null and added a CHECK. It is clear that CHECK is being hit (we've seen this in EndCompositorFrame as well with issue 1139104) and I speculate that the LocalRootImpl is non-null but MainFrameImpl is null. The only code that still accesses the MainFrameImpl is this piece of HandleGestureEvent as it hasn't been converted yet. Since branch for M88 is coming up silence this condition that was previously an early return. BUG=1148018,1146579 Change-Id: I1d214c8787fcd8e4dcfe5983752b3468373f7321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532990 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826875}
-
chinsenj authored
The {TabletOrClamshell} token is used in various different ash histograms but they all use the same variants. This CL extracts the variants into a common variants tag. Bug: 1140182 Change-Id: Ifd9b5233405b65308c09b24e0e6d7700eef2db3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533362Reviewed-by:Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Jamie Madill authored
This reverts commit e4620991. Reason for revert: Suspected for causing crashes on Windows/Intel. For more info see bug. Bug: 1148269 Original change's description: > Ignore unknown record types in DNS responses > > Previously worked only for address requests. Other request types (e.g. > HTTPS), on seeing any unrecognized (and therefore unparsable) record > type in the response, would fail the whole response as malformed. > > Bug: 1147247 > Change-Id: Icd9e5ab2e39cf09ffe7c3945b011ebf1d4b45778 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529619 > Commit-Queue: Eric Orth <ericorth@chromium.org> > Auto-Submit: Eric Orth <ericorth@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826462} TBR=mmenke@chromium.org,ericorth@chromium.org Change-Id: I03ea912d1a9c8a01be3d84a3f4d417c385f97c2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533548Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#826873}
-
