- 14 Nov, 2019 40 commits
-
-
David Black authored
Proactive suggestions controller logic in ash currently lives in AssistantUiController. It makes use of some of the same logic as standalone Assistant UI (e.g. for calculating usable work area). Proactive suggestions logic has grown and will grow again soon as we update triggering conditions (to only show UI as a result of user scrolling activity). This is going to further muddy the AssistantUiController if added to the code in its current state. To address this, I've refactored Proactive suggestions controller logic into AssistantProactiveSuggestionsController, a sub-controller owned by the AssistantSuggestionsController. It is fairly self-contained and copies some logic (e.g. for calculating usable work area) from the AssistantUiController. This will make it much easier to clean up the AssistantUiController when standalone UI is deprecated. Bug: b:142144655 Change-Id: I10f4892ae166618a588505d75634c6c18a7cc6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906935Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#715449}
-
Elly Fong-Jones authored
This change removes all dependencies on and mentions of DialogClientView from //cbui/views/autofill. The only wrinkle is that a couple of tests use GetViewByID() on the DialogClientView; these have been changed to use it on the RootView instead. Bug: 1011446 Change-Id: I8276c676d085c611cd27ababddad9fd60d849191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917542 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#715448}
-
Elly Fong-Jones authored
For this dialog, the LegalMessageLines parameter comes from SaveCardBubbleControllerImpl, which has two code paths to show this dialog. Both those code paths look roughly like this: if (already_showing_dialog) return; legal_message_lines_ = ...; ShowDialog(); and there are no other places that change legal_message_lines_, so it is effectively const across the lifetime of the dialog. Unfortunately, because the same SaveCardBubbleControllerImpl is used for several different concrete bubble subclasses, changing the behavior of ShowDialog to simply pass the message lines in as a constructor parameter (which would make it obvious that it's const for the lifetime of the dialog) is not easy to do. Bug: 1011446 Change-Id: I9b0584de8495b97f685b2973134e9d04873c317e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917520Reviewed-by: -
Elly Fong-Jones authored
These are all straightforward. Bug: 1011446 Change-Id: I3895608ba6b671dac81a36928f58bc4b72955b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917540Reviewed-by:
-
Nate Fischer authored
No change to logic. This re-enables a test which was marked as flaky. This passed 1000 local runs, so it appears it's no longer flaky. Bug: 984705 Test: run_webview_instrumentation_test_apk --num_retries=0 \ Test: --break-on-failure --repeat=1000 \ Test: -f SafeBrowsingTest#testSafeBrowsingProceedThroughInterstitialForSubresource Change-Id: I48bb6dbbeb1fa96f62d43da74de2a34255f2b3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911150 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#715445}
-
Evan Stade authored
This fixes navigator.language, navigator.languages and the ACCEPT-LANGUAGE http header. For now, the locale is only read at startup. In the future, WebLayer should listen for changes to the system locale and allow the client to specify an active locale that is not the system's default. LANGUAGE environment variable for Linux WebLayer shell. Navigate to test pages in linked bug, or google.com Test: set Android system language to non English, or use Bug: 1022616 Change-Id: Id680f38953c1a81fc155ef0d3434fa8fc0d59b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906635Reviewed-by:John Abd-El-Malek <jam@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#715444}
-
Eric Stevenson authored
To make debugging failures a bit easier. Also add reasons for LifetimeAssert and JNI wrapper classes. Bug: 1020936 Change-Id: Iccd027fa73baa6f7a56d97b6ac32e1d7283f48b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904752 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#715443}
-
Andrew Xu authored
In this CL, metrics are added for the following hotseat gestures: (1) The gesture to enter overview mode from home page. (2) The gesture to show/hide the in-app shelf. (3) Fling up the in-app shelf to show the home page. Test cases for the metrics are also created. Bug: 1018921 Change-Id: I86bdee0e28f28d222a03d1b474fb47b74e5b23f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906301Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Theresa Wellington authored
BUG=966644 Change-Id: I2d418578e03e42f4f6e638f1c21afb71ba202cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917750Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#715441}
-
liberato@chromium.org authored
Change-Id: Ic82967272461d063fdf4edc2b65028a59802397b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917979 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#715440}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/90df527f91c3..168bb0dc14f2 git log 90df527f91c3..168bb0dc14f2 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 swiftshader.regress@gmail.com Regres: Update test lists @ b2407dd7 2019-11-14 capn@google.com Rasterize 'Bresenham' line segments as parallelograms Created with: gclient setdep -r src/third_party/swiftshader@168bb0dc14f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/80135519 Change-Id: I19c4d2ae2f9b1399b42732ebdbbdc0e8664da4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917804Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715439}
-
David Trainor authored
We're still running an experiment and are about to add a few more experiment arms, so extend the metrics for the next few releases at least, as the events only happen once or twice an update. Bug: 1016400 Change-Id: Ibae4038579882ad4c96509f32aea70ffb464f228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917752Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: David Trainor <dtrainor@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#715438}
-
Matthew Mourgos authored
Bug: 1024623 Change-Id: Ie5ca2f8259598130d9d046520c568c562d13f28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915185Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#715437}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d347d8903a96..bacb84b99758 git log d347d8903a96..bacb84b99758 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 chrome-bot@chromium.org Update config settings by config-updater. 2019-11-14 dhanyaganesh@chromium.org chromite: Kill cros uprevchrome Created with: gclient setdep -r src/third_party/chromite@bacb84b99758 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I5b3400ab9520c229d56635e912fe9efae58879f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917801Reviewed-by:
-
Bailey Berro authored
Previously, there were 3 navigation stops on the Google Accounts row item in the People section with stops for 1) User name, 2) User email address, and 3) The subpage button, marked as described by the user name. With this change, there is now just one stop on the subpage button that is described by both the user name and user email. "Google Accounts, button, bailey test baileyberrotest2@gmail.com" Bug: 1012565 Change-Id: I2c44a308dca82e0e0669be8e9a04f97385fc85c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915188 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#715435}
-
Ilia Samsonov authored
Skipping manual test in test harness causing tests to fail due to timeout in some windows builders. Win7 Tests (dbg)(1) constantly fails on MANUAL_ tests: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 other builders fail or flake less frequently: Win10 Tests x64 Win7 (32) Tests win10_chromium_x64_rel_ng https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyfQsSBUZsYWtlInJjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlYlJ0Y0ludGVybmFsc1BlcmZCcm93c2VyVGVzdC5NQU5VQUxfUnVuc09uZVdheUNhbGw2MFNlY3NBbmRMb2dzSW50ZXJuYWxNZXRyaWNzV2l0aE9wdXNEdHgM Skipping these tests in launcher will resolve flakiness on these builder. Bug: 1020591 Change-Id: Ie2ea8510ab31a3c56b783f0e8b9bded98c21d9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909958 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#715434}
-
Esmael El-Moslimany authored
For example cr-camera's videocam-shutter has a red fill enclosed by a white stroke. In this case, the ripple should be white matching the outer region of the icon. Currently, --cr-icon-button-color to white for all cr-icon-buttons in cr-camera. There should be no change in behavior due to this CL. This CL is needed for a follow-up CL that removes --cr-icon-button-color. Bug: 1022752 Change-Id: Ib22042d8719aa8d4d54cea9c87ce1641e7f7994b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914515 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715433}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb53c26684a5..cc70a4f8a96a Created with: gclient setdep -r src-internal@cc70a4f8a96a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1021528 Change-Id: I7b4495c8e736001cd1216f3dc3712fc5c64c497f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917802Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715432}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6e5db55004d..3da78c4bb7dc git log e6e5db55004d..3da78c4bb7dc --date=short --no-merges --format='%ad %ae %s' 2019-11-14 jbudorick@chromium.org Revert git cache diagnostic tracing. Created with: gclient setdep -r src/third_party/depot_tools@3da78c4bb7dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1019824 Change-Id: Ifbfd2c41c4d5a063303996df407419767663c644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917803Reviewed-by:
-
Dale Curtis authored
Most output clients are expecting that |worker_cb_| will consume N frames and that subsequently the clock advances by N frames. Not calling the |worker_cb_| stalls these internal clocks. There's still the issue that tasks are incredibly delayed in the ScopedTaskEnvironment on macOS. I.e., playback will still be slower than realtime, but it at least won't be 0.25x as we spend forever trying to catch up before executing the callback. BUG=1003761,1014646 R=miu Change-Id: Iaa98d683ba77fa664f13da2436cb69bf834251ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898641 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715430}
-
Robbie McElrath authored
crrev.com/c/1900130 renamed //aw/apk to //aw/nonembedded, and crrev.com/i/2103749 removed the last //aw/apk dependencies. Now that the latter CL has landed, we can delete //aw/apk. Test: ninja -C out/aw Bug: 934152 Change-Id: I1e5322adfda9813d296ca0f027a75463db18efc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913597Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#715429}
-
Wei-Yin Chen (陳威尹) authored
Regain some coverage before we can fully deflake pixel differences. Bug: 1023299, 983170 Change-Id: Ia3d42a732e213377d97a4aefe2cc7eb8c63a1062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916300 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715428}
-
Peter Wen authored
Use trichrome_chrome_bundle instead. Removed: - trichrome_chrome_apk_pak_assets - trichrome_webview_for_bundle_apk - trichrome_library_for_bundle_apk - trichrome_chrome_apk Downstream target removed here: https://crrev.com/i/2095508 Bug: 1021196 Change-Id: I4b6e249f393adf6bb49d845aff430172c8658268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914604 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#715427}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3876a9f26706..3120d0337382 git log 3876a9f26706..3120d0337382 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 csmartdalton@google.com Revert "Reland "Reland "Implement sample mask and sample locations support in Vulkan""" 2019-11-14 kjlubick@google.com [canvaskit] Expose a few more methods 2019-11-14 fmalita@chromium.org [skottie] One-node camera support 2019-11-14 robertphillips@google.com Respect max index buffer sizes in GrFillRectOp::MakeSet 2019-11-14 csmartdalton@google.com Reland "Reland "Implement sample mask and sample locations support in Vulkan"" Created with: gclient setdep -r src/third_party/skia@3120d0337382 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:b/143572065 Change-Id: Iff43a23b69ac5bdca5cd760c3f93f0e4e289eb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917800Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7dbefa69. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." e83dd93c "Limit backtracking on regexp called from blink." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ia923889a3e7bd4fa5725fa25391f376bf4316ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917085Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715425}
-
Asanka Herath authored
This authentication handler has some custom logic for parsing Digest authentication challenges. We should have some fuzz coverage for it. Bug: None Change-Id: I53ebe3496daf763a2bfb83bfb5f5e90cbe2b02b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907157 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#715424}
-
Victor Vasiliev authored
The goal is to make QuicTransport easier to write by sharing state that is currently owned by QuicStreamFactory. This CL only factors out the connection helper. The other things to be moved in follow-up CLs would be: * QuicAlarmFactory * QuicParams * QuicConfig * Logic to configure UDP sockets and create a QuicConnection. R=rch@chromium.org Change-Id: I7fcd060c2e29dcc49396da4d56c62621fad24629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911080Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
For more test coverage. Bug: 561209 Change-Id: Ibcd2c1b854d4748fb948998da9def1279e6daded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911343 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
In order to not relying on render test that much, add verification about thumbnails being available on non-render tests as well. Bug: 983170, 1023299 Change-Id: I384cf6d428d14a2ade1f5936efa9d839fd2b996a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913714 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
TemplateUrlService initialization occurs via ProcessInitializationHandler.handlePostNativeInitialization() -> SearchWidgetProvider.initialize(), so this out-of-place load appears to be safe to remove. Bug: 1016957 Change-Id: Iffab09bd1ba90e082eff2b588855b55f63b2fab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915281 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#715420}
-
Peter Kotwicz authored
This CL introduces a new UMA metric - WebApk.NewStyle.Startup.Cold.ShellLaunchToSplashscreenVisible which measures the time elapsed between Activity#onCreate() of the activity which handles the launch intent and the ShellAPK adding the splash screen to the view hierarchy. The purpose of the UMA metric is to be comparable to WebApk.Startup.Cold.ShellLaunchToSplashscreenVisible BUG=1000949 R=hartmanng,dominickn,rkaplow TBR=yfriedman (For code deletion in IntentHandler) Change-Id: I934297febaba5e6c8c8f5087c770542ede27f257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786720 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715419}
-
manuk authored
Change-Id: I96e6877c3c1eee0161208b9f4d776dac2f82b4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917330Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715418}
-
Kevin Ellis authored
Previously, the pending pause and play flags were reset in Animation::Update. The flags should be reset when the animation is ready (received start notification or stopped a running animation). This change will affect when Animation::pending() changes state from true to false. The next step is to reset these flags inside of play and pause tasks per spec, which requires further cleanup of the use of PlayStateUpdateScope. The following patch introduced a subtle bug to the timing of notifications to devtools > Animations, whereby the devtools notification could fire a start notification before the start time was received. https://chromium-review.googlesource.com/c/chromium/src/+/1822321 Fixing the timing of the pending task resets forces the devtools notification to sync with the start of the animation, which in turn undoes the faulty perf improvement seen in 1822321. Bug: 960944 Change-Id: Icbcf546614570e1936bec3db94facb1b5bfc4e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873905Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#715417}
-
Ben Pastene authored
And fix //third_party/android_sdk/OWNERS to prevent presubmit warnings when touching //infra/OWNERS. Change-Id: I4cfaed0f2dfa8b4b2f81e341e8492febe4f83995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916964Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#715416}
-
Tommy Steimel authored
LoginTest.GaiaAuthOffline is failing often on the linux-chromeos-google-rel bot. Example failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/9135 Disabling the test for now TBR=antrim@chromium.org Bug: 1023591 Change-Id: I1aced34639a552c0badea33f3787358d898c5b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917879Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715415}
-
Tommy Li authored
Previously, both ChromeOS launcher and NTP ZeroSuggest avoided calling MaybeCullTailSuggestions. This was because MaybeCullTailSuggestions did not handle the no-default-match case. This was fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/1872485 So this carveout / special case is no longer needed, and in fact, no longer desirable. Going forward, we aim to support the no-default-match case as a first-class citizen in the autocomplete world, so we are working to eliminate all these special cases in the codebase. Bug: 1016845, 363656 Change-Id: Ic42bb0d6e114393b03df20cf218a6e328bd197dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913566 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#715414}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3f3aa545f7de..5bd6ca022650 git log 3f3aa545f7de..5bd6ca022650 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 brcui@microsoft.com Revert: DevTools: Fix NVDA screen reader Enter keypress hiding settings pane https://chromium-review.googlesource.com/c/chromium/src/+/1848114 Created with: gclient setdep -r src/third_party/devtools-frontend/src@5bd6ca022650 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1023755 Change-Id: If1d52c6ae732162ac1b727ae073f26599980c269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917799Reviewed-by:
-
Regan Hsu authored
Currently, on tablets, if you tap on the "Set up PIN" button, the entire row is highlighted grey. The row should not be highlighted at all when the button is tapped because it is a bad experience for the user. This CL ensures when the user taps on the "Set up PIN" button, the row is not highlighted grey. Fixed: 1020087 Change-Id: Icba9e6db6b3e561fb124c2b9cb06ae43c982ae6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913483Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715412}
-
Andrew Grieve authored
* trichrome_shared_assets GN arg * references to o_mr1 and p in config.gni Bug: 1003532 Change-Id: Ib3c9df5638ed8b336457b9dc9a450ffc9b578879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916681 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
-
Yun Liu authored
Bug: 1008894 Change-Id: Icbf5e6212a63cedd87f7c0a829824e415a21b0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911701Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#715410}
-
