GitLab

Bug: 678128
Change-Id: I77057cf8f630668d07fa93f9c4d09fefae187aa3
Reviewed-on: https://chromium-review.googlesource.com/1013054
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555154}

Real world reports show we are sometimes promoting elements to be the
root scroller when that's clearly not wanted. This patch adds further
restrictions so that we promote in fewer situations. Namely, we avoid
promoting an element if:

1. It isn't visible
2. It doesn't have overflow
3. The main document has overflow and allows scrolling it

Bug: 815068
Change-Id: I51aa03c23c67c7bd9c29b4fd119b89fc1f88ca24
Reviewed-on: https://chromium-review.googlesource.com/1035449Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555153}

This patch re-implements 'text-overflow: ellipsis' in LayoutNG.

Before this patch, it was implemented in NGLineBreaker. It
helped sharing the code with other line breaking logic, and
working in logical coordinate made things simpler. However,
some tests fail due to taller fonts/objects in the hidden
part, or when out-of-flow/float objects in the line. While
these look edge cases, given the high usage of the
'text-overflow' property, this patch fixes them by moving
the logic to NGInlineLayoutAlgorithm.

The logic is largely independent and that it is moved to
a new class, NGLineTruncator.

This patch also uses a new ShapeResult::OffsetToFit()
function added in CL:1020760 for more accurate truncation.

Relative position is not supported yet. And tests for
inline-block container still fail, they will be investigated
in following patches.

Bug: 636993
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Idb0d80b239d9f53cd6a4878a9378f5bfbc0d24ea
Reviewed-on: https://chromium-review.googlesource.com/1013019
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555152}

The test class now works with frame requests when the network service is disabled.

This change also:
-removes the DCHECK in PageLoadTracker::WillProcessNavigationResponse since intercepted requests won't have a request ID (since they didn't go through ResourceDispatcherHost)
-makes NavigationURLLoaderNetworkService::URLLoaderRequestController::OnReceiveResponse handle receiving a response when there's no net::URLRequest, for the same reason as above

Bug: 776589
Change-Id: If68216f77ab08659bb65c6c37efca6ed9396a47a
Reviewed-on: https://chromium-review.googlesource.com/1037769Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555151}

CdmInfo will now keep track of the encryption schemes supported by each
registered CDM. For component-updated Widevine, this will be determined
from the manifest. For built-in CDMs, this list is compiled in.

The set of encryption schemes supported is also passed to KeySystemSupport.

BUG=657957,658026
TEST=new content_unittests pass

Change-Id: I444091035e7ae1bc18720aff5bfea86afeca5ba7
Reviewed-on: https://chromium-review.googlesource.com/1019884Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555150}

It doesn't seem like there's any reason to defer auto-resize embeddings
anymore. There was a concern way back when about re-entrancy and flicker:

https://codereview.chromium.org/9702068

Child allocated LocalSurfaceIds address both of these issues.

Change-Id: Ieaefdf517f7c6c14d0e6a8ac496e233798185dc0
Reviewed-on: https://chromium-review.googlesource.com/1036501Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555149}

This CL adds a test case for the case of resolution change (which
bit me in crbug.com/834146). In the process, a few common
VaVDA<->test harness subsequences are factored out into methods:
- QueueInputBufferSequence
- AssignPictureBuffersSequence
- DecodeOneFrameFast

which allows to simplify other test cases. Finally, the test case
SupportedPlatforms() is moved around untouched.

Bug: 717265
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic19d89c1355eb74d12658f5fee04eaf17ee39c6e
Reviewed-on: https://chromium-review.googlesource.com/1020303Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555148}

This is part of go/chromeos-sts-on-screen-ui, which requires the chrome process
to be able to communicate bi-directionally with the Select-to-Speak extension:
Chrome must be able to request Select-to-Speak to change states, and must get
notified whenever Select-to-Speak's state changes.

1. This change hooks up the extension receiving requests from Chrome to change
state, although the implementation of changing state logic in the extension is
currently a TODO.

2. This change also hooks up the extension communicating its state back to
Chrome, although the accessibility_extension_api method that receives the call
is implemented as a TODO after converting accessibility_private state into a
more universal mojom::SelectToSpeakState state.

Note: We need mojom::SelectToSpeakState because chrome needs to communicate
state changes through to the shelf in Ash, so the enum needs to be usable across
processes.

The next changes will complete the TODOs in 1. and 2. above.

Bug: 753018
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia1785a85adea02b3e60ed2e60525012d166e7ad2
Reviewed-on: https://chromium-review.googlesource.com/1030901
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555147}

The navigation performed in the MemoryInstrumentationTest::Navigate
method is using a non-existing file, which means the navigation does
not succeed. This CL fixes the code to use a file that exists and
to check the navigation is actually successful.

Bug: 838161
Change-Id: Icf0715f687a1cdf763b47e3bd3155321e761af96
Reviewed-on: https://chromium-review.googlesource.com/1037637Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555146}

This also adds some plumbing that will be used later for variable tab
corner radii, and safes a few spots against crashes on startup (found
when testing with unusual mode combinations, e.g. TRAILING NTB in
non-MATERIAL_REFRESH mode).

BUG=822037
TEST=none

Change-Id: Iba16ab3f238887c0c93feac67451c36a7317e389
Reviewed-on: https://chromium-review.googlesource.com/1029422Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555145}

Bug: 837565
Change-Id: I69f5061cfd9352fd2976cdea0f4d1b43f423163d
Reviewed-on: https://chromium-review.googlesource.com/1036605Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555144}

Previously move-only types are not supported in gmock so we had to use a
hack to workaround the issue. Now this is supported by gmock, and we can
mock those methods directly.

This CL only updates mock_filter.h and related tests. More changes will come
later.

Bug: 759710
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7ed40687c0eb2248b6f04989bad94e7bb17e37ba
Reviewed-on: https://chromium-review.googlesource.com/1036649Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555143}

Allow Console to evaluate without throwOnSideEffect when the entire
expression meets the same strict conditions used by JSAutocomplete.

Bug: 810176
Change-Id: If5c80250cd75d81eec1e495d0414903213fac930
Reviewed-on: https://chromium-review.googlesource.com/1028934
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555142}

Bug: 837753
Change-Id: Iaf98bcb0b98b096880a0e888da690e411505b3c4
Reviewed-on: https://chromium-review.googlesource.com/1037245
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555141}

Move many but not all WebAudio AudioParam tests to WPT.

The criteria was whether Firefox passed the tests or, if not, the
errors are actually bugs in Firefox.  Most of the failures are because
Firefox threw the wrong type of error.  We also skipped over most of
the tests that use offline.suspend().

Bug: 745778
Change-Id: If4755089938ddf1b9825faa3392d1d10e3b9293f
Reviewed-on: https://chromium-review.googlesource.com/1036456Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555140}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Iaad06800c9481fb681d957ef11aa927829d71d3f
Reviewed-on: https://chromium-review.googlesource.com/1037190Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555139}

Add flag states and preload version to chrome://media-engagement
to make it easier to diagnose bugs in MEI.

BUG=835938

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I736f17f5b020b459c236abdabd9d0961efea29d3
Reviewed-on: https://chromium-review.googlesource.com/1024805
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555138}

Wrap file path references with "EnsureFileExists()" which acts as a
simple identity function, except for invalid paths for which it
raises IOErrors.

Bug: 837200
Change-Id: Ie718cd5517415b375ed3bf5d5112d59b32074c04
Reviewed-on: https://chromium-review.googlesource.com/1037778Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555137}

This CL standardizes the |natural_size| computation in all decoder
implementations to use the decoded |visible_size| and the
VideoDecoderConfig's pixel aspect ratio.

Bug: 766657, 837337
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I01a5bd59c353d6f07fd02c9fc3d3e64ab1a04434
Reviewed-on: https://chromium-review.googlesource.com/1026992
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555136}

Precursor for
https://chromium-review.googlesource.com/c/chromium/src/+/1035788

TBR=fdoray@chromium.org

Bug: 825327
Change-Id: Ic6e7440c152dde11b6cab9c1ccddd46106d48d8b
Reviewed-on: https://chromium-review.googlesource.com/1037634
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555135}

It would be good if we could use `gn refs` to tell us which
target generated a given executable. The docs suggested that
refs should do this, but it doesn't appear to do so.

Bug: 837876
Change-Id: I45f45bb3346ed21ede83fbacdea2207f1322ad69
Reviewed-on: https://chromium-review.googlesource.com/1033506
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555134}

This CL adds:
- Ctrl + Search + M to toggle the fullscreen magnifier on/off
- Ctrl + Search + D to toggle the docked magnifier on/off

It also adds their entries in the keyboard shortcut helper,
and the keyboard overlay.

BUG=838310
TEST=Added new test.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I65119263a39f3630118c87332099c7ec7e73439a
Reviewed-on: https://chromium-review.googlesource.com/1036533Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555133}

Log intentional kill UMAs yet a new histogram entry.
This time, instead of logging all possible combinations of states that
we might care about, aggregate them into counts on the client side
directly. So it's not really a "histogram" exactly. The up side is
that this will be easily extensible in the future.

Add renderer visibility to TerminationInfo which is needed for one of
the new UMAs.

Bug: 693484
Change-Id: I9bf4cc8cfa969a8098bcdabf002585f0bf4a713a
Reviewed-on: https://chromium-review.googlesource.com/1032093Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555132}

https://pdfium.googlesource.com/pdfium.git/+log/ea603b9f0baf..b5902c780751

$ git log ea603b9f0..b5902c780 --date=short --no-merges --format='%ad %ae %s'
2018-05-01 hnakashima Fix possible integer overflows in CFX_RTFBreak.
2018-05-01 thestig Add struct CJBig2_GRDProc::ProgressiveArithDecodeState.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:838095


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I0b6eee2a9f50d795a803b5dac8dfeea010c07e68
Reviewed-on: https://chromium-review.googlesource.com/1036940
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555131}

The revised comments more accurately reflect the current runner
behavior.

Bug: 808057
Change-Id: I4b193241a26034d608f3e1281eea7f4ce21dd510
Reviewed-on: https://chromium-review.googlesource.com/1037780
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555130}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/166bc4ceedaf..1eb58e1f8892

$ git log 166bc4cee..1eb58e1f8 --date=short --no-merges --format='%ad %ae %s'
2018-04-30 mmoss Add a recipe config to enable the bot_update "--with_tags" flag.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:825063


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I807cb34b62e6f5f71fd32fc8377242fef4ac9a41
Reviewed-on: https://chromium-review.googlesource.com/1037463Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555129}

Fuchsia, running on the test bots, was sometimes taking too long to
return data to AudioSyncReader (observed 21ms, max 20ms), which
lead to test flakes.


Bug: 838367
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If2e25357acd70eaa28c6e618e696cc39ea9ba372
Reviewed-on: https://chromium-review.googlesource.com/1036196
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555128}

When downlink client hint is attached to the request during main
frame navigation, convert kbps to Mbps correctly.

Change-Id: If0b12bb2eb0acc85ed64d349ca0e28f2c6a0b025
Bug: 838364
Reviewed-on: https://chromium-review.googlesource.com/1036190
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555127}

This CL ensures that popups, like the sogou popup, show up on standalone
VR devices.

To support popups on standalones, we have to turn VR mode off before
showing the popup, using the window focus change to know when to turn
VR mode back on.

Bug: 830041
Change-Id: I4771970fe5d4c13b6a3c9756aa6e8dbcf4689084
Reviewed-on: https://chromium-review.googlesource.com/1036204Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555126}

Created a java side mirror object to the class that can be parceled
into an intent so that it works with the FullscreenActivity code.

Change TabObserver from onToggleFullscreenMode to
onEnterFullscreenMode/onExitFullscreenMode so that we could pass the
FullscreenOptions around.

This change does not have any behavior changes as of yet it is just
plumbing passing options around.

BUG=829937

Change-Id: I8599df0e155de78704d70dd22f886cd94f68d6ff
Reviewed-on: https://chromium-review.googlesource.com/1030837Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555125}

https://chromium.googlesource.com/catapult.git/+log/859155b40806..4e78157a8a47

$ git log 859155b40..4e78157a8 --date=short --no-merges --format='%ad %ae %s'
2018-05-01 perezju [soundwave] Add pandas_sqlite.InsertOrReplaceRecords

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Iccb759f29763321b1455b9bae9d9d96ac94f02e3
Reviewed-on: https://chromium-review.googlesource.com/1037444
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555124}

Revision efe0c886 added a check to
verify that extensions that would be loaded in all cases (in order
to fix a crash in ExtensionPrefValueMap). However, this depended on
knowing the type of extension, which was determined by the manifest
(stored in the extension preferences). Unpacked extensions do not
store the manifest, so this caused a crash.

As a workaround, gracefully handle the case of the extension having
no manifest. This is only safe because the only type of extension
that we would still load with extensions disabled is a theme, and
themes do not need entries in ExtensionPrefValueMap. This is a
pretty ugly/hacky solution, but should work to fix the crash.

Also add a regression browser test for the same.

Bug: 836624

Change-Id: Ie7c766ceee261504b1d3f2cc570b7072e71e0f71
Reviewed-on: https://chromium-review.googlesource.com/1035448
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555123}

Bug: None
Change-Id: I8c9c12a5f958a16d191b1be555245fe27ebdebcb
Reviewed-on: https://chromium-review.googlesource.com/1037803Reviewed-by: Meggin Kearney <mkearney@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555122}

As per crbug.com/788027 Comments 1,6,7:
- Update checkbox text to "Don't show again"
- Move "Don't show" checkbox to content area
- Consolidate text into one paragraph
- Change title text to "Warning: Experimental feature"
- Remove X (Close) button from upper right

window to <account>".  Verify that dialog is Harmonious.

Bug: 788027
Test: Open two multi-profiles, right-click on a window, select "Move
Change-Id: Ia50d338271349d47a947b6d7c9e3a9bc13ade44f
Reviewed-on: https://chromium-review.googlesource.com/941612
Commit-Queue: Greg Levin <glevin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555121}

This ensures that back/forward buttons can be updated correctly for
iframe navigations, which are not visible via DidStartNavigation and
DidFinishNavigation callbacks of WebStateObserver.

Bug: 835799
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibc08db795617519244a6414bbe800b38953e7dbf
Reviewed-on: https://chromium-review.googlesource.com/1036453
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555120}

Adds optional tabId to echoPrivate.getUserConsent consentRequester
argument. The tabId identifies the tab which requested user consent to
verify the device's eligibility for an offer.
The tabId will be used to determine in which browser window the dialog
asking the user for consent should be shown.

End goal is to remove GetAssociatedWebContentsDeprecated usage from echo
private API implementation. Merely replacing it with
GetSenderWebContents does not work, as the method gets called from the
component echo extension's background page, so the sender web contents
does not correspond to the actual contents from which the request came.

This change is step 1 in removing GetAssociatedWebContents usage from
echo private API. After this step GetAssociatedWebContents usage will be
restricted to the case where tabId was not passed to the method. It will
be followed up with:
 2. Changing echo extension to pass tabId to getUserConsent method.
 3. Replacing remaining GetAssociatedWebContents usage with
    GetSenderWebContents - at this point tabId would not be passed to
    the getUserConsent method only if the method was called from a
    platform app, in which case GetSenderWebContents is appropriate.

Bug: 461394
Change-Id: If6b2913aab17bb1745d040996cad0696a293d97f
Reviewed-on: https://chromium-review.googlesource.com/1035784
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555119}

partition_alloc.h has been a dumping ground for all objects related to
PartitonAlloc. The original code used many inlined top-level functions
making the implementation very coupled. This splits out most of the
critical clusters of functionality into separate files with roughly
one struct/class per file.

The split makes the module layering and interaction boundaries much clearer.
Because of the heavy use of inlining, and the highly coupled nature of the
original code, it was not possible to make a clean split yet between
declaration and implementation. Therefore, this splitting required introducing
"-inl.h" files because too many of these objects reached direclty into each
others's fields. These "-inl.h" files can likely be reduced in future
refactors.

Bug: 766882
Change-Id: Iceeccc64a1d810a68cedfb28599dfbcf66642b98
Reviewed-on: https://chromium-review.googlesource.com/1006154Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555118}

Mojo passes around base::ProcessHandle values for various reasons. On
most systems this is fine, but at least on Windows, a ProcessHandle
refers to an owned reference to a system process object, and if not
careful it's possible for a base::ProcessHandle value to inadvertently
change meaning over time.

This CL introduces the concept of a move-only ScopedProcessHandle
within Mojo, which on most platforms is just a base::PlatformHandle.
On Windows, this represents an owned base::ProcessHandle which closes
on destruction and clones correctly using DuplicateHandle rather than
merely copying the raw handle value.

ScopedProcessHandle is used in a few places where process handle
ownership semantics were previously weaker than necessary, or were
correct but implemented ad hoc.

This also updates ScopedPlatformHandle (and supporting code like
Channel::RewriteHandles) such that the |owning_process| field (if not
the current process) is always an owned process handle. This ensures
that when such handles are closed in unsent messages, they can be
safely closed in the target process (from within the source process)
without any risk of raciness against target process termination.

Bug: 837612
Change-Id: I943bb5f70ede56351d52b2ecea7d76fcfdee46ce
Reviewed-on: https://chromium-review.googlesource.com/1036459Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555117}

Currently defaults to voice but will eventually be read from user
preferences.

Bug: b:78637398
Change-Id: I61d5d2090ff70d2af4f212c9c27cad0ad90eb029
Reviewed-on: https://chromium-review.googlesource.com/1034373Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#555116}

BUG=837689
TEST=none

Change-Id: Ie04f4e48afd0f6a33bc66b5f7921f83b79e1729d
Reviewed-on: https://chromium-review.googlesource.com/1033915Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555115}