- 31 Jul, 2017 40 commits
-
-
MinChen authored
1. Update the app list background opacity based on the shelf's original opacity. Shelf changes to fully transparent if app list is opened. Relationship: Applist background opacity = (Opacity of app list) * t + (1 - t) * (opacity of shelf) t = gesture_drag_amount / (3.0 * shelfsize) 2. Update the opacity of all the items in the app list. Includeing, searchbox view, suggested_apps_indicator, suggested_apps, all_apps_indicator, all apps in the first page, page switcher Formula: Opacity of item = (work_area_bottom - centroid of the item's screen bounds) / (2.0 * shelfsize) Bug: 748620 Change-Id: Ia1fc25628423fcc1ffad666319e04292837aae2c Reviewed-on: https://chromium-review.googlesource.com/585398Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#490786}
-
Torne (Richard Coles) authored
Update code in cronet to use JavaRef when calling Java methods via JNI, instead of passing bare jobject. Various function parameter types are converted from jobject to JavaRef to enable calls to obj() higher up the call chain to be removed. BUG=506850 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Id58e5b96c08df22f81f1a205cff877523ff2dad0 Reviewed-on: https://chromium-review.googlesource.com/591617Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#490785}
-
Samuel Huang authored
This is part of the effort to remove ChromeApplication. Now nativeGetBrowserUserAgent() is moved to a new class org.chromium.chrome.browser.content.ContentUtils. Bug: 698015 Change-Id: I22d848f484d81bb13bc8ba065ff9bda2ed02d16d Reviewed-on: https://chromium-review.googlesource.com/585630Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#490784}
-
Evan Stade authored
Bug: none Change-Id: I9ef8991ab9861760edc55877e818b010c6cc78a0 Reviewed-on: https://chromium-review.googlesource.com/594356Reviewed-by:
Terry Anderson <tdanderson@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#490783}
-
Robert Ma authored
OWNERS files for these entries have been created @281fecb6 (The only change since then was to add a few [ Skip ] entries.) DirectoryOwnersExtractor has been modified to read from OWNERS files and verified to work correctly. Following steps were carried out in this batch removal: $ sed -e '/external.*\[ Pass\ ]/d' -i W3CImportExpectations $ sed -e '/^## Owners/d' -i W3CImportExpectations Line "# external/wpt/media-capabilities" was manually removed as it is treated equivalently as a [ Pass ] entry by TestCopier. Now W3CImportExpectations should only contain [ Skip ] entries. Bug: 713987 Change-Id: Ib5906aa652a3db64deb973a961b0dbf7cbfcc2ff Reviewed-on: https://chromium-review.googlesource.com/592290 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#490782}
-
Fernando Serboncini authored
Allows a DWriteFontProxy to have a thread-safe way to send IPCs even when it's not on main thread. Bug: 722393 Change-Id: I6f840898bce9340ed5c12dcb43ae74ea3bbe7f47 Reviewed-on: https://chromium-review.googlesource.com/587415 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490781}
-
pennymac authored
Enforced in base QueryRegKeyValue function. TBR=robertshield BUG=714401 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2885243002 Cr-Commit-Position: refs/heads/master@{#490780}
-
Leslie Watkins authored
Bug: 672263 Change-Id: I8d8e9c563175f26e8c6cee1aaaa4e9e3dcd2e144 Reviewed-on: https://chromium-review.googlesource.com/592410Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#490779}
-
Yi Gu authored
In non-single-process tests, there's a good chance that two unit tests running in the same process need to set different client names. Currently whichever comes second cannot set the client name correctly. However, there is no ideal way to test both processes. Resetting the client names in the test doesn't work because the histogram has static client name which invalidates the name resetting. To fix, it requires confusing work-around in the code therefore we prefer to test only one process after all the logic is almost identical. Bug: 749366 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iebd312e1138292754f4aa2aa1875b13365e5602f Reviewed-on: https://chromium-review.googlesource.com/590172Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#490778}
-
Stephen McGruer authored
Bug: 699244 Change-Id: I4cc9d213d5a1ca96631d77388f286592b5bffd1e Reviewed-on: https://chromium-review.googlesource.com/558495Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#490777}
-
Yue Li authored
Reset login container opacity before voice interaction OOBE since the container could be transparent after unlock animation. BUG=b/64123072 Change-Id: I38b7d176d83f122bf680674f8ee7ebea5a0054fd Reviewed-on: https://chromium-review.googlesource.com/591634Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#490776}
-
Francois Doray authored
ScopedAsyncTaskScheduler is deprecated. Bug: 708584 Change-Id: If36e43e68fe63bee75f2b34f13f98acaa8571f1c Reviewed-on: https://chromium-review.googlesource.com/591988Reviewed-by:
Stanislav Chiknavaryan <stanisc@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#490775}
-
galinap authored
This CL reverts a change that was made in https://chromium-review.googlesource.com/c/519422. Namely, the desired size when fetching a favicon image has to be set to 32px. Even though the image will not be resized in the c++, this provides information to the c++ side about what image to fetch from the server. Bug: 715477 Change-Id: Iadb89de97cdc7ab0e188b95bd8fbae63de271bb5 Reviewed-on: https://chromium-review.googlesource.com/593947Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Galia Peycheva <galinap@google.com> Cr-Commit-Position: refs/heads/master@{#490774}
-
Francois Doray authored
ScopedTaskScheduler is deprecated. Bug: 708584 Change-Id: I011a4eab603068729a0c754e4e4dc6a33b23ec77 Reviewed-on: https://chromium-review.googlesource.com/586924Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#490773}
-
Paul Jensen authored
Date.after() and .before() don't allow for equal times, which can happen on fast emulators/devices. Bug: 749148 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I5e81e17435e5827855e44adbc7eb91052f17aa66 Reviewed-on: https://chromium-review.googlesource.com/592751Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490772}
-
Boris Sazonov authored
This CL extracts two lengthy (8 and 57 lines) callbacks into a single method and renames affected methods. Bug: None Change-Id: I712116269eef394c1582263d0a2d24e16fdedfe8 Reviewed-on: https://chromium-review.googlesource.com/591652Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#490771}
-
Gabriel Charette authored
R=rohitrao@chromium.org Bug: 667892 Change-Id: Ia6cd649c678a65a1f16351864d6a88c9a8e4b9d2 Reviewed-on: https://chromium-review.googlesource.com/590080Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#490770}
-
Vadym Doroshenko authored
Bug: 747828 Change-Id: I1d531f2288017b64b6c43f43f855c02e6ad74732 Reviewed-on: https://chromium-review.googlesource.com/588790Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#490769}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/50b2084bd15e..1eace2db482c $ git log 50b2084bd..1eace2db4 --date=short --no-merges --format='%ad %ae %s' 2017-07-31 caryclark fix capitalization Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ia3b3b108dc51f8f383f1c894cf638bddfd8f3f2c Reviewed-on: https://chromium-review.googlesource.com/593850Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490768}
-
Bernhard Bauer authored
Change-Id: Ie93c7c9010a5e946290aa0482d224bcc96913b73 Reviewed-on: https://chromium-review.googlesource.com/591967Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#490767}
-
Gabriel Charette authored
(this doesn't use the TaskScheduler API directly because that's the default behavior on JsonPrefStore now when not provided an explicit SequencedTaskRunner at construction :)) R=rohitrao@chromium.org Bug: 667892 Change-Id: Ifa0549e4ddf65ad8606451a47724234981c35467 Reviewed-on: https://chromium-review.googlesource.com/590573Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#490766}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a01b55b5..c3650168 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ic3470d618722b6269fda0817be6707cb5e359808 Reviewed-on: https://chromium-review.googlesource.com/593769Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#490765}
-
Mâdâlina Hurmuz authored
Adding a new enum related to username vote type in server.proto. It will distinguish the cases when Chrome uploads |USERNAME| autofill type: 1. The user overwrites their credentials. 2. The user reuses their credentials. 3. The used edited username value in a prompt (see crbug.com/734965). 4. Base heuristic (i.e. take the last field before the first password field) determines the username field. 5. Client-side HTML classifier determines the username field. In this CL, (2) is added. (1) was added in https://codereview.chromium.org/2747733004/. 3-5 will be added later, but let's update the proto once. Bug: Change-Id: I2a25881555b9fe2fd257ef78fffc0c34ec540d98 Reviewed-on: https://chromium-review.googlesource.com/582629Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Mâdâlina Hurmuz <madalinahurmuz@google.com> Cr-Commit-Position: refs/heads/master@{#490764}
-
Philip Jägenstedt authored
Using wpt-import in Chromium b8218917. TBR: qyearsley@chromium.org No-Export: true Change-Id: I874418c22c54f7225cc1c28f7bd0aa80de90be73 Reviewed-on: https://chromium-review.googlesource.com/593616Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#490763}
-
Marc Treib authored
Previously, we were detecting them by an "is_animated" flag, but it is actually called "is_animated_gif". Bug: 690467 Change-Id: I15337ac06886fcc737523b70a1d96fb36c19bf82 Reviewed-on: https://chromium-review.googlesource.com/593316Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#490762}
-
Mohamad Ahmadi authored
Also fixes a bug where non cryptographic URLs with a secure origin (e.g., Data URI) were being deemed as local and were not being caught. Bug: 602666 Change-Id: I1d017e47253ac3c60f3a9a178f5f3c525e801abb Reviewed-on: https://chromium-review.googlesource.com/590698Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: mahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#490761}
-
yasong authored
Also add one comment. No functional change. This CL lands server change 162922389 by bnc. This CL lands server change 162991254 by yasong. BUG=488484 Change-Id: I33889d0895da9c7a322cb8a11e0da3e4e0697470 Reviewed-on: https://chromium-review.googlesource.com/591774Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#490760}
-
gambard authored
During the removal of the VoiceSearch commands, ContentSuggestions was forgotten. This CL uses the new API to start voice search with the dispatcher. Bug: 750636 Change-Id: Ie1cb80f0beb2969868a565c2c60c0df564c10bc8 Reviewed-on: https://chromium-review.googlesource.com/593660Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490759}
-
Hector Dearman authored
The 'new' memory UMA computed by memory instrumentation (Memory.Experimental.Renderer2.PrivateMemoryFootprint etc) have fewer results than the old memory UMA (Memory.RendererAll etc). It is possible this is due to the memory-infra getting stuck or ignoring whole dumps due to single processes failing. This adds some UMA to memory instrumentation to help debug the issue. Change-Id: Ic4abaf314f8cfa9afb585b4b20da1c956e80b025 Reviewed-on: https://chromium-review.googlesource.com/586607 Commit-Queue: Hector Dearman <hjd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490758}
-
chrome://flagsTatiana Gornak authored
BUG=739343 Save skeletoon Change-Id: I5aac58e8e4675c3a12044130b5b9329a743f1361 Reviewed-on: https://chromium-review.googlesource.com/586604Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#490757}
-
Elly Fong-Jones authored
This dialog uses ConstrainedWindowCustomWindow, but it needs a white background so that the contained text can be properly antialiased. Bug: 747782 Change-Id: I973b00096feaaea44ba72e699838f37ac8a3e518 Reviewed-on: https://chromium-review.googlesource.com/590491Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#490756}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/88cac37a87f3..9e69c338846a $ git log 88cac37a8..9e69c3388 --date=short --no-merges --format='%ad %ae %s' 2017-07-31 loloangela Fixed errors related to bad-continuation pt.37 Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib628c0da53fb57e5f0fa82916c3faa383b9f9ede Reviewed-on: https://chromium-review.googlesource.com/593827 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490755}
-
Lucas Garron authored
Bug: 701452 Change-Id: I678802b5c69729b6c9422b8fffd1c3df7354760c Reviewed-on: https://chromium-review.googlesource.com/592161Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#490754}
-
Gyuyoung Kim authored
As a step to reduce uses of wtf/Assertions.cpp/h, this CL extracts ScopedLogger class from Assertions.cpp/h files. BUG=596760 TEST: The unit test for ScopedLogger starts to work on ScopedLoggerTest.cpp. Change-Id: Iceaee21136fae9244c96579f3a7bd963f89b2eec Reviewed-on: https://chromium-review.googlesource.com/577576 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#490753}
-
gambard authored
Removes the plumbing for the pool and creates it directly in the class. Bug: 667892 Change-Id: Idf70d171f20d5f649978ef36db9988c4918430f5 Reviewed-on: https://chromium-review.googlesource.com/591128Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490752}
-
Helen Li authored
Bug: 730036 Change-Id: I3f1dd86dfea6e56868e0766825f22549dd33c05e Reviewed-on: https://chromium-review.googlesource.com/580618Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#490751}
-
Takeshi Yoshino authored
The logic to determine whether the CORS-preflight fetch is needed for the given request is duplicated in FetchManager and DocumentThreadableLoader. Remove one in FetchManager. This is safe because: - One in FetchManager::Loader::Start() sets the CORS preflight flag for the forbidden header names while one in DocumentThreadableLoader doesn't. - But since all the headers with a forbidden header name are removed by the Headers guard, FetchManager::Loader::Start() never encounter any header with a forbidden header name. Due to Request::Create() on the given |input| in GlobalFetch::Fetch(), UnsafeRequestFlag() is always true in FetchManager::Loader::Start(). So, this in the condition had no effect. Remove it. Bug: 727596 Change-Id: I7f2ddd49b619db067f68128227c7bb42ba16cd23 Reviewed-on: https://chromium-review.googlesource.com/553097 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#490750}
-
Chris Pickel authored
Add a set of channels 'STARTUP'. It does not need to contain all of the channels in 'MAP'; only those in STARTUP will be initialized automatically. Other channels can be initialized conditionally. (also, import R) Bug: 747380 Change-Id: I4667a0c38a03478c8f88f6621c80db57a2a487f1 Reviewed-on: https://chromium-review.googlesource.com/591374Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#490749}
-
Emil A Eklund authored
This reverts r490644 (commit 65b35725). Caused certain websites (such as permission.site) to not render at all. Bug: 750553, 750546 Change-Id: I4233a2e16b8145e5a486e45b6c585ad54b0f4f7d Tbr: cbiesinger@chromium.org Reviewed-on: https://chromium-review.googlesource.com/593608 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#490748}
-
tanvir.rizvi authored
Use FrameSelection::IsDirectional() in TextControlElement This is done as a preparation of moving member variable is_directional_ of class SelectionTemplate to class FrameSelection for code health. BUG=740804 Change-Id: I287ed4b01ffe531c38c09a79f4f90dd5a5abc896 Reviewed-on: https://chromium-review.googlesource.com/589092 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#490747}
-