- 13 Aug, 2020 40 commits
-
-
Dominic Battre authored
Passwords can be keyed by multiple subdomains and it is important to support all of them. Bug: 1095627 Change-Id: I952bd06cb5a7f7123d149787613c4335ccdeff42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352933 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Milica Selakovic <selakovic@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#797654}
-
Omar Morsi authored
This CL separates non service-related definitions from platform_keys_service.h Bug: 1115581 Change-Id: Ic9912960009968b9d348c72217b3523d531dafc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352793Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#797653}
-
Florent Castelli authored
The parameter is not optional and has never really been optional as calls would fail with empty values. Bug: 803494 Change-Id: I44a2f25b9368f9759f296a95d9ad878de1292faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351836Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#797652}
-
Rouslan Solomakhin authored
This reverts https://crrev.com/c/2351959, https://crrev.com/c/2345928, https://crrev.com/c/2302970, and https://crrev.com/c/2257090 because they are causing hard-to-diagnose crashes in production for a feature that is supposed to be still turned off. The patches should be relanded with more test coverage. TBR=jdragon.bae@gmail.com, manukh@chromium.org, maxlg@chromium.org Bug: 1114556, 1052493 Change-Id: Ic221c99e28246676d24bcd2185773657abef4781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354149 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797651}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/86c9a7134948..522a635391bd 2020-08-13 szuend@chromium.org [ts] Type-check ui/ProgressIndiciator.js with TypeScript 2020-08-13 szuend@chromium.org Revert "Reland "eliminate initial timeout in waitForFunction"" 2020-08-13 szuend@chromium.org [ts] Type-check ui/FilterSuggestionBuilder.js with TypeScript 2020-08-13 szuend@chromium.org [ts] Type-check ui/DropTarget.js with TypeScript 2020-08-13 patrick.brosset@microsoft.com Copy formatted HTML when the console selection contains a table 2020-08-13 jobay@google.com Reland "eliminate initial timeout in waitForFunction" 2020-08-13 kimanh@chromium.org Gate dwarf extension api behind wasmDWARFDebugging experiment flag 2020-08-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1112346,chromium:1112692,chromium:1115011 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6d61142415b9561157dd1456e19b443d4250c9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353485Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797650}
-
Francois Beaufort authored
This CL makes sure initialized callback from the MediaStream constructor is called asynchronously as it was causing a JavaScript crash potentially caused by the fact that the MediaStream was not completely registered with oilpan. Bug: 1114398 Change-Id: If6058b183bdd07fa747d810efe0f6abed4914e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352800Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#797649}
-
Rainhard Findling authored
* The current translation screenshot presubmit check flags messages which got modified but for which no new translation screenshot got uploaded. It thereby also flags messages that got modified, but of which the message content itself did not change. This is the case, for example, if only the message description for translators got changed. * This CL restricts the translation screenshot presubmit flagging modified messages. It will trigger 1) if the message did not have a screenshot at all so far, or 2) if the message content itself changed. Only changing the non-visible part of a message that already has a translation screenshot does not trigger it anymore. Bug: 1103844 Change-Id: I254ce2a7267a7d2308b606b16d080c74188d582b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328669 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797648}
-
Caitlin Fischer authored
Calling TearDownAuthForTesting() causes a crash in SigninManager::signOut() (Java). This is because the sign-out operation started during the test body does not finish before TearDownAuthForTesting() is called. In other words, we try to sign out during tear down while sign-out is already in progress. We don't need to sign out during tear down, so we'll stop doing this. However, we'll continue to reset the AccountManagerFacadeProvider. Bug: 1102746 Change-Id: I0cc97c8cfa04591d150305418858eaa0abe4b38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350231Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#797647}
-
Rossana Monteriso authored
In the current master state the grid highlighted by Inspector Tool is always being calculated and rendered with direction:ltr, regardless of its CSS direction property. This CL adds getColumnPosition function, that checks if grid's direction is ltr or rtl. If direction is rtl, it translates the coordinates to rtl. getColumnPosition is then called by BuildGridInfo to evaluate PhysicalOffset and PhysicalSize when painting the grid. BUG=1086923 Change-Id: Ic43463b9aa643358d2ad06e2a6f4f7755c6c48f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213530 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#797646}
-
Marc Treib authored
This CL adds code to notify the IPH tracker of relevant events related to the PasswordsAccountStorage IPH: - When the feature was used, i.e. a password was saved to the account store. - When the feature was "disabled", i.e. the user explicitly chose to save to the profile store instead. The IPH tracker can use these events to decide whether to show the IPH bubble. Bug: 1115476 Change-Id: I97f1c1b4a3d6d536968083b2ac0dac5fe693eb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352874Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#797645}
-
Rune Lillesveen authored
Change-Id: I3d1fbd99faac4fb12b7d8decba24e282737c521b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353254Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797644}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc958e0e8703..31e5a5d45d5d 2020-08-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 13f04d59c727 to cda86eff6461 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ibf2dfcc6eae2f3d8e1a511fb1337062c91afaffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353482Reviewed-by:
-
Monica Basta authored
This CL adds the 'Customize' button. On click, the user will be directed to manage profile settings sub page for the selected profile. Bug: 1063856 Change-Id: I0b85f01e9efe0a2fb9a2ca20885147d48b83a3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353249Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#797642}
-
Dylan Cutler authored
participation. Bug: 973801 Change-Id: Ic5e2c7f2118c10dc2b277ad032a282f59741e6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353110Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#797641}
-
Matt Wolenetz authored
Improves MediaSourceRegistry code readability by DCHECKing in its URLRegistry overrides and in its LookupMediaSource interface that the KURL |url| in the former, and the wtf::String |url| in the latter are not empty (or null). The former is prevented by the FILE API PublicUrlManager already, and the latter is now (by this change) protected against in MediaSourceAttachment::LookupMediaSource(). This is a follow-up on a review comment in an MSE-in-Worker CL: https://chromium-review.googlesource.com/c/chromium/src/+/2300804/7/third_party/blink/renderer/modules/mediasource/media_source_registry_impl.cc#74 BUG=878133 Change-Id: I2ef93b8d3fc894ee71b1a605acdc58df88e722d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346797 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#797640}
-
Robbie Gibson authored
On iOS 14, using pasteboard.string triggers a notification saying that the app pasted. There is a better property hasStrings that doesn't trigger this notification. It is also the recommended way from Apple to check if the pasteboard contains any strings. Bug: 1110848 Change-Id: Ia892c76ee17d5230582e8907db927ad3a27e82b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351832Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#797639}
-
Eric Sum authored
See internal buganizer bug for context. Bug: internal b/163291366 Test: Build locally. Change-Id: Iac091d9a0cd9d4c39e22b51a1d89a442536e9909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345723Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Eric Sum <esum@chromium.org> Cr-Commit-Position: refs/heads/master@{#797638}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6e1012fcb6bb6c85720af7d0a7a98e60ed3dec82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351764Reviewed-by:
-
Nohemi Fernandez authored
During the EG1 to EG2 migration a duplicate testing class was created to help expose necessary class-specific methods to EarlGrey. Now that the transition is complete we will remove the dependency to SigninEarlGreyAppInterface helper class and only expose SigninEarlGrey to client code. This patch also uses the more canonical 'verify' prefix for EarlGrey assertions. Bug: 1103274 Change-Id: I7cf71df0826068e79c8e0006744907fe36c70be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352931 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#797636}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dbee93ac203d..e1360ddcec9e 2020-08-13 simonmacm@google.com Merge "Fix O(n^2) wakelock merging in android_batt.sql." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8e839835a6eaf2834fe04d53811c47646f65eb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353484Reviewed-by:
-
Bret Sepulveda authored
This reverts commit 1523bb86. Reason for revert: ClipboardTest/TestClipboardTest.TextTest is failing on linux-lacros-tester-rel. See for example https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/944 Original change's description: > [ozone] Improved clipboard tests and de-duplicated string constants. > > This CL pays a bit of technical debt in the clipboard implementation. > > First, it updates a test that verifies that putting text into clipboard > registers the proper set of MIME types, as had been suggested in [1]. > > Second, it enables for Ozone the test that verifies selection buffers. > > Third, it de-duplicates some string constants. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2306252 > > Change-Id: I6beb6b5b3827f0ec09cf19bc1868e7955141f680 > Bug: 911992, 1105892 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346338 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Cr-Commit-Position: refs/heads/master@{#797572} TBR=sky@chromium.org,adunaev@igalia.com Change-Id: I376620331b967c70225b10d67b5e6e467802cf5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911992 Bug: 1105892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352802Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797634}
-
Peng Huang authored
Bug: 1115065 Change-Id: I45873297b649d6b229823bfab100c00fb9fbbe52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351956Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797633}
-
Carlos Caballero authored
Bug: 1111720 Change-Id: I03f07bb982b2f98ab7213cbeb50911c6affe78b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339616 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797632}
-
Hirokazu Honda authored
Bug: b:155054799 Test: video_decode_accelerator_tests test-25fps.vp9_2 --use_vd on rammus Change-Id: I53103feebd9987583eaf029320f3b490d98f7298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350719Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#797631}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Ida05281d3ce64dbafeb186fff3911304eb2e0bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352959 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797630}
-
Jan Wilken Dörrie authored
This change updates the zxcvbn data component and library to support parsing the data dictionaries on the background thread. Fixed: 1112461 Change-Id: I1b553bf448c1baf9b0a1359a853fc5360716e52a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332609Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#797629}
-
Makoto Shimazu authored
This is a follow-up CL for https://crrev.com/c/2114932. This CL lets FetchRespondWithObserver call methods of FetchEvent directly. Bug: 1039558 Change-Id: I332945e4248840cfeddb66ee5599ca18f35394e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352296 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797628}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/652124c372e5..fec8e60ea3e4 2020-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d667ad2f0127 to cc958e0e8703 (4 revisions) 2020-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7a75987d to ffe84295 (455 revisions) 2020-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 13f04d59c727 to cda86eff6461 (4 revisions) 2020-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 37f547456cc6 to 4a486be696b4 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I1c5a883206789adcf795a7f8ff957a285cf9e275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353480Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/13a65b1aee42..df859f77dab3 2020-08-12 andreperezmaselco.developer@gmail.com spirv-fuzz: Check integer and float width capabilities (#3670) 2020-08-12 andreperezmaselco.developer@gmail.com spirv-fuzz: consider additional access chain instructions (#3672) 2020-08-12 andreperezmaselco.developer@gmail.com spirv-fuzz: Ignore specialization constants (#3664) 2020-08-12 vasniktel@gmail.com Fix the bug (#3683) 2020-08-12 vasniktel@gmail.com spirv-fuzz: Fix width in FuzzerPassAddEquationInstructions (#3685) 2020-08-12 jaebaek@google.com Preserve debug info in dead-insert-elim pass (#3652) 2020-08-12 jaebaek@google.com Validate more OpenCL.DebugInfo.100 instructions (#3684) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Id932045ee512891cd5a5e39ce7810c70bc9e7ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353477Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia2e2b9be69d9434a7ea9c1c6255a104e27b522b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354030Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797625}
-
Yuki Shiino authored
This reverts commit d4f833b0. Reason for revert: Due to the revert at https://chromium-review.googlesource.com/c/chromium/src/+/2353115 Original change's description: > bind-gen: Update PerformAttributeSetCEReactionsReflect > > Ports https://crrev.com/c/2351950 to the new bindings generator. > > Bug: 839389 > Change-Id: Ia3bab7ba01b527acb550b40a7178563f70edd88d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352571 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797573} TBR=peria@chromium.org,yukishiino@chromium.org Change-Id: Ia4a96c4a26bfdba31b6b3d38f3b2ba753b95437f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352467Reviewed-by:
-
Ewann authored
Adding: - Edit folder - move folder Bug: 1093302 Change-Id: I76c82a14fdc6956d5412891a2ba7cc575100e653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349305 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#797623}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597275686-7da657e756f53f89a89030a34195741313ee681f.profdata to chrome-mac-master-1597298325-7a1b28e7d249f4f2f87ee413bc832fdaab0b39d9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If40186f00a641f8d68031d52a98b77d8537f0bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353481Reviewed-by:
-
David Roger authored
Bug: 1076880 Change-Id: Icbdb6c50e53321acd30288e0f14c9f788a46cbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352230Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797621}
-
arthursonzogni authored
Those 4 tests are consistently failing on Lollipop: org.chromium.chrome.browser.keyboard_accessory.ManualFillingUiCaptureTest #testCaptureKeyboardAccessoryV2WithPasswords #testCaptureKeyboardAccessoryV2WithPasswordsRTL #testCaptureKeyboardAccessoryWithPasswords #testCaptureKeyboardAccessoryWithPasswordsRTL TBR=fhorschig@chromium.org Bug: 1095672 Change-Id: I4017cc75b4dec74fe91ac7df4bb4ad0aab209c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352915Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#797620}
-
arthursonzogni authored
TBR=wenyufu@chromium.org Bug: 1115870 Change-Id: I7e054c247595b09f3fe83e9063065aff702a80ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352895Reviewed-by:
-
arthursonzogni authored
This test is flaky. In particular on the Marshmallow Tablet Tester: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester/b8872140678652429312 TBR=adithyas@chromium.org Bug: 1115888 Change-Id: I933c0e369d93aa343576f03c3f76af8c0ddbc82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352936Reviewed-by:
-
Antonio Sartori authored
Since the Content-Security-Policy directive `frame-ancestors` is now checked in the browser and no longer in blink, this code should be safe to remove. Bug: 1032139 Change-Id: I25faca527955b374578454ddaf9385e98898bb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351837Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#797617}
-
Arthur Sonzogni authored
This reverts commit ffd982c9. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1115915 Caused several tests to fail. Original change's description: > Move URL to CriticalPersistedTabData > > This supports the effort of moving fields to UserData objects > so Tab doesn't become too big and unwieldy. > > Bug: 1112357 > Change-Id: I6c484d9586ca8ad7d1866fbbc9dac4735ecf1470 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337673 > Commit-Queue: David Maunder <davidjm@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797555} TBR=nyquist@chromium.org,dtrainor@chromium.org,jinsukkim@chromium.org,davidjm@chromium.org Change-Id: I084d6dcb0cef11311a8d9d5f8bc26bffe6309339 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352813Reviewed-by:
-
Matthias Körber authored
Currently, "Apellido Materno" is matched as a middle name although it is actually the second last name. Change-Id: I16086145cc46e29370f313b01bae8bb6c3785203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351917Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#797615}
-
