- 06 Jan, 2021 40 commits
-
-
David Roger authored
This CL changes the way DiceInterceptedSessionStartupHelper adds the account on the web. Previously it was mostly waiting for the reconcilor to trigger, and making sure that the process is not stuck (by forcing calls to list accounts). The new behavior is more proactive: when the profile is new, it blocks the reconcilor and forces a call to multilogin directly. The advantages are: - it is easier to control and hopefully it should be less brittle. - it should be faster: * the previous flow was doing an extra /ListAccounts call after the reconciliation, which is now removed * the previous flow was using MergeSession while the new flow uses multilogin, which should be faster on desktop (no need to fetch an access token) When the profile is not new, it's not possible to simply use multilogin, as there may already be accounts in the profile. The reconcilor is still used in this case, as it has the logic to handle this. Note: it would be possible to use MergeSession instead of Multilogin, as this would work for all profiles (including existing profiles). However MergeSession is now discouraged and thus we avoid adding a new usage here. This CL also improves histograms. Bug: 1151313 Change-Id: I4871eb123eb37081595164bd5280adf2b0b1290b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600909 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840690}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cee13faaf357..ca7d9ee2a720 2021-01-06 fmayer@google.com Merge "Remove AHeapProfile_initSession from public header." 2021-01-06 treehugger-gerrit@google.com Merge "Fix skipped test being marked as [FAIL] in logcat." 2021-01-06 treehugger-gerrit@google.com Merge "ui: Make "f" slice focusing work for instant events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I747179222ee780c8601fd810932c1e655db10c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840689}
-
Nick Diego Yamane authored
The case where the entered surface in a drag session (through wl_data_device::enter event) is suddenly destroyed at client-side, was not being properly handled, causing use-after-free crashes. This fixes it as well as adds a unit test to prevent future similar regressions. Bug: 1143707 Test: ozone_unittest --gtest_filter='*WaylandDataDragControllerTest.*' Change-Id: I0fb0b7abbc257398c3a114f1c2d438ecc8d9adf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593572 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#840688}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8ef860714479..a8b962b78978 2021-01-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 481852c5 to 38610c88 (120 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I4daf7fec2227c9fb8fea83f3d818a10da267ac1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611123Reviewed-by:
-
James Hollyer authored
To support the new XBox Series X controller over usb we simply need to recognize the device id as an XInput device. The reports are identical to an XBox One controller so we recognize it as one and it works. This does not work on macOS because the device seems to need some initialization that is not provided by macOS. Bug: 1147578 Change-Id: I494835535d4e3f9dd4bbed657fef2f3e15acbeac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612116Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#840686}
-
Reilly Grant authored
In all implementations this method does the same thing as Disconnect() but doesn't accept a callback parameter. This patch unifies them. Bug: 1151533 Change-Id: I64b78257af1e1971a6ab2fb5b70592726eb9f7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597830 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840685}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609934346-02960af12c9c6cfb124c9f1bb5033b3eb2b936e3.profdata to chrome-win64-master-1609945018-70431859900ba317039e4e8fedf6f4732373dd6e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1a6a72f369610e59e004623f021576a45c6ab1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613233Reviewed-by:
-
adamta authored
Animates the NTP's fake omnibox to adjust its width and add a separator when the NTP is scrolled. Refactors headerSynchronizer and moves it from ContentSuggestionsCoordinator to NewTabPageViewController. Refactored synchronizer includes additionalOffset property to compensate for offset header in the refactored NTP. The omnibox sticking to the top of the NTP will be added in a follow-up CL. Bug: 1114792 Change-Id: Iebb1e7ae9a23772bf03d8cfedb5aed3b0ca16762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611286Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#840683}
-
Jeffrey Cohen authored
Bug: 1161331 Change-Id: I0377693c7cd63bef7d986b7474df1722c2119c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601049Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840682}
-
Colin Blundell authored
This CL incorporates Chrome's adjustment of subresource filter page activation decisions based on content settings within WebLayer. To do so, we have the shared SubresourceFilterSafeBrowsingActivationThrottle directly invoke the logic in question rather than having ChromeSubresourceFilterClient do so. That change necessitates some others, also made in this CL: - WebLayer brings up ProfileInteractionManager. - SubresourceFilterClient provides an accessor for ProfileInteractionManager. - SubresourceFilterSafeBrowsingActivationThrottle calls the adjustment logic via a new Delegate interface rather than doing so via SubresourceFilterClient. This interface is implemented by ProfileInteractionManager in production while allowing for porting of tests that provide custom (or nil) stub logic. We also add browsertests of this interaction in //weblayer. Note that this CL does not do any incorporation of the relevant *UI* for content/site settings of ad blocking in WebLayer; that will be followup work. Bug: 1116095 Change-Id: I394e62f12d5209a4302ffa57de9095c861b59613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603574 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#840681}
-
Nazih Almalki authored
Change-Id: I16c2ff2d6aea8a8b2195b6e4c77cd4c143821658 Bug: https://crbug.com/956695 Change-Id: I16c2ff2d6aea8a8b2195b6e4c77cd4c143821658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611308 Auto-Submit: Nazih Almalki <nalmalki@google.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#840680}
-
Victor Costan authored
Chrome's googletest version exports testing::DoAll to the global namespace. The master version does not. This means that Chrome does not compile with the master version of googletest. This CL fixes Chrome's tests that use testing::DoAll without a "using" statement, unblocking rolling googletest. Bug: 1163396 Change-Id: I9778cee59dc4476bcd586a8592949068f696b6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611843Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840679}
-
Yue Li authored
Bug: b/175747630 Test: None Change-Id: I48729ab6e3105a829f1338517cb1796bd70a8e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612517 Auto-Submit: Yue Li <updowndota@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840678}
-
Brian Sheedy authored
Removes expectations for the webgl_conformance suite that have been determined to be stale. This only touches expectations that have passed 100% of the time on all builders. Bug: 1155766, 1018028, 1110111, 979444, 1105129 Bug: 685232, 772037, 825338, 1023745, 478572 Bug: 931006, 951628, 626524, 630860, 898674 Bug: 829389, 680754, 750896, 825416, 737018 Bug: 680754, 829389, angleproject:4539, 728670, 690248 Bug: 653533, 415609, 617148, 992224, 703779 Bug: angleproject:3741, angleproject:2939, 1020295, angleproject:3481 Bug: angleproject:2926, angleproject:4569, 1017162, 974347 Bug: angleproject:4286, 599272, 928926, 1108676, 1154745 Bug: 1018028, 886970, 635081, 992313, 871352 Bug: 948218, 1027776, 1059760, angleproject:4846, 1021428 Bug: 524144, 596622, 703779, 918995, 550989 Bug: 965594, 1028639, 1060632, 1081973, 1143323 Bug: 907512, 733599, 611943, 709704, 1098311 Bug: 920737, 912161, 793050, 818041, 1135659 Bug: 716496, 891456, 934545, 1043431, 1135785 Bug: 912161, 891456, 798117, 606096, 912161 Bug: 891456, 478572, 845411, 845438, 995652 Bug: 981579, 906724, 1081973, 1136106, 1145830 Bug: 1042897, 1114284, 1119939, 1102991 Change-Id: I6fc4058996d2c20513310f174256c5b7cfe388af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593183Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#840677}
-
Tanmoy Mollik authored
Adds a histogram that records number of android accounts present on device even if the user isn't signed in. Bug: 1025410 Change-Id: Ide66597ea3da5857e6f7ccd5bec018b54ebc03e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607306Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840676}
-
Hongbo Song authored
UKM privacy review: https://docs.google.com/document/d/1DpX7LvTIAzXPP3KUOlEeGpwrzAH3eVFH0vE0w3-RNpM/edit?usp=sharing Change-Id: Ie175254aa965ec7529506eebea4f90fdaba462f4 Bug: 1139533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533590Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#840675}
-
Willie Koomson authored
This change modifies ArcVmClientAdapter to start ARCVM before login (to implement mini-ARC). Among the changes are: - Starts mini-ARCVM with a generic user kArcVmDefaultOwner - Sets correct owner id during UpgradeArc() - Stops VM if UpgradeArc() fails - On StopArcInstance(), checks if mini-ARC or full ARC is running - Update unittests BUG=b:144542975 TEST=ArcVmClientAdapterTest unittests TEST=tast run <DUT> arc.Boot.vm crostini.Basic.buster_amd64_stable TEST=build and flash. On login screen, check chrome log and syslog to make sure ARCVM has started successfully. Check guest logcat and make sure init is blocked on arcvm-boot-notification-client. After login, check that instance is upgraded successfully and Play Store is able to start. Change-Id: I190a9ede041b53f0dbcb1773ea82b2e0ac51ae54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354623Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#840674}
-
Tibor Goldschwendt authored
We are still using them. Specifically, this CL extends the following histograms: * NewTabPage.BackgroundService.Collections.RequestLatency* * NewTabPage.BackgroundService.Images.RequestLatency* * NewTabPage.CustomizedShortcuts * NewTabPage.CustomizeLocalImageBackgroundAction * NewTabPage.CustomizeShortcutAction * NewTabPage.LogoDownloadOutcome * NewTabPage.LogoDownloadTime * NewTabPage.LogoImageDownloaded * NewTabPage.LogoShownTime2 * NewTabPage.Modules.ShownTime * NewTabPage.Modules.Usage* * NewTabPage.Promos.RequestLatency2* * NewTabPage.RecipeTasks.RecipeClick * NewTabPage.RecipeTasks.RelatedSearchClick * NewTabPage.ShoppingTasks.ProductClick * NewTabPage.ShoppingTasks.RelatedSearchClick * NewTabPage.TileTitle* * NewTabPage.URLState Fixed: 1151982, 1156215, 1151981 Change-Id: Id31e792fe3d4b205ea8d1fd1ea5f17d9c5f4157b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611634 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
cfredric authored
Bug: 1143756 Change-Id: I7c8f9b94c817a577367f377ed2d7a0dd3c81ca24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523414Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#840672}
-
Andrew Grieve authored
Noticed a significant delay between "Finished" log message and process terminating. Turns out this call to _exit(0) saves 2 seconds off of a 4.6 second run for content_common_mojo_bindings. Bug: 1143399 Change-Id: I0beb911033ddb7f96027796afac0c65ac5306df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611950Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#840671}
-
Justin Cohen authored
UIImageWriteToSavedPhotosAlbum appears to force a png instead of a gif. Use PHAssetCreationRequest instead to preserve the gif. Bug: 1159431 Change-Id: I3640085f97d6f20fe62d96c8ac02d2bbed353585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595254 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840670}
-
Andrew Grieve authored
The exception was not being checked for, and so never shown. Bug: None Change-Id: Ia61ed3cb2379defe087262d61374fbe6c6675217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611450 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840669}
-
Steven Bennetts authored
Bug: none Change-Id: Ibfa838ae47f5004566deb0d0ef9973531ce0f340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597781 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#840668}
-
Dominic Mazzoni authored
Bug: 1153721, 1153720 Change-Id: Ib808bb4e00028ba584e2c9de40830ffeb9d78122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605568Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840667}
-
dpapad authored
This is in preparation of auto-generating grd entries for the PDF Viewer. Bug: 1132403 Change-Id: I695823e98d672a611ddc136eebb1afe40693f2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612098Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#840666}
-
Alice Wang authored
This CL adds tests to check SigninStartAccessPoint logging. Bug: 1163476 Change-Id: I35ff0b27780d537e97109dc3f0fa71c2785a6ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611716Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840665}
-
Jesse Schettler authored
The histogram records the number of detected scanners. Bug: 1059779 Change-Id: I2db04c38c6ddf7dc4a3d7e3ff7df69e67076c743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596428Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#840664}
-
Peter Kasting authored
It makes little sense for GetFontListWithDelta() to also take non-delta values. It will also be convenient for a future CL for callers to be able to use a struct that represents "the meaningful data about a font". For both these reasons, replace the private FontKey struct with a public FontDetails struct that bundles these details, and update callers to use it as appropriate. Also, replace seemingly-unnecessary usage of Font with FontList in l10n_font_util.h (and remove dead method there). This allows removing another ResourceBundle method. Bug: none Change-Id: Ie6b35e7015fe8bdf704fc4111c0e6ca4de522308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611841 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
An iframe can only have 1 hyperlink. If the iframe is not loaded yet, then it should have 0. When hyperlink 0 is retrieved, it should never be null. However, this is occurring where the url is "empty". It may be occurring during document destruction. There exists code to update the parent hypertext when a BrowserAccessibilityManager's contents are attached, but not on destruction. It's unclear whether a single BrowserAccessibilityManager can be destroyed without the entire tree of them being destroyed. To be safe, update the parent when a BrowserAccessibilityManager is destroyed. Bug: 1157731 Change-Id: I96a6654d3aa2d6934c07a0145e76edad9ee93243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611665Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#840662}
-
Tom Anderson authored
On Linux, the display server closes when the session is ending. In particular, for X11 connections, the server may be remote, so the connection can go down at any time. [1] added a crash on connection IO errors where it would previously gracefully exit. This is desirable on ChromeOS to generate crash reports, but not for desktop Linux, so this CL restores the old behavior on Linux. [1] https://chromium.googlesource.com/chromium/src/+/59a4564762df2b3cb5a6037d5ce97e5ad626eb48 R=rjkroege BUG=1160140 Change-Id: Ie5a5ce762e6b65f533411ce88caa51d3c27366a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600045 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840661}
-
Wei Li authored
RoundedOmniboxResultsFrame is the content view for omnibox's autocomplete popup widget. It is in a TYPE_POPUP widget. For this kind of widget, SMALL_SHADOW and BIG_SHADOW has no difference. Since SMALL_SHADOW is the default value for most dialogs, use this type instead. We will eliminate the BIG_SHADOW eventually. Bug: 940027 Change-Id: I4da68c4eeb9eeecb44b0a1a9f6bf610880b90acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612150Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#840660}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cdde253e4082..32d68537a88c 2021-01-06 johnstiles@google.com Add SkVM support for conversion constructors to and from boolean. 2021-01-06 johnstiles@google.com Unify conversion constructor simplification code. 2021-01-06 bsalomon@google.com exclude surfacecontextwritepixels from CK 2021-01-06 bsalomon@google.com Revert "Add more comprehensive test for GPU write pixels." 2021-01-06 egdaniel@google.com Fix inline uploads when using vulkan load resolve. 2021-01-06 bsalomon@google.com Revert "Revert "Reland "Make textures used with alpha-only color-types produce 0s for RGB"""" 2021-01-06 johnstiles@google.com Fix cross-platform deviations in SkStrAppendScalar for inf/nan. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I487dd4ca6160fb2347a7a4b7681120080edbe6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613120Reviewed-by:
-
Miras Myrzakerey authored
Implement encoding part of Save-Page-As-WebBundle feature by introducing a WebBundleBuilder class. This CL will encode a series of snapshots (from a single web page) into a correct WebBundle. Bug: 1040752 Change-Id: I3ab17deb1d658b3098ba32916e8832ea0c829e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215543 Commit-Queue: Miras Myrzakerey <myrzakereyms@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#840658}
-
Tibor Goldschwendt authored
Fixed: 1154738 Change-Id: I319269ac2ad02fbf8fb5776e0904ca2fcd4c9b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611700 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#840657}
-
Brian Sheedy authored
Removes chrome_public_test_vr_apk from the two Android L-based builders it was being run on, as we have decided that it's no longer worth the effort to try to keep the tests running on that version of Android. Bug: 1159619 Change-Id: I22722da53fbb288e7ab90f34afffcbe8f463eddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611900 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#840656}
-
Mihai Sardarescu authored
Methods OnUnconsentedPrimaryAccountChanged is deprecated, so this CL changes the chrome/browser/profiles/* and c/b/safe_browsing/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: I0dbabb38085373cf44de5f7273812d4f44fe7969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611091Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
Methods OnUnconsentedPrimaryAccountChanged is deprecated, so this CL changes the chrome/browser/ui/views/profiles/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: Ia0168bae3070c7c5eefd9919598919b9d0ae4e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611711Reviewed-by:
-
John Delaney authored
This is a reland of 53e3903f This now correctly initializes the was_opener_suppressed_ member on NavigationRequest. Original change's description: > [conversions] Route impressions alongside rel="noopener" anchor navs > > What: > Route impressions for the Conversion Measurement API to the browser > process for anchor tags with rel="noopener". > > Why: > We currently drop impressions for anchor clicks which have noopener > set because the impressions do not get forwarded to the browser process. > > Anchor click navigations with the rel="noopener" attribute use a > different navigation path than those without the attribute, in which > the window creation mojo also navigates the frame to the target url. > This navigation is not annotated with an impression. > > How: > Add an Impression member to CreateNewWindowParams which will get > forwarded as a LoadURLParam for the subsequent navigation of the > window. > > This change also fixes a bug in which initiator_frame_tokens are not > set for noopener navigations. > > As of https://chromium-review.googlesource.com/c/chromium/src/+/2327963, > the lack of an initiator frame tokens are used to to indicate whether > an opener was suppressed for a navigation. Because attaching the token > breaks this logic, we route a new |was_opener_suppressed| param through > the NavigationController:LoadUrlWithParams() flow to recover the > behavior. > > Bug: 1155577 > Change-Id: I84739a9f4ec0df9a867f91397f80b46eea1bcee6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575223 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838275} Bug: 1155577 Change-Id: I1ab5bf85e62525e898bd9e9a6986ed844a7a5c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600016 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Yi Gu authored
Bug: 1015645, 1138322 Change-Id: I88a989a5cfad63383dbd47b95bfe665837d57c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595257Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
-
Alex Ilin authored
The size of a cr-theme-icon element is computed incorrectly if the element doesn't have `display: block` property. This leads to a subtle bug when displaying a `box-shadow` around a focused element. Fixed: 1161116 Change-Id: I908b5e997c01db0db00574319c49029ef438b3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611025 Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
