Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 15 Aug, 2018 23 commits
  3. 14 Aug, 2018 17 commits
    • Chris Mumford's avatar
      Revert "cros: Enable touchable app context menus by default." · 32cd8fcf
      Chris Mumford authored 
      This reverts commit b58ccf6d.

Reason for revert: Possibly introduced a use-after-free bug.

This is a speculative fix for a use-after-free bug in two ash_unittests:

1. OverflowButtonInkDropTest.MouseContextMenu
2. OverflowButtonActiveInkDropTest.MouseContextMenu

[ RUN      ] OverflowButtonInkDropTest.MouseContextMenu
=================================================================
==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188
READ of size 8 at 0x613000031f68 thread T0
    #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30
    #1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670
    #2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168
    #3 0x8c82105 in HasObserver base/observer_list.h:267
    #4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543
    #5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15
    #6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13
    #7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15
    #8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33
    #9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1
    #10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45
    #11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5
    #12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634
    #13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588
    #14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969
    #15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
    #16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
    #17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
    #18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
    #19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
    #20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
    #21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
    #23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
    #24 0x72b9892 in Run base/callback.h:99:12
    #25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
    #26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
    #27 0x178df94 in main ash/test/ash_unittests.cc:37:10
    #28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88)
freed by thread T0 here:
    #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3
    #1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7
    #2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19
    #3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3
    #4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
    #5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
    #6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
    #7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
    #8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
    #9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
    #10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
    #12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
    #13 0x72b9892 in Run base/callback.h:99:12
    #14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
    #15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
    #16 0x178df94 in main ash/test/ash_unittests.cc:37:10
    #17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

previously allocated by thread T0 here:
    #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3
    #1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15
    #2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14
    #3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10
    #4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334
    #5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3
    #6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27
    #7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11
    #8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3
    #9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3
    #10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30
    #11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14
    #12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3
    #13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3
    #14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21
    #15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18
    #16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20
    #17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778
    #18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
    #20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
    #21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
    #22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
    #24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
    #25 0x72b9892 in Run base/callback.h:99:12
    #26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
    #27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
    #28 0x178df94 in main ash/test/ash_unittests.cc:37:10
    #29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin
Shadow bytes around the buggy address:
  0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
  0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
=>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd
  0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa
  0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==28149==ABORTING

Original change's description:
> cros: Enable touchable app context menus by default.
> 
> This will enable:
>  - New context menu UI for:
>   - Application icons
>   - Shelf context menus
>   - Desktop context menus
> 
> Note:
>  - Removed tests whose functionality were already being tested.
>    - MouseContextMenu already tests whether the ink drop is being
>      shown, so there is no need for
>      ShelfButtonShowsInkDropHighlightOnMenuShow.
> 
> Bug: 871843
> Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058
> Reviewed-on: https://chromium-review.googlesource.com/1170985
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582978}

TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org

Change-Id: Ib85676861251f41c84f48f956d36c01edb353266
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 871843
Reviewed-on: https://chromium-review.googlesource.com/1174641Reviewed-by: default avatarChris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583088}
      32cd8fcf
    • Xida Chen's avatar
      Add detailed debugging in TouchActionFilter · 3b945abb
      Xida Chen authored 
      Previously we added some debugging instrumentation in TouchActionFilter,
when the allowed_touch_action_ is set or reset to non-Auto. The results
that we see is not enough to diagose the crash.

This CL adds more detailed debugging. In particular, whenever it is set
or reset, we add a string.

Bug: 851644
Change-Id: I2d19055c1008659365f9c3f54fcbdb30760b2166
Reviewed-on: https://chromium-review.googlesource.com/1174696Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583087}
      3b945abb
    • Greg Kerr's avatar
      Roll src/third_party/cros_system_api/ a2a458bd5..c0be49956 (7 commits) · 9ff16e01
      Greg Kerr authored 
      https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/a2a458bd5d69..c0be499563b8

$ git log a2a458bd5..c0be49956 --date=short --no-merges --format='%ad %ae %s'
2018-08-13 kerrnel cryptohome: Add MOUNT_ERROR_REMOVE_FAILED.
2018-08-07 chirantan seneschal: Add storage location field
2018-08-07 mcchou service_contants: Add kErrorAlreadyExists to bluetooth_device namespace
2018-07-25 hendrich shill: Remove PriorityWithinTechnology property
2018-06-18 akhouderchah shill: Added new error strings for Service::ConnectFailure additions
2018-07-13 ljusten dbus/login_manager: Add deletion error string
2018-06-13 lndmrk Add DBus constant permission_broker::kPowerCycleUsbPorts

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 211405
Change-Id: Iffa3919af789c351199aba156ccea181adcb8fdb
Reviewed-on: https://chromium-review.googlesource.com/1175005Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583086}
      9ff16e01
    • John Chen's avatar
      [ChromeDriver] Fix --whitelisted-ips on Mac · 147ceb36
      John Chen authored 
      ChromeDriver was not starting successfully on Mac when --whitelisted-ips
option was used. This CL fixes it, while ensuring that ChromeDriver
always listen on the same IPv4 and IPv6 ports

Bug: chromedriver:2541
Change-Id: I2024e3c27ea0fcf262c7b5c54791b86ae6a3e0c1
Reviewed-on: https://chromium-review.googlesource.com/1175059
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583085}
      147ceb36
    • afdo-chromium-autoroll's avatar
      Roll AFDO from 70.0.3521.0_rc-r1 to 70.0.3522.0_rc-r1 · f616c50c
      afdo-chromium-autoroll authored 
      This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I132e5ebea28a97bd88b82f0d421ca716468822f4
Reviewed-on: https://chromium-review.googlesource.com/1175213
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: default avatarafdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583084}
      f616c50c
    • Quan Nguyen's avatar
      cros: For arrow-nav in views login, properly handle "no users" and "no user focused" cases. · a88d0e12
      Quan Nguyen authored 
      Previously, the login screen would crash in both these cases (e.g. if
the powerwash confirmation dialog popped up and the user pressed
left/right arrow).

Change-Id: I5880d72112508de93e77c507239ea28c475d86ae
Reviewed-on: https://chromium-review.googlesource.com/1174907
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: default avatarJacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583083}
      a88d0e12
    • Ben Pastene's avatar
      Re-enable DCHECKs on amd64-generic simplechrome cros CQ bot. · a1694874
      Ben Pastene authored 
      The sanity test looks much more stable:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel-vm-tests

This should be safe to land now.

Bug: 869904
Change-Id: Ic0d7e5537e9212b7f7aaf0250041c5a73353279d
Reviewed-on: https://chromium-review.googlesource.com/1174968Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: default avatarAchuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583082}
      a1694874
    • Quan Nguyen's avatar
      cros: Don't shift login bubble right if it covers part of the anchor. · 873ea7a6
      Quan Nguyen authored 
      This is a bit closer to webui-login's behavior (although currently it doesn't
gracefully handle bubbles extending past the bottom of the screen). This also
prevents the auth error bubble from suddenly jumping to the right if it extends
into the shelf a bit.  This Cl also changes the error bubble bounds calculation
to include all of the black box, rather than just the internal content.

Bug: 873953
Change-Id: I13d670a208418f77232c59b756fb7854e1c88cc2
Reviewed-on: https://chromium-review.googlesource.com/1175196Reviewed-by: default avatarJacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583081}
      873ea7a6
    • David Black's avatar
      Fix line wrapping. · 0b0d0625
      David Black authored 
      Line length should not exceed 376dip and should have a line height of
24dip.

See bug for spec/demo.

Bug: b:112597108
Change-Id: Ic0b920d33bc0d571b98f7622a0e9d0fb965c74f1
Reviewed-on: https://chromium-review.googlesource.com/1175057Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#583080}
      0b0d0625
    • Chromite Chromium Autoroll's avatar
      Roll src/third_party/chromite db93180205a6..a2f48ac5546b (1 commits) · 5f4706af
      Chromite Chromium Autoroll authored 
      https://chromium.googlesource.com/chromiumos/chromite.git/+log/db93180205a6..a2f48ac5546b


git log db93180205a6..a2f48ac5546b --date=short --no-merges --format='%ad %ae %s'
2018-08-14 dgarrett@google.com chromeos_config: Disable chrome_binhost_only globally.


Created with:
  gclient setdep -r src/third_party/chromite@a2f48ac5546b

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I1355c118e89be711526f97554a00095b413eb52b
Reviewed-on: https://chromium-review.googlesource.com/1174798Reviewed-by: default avatarChromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583079}
      5f4706af
    • edchin's avatar
      [ios] Disable flaky TabGridMediator tests · a24c6d48
      edchin authored 
      Previously we thought this was only flaky on devices. It is also flaky
on simulator.

TBR=justincohen, javierrobles

Bug: 873633
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iddc823fc1034ba26db75da1b42a63a864e58878a
Reviewed-on: https://chromium-review.googlesource.com/1175194Reviewed-by: default avataredchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583078}
      a24c6d48
    • Helen Li's avatar
      Remove unused SqlitePersistentCookieStore::Close() · edd838a5
      Helen Li authored 
      This CL removes unused SqlitePersistentCookieStore::Close().

Bug: 801910
Change-Id: Ibba90aaeb5c07215de73e85f33bb5c4067cf9f42
Reviewed-on: https://chromium-review.googlesource.com/1174948Reviewed-by: default avatarMaks Orlovich <morlovich@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583077}
      edd838a5
    • Joel Hockey's avatar
      Crostini installer ssh keys error message · 81eb7576
      Joel Hockey authored 
      Tbr: tbuckley@google.com
Change-Id: Ia9079c26605d5cee901b46a13335985ca4ec9e49
Reviewed-on: https://chromium-review.googlesource.com/1174575
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: default avatarJoel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583076}
      81eb7576
    • Xiyuan Xia's avatar
      mash: Clean up AnswerCardWebContents deps · 8dc4077b
      Xiyuan Xia authored 
      Move AppListView::ExcludeWindowFromEventHandling from browser process
to app list code in ash process.

Bug: 854787
Change-Id: I7509fdd8c5cc4ea0db211bdc4c7fe8715fb10660
Reviewed-on: https://chromium-review.googlesource.com/1170036
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583075}
      8dc4077b
    • Peter K. Lee's avatar
      Requires ios_firebase_resources_target defintion if firebase enabled. · 340e51f3
      Peter K. Lee authored 
      Firebase target depends on a Firebase resources target instead of a
file path. Build configurations that want Firebase enabled should
define a target to bundle GoogleService-Info.plist to application
bundle.

At the same time, unit test and Earl Grey test targets need Firebase
SDK too.

Bug: 848117
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I902437afc93dcef39ccdbc89287638ae9d761afe
Reviewed-on: https://chromium-review.googlesource.com/1162713
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583074}
      340e51f3
    • v8-ci-autoroll-builder's avatar
      Update V8 to version 7.0.234. · 83f6a1e7
      v8-ci-autoroll-builder authored 
      Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5ce57437..4f1630e3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I40321b5e2126f7f905e77c76998acc5246e51e59
Reviewed-on: https://chromium-review.googlesource.com/1175088Reviewed-by: default avatarV8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583073}
      83f6a1e7
    • Wenzhao Zang's avatar
      cros: Fix black shadow issue for login shelf buttons · 02c0da02
      Wenzhao Zang authored 
      Verified it works on a Paine. This is a regression caused by
https://chromium-review.googlesource.com/c/chromium/src/+/1138861

Bug: 873609
Change-Id: I929fb3be9f0f811d901811aebf34c8c52ea42bf2
Reviewed-on: https://chromium-review.googlesource.com/1175192Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583072}
      02c0da02