- 03 Sep, 2020 40 commits
-
-
Makoto Shimazu authored
Tbr: mlamouri@chromium.org No-Try: true Bug: 1124352 Change-Id: Icd33fe6153b2659cf7ea0e4ded327ecdd0ceff84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390610Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804136}
-
Chih-Yu Huang authored
Originally, we rely on ARC side to determine if the playback is secure or normal by passing a flag at initialization. But we could get the information from the input buffer directly. In this CL, we determine if the playback is secure by querying ProtectedBufferManager with the first input buffer. If we can get the corresponding protected buffer, then we consider the playback as secure. Otherwise, we consider it as normal playback. BUG=b:153608694 TEST=play sintel at Google Play Movie on rammus-arc-r Change-Id: I0e30ca169a36223b9d82854f3382303a68c1ba3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377040 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#804135}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/683beccf6776..7571f9e49024 2020-09-03 johnstiles@google.com Replace 'typedef xxxxx INHERITED' with 'using INHERITED = xxxx;'. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I60377e2dc95e384ed03fda5958d1300c4f6d12af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391052Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804134}
-
Kent Tamura authored
* Fold it into LayoutBox like other form control elements. * Introduce IsSliderContainer() to share identical code between LayoutBox and LayoutTheme. * Move kDefaultTrackLength from LayoutSliderContainer to SliderIntrinsicInlineSize() in layout_box.cc This CL has no behavior changes. Bug: 1040826 Change-Id: I70bb3c67a1fbdc40502e36ca68d890719fc02f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392280Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804133}
-
Arnaud Mandy authored
These files need to be accessible when running wpt outside chromium environment. see: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#mojojs This is the first step towards making these tests pass outside the Chromium CI Bug: 1123988 Change-Id: Ie151810cdd55e474857670e092a8e036923a8e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390202Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#804132}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ffd1d826be3..46877765c47c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I79a8129c51cc460316fe6281b83551c3d3e8992b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392261Reviewed-by:
-
Hesen Zhang authored
Bug: 1096224 Change-Id: Ic697d934bc1975ef45f446a9bfc3acd713b385cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389540 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804130}
-
Makoto Shimazu authored
This reverts commit 69caa3d0. Reason for revert: AccessibilityFocusHighlightBrowserTest.FocusAppearance looks failing. https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/37326 Original change's description: > Reland "Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest" > > This is a reland of b89144a4 > > Original change's description: > > Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest > > > > AX-Relnotes: n/a > > > > Bug: 1114959 > > Change-Id: Ib6d9f51a04fa8059dc6bd6192d182b8e0244367d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352451 > > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Joey Arhar <jarhar@chromium.org> > > Reviewed-by: Mason Freed <masonfreed@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803007} > > TBR=ellyjones@chromium.org,masonfreed@chromium.org,jarhar@chromium.org > > Bug: 1114959 > Change-Id: I1997496df505691103568989a9cbfaa38e4e9b0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388025 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804034} TBR=ellyjones@chromium.org,dmazzoni@chromium.org,aboxhall@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Change-Id: I28f6ebeabe7204a329ff6fd4f42b87312ff9829e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390586Reviewed-by:
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/c03c18e7fe..930fbec75b Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/c03c18e7fe..930fbec75b Bug: None Change-Id: Ife0309227c5970506a08fa96db6bd79b2e7f8bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391082Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#804128}
-
Kent Tamura authored
This doesn't change rendering behavior, but changes |getComputedStyle(element)['appearance']| results. The new behavior matches to Firefox. Bug: 965432 Change-Id: Id354dd63f0034f2863f594aaf653c624123979b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389880 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Kalvin Lee authored
This change implements PpdProvider::ResolvePpdLicense(). Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdProviderTest.ResolvePpdLicense' Change-Id: I649397270fa45b809f8039fdee7808b55621a8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355008 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#804126}
-
Yuichiro Hanada authored
The mojo call is connected to InputConnection.setComposingRegion() in Android side. Bug: b:163013722 Test: components_unittests Change-Id: I4dd9d76f8788fb76e649fd8418c84ef56c8cc6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352453 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#804125}
-
Meredith Lane authored
AX-Relnotes: N/A Bug: 1025300 Change-Id: I2ec0d66d0d7df2a2d618029e1fc496b642532d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391941 Auto-Submit: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#804124}
-
Jit Yao Yap authored
This CL updates Remote Apps so that the App List is dismissed when launching the app from the context menu. Bug: 1101208 Change-Id: Ic52f2e81bfd458ff3b68db65f14e0188617b2ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388285 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804123}
-
evliu authored
This CL updates SODA to take in a path to the language pack direcotry instead of a path to the dictation.ascii_proto config file. SODA will instead choose the appropriate config file to use within the language pack directory. Google3-side changes: cl/326259391 Bug: 1124367 Change-Id: I3ec52682a1d22afe9077a9ddfdb02c054319fa14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391283Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#804122}
-
mhasank authored
session_manager_client uses observer_list which allows reentrancy by default i.e. it allows adding more subscribers while it is firing the events on the observers. One event that causes the problem is when the container is shutdown. When the user is attempts the retry of opt-in flow then we first shutdown the container and then restart the flow by creating a new container. However, when we create a new container, another subscriber is added to session_manager_client and it has not yet completed firing the ArcInstanceStopped event so the new container also is incorrectly detected as shutdown. With this change, we are going to safely invoke the observers and ignore the new subscribers during invocation of events. Currently there are five consumers of the observer interface 1. login_display_host_webui.cc implements OnLoginPromptVisible and plays a sound 2. arc_session_manager.cc implements OnLoginPromptVisible and starts a mini instance. 3. owner_settings_service_chromeos.h implements OwnerKeySet and reloads keys 4. device_settings_service.h implements OwnerKeySet and PropertyChangeComplete and reloads settings 5. arc_container_client_adapter.cc implements ArcInstanceStopped where the problem was occurring initially From the code inspection it is clear that the change should not cause any regression since we're not relying on the same event being fired while handling the event in question for the same instance of container. BUG=b:164816080 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: Ic820d4f014d5890c68aef99512e38de5acfb0279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381050Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#804121}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7f5e0320..4cac73d9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf61f3231a9124373a6f2e548a4931c84988193c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390519Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804120}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3c0e0582acfa..75690ce7ef4a 2020-09-03 sugoi@google.com DescriptorPool error fix 2020-09-03 sugoi@google.com Only use clang specific directives when clang is used If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1122889 Tbr: swiftshader-team+autoroll@google.com Change-Id: I430b5305489aeb1087aab664a82cb032bc339292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391834Reviewed-by:
-
Kalvin Lee authored
This change modifies ParseForwardIndex() to account for the presence of licenses in forward index metadata. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataParserTest.*' Change-Id: I6af51413dc26d7a8cb213a5bee8be35332b4f409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354908 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
-
Nicholas Hollingum authored
MouseEvent.movement() stores the platoform-dependant "Raw mouse motion" values, as reported by hardware. It is currently only available on windows. Support for the value is indicated by the presence of the flag EF_UNADJUSTED_MOUSE. In this CL, we add support for this on CrOS. We intend to use this in order to improve the relative pointer handling in Exo, which requires unaccelerated mouse motion (and currently we only have access to accelerated motion). This change is only implemented for CrOS (for now) because: 1) previously it was only implemented for windows, so cross-platform is not a hard requirement. 2) For our use case, the intended user is zwp_relative_pointer.cc, which is only compiled for CrOS. Bug: 957455 Change-Id: I9b6ca1740dcfb6aaba60c32f268270b3b0d386a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277694Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#804117}
-
Yuki Shiino authored
Reenable http/tests/serviceworker/service-worker-gc test since the test seems passing stably. Bug: 1111410 Change-Id: Ia4cbea9443004c3a6881220561d27150d7388ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389743Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#804116}
-
rbpotter authored
There is no value to running these tests with the PDFViewerUpdate flag disabled, as they are unit tests for elements not used in the old UI. Bug: 1120279 Change-Id: I55ae870f749f8737ab4076c59fbb8619856243c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391763Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#804115}
-
Meilin Wang authored
We should keep the same user policy as lock-screen media controls: namely, the ambient media string should only be available on lock-screen when the corresponding pref has been enabled. Bug: b/167488694. Test: unittested. Change-Id: I26256f1160ab869054fa18ec4360ab2cfd6f1815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380143 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804114}
-
rbpotter authored
Some tests already passed with the PDFViewerUpdate flag enabled, and others were recently fixed by https://crrev.com/803276. Run these tests in both flag states. Refactor some test classes to reduce repeated code. Bug: 1120279 Change-Id: I62d476c0999b8c973757c7bf96ee5066d5182131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391726 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Minggang Wang authored
Currently, IsURLHandledByNetworkService() util is used by ResourceDispatcher, which will be removed along with OnionSoup. This patch moves IsURLHandledByNetworkService() into Blink, so that we could onion-soupify the ResourceDispatcher. To enable this change, also moves the kFtpProtocol feature from content_features.h to Blink's features.h, as it's used in the impl of IsURLHandledByNetworkService(). Bug: 1110032 Change-Id: I9ee2101b15c1d2c409a7090375d65486b2e84bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389412Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#804112}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ffd1d826be3..46877765c47c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9082513c59e1e21477667e6726a359bd8d109cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390973Reviewed-by:
-
Tina Wang authored
Previously the button won't be read and the users can't double tap to show the popover when voiceover is on. Bug: 1123788 Change-Id: I0e638b5f14fea8cddd67b1e7c8525b38bfd82c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387151Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804110}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/51a5e3389cef..600d59e343a0 2020-09-02 apodtele@gmail.com [truetype] Reduce Infinality footprint (cont'd). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I83b94c02caf1ed78601c18ba885fdaa1b8aa0ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391367Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804109}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46877765c47c..96dcbc6eb372 2020-09-02 treehugger-gerrit@google.com Merge "perfetto-ui: Improve bug report dialog" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ieebbae68a48a023d41bfe1f022cd6c78bf717fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391051Reviewed-by:
-
Brian Sheedy authored
Fixes the Gold interaction code not properly handling the case where a bug on Gold's end prevents it from writing a triage link to the provided file. Bug: 1124368 Change-Id: Ic3e9a4d8808b97831fba1c4f42338b6b1435acde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391505 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#804107}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f88ee785. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Ic06f87a8013745c063cb511088e1373f3177ce71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391544Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804106}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88d9ad2f3b2d..a6cebd4f5bf5 2020-09-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8f071df2533db0a6306a7711c6ad74f4c1a39c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391836Reviewed-by:
-
Sinan Sahin authored
A runnable is set to run once the slide-in show animation is complete. However, the show animation is never run if a tab modal dialog is shown. Once the dialog is dismissed after the status indicator is hidden (though it was never really shown), the runnable ends up running and tries to access the model, which is null. The fix is to check that the indicator has a positive height in addition to checking that the current min-height offset is equal to the height. This makes sure we don't run the mOnShowAnimationEnd runnable after the status indicator is hidden. Bug: 1122906 Change-Id: I1a0a7d9ef231b198de1ee96fd9af89602ede03e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382874Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#804104}
-
Hirokazu Honda authored
VaapiWrapper owns VABufferIDs of the VA buffers that are used outside of VaapiWrapper. This CL moves the ownership out of VaapiWrapper. The VA Buffers are owned by ScopedVABuffer in order to prevent the buffer leakage. Ths ScopedVABuffer will be used for other VABufferIDs later. Bug: b:166646505, b:162962069 Test: video_encode_accelerator_tests on atlas Test: media_unittests --gtest_filter=VaapiVideoEncodeAcceleratorTest Test: vaapi_unittest --gtest_filter=VaapiUtilsTest Change-Id: I7b0dda7491d29ebba70bc42051a8657144209dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379423Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#804103}
-
Robbie McElrath authored
Bug: 1123686 Change-Id: Ide2078acfcbe13404a41afb6df9eceb870986d09 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386117Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#804102}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: If18a818ef82e7b5a0256e2d385eeb6fb1db292bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382072Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#804101}
-
Makoto Shimazu authored
This reverts commit 8258fb07. Reason for revert: The test seems to be still flaky. https://crbug.com/1123786 Original change's description: > Reland "[Cast MRP] Stop mirroring immediately when a the tab is closed." > > This is a reland of f51b93d7 > > Original change's description: > > [Cast MRP] Stop mirroring immediately when a the tab is closed. > > > > Bug: 1095764, b/159154368 > > Change-Id: I36829467e3a6477499c76ae0b15e110acba00c89 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346911 > > Reviewed-by: Yuri Wiitala <miu@chromium.org> > > Commit-Queue: John Williams <jrw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803343} > > Bug: 1095764 > Bug: b/159154368 > Change-Id: Ib3fbf021e10e48b3cb7289427ed130b01109a71d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388153 > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Auto-Submit: John Williams <jrw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804019} TBR=miu@chromium.org,jrw@chromium.org Change-Id: I39378cce3c1e9951fc4d10d64f535d44ca87832b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1095764, 1123786 Bug: b/159154368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392224Reviewed-by:
-
Devlin Cronin authored
Extensions can be "transitively-visible" in the toolbar, such as when they are unpinned, but showing a popup. Add test coverage for checking the "pin" string in the context menu during this state. Bug: 1100412 Change-Id: I5880111fc4a31bc35cb2e49dd8846a2f919031ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390951Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804099}
-
Jimmy Gong authored
- This class exposes an AttemptConnection() function to connect the local Chrome OS to a remote phone device. - Also exposes a GetStatus() function to retrieve the current status of the connection. Bug: 1106937 Test: unit_tests Change-Id: I2851cd28ba83034af8c2bddcc17f5a50ddd0c90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387149 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#804098}
-
Moe Ahmadi authored
- Displays trending icon for non-historical matches with SUBTYPE_TRENDS. - Adds Vector and SVG icons for use in Omnibox and Realbox respectively. The SVG was optimized using svgomg and converted to .icon using skiafy. Omnibox: https://screenshot.googleplex.com/7iRhFnNGXP2Kh4j Realbox: https://screenshot.googleplex.com/FjvWaT4DXonaFWz Bug: 1122669 Change-Id: Ic9fd6594e633128eed0c2ff621509acdddf100f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386096Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804097}
-
