- 22 Jul, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/398319047f2c..14ddd018d942 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC orphis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: orphis@google.com Change-Id: I8d8782c13541eab45c5936c018f280fb0e23b644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311944Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790769}
-
Friedrich Horschig authored
This CL replaces the image view with the default more button in Chrome. When clicked, it opens a menu that offers the delete option which ends up asking the bridge to remove the selected credential. Additionally, this CL fixes some enum declarations and provides a minimal implementation for the PasswordCheckObserver in order to set up and test the wiring for the event handling path. Bug: 1106726, 1092444 Change-Id: I2ef8cf1fa037fbbd6e83097f6bbbd07fdfe65e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306260Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790768}
-
arthursonzogni authored
MediaCanPlayTypeTest.CodecSupportTest_HLS MediaCanPlayTypeTest.CodecSupportTest_mp3 MediaCanPlayTypeTest.CodecSupportTest_mp4 TBR=dalecurtis Bug: 1090770 Change-Id: I484d9840b343386f696d563aab3182219a69822f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310536Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#790767}
-
Gyuyoung Kim authored
This CL migrates PageMsg_SetInsidePortal to the blink's PageBroadcast interface as InsidePortalChanged method name. Additionally, this CL adds |is_inside_portal| parameter to WebView::Create to remove SetInsidePortal in WebView because it is only called by RenderViewImpl::Initialize once. Bug: 1102426 Change-Id: I2d981efefb380d2e3d92f5eb862b939975564603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302974 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#790766}
-
Victor Hugo Vianna Silva authored
crrev.com/c/1478878 started exposing the web signout state as a DisableReason in the SyncService API. This caused a number of bugs when kStopSyncInPausedState was enabled, the main reason being that the presence of a DisableReason causes the class to consider sync-the-feature as disabled. The CL removes the DISABLE_REASON_PAUSED and adds a new transport state PAUSED. IsEngineAllowedToStart() now checks that a) no reason to disable sync-the-feature exists; b) sync is not in the paused state. The feature flag is still kept as DISABLED_BY_DEFAULT, pending experimentation on Canary/Dev. TBR=parastoog@google.com Bug: 906995 Change-Id: I533da440835330ffbbbaaf3862b9343f16149f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302149 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790765}
-
Kent Tamura authored
Also, add many #includes to *.cc files which relied on local_frame.h in the headers. This CL has no behavior changes. Bug: 242216 Change-Id: Id6ab1f10ef5444b3d99847aab4fd240a8f51a0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311602 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#790764}
-
dizg authored
Bug: 1105865 Change-Id: I6a2b6ef0ec3e73511be20be190f74de64a5a8b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302619Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Diana Zagidullina <dizg@google.com> Cr-Commit-Position: refs/heads/master@{#790763}
-
arthursonzogni authored
Same as in: https://chromium-review.googlesource.com/c/chromium/src/+/2306043 Disable failing MediaCapture tests on Lollipop and Marshmallow Tablet Tester bots. Tests: MediaCaptureTest#testMediaCapture_basic MediaCaptureTest#testMediaCapture_rememberPermission MediaCaptureTest#testMediaCapture_twoStreams MediaCaptureTest#testMediaCapture_twoStreamsNotification For unknown reasons, the previous patch was ineffective. This patch tries to disable based on the Android version. BUG=1107380 TBR=estade@chromium.org Change-Id: I471cbaa1b29f47c378c9fc03a394aa39f089944b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311579Reviewed-by:
-
Maksim Moskvitin authored
This file isn't even used in any build.gn files. Bug: 1105388 Change-Id: I4b4ab6c7c24b1f260b8a4cbb2c3c02697bba7574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296086 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibfe5317a1c300bd3628f66aac1d6cd3896b37a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311945Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790760}
-
Arthur Sonzogni authored
This reverts commit 6b1e649d. Reason for revert: Fail to compile. https://crbug.com/1108238 Original change's description: > Merge blink::WritingDirection to mojom::TextDirection > > In this CL, WritingDirection {kNatural, kLeftToRight, kRightToLeft} is > replaced by TextDirection {UNKNOWN_DIRECTION, RIGHT_TO_LEFT, > LEFT_TO_RIGHT} and dependant files are ported to use |TextDirection| > enum. > > Bug: 1088377 > Change-Id: Iac185f2d34eddd78127c3f59b7dc90fe380b5f34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306127 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> > Cr-Commit-Position: refs/heads/master@{#790314} TBR=kojii@chromium.org,abhijeet@igalia.com Change-Id: If73ac51c1f0ed22c4a1962884c735d70eb9dd7b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1088377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310537Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1595373454-95f078484e58a8592358a4d377034f6d1c7c30df.profdata to chrome-win32-master-1595383207-383ffdc8ec941b58d960256b6aec4daee6f9b86f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I01d3e318dad670a9b2a00d5d4ca41c7a44b0a14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311624Reviewed-by:
-
Jeremie Boulic authored
Add "need password" enumeration values for the CrosDisksClientMountError and CrosDisksMountTypeError metrics. Bug: 912236 Change-Id: I099c9801f5fd1651fae016c89472e084f06651cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303935 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#790757}
-
Mugdha Lakhani authored
Now that all prerender browsertests have been ported over, delete the class the unused methods. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I069ba05d37e11f40e82d867e32cea2e15e07cdba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307336Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#790756}
-
Mugdha Lakhani authored
Componentize PrerenderObserver and PrerenderObserverList so WebLayer can use it to support NoStatePrefetch. Bug: 1096088 Change-Id: I6012e2a5699d21dc695cad913772f072986cd8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308725Reviewed-by:
-
Richard Stotz authored
As a missing function gives a TypeError, one of the WPTs for renameSync would pass when renameSync is not implemented, which is counterintuitive. Bug: 914488 Change-Id: I4c16cf55723b772b0cba5c5c3acd376165e25591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310531Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Richard Stotz <rstz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790754}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I226faa90591b1564587ff33f00da203c93adf746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311937Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf6e84f91568..2675d65f6664 2020-07-22 szuend@chromium.org Migrate issues module to use devtools_entrypoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e9e2f64afc4f01e1b8e2a82fc1749b6c521ad9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311727Reviewed-by:
-
Yuki Shiino authored
Prioritizes the receiver check in the new IDL interface implementation over [Measure], etc. Bug: 839389 Change-Id: Ib799685540fb4f4cad837c94648a45c278c6bcbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305815 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#790751}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595373454-79eaab8f620a7766eb9eee9c5fee25e0cd6be377.profdata to chrome-mac-master-1595397501-73227feb72e80d042b6cedd93932654832bac5dd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I84f4db63e992d09a42578a55b8637fb3adb4ce38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311728Reviewed-by:
-
Hayato Ito authored
This reverts commit f56c8f8e. Reason for revert: win-asan is consistently failing See http://crbug.com/1108222 Original change's description: > Reland "Add test that verifies CFG loader config is generated correctly." > > This is a reland of c2b6797f > > Fixed to add CALLBACK in front of the callback function. > > Original change's description: > > Add test that verifies CFG loader config is generated correctly. > > > > This CL adds a test that creates a callback from operating system > > code to a module that has CFG enabled where the callback is not > > listed as a valid indirect target. > > > > Note: this test does not require dispatch guards to be present > > in chromium code, just for them to be present in OS code and > > for the CFG load config to be generated correctly. > > > > BUG=584575 > > > > Change-Id: Id6f5f4061f7237c23f08c8fe1b7471ea200f0628 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308854 > > Commit-Queue: Will Harris <wfh@chromium.org> > > Reviewed-by: Alex Gough <ajgo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790587} > > Bug: 584575 > Cq-Include-Trybots: luci.chromium.try:win7-rel > Change-Id: Ie721a3f3aebcb3ff1eaae711e588ba1ec8a6e507 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311038 > Reviewed-by: Alex Gough <ajgo@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790690} TBR=wfh@chromium.org,ajgo@chromium.org Change-Id: Ifa2fd1bea09548f9993661a4bf0d08726c2b83c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 584575 Cq-Include-Trybots: luci.chromium.try:win7-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312036Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#790749}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d8ee8b15. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I38b13f6a9927043cb65eacfd8d600f1cddd6a7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311800Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790748}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96dc2c70cf5b..492e4daa3747 2020-07-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ibf60931d3136ada407b3e869333a5c44d24630e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311936Reviewed-by:
-
Jose Dapena Paz authored
GCC refuses to compile the recently added ConstructAndNotifyElementImpl Construct method, that gets a template specialization inside the struct namespace. This is not working in GCC. To avoid that, we avoid the template specialization using a new struct for when type is garbage collected, and select the struct with std::conditional. Bug: 819294 Change-Id: Ibd88999c2667b1130c0132864ec692b1e0a8fbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304575Reviewed-by:
-
Hayato Ito authored
Disable the failing test on Linux. Bug=1108205 TBR=miu@chromium.org Change-Id: Ie388ca75a2fadce937d613994847217e7f9579fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310271Reviewed-by:
-
jchen10 authored
This parses the codec information in EncodedVideoConfig. Size has to be explicitly specified in the config as well. With these changes, a basic VP9 encoding and decoding test can run correctly. This test can also cover the path of creating ImageBitmap from hardware decoder VideoFrame. Bug: 897297 Change-Id: Ifbac15db0305bcd781786707916b94be5a151215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301590 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#790744}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1c42d4ee7bcb..11fa4d0d5694 2020-07-22 johnkslang@users.noreply.github.com Merge pull request #2348 from ben-clayton/thread-local If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I94a859ef673e60b5c5df25022fac5db09d10170e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311086Reviewed-by:
-
Jan Wilken Dörrie authored
This change is a simple search and replace to rename base::win::String16FromGUID to base::win::WStringFromGUID. This is a better name, since the function was changed to return a std::wstring. TBR=dcheng Bug: 911896 Change-Id: I846674496295b1545d0890627611d5fa2ceb34f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308718 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#790742}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/964c4089cb51..f6659b3df028 2020-07-22 syoussefi@chromium.org Vulkan: Fix invalidate + deferred clear 2020-07-22 syoussefi@chromium.org Vulkan: Fix deferred clears and noop clear and blit 2020-07-22 courtneygo@google.com Inline depth/stencil clear if in middle of renderpass If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ib6864bfcc87096efab947b71256bb9f1a6062423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311087Reviewed-by:
-
Yuki Shiino authored
The build rule of V8 context snapshot is missing some deps, and this patch supplements them. Bug: 839389 Change-Id: I875a194718f32d291b582da5071ec28dd992f08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307849 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Kalvin Lee authored
This change migrates the Chromium browser's primary documentation for CL footers from the Chromium site: https://dev.chromium.org/developers/contributing-code/-bug-syntax into the in-tree contributing guide. There are two bugs to correct the language used in this change: * https://crbug.com/1108213 * https://crbug.com/1108214 Test: Gitiles preview Change-Id: I3c67aa008c3d77edc373531a8a698e3af033be0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311826 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#790739}
-
Jose Dapena Paz authored
In decoder selector test, we alias DecoderSelector to the instantiated template (i.e. DecoderSelector<media::DemuxerStream::AUDIO>). GCC does not allow that as the alias name clashes with template name. To solve it we rename the alias to be MockDecoderSelector. Bug: 819294 Change-Id: I8ca0664df9b874fd5bd0c1db3397cbd17d14e084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310492Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#790738}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e102dafa79a..398319047f2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419,chromium:1106471,chromium:1106878,chromium:1107845 Tbr: hayato@google.com Change-Id: I8228d698b7f9abd90ca239d9a0c7840facea74bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311725Reviewed-by:
-
Yuki Shiino authored
Implements ReportCoopAccess in the new binding generator. Bug: 839389 Change-Id: I76cbc937e8dee63abbebeafedc834060b8fca5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306111 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Greg Thompson authored
With this CL, mini_installer now holds the files it creates open with FLAG_DELETE_ON_CLOSE so that they are automatically deleted by the filesystem when they are no longer needed. The most risky operation is the multi-step process to drop write permission on the files so that they can be opened for consumption by parties that do not allow writers. New process exits codes have been introduced to track whether or not this operation fails in practice. BUG=516207 Change-Id: Ic5e25692cf3dca0fcc7cd01faf5759648f5c6890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307250Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790735}
-
Julie Jeongeun Kim authored
When a modal dialog appears, GetChildCount and ChildAtIndex just consider the modal dialog and skip other children. Since GetIndexInParent compares itself with all siblings to get the index, if the parent has a modal dialog, it couldn't find anything matched. This CL returns nullopt on GetIndexInParent if its parent has a modal dialog. AX-Relnotes: n/a. Bug: 1104282 Change-Id: I3c8b45fe96aa188fd29aa63bc5fd4b1fc0bac476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299664 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#790734}
-
Dominic Farolino authored
Context: LazyLoadFrameObserver::LoadImmediately only expects to ever be called one time. Before this CL, both LocalFrame::Navigate and RemoteFrame::Navigate didn't immediately call HTMLFrameOwnerElement::CancelPendingLazyLoad(). Therefore if LazyLoadFrameObserver::LoadImmediately() was called, and attempts to navigate a frame but the navigation fails before CancelPendingLazyLoad() was called (which can happen due to the navigation rate limiter etc.), LazyLoadFrameObserver::LoadImmedaitely may be called a second time by the underlying intersection observer which still observes the element. R=sclittle@chromium.org Bug: 1106290 Change-Id: I77f052c5d5a113d0c35f702322d6dc6ec831650b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303352Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595128170-8aaf6de27e89b142e6e1e7e7a3316cb88b9b2b37.profdata to chrome-win64-master-1595373454-124f6f7a8fdf3bef9667f80d39ed93302475736e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If3d2f06d87356d871de8f64635862c6db2c8b272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311083Reviewed-by:
-
Trent Apted authored
Currently it bails out early due to a missing dependency on accessibility_common/accessibility_common.js The file was moved to accessibility_common/autoclick/autoclick.js, but it doesn't compile so comment out the build target. The move happened in r780890 and r781588. AX-Relnotes: n/a. Tbr: katie@chromium.org Bug: 1108171 Change-Id: I3ea751c538b689cf7515529e80aa50f1b101b642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311838 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#790731}
-
Hayato Ito authored
Skip the following tests on Mac as they seem to be failing. - http/tests/devtools/tracing/timeline-js/timeline-script-id.js - virtual/threaded/http/tests/devtools/tracing/timeline-misc/timeline-event-causes.js TBR=aerotwist@chromium.org BUG=1107572 Change-Id: Idd6fa34188bf5efc5acb84f9bc5b8febbecd68e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310020Reviewed-by:
-
