- 04 Apr, 2020 23 commits
-
-
Oksana Zhuravlova authored
This change removes ContentBrowserClient::BindInterfaceRequestFromFrame() overrides from AwContentBrowserClient and ChromeContentBrowserClient. This will allow us to remove ContentBrowserClient::BindInterfaceRequestFromFrame() in a follow-up CL. Bug: 1062403 Change-Id: Ic5c52f4e76fe964d547f24386366f5e3ac59f398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134927Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#756496}
-
Matthew Porter authored
Removed SetImageFromVectorIcon as that function is no longer used. Also removed a not needed function off the #include statements Bug: 1056948 Change-Id: I4bb8a3146455d45bee24ef911aed7d3bb4f60cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133549 Commit-Queue: Matthew Porter <matt.porter@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756495}
-
Andres Calderon Jaramillo authored
CL:2122484 overrode ProvidePictureBuffersWithVisibleRect() in VdaVideoDecoder in order to fix an issue where the coded size of a VideoFrame was not being advertised correctly to the client. This fix must also be applied to GpuVideoDecodeAccelerator. Otherwise, an AssignPictureBuffers() call can fail due to the validation in [1]. This CL makes the default implementation of ProvidePictureBuffersWithVisibleRect() behave as in VdaVideoDecoder. However, it only does so when the texture target is GL_TEXTURE_EXTERNAL_OES; otherwise, it uses the same implementation as before. In order to test, I adapted the video_decode example that comes with the Native Client SDK to use a 1920x1080 video which triggers this problem. Before this CL, no video would be rendered and we would get validation errors from [1]. After this CL, no errors are observed in the logs and the video is rendered. I tested this across multiple devices. Kukui is the only one that failed (Native Client says it's a crash) but this happens even before CL:2122484, so it's not a regression caused by the series of fixes for the referenced bug. Nyan_kitty shows a small white artifact on the bottom that will need to be addressed later. The test results are in [2]. [1] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc;l=1275-1286;drc=2b1b0cc6e2fa7c34965c39caa561e28e9e831626?originalUrl=https:%2F%2Fcs.chromium.org%2F [2] https://drive.google.com/open?id=1ErWDq9bd3ZnLnPU3uhlGQ2zV6zJw7wyT Bug: 1062002,1067794 Test: kevin, kukui, eve, hana, nyan_kitty with procedure described above. Change-Id: I0177f63ab7d19ca196646a017ee532880ec555fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134417 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756494}
-
Xida Chen authored
This CL adds a new throughput test story, to test the cases where the main thread is extremely jank, and that the throughput can be 0. Bug: 1048187 Change-Id: Ifdd44d165652489de8b41965921801894fba86f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134929Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756493}
-
Klaus Weidner authored
This is a workaround for an issue where the WebXR framebuffer content is displayed out of order, leading to jumpy animations and other glitches. Until the root cause is identified, disable shared buffer frame transfer, and instead use the Mailbox+Surface path. This was originally intended for use on Android N which doesn't support AHardwareBuffer, and is less efficient due to needing an extra pixel copy, but the APIs are still supported on current Android versions. Bug: 1067795 Change-Id: I256f878836eeac201934392ec6ce79f9f2fd7c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135957Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#756492}
-
Arthur Wang authored
R=hypan@chromium.org, jbudorick@chromium.org Bug: 1066503 Change-Id: I8bc1617f7ed2c2ff0b194114e5fe981075145e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135130Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b70ef7756a4d..0d8e8366806d Created with: gclient setdep -r src-internal@0d8e8366806d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1055164,chromium:912681 Tbr: jbudorick@google.com Change-Id: I00debdd0758a059f282be542087895439f18c11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136271Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756490}
-
Wan-Teh Chang authored
Change-Id: I7572d81f261f1f7277ec1d1fc8bf9d089174f411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134784Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756489}
-
Dan Harrington authored
Added more events we'll need for metrics. Trying to organize and name these all 'Report*' to make it clear they don't have side-effects other than for reporting metrics. Bug: 1044139 Change-Id: I57931817550ae52f91df4fd10b359575efec5e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135873 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#756488}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/63f96a1f9b5e..ad392d71ebed $ git log 63f96a1f9..ad392d71e --date=short --no-merges --format='%ad %ae %s' 2020-04-03 code CI: Remove port number from registry URL 2020-04-03 code CI: style: Allow the name 'David' in connection with copyright 2020-04-03 code CI: Add debug messages to style checks 2020-04-03 victorien x86: add some explanatory comment to wiener_filter_h 2020-04-03 wtc Look up __pthread_get_minstack only in glibc 2020-04-03 wtc Update a stale comment for dav1d_alloc_aligned() 2020-04-02 martin x86: mc: Skip checks for zero leftext/rightext within the need_left_ext/need_right_ext blocks 2020-04-01 rsbultje Skip loop restoration cache buffer resize for too-small buffers 2020-03-29 rsbultje x86: add SSSE3 versions for filmgrain.fguv_32x32xn[422/444] 2020-03-30 rsbultje x86: use btc instead of xor+test or 32byte alignment in fgy_32x32xn_ssse3 2020-03-28 rsbultje x86: add AVX2 versions for filmgrain.fguv_32x32xn[422/444] 2020-04-01 rsbultje x86: use btc instead of xor+test in fgy_32x32xn_avx2 2020-03-31 gramner Align dav1d_resize_filter[] 2020-03-31 rsbultje x86: don't use vptest in SSSE3 version 2020-03-30 rsbultje x86: add SSSE3 version of mc.resize() 2020-03-27 rsbultje x86: add AVX2 version of mc.resize() 2020-03-26 rsbultje checkasm: add test for mc.resize() 2020-03-27 rsbultje Invert src_w/h argument in mc.resize() 2020-03-27 rsbultje Make dav1d_resize_filter[] negative so it fits in int8_t Created with: roll-dep src/third_party/dav1d/libdav1d Change-Id: Ieb08bddc67521175b5297ef0326700cdab132cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135897 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#756487}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Since there was already a similar test already in WPT, this CL also renames it adding the -001 suffix to it, so that we can consistently add this new one as a -002 one. Bug: 1063749 Change-Id: Ibb6f0ef3783cf9805e339f70b0e7616369cbc752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133936Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#756486}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/36e67aa86981..2eb4bd46bdb8 git log 36e67aa86981..2eb4bd46bdb8 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 egdaniel@google.com Fix some d3d ref counting. Created with: gclient setdep -r src/third_party/skia@2eb4bd46bdb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I2696b2c1dee1cce34e8208afeedbfae531c1502e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756485}
-
Jian Li authored
ListContentManagerImpl supports both native view and external view. The methods defined in feed/v2/FeedActionHandler has been merged to xsurface/FeedActionsHandler, except navigate* methods that are already included in xsurface/SurfaceActionHandler. Bug: 1044139 Change-Id: Ic708a1295e2a0e6700f5b72195940a8bd365c76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133110 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#756484}
-
Pavel Yatsuk authored
Test fails to receive callback about url focus change. Screenshots indicate that url bar didn't get focused. I suspect that OmniboxTestUtils.toggleUrlBarFocus logic to tap in the middle of the view doesn't correctly focus urlbar in some cases. If that's the case then directly calling urlBar.requestFocus() would work better for this test. This CL adds check to see if urlbar got focused. BUG=812066 R=twellington@chromium.org Change-Id: I9b120fa6cb2cf68b95a34f1e08c4143bf6e5787a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136060 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756483}
-
Aaron Leventhal authored
Bug: None Change-Id: Idb3c060bcaa162c0ba316a797fd59df19a185b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134392 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756482}
-
John Budorick authored
Pretty sure this has been unused for years. Change-Id: I573e2f58dcce72bf6a6ec74ca560fd71d23388b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135901Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#756481}
-
Alex Turner authored
Currently, in ContentSubresourceFilterThrottleManager:: DidFinishNavigation, there is a call to NavigationConsoleLogger:: LogMessageOnCommit. This always results in a message being immediately added to console, as it is only called for committed navigations. For simplicity, and as the other functionality of NavigationConsoleLogger is unnecessary for this purpose, we change this call to a direct call to RenderFrameHost::AddMessageToConsole. This will also aid in minor refactoring planned for crbug.com/1055558, which will factor out this code path into a function and pass it as a callback for a posted task in certain cases. This change avoids the need to pass a pointer to a navigation_handle, which may be in the process of being deleted, to any posted task. Bug: 1067010 Change-Id: I7a3f3a8fed2bfbac23955afe5f45f5a43c22c46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132779 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#756480}
-
Su Hong Koo authored
Add ash::features::kDisplayIdentification flag to enable display identification in the settings. Bug: 1062499 Change-Id: Ifec242fa48c57e6a9965725ddf32d73728800991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083597 Commit-Queue: Su Hong Koo <sukoo@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#756479}
-
Lei Zhang authored
Bug: 1067755 Change-Id: I5d52f194788aeaf211f3035892ca9d2a7d8f66fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134673 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#756478}
-
Karandeep Bhatia authored
This CL starts loading all the static rulesets provided by an extension. BUG=754526 Change-Id: Idba883ec8f54211d2933d755033b1e7fdebef4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131218 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756477}
-
Joey Arhar authored
This test is failing on msan. I can reproduce locally with the following gn args: is_component_build = false is_debug = false is_msan = true msan_track_origins = 2 use_goma = true TBR=sandersd@chromium.org,dominickn@chromium.org,hiroh@chromium.org Bug: 1067758 Change-Id: I83549612a97e35c06081da320398213a7bc1914d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136119Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#756476}
-
Lukasz Anforowicz authored
Before this CL, random tests in the RenderFrameHostManagerTestWithSiteIsolation test suite would flakily fail when calling content::Compositor::Initialize from RenderFrameHostManagerTestWithSiteIsolation::SetUp: Check failed: !CompositorImpl::IsInitialized(). Because of the above, the CL removes the call to CompositorImpl::IsInitialized and disables the TwoTabsCrashOneReloadsOneLeaves testcase, because the disabled test case fails without such call - it hits another DCHECK - one in RenderWidgetHostViewChildFrame::SetFrameConnectorDelegate: about |parent_view->GetFrameSinkId().is_valid()|. The CL doesn't simply move the call to CompositorImpl::IsInitialized into the single test case that needs it, because of concerns about the first flaky DCHECK (the one about |!CompositorImpl::IsInitialized()|). Bug: 1067432 Change-Id: Ib1febb7252b4628573f64c7971b917a261aef24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135900 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#756475}
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: Ic6ee035e7ac32362ea3392534acd3af71ef0c87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135896 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756474}
-
- 03 Apr, 2020 17 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1575b47cd3bd..5540fdbe7451 git log 1575b47cd3bd..5540fdbe7451 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 bravi@microsoft.com Modify test to validate tabbing over links and highlights 2020-04-03 tsepez@chromium.org Store uint8_t vector data in data partition in fxcodec/ 2020-04-03 tsepez@chromium.org Store uint8_t vector data in data partition in fxge/ 2020-04-03 thestig@chromium.org Consolidate more work into CFX_WideTextBuf::ExpandWideBuf(). 2020-04-03 thestig@chromium.org Roll v8/ 633234050..1668abddd (139 commits) 2020-04-03 nigi@chromium.org Refactor image comparing code into _RunImageDiffCommand(). 2020-04-03 bravi@microsoft.com Tests added for Action handling of enter key press over buttons. Created with: gclient setdep -r src/third_party/pdfium@5540fdbe7451 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028991,chromium:994500 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I80bf6dffc717be0bcab83155fa382e445525503b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136200Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756473}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1c82afee. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." edb8adb1 "Implement and ship RTCRtpSendParameters.degradationPreference" 7e979350 "Handle k-rate AudioParam inputs for PannerNode" c39d7360 "ImageLoader: Stop storing request KURL in Task" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I7bcada754b5b830fc4a8fe00581c6e07bb454e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136166Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756472}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d9c51142bd01..38cf390f9cf2 git log d9c51142bd01..38cf390f9cf2 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9dce00d2..22aaaa25 (756252:756379) Created with: gclient setdep -r src/third_party/webrtc@38cf390f9cf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7a7fb73f28877c5c470d32d73737633400a8244f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756471}
-
Mustafa Emre Acer authored
The delayed warnings experiment should only handle phishing pages. It doesn't make sense to run it for other threat types, as the goal is to understand the effect of different URL display modes to phishing threats. This CL also fixes a DCHECK when there are multiple unsafe resources in the current WebContents. The old code assumed that the method to create the user interaction observer could only be called once per WebContents. In reality, it's called for each unsafe resource, so this CL ignores subsequent calls. Bug: 1057157 Change-Id: Ifb87dae060c2a08c37aeef55835c318ba7bcdfec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130626 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756470}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b6e7ef1092b7..36e67aa86981 git log b6e7ef1092b7..36e67aa86981 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 bungeman@google.com Mark dawn and shaderc as third_party. 2020-04-03 bsalomon@google.com Make copy proxy in GM budgeted when texgen policy is kDraw. 2020-04-03 mtklein@google.com every label has a use 2020-04-03 csmartdalton@google.com ccpr: Don't use half float vertex attribs 2020-04-03 reed@google.com plumb camera info down to devices 2020-04-03 jvanverth@google.com Set gn output_dir variable for test apps. 2020-04-03 jvanverth@google.com Add GrD3DBuffer. 2020-04-03 kjlubick@google.com [canvaskit] Add gm helper functions to tests. Created with: gclient setdep -r src/third_party/skia@36e67aa86981 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: Idabcbb6fe0f2e40d72b668a2f7407ee9f5ffe46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756469}
-
Pavel Yatsuk authored
When test scenario involves tab switching, the toolbar is animated into view. ChromeTabModalPresenter has a logic that prevents it from running enter animation when toolbar animation is not finished (browser controls are not fully visible). Because of this logic modal dialog view is not added to container view immediately in ModalDialogManager.showDialog call. On the other hand Espresso's onView(...).check() call verifies condition immediately and asserts if the condition is not met (descendant with a particular text is not present in container view). This causes occasional test failures. Semantically test should verify that a dialog with particular text is shown at some point. Container view visibility it closest approximation to a condition that modal dialog view is added to the container. In this CL I add helper that polls UI thread waiting for dialog container to become visible. BUG=1030683,1030903,1031092 R=twellington@chromium.org Change-Id: Id1a42aefa45ee50d26171ecbff662c44226ad056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134401Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#756468}
-
Yuly Novikov authored
Don't specify ssd dimension. TBR=kbr Bug: 1064477 Change-Id: Idd00b8601bbfd072bf4043ee27c9beebeb56c915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136270Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#756467}
-
Peter Kotwicz authored
This CL deprecates: - WebApk.Permission.ChromeWithoutPermission - WebApk.Permission.ChromePermissionDenied2 I am deprecating the metrics because we did the analysis we were planning on with the metrics and no longer need them. BUG=1064849 Change-Id: I068372555566daa03859e1cd1afc490a0c961d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121430 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#756466}
-
Peng Huang authored
Tested with AMD GPU on WIndows 10. Bug: 1067709 Change-Id: I0c7147ef6e2cb9338304f5692f66f6e0715986c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135980Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756465}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/390ef29999bc..96c26c681bc7 git log 390ef29999bc..96c26c681bc7 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 m.maiya@samsung.com Add support for NV_shader_noperspective_interpolation 2020-04-03 jmadill@chromium.org Pass layer count to robust 2D array texure init. Created with: gclient setdep -r src/third_party/angle@96c26c681bc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I635422d4989ea65e96e2a0d750ed36724bab9e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136050Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756464}
-
Matthew Jones authored
Bug: 1067737 Change-Id: I698b88bcdc00f8ffc59eaada119f0c92bd54f929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134518 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756463}
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: I10ae4609d00c1ad2c23c04226e2ac930149fe1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136086 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756462}
-
Maggie Chen authored
It is for the debugging purpose only and it wil have a performance impact. The code will be removed immediately once valid crash dumps are collected. Bug: 885066,885066 Change-Id: Ie8761ed4e6050a07e76af0a030b67dab5bb011e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129028 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756461}
-
John Budorick authored
Bug: 922145 Change-Id: Ic21bfc796baa5d8b8f55a5dedef7b9eaa35aa5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135340Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#756460}
-
Tao Bai authored
Bug: 1067334 Change-Id: Ibf64b31d7ad6289a9a1ab5f4aab1fcf4dcbd14eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134611 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#756459}
-
chrome://signin-errordpapad authored
Fixed: 1012533 Change-Id: Id45159fb7fcf33ac14b954cc05d6139dd4abbbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132941Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#756458}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e06125cb520f..ad6d1b30e0f1 git log e06125cb520f..ad6d1b30e0f1 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 amaiorano@google.com Really fix Android build Created with: gclient setdep -r src/third_party/swiftshader@ad6d1b30e0f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Idb24445b6d1b20980267cb21a085b1b46b9a10ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136137Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756457}
-