- 22 Dec, 2017 40 commits
-
-
David Reveman authored
This enables motion-stills by default and adds a feature flag for turning it off. Bug: 769140 Test: chrome --disable-features=ChangePictureVideoMode Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia2eef2d627914572d95c91d08e876e5e37d282e6 Reviewed-on: https://chromium-review.googlesource.com/842703 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#526052}
-
Jiaquan He authored
This commit does miscellaneous work in preparation for breaking ChromeAppListItem from AppListItem to make future CL smaller, with the following change: - For ChromeAppListItem: - overriding AppListItem methods explicitly; - moving methods into proper scopes; - add test apis for non-public methods in tests. - For (Chrome)AppListModelUpdater: - adding more methods that will be used; - moving methods into proper scopes; - grouping and reordering methods by their behaviors; - add test apis for non-public methods in tests. Bug: 733662 Change-Id: I3e9661b83b8b5493afe4fa4847edef48d01951f7 Reviewed-on: https://chromium-review.googlesource.com/841755Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#526051}
-
Sahel Sharify authored
org.chromium.chrome.browser.vr_shell.VrShellControllerInputTest#testControllerScrolling failed after landing browserside touchpad fling. The resean for this regression is that with touchpad fling the proper event stream is WebMouseWheelEvents from which Gesture scroll events are generated and then a GFS event with touchpad source. However in VR while scrolling with touchpad Gesture scroll events are directly injected to RWHI rather than injecting WebMouseWheelEvents and then generating gesture scroll events from them. The proper fix is to make the VR event stream similar to the proper event stream for touchpad scrolling but meanwhile this cl fixes the issue by handling the VR case separately. The fix has three parts: 1- The ProgressFling is called in RWHV_Android to progress the fling. It used to get called only on Aura for touchpad flings on chromebook. 2- is_in_gesture_scroll_ DCHECK logic in RWHI is changed for Android VR: When a GFS with touchpad source gets handled by FlingController, the controller sends wheel events to progress the fling. In Android VR the is_in_gesture_scroll_ should get reset on GFS since the first wheel event sent by the FlingController will cause a GSB generation in MouseWheelEventQueue. This GSB generation happens since during scrolling with touchpad the WebContentsEventForwarder directly injects gesture scroll events to the RWHI rather than injecting wheel events. Once Motion events are used for VR event processing this DCHECK change must get back to what it was. 3- Input_handler_proxy used to assume that nonblocking wheel events have always had a blocking wheel event before them. This assumption is not valid anymore since as explained in number 2, in VR case the first wheel event that is send by the flingController is nonblocking and it doesn't have any wheel events prior to it since the scrolling is directly handled by gesture scroll event injection. TBR: dtapuska@chromium.org, tdresser@chromium.org Bug: 797322, 797299 Change-Id: I9ab4e8236c6fd274d84e3d571ef0fc2388ec17e1 Reviewed-on: https://chromium-review.googlesource.com/842707 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#526050}
-
Hector Carmona authored
Bug: 791666 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I847476ac80c96d7df6e66ea4547d6fab32845b38 Reviewed-on: https://chromium-review.googlesource.com/835470 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526049}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/92c7fa6b009b..0482ced2cd10 $ git log 92c7fa6b0..0482ced2c --date=short --no-merges --format='%ad %ae %s' 2017-12-22 rmistry Revert "Update isolate binaries and update isolate recipe" 2017-12-22 csmartdalton CCPR: Initial semi-optimized vertex shader Impl Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I74d3ca0e2c67e3af79ce572928d269e715725691 Reviewed-on: https://chromium-review.googlesource.com/843054Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526048}
-
Kevin Marshall authored
The new SDK contains the Fuchsia package archival tool "far". Bug: 707030 Change-Id: I41ecbe9e946919734f487ee824a48be177953a13 Reviewed-on: https://chromium-review.googlesource.com/843049Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#526047}
-
Ian Vollick authored
With this CL, a layer may preclude squashing by subsequent layers in paint order. NB: it makes no attempt to handle cases where layers change sort order due to relative position in a 3D rendering context. I plan to add the test separately. It's in progress here: crrev.com/c/842946 Bug: 788807 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I817a7ddc6f446b7d65dde2c4b4d88a6ac8912549 Reviewed-on: https://chromium-review.googlesource.com/832668Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#526046}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/221b12666ff6..11556464a62e $ git log 221b12666..11556464a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtcBUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia75feb4ebfb112437d71febc05502595b3ff3da0 Reviewed-on: https://chromium-review.googlesource.com/843052Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526045}
-
Jonathan Metzman authored
Bug: Change-Id: I85fd75a9d8c70e2ed106a34e567bd2b95e8984ca Reviewed-on: https://chromium-review.googlesource.com/826709Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526044}
-
Dominic Mazzoni authored
Originally landed: crrev.com/c/833221 Reverted: crrev.com/c/837517 Moved the code that sets roles to ignored out of the code shared with Chrome OS and manually verified that the lock screen works now. Instead of only using NativeViewAccessibility on some platforms, rename the base class ViewAccessibility and make it a general-purpose class for view accessibility code. Potential benefits of doing it this way: * View subclasses like Slider wouldn't need to add a special method like SetAccessibleName. Instead any client could override the name or any other property directly: view->GetViewAccessible().SetName(...); * Creates a means to share more code with AXViewObjWrapper. * Creates a way to have a single consistent ID for all Views, making relations between views easier. As a next step, these could be moved from View to ViewAccessibility, further simplifying view.h: HandleAccessibleAction(const ui::AXActionData& action_data); gfx::NativeViewAccessible GetNativeViewAccessible(); void NotifyAccessibilityEvent(ui::AXEvent event_type); Bug: 796350 Change-Id: I61f88707a7f302bafdf1f5cb5fe4b2faa6a9095c Reviewed-on: https://chromium-review.googlesource.com/837901Reviewed-by:Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#526043}
-
Lei Zhang authored
Change-Id: Ic0c82bda4051f2e005354bf04e0352faf181122a Reviewed-on: https://chromium-review.googlesource.com/842251Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#526042}
-
Lukasz Anforowicz authored
After r512625, various ways of viewing page or frame source end up going through RenderFrameHost::ViewSource which depends on ability to present the view source WebContents to the user via WebContentsDelegate's AddNewContent method. This method was not overriden by ExtensionOptionsGuest, leading to https://crbug.com/796080. This CL fixes https://crbug.com/796080 by overriding ExtensionOptionsGuest::AddNewContent and making it forward the call to the embedder. This CL also adds a regression test for this scenario. Note that by default guest views cannot open new windows - this is blocked (unless the embedder explicitly allows this) and results in "<webview>: A new window was blocked." error message. This CL does not change this - window.open('<url>', '_blank') as well as <a target="_blank"...> in a guest view will continue to be blocked by default. I've tested this manually after temporarily overriding AddNewContent method higher in the class hierarchy - in GuestViewBase. See also https://crbug.com/796080#c7. A follow-up bug has been opened to investigate if AddNewContents method should instead be implemented in the base class of ExtensionOptionsGuest - in GuestViewBase: https://crbug.com/797340. Bug: 796080 Change-Id: I83ece7fc94bbf1005c5e2878159076949c48b076 Tbr: finnur@chromium.org or rdevlin.cronin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/841623 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526041}
-
Lei Zhang authored
Its functionality has been duplicated by PdfToEmfConverterClientImpl. Change-Id: If5f832b7d282b6da19ccaf6ebe85d9e4988e3e8e Reviewed-on: https://chromium-review.googlesource.com/842250Reviewed-by:
-
Anthony Zhang authored
Newly added observers are not currently notified of existing devices. If ScanDevices() is called before all observers are registered then some observers will miss device events. Bug: 70595920 Test: Observers receive OnDeviceEvent() correctly when registered Change-Id: Ia04b894773ac676409e2d6d12b31e3b3801eb140 Reviewed-on: https://chromium-review.googlesource.com/841424Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Anthony Zhang <antz@chromium.org> Cr-Commit-Position: refs/heads/master@{#526039}
-
Katie Dektar authored
This reverts commit 15df088c. Reason for revert: Breaks PFQ trybots Bug:797339 Original change's description: > Use ChromeVox utils in Select-to-Speak to support future changes. > > Includes a closure_shim.js that allows Select-to-Speak to use these > files without closure. > > This is temporary, eventually ChromeVox and Select-to-Speak should > both pull these utility files from one shared location. > > Bug: 713303 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I0bb93e5989e2ea83d89a500b6d92134031e78f07 > Reviewed-on: https://chromium-review.googlesource.com/834206 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525820} TBR=dmazzoni@chromium.org,dtseng@chromium.org,katie@chromium.org Change-Id: I108428209aec17d0c88e0feee21837da7eb4d769 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797339 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/843206 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#526038}
-
Yuke Liao authored
This CL implements tracking build dependency files for targets, configs, toolchains and pools and write corresponding unit tests to verify the behaviors. Bug: 795913 Change-Id: I3f7a9302db0725ef8167160838448e7eb39c4eee Reviewed-on: https://chromium-review.googlesource.com/838220 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#526037}
-
Weidong Guo authored
Changes: Remove |mirrored| in DisplayLayout and related code because mirror mode restoring no longer depends on DisplayLayout any more. Bug: 791881 Change-Id: I99c5d7d443e0ab511c0c6003190c4e09843f97d9 Reviewed-on: https://chromium-review.googlesource.com/835626Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526036}
-
Marijn Kruisselbrink authored
TBR=rdevlin.cronin@chromium.org Bug: 770305 Change-Id: Ia8f61e1bbc8aa9f2af1fe4f47bcb7a2d1050edaa Reviewed-on: https://chromium-review.googlesource.com/842223Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526035}
-
Sadrul Habib Chowdhury authored
Remove the version of FindViewAtLocation that takes a gfx::Point. All the callers can use the version that uses a gfx::PointF wihout having to do extra work. So update the code to do that. Also, make TargetData::delta a gfx::Vector2dF because blink event locations are floats. BUG=796649 Change-Id: Ib1f8d19671a642aed5f111b03a22a632521e33af Reviewed-on: https://chromium-review.googlesource.com/841724Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#526034}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1fa9c434fc0d..92c7fa6b009b $ git log 1fa9c434f..92c7fa6b0 --date=short --no-merges --format='%ad %ae %s' 2017-12-22 ethannicholas fix usage of deprecated SkMatrix44 constructor 2017-12-22 kjlubick Quarantine android bots instead of shutting off device Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ia78c37ce90fe05647189d435d99c58f43764bc1e Reviewed-on: https://chromium-review.googlesource.com/843064 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
The tests has nothing to do with canonicalization, so this patch removes the usage of VisibleSelection to keep the test cases simple. Bug: 657237 Change-Id: Ib0d36734cface043d89118374e339c45938f945f Reviewed-on: https://chromium-review.googlesource.com/843046Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#526032}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/5626f3590eea..3b3f9e1e789d $ git log 5626f3590..3b3f9e1e7 --date=short --no-merges --format='%ad %ae %s' 2017-12-22 charliea Remove Benchmark.GetExpectations Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2736e53aca3945df1652af7f47170322e1acdfd4 Reviewed-on: https://chromium-review.googlesource.com/842109 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526031}
-
Michael Thiessen authored
testScreenTapsNotRegistered would fail when run locally with an INJECT_EVENTS permission error. This CL fixes that by injecting the event in a slightly different way. Bug: Change-Id: I04277ea74feb3de70a8472839992c9976763544d Reviewed-on: https://chromium-review.googlesource.com/843203Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#526030}
-
Daniel Bratell authored
Change-Id: I3a9785519bfe9d6b10972bbe7b70a3c9c3f5fdbc Reviewed-on: https://chromium-review.googlesource.com/842803Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#526029}
-
Daniel Bratell authored
The animation code has two different kDefaultTransationDurationMs depending on what code is used. This caused issues with jumbo builds where one of them shadowed the other one (scary). This renames them so that they have unique names, and also moves them into the same scope to keep things consistent. Bug: 773275 Change-Id: I77b5ab72e48a9c967105d8eb0b2610cfbd6f0b40 Reviewed-on: https://chromium-review.googlesource.com/841063Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#526028}
-
Tommy C. Li authored
Explicitly specifies that 'Flash' is the name of a plugin and should not be translated. Bug: 766447 Change-Id: I00d53a7628697720640cacfe5cd1e7f677d5e048 Reviewed-on: https://chromium-review.googlesource.com/831088Reviewed-by:
Anthony LaForge <laforge@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#526027}
-
Kurt Horimoto authored
This CL updates fullscreen to: - not perform an animation if a scroll ends when the toolbar is fully visible or hidden. - scale the scroll end adjustment animation duration to the fraction of progress change required. Bug: 796597 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8939fbdd93735155e41a9ed1e2d19d1b72902b4a Reviewed-on: https://chromium-review.googlesource.com/841535Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#526026}
-
Jeremy Roman authored
Bug: 796975 Change-Id: I61fc830dd8a6fdba1ed0eacd1d33416553b57e45 Reviewed-on: https://chromium-review.googlesource.com/842844Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526025}
-
Marijn Kruisselbrink authored
This test flakily times out on all platforms regularly. TBR=qyearsley@chromium.org Bug: 796668 Change-Id: I7412389b460b371c3d53976960d3b39cc40fc4a9 Reviewed-on: https://chromium-review.googlesource.com/842465Reviewed-by:
-
sreten.kovacevic authored
Adds support for usage of --dynamic-linker flag when using gcc. This allows user to specify path to custom dynamic linker. Bug: Change-Id: I3fcd549664e90e8a1eb2cbd190f47aa98b7f1f34 Reviewed-on: https://chromium-review.googlesource.com/763347Reviewed-by:
-
David Bokan authored
I've fixed various issues in telemetry that were keeping pinch-zoom tests from being enabled (see commits in bug). There should be nothing blocking this anymore so lets turn them back on. Bug: 610021 Change-Id: I71c380322655af213c20b73bb8361cd199d2b64e Reviewed-on: https://chromium-review.googlesource.com/843122Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526022}
-
Reza.Zakerinasab authored
After Skia rolls this recent CL to fix the alpha clamping issue in high filter quality (https://skia-review.googlesource.com/c/skia/+/87000), we can refactor ImageBitmap code path to unify high quality premul and unpremul. Bug: 787034, 796797 Change-Id: I2efc0c86b15b2f182e4af99afc538918d11f2f0d Reviewed-on: https://chromium-review.googlesource.com/840829Reviewed-by:
Olivia Lai <xlai@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#526021}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/5ec7e1276029..221b12666ff6 $ git log 5ec7e1276..221b12666 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtcBUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I804691e61357ba78fd2a2f47c5c6c26de3d3d88b Reviewed-on: https://chromium-review.googlesource.com/843007Reviewed-by:
-
Miguel Casas authored
This CL removes the content features kMojoVideoEncodeAccelerator and its surfacing to chrome://flags, because crrev.com/c/585512 removed the old IPC parts in favour of the Mojo path, thus rendering this flag effectively meaningless. Bug: 736517 Change-Id: Id0264d1c7e2382425f609219d7031ec799fa5f9f Reviewed-on: https://chromium-review.googlesource.com/843123 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
bsheedy authored
Moves the native URL lists that VrShellNativeUiTest#testUrlOnNativeUi and VrShellNavigationTest#testNativeNavigateAndInteraction use to a constant, and switches testUrlOnNativeUi to use a loop instead of duplicating lines for each URL. Bug: Change-Id: I0a4e7889a25375ebd760bdd408ba2014442f1927 Reviewed-on: https://chromium-review.googlesource.com/841402Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526018}
-
clamy authored
This CL cleans up the old navigation code from RenderFrameImpl. In particular, it removes the StartNavigationParams and the FrameMsg_Navigate IPC, which are no longer used. Bug: 789577 Change-Id: I3c4e7a1ed8b735095f05234acaabbbe028c45156 Reviewed-on: https://chromium-review.googlesource.com/842543 Commit-Queue: Camille Lamy <clamy@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
sczs authored
Since the locationBarContainer is expanded and its stackView is not, this CL creates a margin constant and anchors the bottomAnchor to the toolbar bottomAnchor, this way the Y position of the StackView is not changed during expansion or contraction. Bug: 796482 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I69aac20beb0a2b3b31d516b78da7b1b4ba3a6ab8 Reviewed-on: https://chromium-review.googlesource.com/841442Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#526016}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b2af9586a0f6..f2cb0f5b3ea5 $ git log b2af9586a..f2cb0f5b3 --date=short --no-merges --format='%ad %ae %s' 2017-12-21 joaodasilva Updated the gsutil version used by download_from_google_storage. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Ia55e13e39b29793ecc7ff97ffad1612e249e1bdc Reviewed-on: https://chromium-review.googlesource.com/842904Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526015}
-
Doug Arnett authored
This add two Feature params for calculating an inflation value to apply for a loaded page with NoScript previews active. It uses the DataReductionProxyDataUseObserver to report the estimated extra original bytes (first capturing the committed PreviewsType during the main frame load and then making the calc at DidFinishLoad time based on the total network bytes). Bug: 781885 Change-Id: I0618fd2d8801364f72ba52178aeb57df7d4a098b Reviewed-on: https://chromium-review.googlesource.com/834807 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526014}
-
Bailey Berro authored
This change implements OpenFile and CloseFile in SmbFileSystem. Bug: 757625 Test: Open and Close called manually via UI, producing expected results Change-Id: Ib45025963afdaced2da646bda610e6a54b079f40 Reviewed-on: https://chromium-review.googlesource.com/840730 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#526013}
-
