GitLab

ShutdownAndBlock function can be called multiple times safely.
So checking |shutdown_completed_| in OnDisonnected function is not necessary.

BUG=174431
TEST=Checked no crash at sing out.


Review URL: https://chromiumcodereview.appspot.com/12212133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174924
TEST=on lumpy, launch the settings page, and confirm the setting is hidden.

R=nona@chromium.org
TBR=nkostylev@chromium.org
# TBR for just inverting the flag...

Review URL: https://chromiumcodereview.appspot.com/12207143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182160 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182159 0039d316-1c4b-4281-b951-d872f2087c98

This was broken by https://chromiumcodereview.appspot.com/12096096,
which refactored the code causing a 304 response to no longer
resulting in an early return.

I'll write a test in a follow-up CL.

BUG=175795
TEST=VariationsService logging shows that the seed
does not get reset when we get a 304.

Review URL: https://chromiumcodereview.appspot.com/12251003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182151 0039d316-1c4b-4281-b951-d872f2087c98

After switching the HudLayer to use skia's font rendering the FontAtlas has
become obsolete. This change removes the FontAtlas and all the related
plumbing.

BUG=172284


Review URL: https://chromiumcodereview.appspot.com/12212099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182150 0039d316-1c4b-4281-b951-d872f2087c98

I'm refactoring these APIs in the WebKit repo but can't sanely stage changes to
the API without breaking these OVERRIDE annotations since the interface and
implementations are in separate repositories. The clang plugin knows to not
enforce OVERRIDE for APIs in the WebKit namespace so this won't break that.


BUG=


Review URL: https://chromiumcodereview.appspot.com/12250021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182149 0039d316-1c4b-4281-b951-d872f2087c98

This function showed up as hot in the trace and should not have been explicitly implemented as non-inline (pushing the args for the function call costs as much as the copy itself so operator = should *never* not be inlined if it's just doing a normal copy)

BUG=175855


Review URL: https://chromiumcodereview.appspot.com/12250019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182148 0039d316-1c4b-4281-b951-d872f2087c98

There is timing issue around initialization, if the InputContext is initialized
after InputMethodManager, Reset function will be called with NULL object proxy.
This cause a crash. If the object proxy is not ready, calling Reset is not
necessary. So just doing nothing is fine.

BUG=174248
TEST=None


Review URL: https://chromiumcodereview.appspot.com/12223084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182147 0039d316-1c4b-4281-b951-d872f2087c98

And put them in unnamed namespace.

TEST=browser_tests
TBR=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12220139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182146 0039d316-1c4b-4281-b951-d872f2087c98

turns out calling SetOverlayIcon() runs a nested message loop, which
can result in all sorts of problems (and crashes). Since we don't care
about the result I'm moving the call to a worker thread.

BUG=174768
TEST=none
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12212053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182145 0039d316-1c4b-4281-b951-d872f2087c98

This is preparation to replace |upload_url| of InitiateUpload methods in
DriveServiceInterface by resource id.

BUG=148632
TEST=Ran unit_tests


Review URL: https://chromiumcodereview.appspot.com/12226073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182144 0039d316-1c4b-4281-b951-d872f2087c98

This splits the network changed event into two separate events
and changes the events so that they report only the identifiers for
the networks, and not their properties.

Also fixed a bad bug in startDisconnect (was calling connect instead
of disconnect).

Modified the apitest so that we now run each test as a separate
browser test so that the networking stubs are reset between
tests.

BUG=chromium:168713


Review URL: https://chromiumcodereview.appspot.com/12220113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182143 0039d316-1c4b-4281-b951-d872f2087c98

happen with some code paths.

BUG=175600
TEST=none
R=sadrul@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12212144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182142 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174836

Review URL: https://chromiumcodereview.appspot.com/12212083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182141 0039d316-1c4b-4281-b951-d872f2087c98

I would also like to rename it to TouchEditingController since it is not just for selection. But that makes enough changes to the file to render git incapable of recognizing it as a move instead of a new file. So I will do the renaming in a separate CL.

BUG=115237


Review URL: https://chromiumcodereview.appspot.com/12224133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182139 0039d316-1c4b-4281-b951-d872f2087c98

It looks up the current preference through DesktopNotificationService
and reports failures when it's stopped.

BUG=161094


Review URL: https://chromiumcodereview.appspot.com/12221127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182138 0039d316-1c4b-4281-b951-d872f2087c98

Added a unit-test to BookmarkBarViewTest. It opens a context
menu. The menu is dismissed by clicking the mouse outside of
it. The underlying view gets the mouse event after the
context menu has exited.

See also: 
https://chromiumcodereview.appspot.com/11761027

BUG=171891
TEST=manual, Run: 
out/Debug/interactive_ui_tests --gtest_filter='BookmarkBarViewTest20.*'

Review URL: https://chromiumcodereview.appspot.com/12217158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182137 0039d316-1c4b-4281-b951-d872f2087c98

Surface caching is currently broken if any layers in the surface do not
draw themselves fully within the bounds of the surface for any reason
other than being occluded. This includes:
1) Being at non-ideal scale.
2) Being checkerboarded.
3) Missing a texture resource.
4) Having visibleContentRect clipped by something outside the surface.

This disables the feature entirely.

R=jamesr,vangelis
BUG=170713
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12210077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182136 0039d316-1c4b-4281-b951-d872f2087c98

BUG=152854

Review URL: https://codereview.chromium.org/12250024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175805
TEST=Added to browser_tests OomPriorityManagerTest. Also, manual test (see bug)

Review URL: https://codereview.chromium.org/12221159

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182134 0039d316-1c4b-4281-b951-d872f2087c98

The problem was caused by auto focusing to the first focusable control when switching pages. To show an overlay, a owning page is shown, very often to the same current one, what is causing setting focus to the first focusable item, and scrolling to the top just before showing an overlay. This patch addresses this issue by not changing focus if the current focused control is on the active page/overlay.

TEST=Follow the bug's repro steps.
BUG=174608

Review URL: https://codereview.chromium.org/12226110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182133 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175605
TEST=visual


Review URL: https://chromiumcodereview.appspot.com/12217146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182131 0039d316-1c4b-4281-b951-d872f2087c98

as well.

BUG=170936


Review URL: https://chromiumcodereview.appspot.com/12212155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182130 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 55e4b3b0.

BUG=173804


Review URL: https://chromiumcodereview.appspot.com/12208140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182129 0039d316-1c4b-4281-b951-d872f2087c98

of the Usb Api. Parameter limits are determined from the following:

packets: 4MB from http://msdn.microsoft.com/en-us/library/windows/hardware/ff538112(v=vs.85).aspx
packet_length: 65k since wMaxPacketSize is 16bit integer: http://msdn.microsoft.com/en-us/library/ee437177.aspx

BUG=169765
R=gdk@chromium.org,miket@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12096024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182128 0039d316-1c4b-4281-b951-d872f2087c98

Need time to address privacy issues.

BUG=175941
TBR=keybuk

Review URL: https://codereview.chromium.org/12251017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182127 0039d316-1c4b-4281-b951-d872f2087c98

Failures:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tests%20%28dbg%29&number=7589

> Expose the capturePicture feature in RenderView for Android WebView legacy API support.
> 
> These methods are required to implement WebView.capturePicture and WebView.PictureListener.onNewPicture.
> - http://developer.android.com/reference/android/webkit/WebView.html#capturePicture()
> - http://developer.android.com/reference/android/webkit/WebView.PictureListener.html
> 
> BUG=167908,167913
> 
> Review URL: https://chromiumcodereview.appspot.com/11861008

TBR=leandrogracia@chromium.org
Review URL: https://codereview.chromium.org/12211149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182124 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182122 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175858
TEST=Manual test by following the repro steps in the bug


Review URL: https://chromiumcodereview.appspot.com/12223114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182121 0039d316-1c4b-4281-b951-d872f2087c98

Launch data for apps no longer includes intents. This removes the custom
bindings code to translate the intent data, and also re-enables some tests
which were disabled.

BUG=175534


Review URL: https://chromiumcodereview.appspot.com/12223086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182120 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a new value to the net::SSLClientCertType that matches
DSA-based client certificates. This will be used by Android's client
certificate support code.

For an example, see https://chromiumcodereview.appspot.com/12220104/

More specifically:

- It modifies <net/base/ssl_client_cert_type.h> to add the new
  enum value.

- It adds a corresponding non-translatable string ID to
  chrome/app/generated_resources.grd, and ensures that the
  ClientCertTypeToString() function in cookies_tree_model_util.cc
  returns it appropriately.

- It adds SpdyCredentialBuilderTest.MAYBE_FailedWithDSACert
  unit test, similar to the MAYBE_FailedWithRSACert. This is
  based on the assumption that SPDY uses ECDSA certificates
  exclusively (no code supporting RSA-based ones was found
  under net/spdy).

Note that server-bound certificate unit tests have not been
modified (some of them handle both RSA and ECDSA certificates),
given that none of the production support code for this feature
seems to care about the certificate type, and that DSA-based
certificates are extremely rare in practice, and disappearing.

BUG=165668


Review URL: https://chromiumcodereview.appspot.com/12221136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182119 0039d316-1c4b-4281-b951-d872f2087c98

* Allowed overrides for methods.
* Fixed correct detection of base-type choices objects
* Added support for Array types; still no support for inline type definitions.
* Fixed detection of base & serialized types in external namespaces
* Some fixes in generated whitespace
* Fixes to allow type, method & function overrides


Review URL: https://chromiumcodereview.appspot.com/12221050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182118 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182117 0039d316-1c4b-4281-b951-d872f2087c98

This will allow us to revert texture clamping logic that reduces
the fill rate on some devices.

Instead of requiring us to clamp texture sampling, this patch
stretches textures by .5 texels past quad bounds to avoid
blending in invalid texels when GL_LINEAR filtering is used.

BUG=173480


Review URL: https://chromiumcodereview.appspot.com/12220133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182116 0039d316-1c4b-4281-b951-d872f2087c98

This CL also updates the client and host protocol handlers to the new name.

BUG=172404


Review URL: https://chromiumcodereview.appspot.com/12220092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182115 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/log/?rev=142684&stop_rev=142638&verbose=on

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/12218130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182114 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in https://gerrit.chromium.org/gerrit/#/c/43063/ to fix win64 ffmpeg on AVX machines.

BUG=174160


Review URL: https://chromiumcodereview.appspot.com/12217154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/12210150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182110 0039d316-1c4b-4281-b951-d872f2087c98

Needed by cc-frame-viewer. As noted in README.chromium, this is all unshipped and part of tooling.

R=vmpstr

Review URL: https://codereview.chromium.org/12251005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182109 0039d316-1c4b-4281-b951-d872f2087c98

fixes the crash while I wait for a review on 12208070

BUG=none

Review URL: https://codereview.chromium.org/12226125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182108 0039d316-1c4b-4281-b951-d872f2087c98