- 15 Nov, 2018 33 commits
-
-
Shawn Gallea authored
Move WaylandTouchDelegate out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: I8fc2cb3d52c76bdcc4d52c70e63beeb6cd403894 Reviewed-on: https://chromium-review.googlesource.com/c/1318737 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608211}
-
Nate Fischer authored
No change to logic. This adds metrics to track the scheme passed to loadUrl(). This also modifies our previous metric (tracking baseUrl() scheme) to distinguish between file:///android_asset/ URLs (and android_res) from other file:// URLs. This treats loadData() as "data:" scheme. This intentionally excludes loadDataWithBaseURL(). R=isherman@chromium.org, torne@chromium.org Bug: 901581 Test: run_webview_instrumentation_test_apk \ Test: --gtest_filter=AwContentsTest#testLoadUrlRecordsScheme* Change-Id: Ic09bf91a25ebeb7dd075337ae3e28e26e603c3ff Reviewed-on: https://chromium-review.googlesource.com/c/1334843Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608210}
-
Tarun Bansal authored
This CL adds logic for determining which URL to prefetch and records UMA around that. Note that navigation predictor is still running in dry-run mode, as in no prefetch is actually done. Change-Id: I620a3c10146f47b3bd2d8b042b54af0a5879fc90 Bug: 903945 TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1333247Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608209}
-
khmel@chromium.org authored
This preserves suppress Play Store show state in case Chrome was restarted during the previous session and initial OptIn flow is currently active. TEST=Locally, simulating that case + unit test BUG=b:119069366 Change-Id: Ifc30bf538baf42d6b91a20d8263d90e7d8962db2 Reviewed-on: https://chromium-review.googlesource.com/c/1331829Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#608208}
-
Yue Cen authored
Bug: 900736 Change-Id: I1413bbfb052850dc6ad2e9ca7137c40d2cd978d2 Reviewed-on: https://chromium-review.googlesource.com/c/1324369 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#608207}
-
dpapad authored
The following elements are only used in ChromeOS, so they don't have to be included in non-ChromeOS builds - iron-input - paper-input-container - paper-icon-item Bug:843350,899982 Change-Id: I376e811a6b53fca71ea5a14df479c6f958632547 Reviewed-on: https://chromium-review.googlesource.com/c/1336189Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#608206}
-
Sammie Quon authored
The logic to check if we should handle certain scrolls was moved to shelf_layout_manager.cc in [1]. The logic remaining in home_laucher_gesture_handler.cc is no longer needed. [1] https://chromium-review.googlesource.com/c/1307233 Test: manual Bug: 896790 Change-Id: Ic4b8a65ff8b4f6f3b5ed39147c09a68506bb1181 Reviewed-on: https://chromium-review.googlesource.com/c/1334648 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#608205}
-
Stefan Zager authored
When an xml-stylesheet is declared before the <html> element, the document's pending stylesheet count is incremented; but the count is not decremented when the xml-stylesheet finishes loading. This has no effect when UpdateStyleAndLayoutIgnorePendingStylesheets is used; but when that mechanism is removed, it blocks rendering, causing the test named below to fail. BUG=521692 TEST=fast/dom/StyleSheet/detached-style-pi-2.xhtml Change-Id: Ibadae4b66d5351cd58ed00ad654247f53fba6861 Reviewed-on: https://chromium-review.googlesource.com/c/1334946 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#608204}
-
Jun Mukai authored
My previous CL (crrev.com/606662) made a few typos in this function. Bug: 854346 Test: manually Change-Id: If9f1c94a28e3f88cbff58ae5b1549ed09aa3c2e6 Reviewed-on: https://chromium-review.googlesource.com/c/1336469Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#608203}
-
Ted Choc authored
This CL: https://chromium-review.googlesource.com/c/1331689 overzealously captures all key events instead of the previous logic that only handled a subset of th expected navigational keys. This restricts dispatching to the list view except for the previously expected keys. In particular, you can't type space in the current state, which is...unfortunate. BUG=898522 Change-Id: I55c055ae6f942cda833f2e3c678a458f55406741 Reviewed-on: https://chromium-review.googlesource.com/c/1336494Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#608202}
-
Yue Li authored
Bug: b/116166191 Test: Histogram unit_tests and Local build Change-Id: I55fc6579bd3346c9ecc7bdf9b2b90758101290e3 Reviewed-on: https://chromium-review.googlesource.com/c/1335963Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#608201}
-
Vlad Tsyrklevich authored
The crash handler needs to know where the GuardedPageAllocator in the crashing process is to determine if the crash is related to a GWP-ASan allocation. Use a crash key to transmit this information. Bug: 896019 Change-Id: I93428ec6d46ebefe2939ff74fab9cb9fd35782a2 Reviewed-on: https://chromium-review.googlesource.com/c/1330073Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#608200}
-
Max Moroz authored
That flag is now always enabled by default (https://reviews.llvm.org/D51251) and the analyzer errors out when the flag is passed via command line. Also adding myself as an owner for Clang Static Analyzer and Code Coverage related files. Bug: 901486, 759794 Change-Id: I54c9988c79f13287bb0580637d1a3ae4aa46bba7 Reviewed-on: https://chromium-review.googlesource.com/c/1330758Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608199}
-
Saman Sami authored
Bug: 900373 Change-Id: Ibaaeda2fcff69b5bf45eb7de767731bf53177f56 Reviewed-on: https://chromium-review.googlesource.com/c/1336510Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#608198}
-
Aiden Benner authored
Normally custom ErrorProne checks would catch this, but they were inadvertently disabled. In preparation for for re-enabling these custom ErrorProne checks this CL fixes all the redundant field initializations that have crept into the codebase. Trivial mechanical change TBR=yfriedman@chromium.org Bug: 904524 Change-Id: I96a81a1cb3b8c67bc682728aa9035c4757ed319b Reviewed-on: https://chromium-review.googlesource.com/c/1334188 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#608197}
-
Mike Frysinger authored
Trying to use --help with grit just ends in errors like: $ grit --help getopt.GetoptError: option --help not recognized Add support for it with `grit --help`. This doesn't update the subtools for now as that'll take much more work/thought. We also don't support the -h short option as it's already used for other things, and we don't want to complicate/break it. Bug: 747171 Change-Id: Ied24f810ed583d464dc2970c8e472784e22ec044 Reviewed-on: https://chromium-review.googlesource.com/c/1327421Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#608196}
-
Joe Downing authored
Checking in the strings early to get a jump on localization. Bug: 902041 Change-Id: I697462486441a009b36f31955f61633946410ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1336084 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#608195}
-
Robert Kroeger authored
vector_scalar_arithmetic_inside_loop fails on Android Nvidia (N9, STV devices.) Suppress. BUG=905370 TBR=kbr@chromium.org Change-Id: I996bd3e01e680dc53267393cf345fc45988028c9 Reviewed-on: https://chromium-review.googlesource.com/c/1335989 Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608194}
-
Sammie Quon authored
Do not activate quick switch when double tapping the tray, if the mru window is not activate. This was causing an unexpected window activation which was messing up the overview state, and also visually popping up and activating an unexpected window. Test: Checked that OnEndingAnimation does not get called between ToggleOverview calls Bug: 905082 Change-Id: Iaa7d3d02482d33d27ade6684ece8b92e9c270204 Reviewed-on: https://chromium-review.googlesource.com/c/1336149 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#608193}
-
Theresa authored
And create a generic thumbnail_placeholder_on_white_bg color for use in Zine as well. BUG=900757 Change-Id: I8cee89a7bfc361288b4f5b0041efb6dc2d8785c7 Reviewed-on: https://chromium-review.googlesource.com/c/1336062Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#608192}
-
Evan Stade authored
Bug: 163931 Change-Id: Ia6be534c8dd82207d91a584be7a49e42545102dc Reviewed-on: https://chromium-review.googlesource.com/c/1334841 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e04de3408e65..8a878e1c2fc6 Created with: gclient setdep -r src-internal@8a878e1c2fc6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie990e6d1b79bddcdf2743d9dd9a8033afbbf978d Reviewed-on: https://chromium-review.googlesource.com/c/1336222Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608190}
-
Tsuyoshi Horo authored
There was a bug that service workers can inject image into favicon cache of any origins (crbug.com/422250). This is becuase the icon URL is used as a key of the "favicons" table in ThumbnailDatabase. So currently MultiResolutionImageResourceFetcher sets the SkipServiceWorker flag of all favicon requests, to make it impossible to handle the fetch event of favicon requests in service workers. Ideally we should change the data scheme of ThumbnailDatabase not to reuse the favicon which was served from a service worker. But it is complicated to change the data scheme, and also there is a performance trade-off. So this cl change MultiResolutionImageResourceFetcher to set the SkipServiceWorker flag only for cross origin favicon requests. So the service worker can handle the same origin favicon requests. Bug: 448427 Change-Id: I3237ae9c4d0cc5d2374830e2c4865a8a852d37c6 Reviewed-on: https://chromium-review.googlesource.com/c/1333120Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#608189}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4925b069e1cf..8a6451c727a2 git log 4925b069e1cf..8a6451c727a2 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 harrytczhang@google.com Added service account email for Android metrics to whitelist. Created with: gclient setdep -r src/third_party/catapult@8a6451c727a2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4186c0fcb901238641b170e0960f198875e678cc Reviewed-on: https://chromium-review.googlesource.com/c/1336269Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608188}
-
rbpotter authored
This is a reland of https://crrev.com/c/1332703, with tests omitted since they were flaking. Tests will be relanded in a followup CL. Bug: 901115 Change-Id: I77112c3640c8eddc8863da902a2e75c0723bd4d7 Reviewed-on: https://chromium-review.googlesource.com/c/1336211Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#608187}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c10b4254..8117fe38 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I526d86ab23bc67810e1b581f35ae272f0584f06e Reviewed-on: https://chromium-review.googlesource.com/c/1336427Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608186}
-
Xianzhu Wang authored
Change-Id: I2c695493e682f6f3870205e03d52ec536867ca9c Reviewed-on: https://chromium-review.googlesource.com/c/1329806Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608185}
-
Antoine Labour authored
Use CheckedNumerics to prevent silent uint32_t overflow. Bug: 905336, 905459 Change-Id: Ie518def9063143ef2393be566419a209f68f0dce Reviewed-on: https://chromium-review.googlesource.com/c/1336083Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608184}
-
Xianzhu Wang authored
We should just dump all layers without culling. This will simplify paint layer dirty rect migrating to CullRect. Bug: 792577 Change-Id: I01f304f4c0166e8ecf7c1984545c3f24ac1b551c Reviewed-on: https://chromium-review.googlesource.com/c/1335007Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608183}
-
Yuri Wiitala authored
This is the replacement for GLHelper::I420Converter. It uses the new GLScaler to efficiently scale and re-format RGBA textures into I420 image planes. In a soon-upcoming CL, GLRendererCopier will be switched over to use this. Includes unit and pixel testing. Bug: 870036, 810131 Change-Id: I465eb933e7eadeb205676211432cced361a3739b Reviewed-on: https://chromium-review.googlesource.com/c/1330830Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608182}
-
Saman Sami authored
Don't send OnFirstSurfaceActivation to browser for OOPIFs when surface sync is enabled. Bug: 893850 Change-Id: I3afda38af2ade88424d28181c51294025c08dd6d Reviewed-on: https://chromium-review.googlesource.com/c/1336051 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e3b7b56f6bc3..2585eafdcba3 git log e3b7b56f6bc3..2585eafdcba3 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 tsepez@chromium.org Rename testing/resources/javascript/*_props.in to *_properties.in Created with: gclient setdep -r src/third_party/pdfium@2585eafdcba3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5a1277ec62c958d1c17244c91a0da160ba1119fa Reviewed-on: https://chromium-review.googlesource.com/c/1335845Reviewed-by:
-
ssid authored
BUG=905461 Change-Id: Idee52c3f44ca7aef6707e010b5e07bd668120109 Reviewed-on: https://chromium-review.googlesource.com/c/1330735Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#608179}
-
- 14 Nov, 2018 7 commits
-
-
Mohamed Heikal authored
Currently exception messages could contain PII but are not sanitized before they are uploaded inside minidumps. This cl adds a PiiElider class to java which is used in both java and native to sanitize stacktraces before writing to the minidump. Bug: 903472 Change-Id: Iadb88a9102d15a7129ace6fae99bed10c04c8423 Reviewed-on: https://chromium-review.googlesource.com/c/1330209Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608178}
-
Pedro Amaral authored
Moving bottom toolbar classes to a new package called: org.chromium.chrome.browser.toolbar.bottom; Bug: 904997 Change-Id: Ibd552668fd2c2711b4403293a8e39e40d2098e29 Reviewed-on: https://chromium-review.googlesource.com/c/1335029Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608177}
-
David Staessens authored
Fixed a bug that would prevent using absolute input file paths. This is required by tast, since the test image data is uploaded to a custom directory. Temporary files are generated, written to a temporary file, and read into memory again. This unnecessary step has been removed. File operations introduce additional points of failure, and it can be tricky to write to temporary files when using the Tast framework. This also prevents files cluttering the temp folder when not being cleaned up on crashes. The encode output of generated images is now written to the current folder using HxW_[black|white].jpg as output file name. TEST=ran jpeg_encode_accelerator_unittest on eve BUG=899605 Change-Id: Ie3f0e299ef85ce663586b4ba4c1177e84ec7a8ca Reviewed-on: https://chromium-review.googlesource.com/c/1333011 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#608176}
-
John Abd-El-Malek authored
This way it can run in the network process, similar to Network Error Logging. Bug: 853251 Change-Id: I403a5dcc3cae12b592a444c7e23f71c552b58e1f Reviewed-on: https://chromium-review.googlesource.com/c/1334848Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#608175}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bb9844ef69e7..44764000b49c git log bb9844ef69e7..44764000b49c --date=short --no-merges --format='%ad %ae %s' 2018-11-14 scroggo@google.com Add SafetyNetLogging and use in SkPngCodec 2018-11-14 bsalomon@google.com Reenable GrOp chaining. 2018-11-14 mtklein@google.com Revert "remove Clamp_S32_opaque_D32_nofilter_DX_shaderproc" 2018-11-14 reed@google.com don't use nested form of FontMetrics 2018-11-14 mtklein@google.com remove Clamp_S32_opaque_D32_nofilter_DX_shaderproc 2018-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d1a55e393e65..fca8fd620190 (2 commits) Created with: gclient setdep -r src/third_party/skia@44764000b49c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:b/117838472 TBR=rmistry@chromium.org Change-Id: I03a9d8897d0a666c50f1a97f6261257f11034a68 Reviewed-on: https://chromium-review.googlesource.com/c/1335846Reviewed-by:
-
Dmitry Gozman authored
We never use error_description coming from ContentRendererClient, so removing this parameter. Also inline LoadNavigationErrorPageForHttpStatusError to reduce the number of Load*Error* methods. TBR=boliu@chromium.org,sky@chromium.org Bug: none Change-Id: I74278b825247cb20cc71de6c6c0a5cf8850a614c Reviewed-on: https://chromium-review.googlesource.com/c/1332928 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#608173}
-
Alexander Alekseev authored
Bug: 905455 Change-Id: I45beaa8dee4cd4aec6056a8e2be7df342726ae02 Reviewed-on: https://chromium-review.googlesource.com/c/1336488Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#608172}
-
