GitLab

Turns out that we do need to escape the ]} characters on 10.5 .

BUG=None
TEST=Installing themes should continue to work.

Review URL: http://codereview.chromium.org/3022005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52853 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2825056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52850 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3012008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52849 0039d316-1c4b-4281-b951-d872f2087c98

The download manager has a concept of a request originating from the "Save As..." contextual menu v.s. a direct download request from the renderer, however this was't hooked up.

The Download Manager uses boolean variables named "save_as" in various locations to track whether a download originated via a contextual menu selection (in which case the save panel should be displayed) or via a renderer request (in which case no UI should be displayed).

This CL contains 3 distinct changes:

1. DownloadFileManager::OnDownloadURL() is where downloads originating from the contextual menu are dispatched, set save_as to true if the download starts here.

2. ResourceMessageFilter::OnDownloadURL() is where downloads originating from the renderer are dispatched (e.g. option-click), don't display UI for these.

3. The "save_as" variable in the DownloadCreateInfo structure doesn't really reflect the origin of the request but whether the Save panel should be displayed. This can happen for example on a name collision or if the default download location isn't writeable regardless of the action that initiated the download.  Renamed the variable and added documentation to this effect.

BUG=36775
TEST=Option-click an image, the image should be saved without prompting the user for a download locate.  Save an image via the "Save As..." context menu, you should be prompted for the save location.

Review URL: http://codereview.chromium.org/2927006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52848 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49012
TEST=See bug. 

Original review:
http://codereview.chromium.org/2819051

Review URL: http://codereview.chromium.org/3040007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52844 0039d316-1c4b-4281-b951-d872f2087c98

Google translate supports some new languages, makes Chrome aware of them. That way the translation feature works with them.

BUG=None
TEST=Visit pages in the new alpha languages (see http://translate.google.com/about/intl/en_ALL/). Make sure the pages can be translated.

Original review:
http://codereview.chromium.org/3013010

Review URL: http://codereview.chromium.org/3024005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52843 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3044008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52842 0039d316-1c4b-4281-b951-d872f2087c98

Also added inferred labels implementation. Label inferred from the person name + differences in other fields to distinguish entries.
BUG=47120,46634,46635,47435,48881,47430
TEST=in the mocks: http://folder/roma/design/chrome/autofill/ and unit tested.
Review URL: http://codereview.chromium.org/2801020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2843062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52837 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49378

Review URL: http://codereview.chromium.org/3031008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52836 0039d316-1c4b-4281-b951-d872f2087c98

This is never called from "live" code, but chrome/browser/tab_contents/thumbnail_generator.cc uses it. ThumbnailGenerator is currently used only on windows, but I'd like to use it on OS X.

TransportDIB::Create() isn't called on OS X because all created by chrome/browser/renderer_host/render_widget_helper.cc, which creates only the shared memory object and stores it away. The actual TransportDIB is created by calls to TransportDIB::Map() in both browser and renderer processes.

Review URL: http://codereview.chromium.org/3020008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52835 0039d316-1c4b-4281-b951-d872f2087c98

A recent regression in intl times results is causing
the XP perf bots to go red.  I put a bug on file to
track the regression, now let's green up the tree.

BUG=49434
TEST=xp intl steps are green
TBR=nsylvain@chromium.org

Review URL: http://codereview.chromium.org/2832059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52834 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2847059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3048001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52832 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2868054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52831 0039d316-1c4b-4281-b951-d872f2087c98

on gtk. This is a revert of most of r52070and 51478. I've kept parts
of these changes we want in though: comments, nuking nano tab gap on
views, having app tabs use a bigger icon.

BUG=49013
TEST=none

Review URL: http://codereview.chromium.org/3011007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52830 0039d316-1c4b-4281-b951-d872f2087c98

Implement WebFileSystemImpl::directoryName.  This is needed for directory upload (including webkit layout tests).

BUG=41762
TEST=webkit layout test fast/forms/input-file-directory-upload.html

Review URL: http://codereview.chromium.org/2847056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52829 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=net_unittests --gtest_filter="*HttpAuthHandlerNegotiate*"

Review URL: http://codereview.chromium.org/3018008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2843061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52827 0039d316-1c4b-4281-b951-d872f2087c98

Set url fetch test timeout back to old values. Increase UI test command timeout a bit to accommodate failng tests.

BUG=none
TEST=Vista perf goes green; xp test dbg 2 goes green.
TBR=phajdan.jr
Review URL: http://codereview.chromium.org/3044007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52824 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49412
TEST=Heapchecker goes green!
TBR=mbelshe
Review URL: http://codereview.chromium.org/3024003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52823 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49300
TEST=none
TBR=tyoshino
Review URL: http://codereview.chromium.org/2827056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=46886
TEST=Heapchecker net gets greener.
TBR=glider
Review URL: http://codereview.chromium.org/3021004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52818 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49409
TEST=none
TBR=huanr
Review URL: http://codereview.chromium.org/3008008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52817 0039d316-1c4b-4281-b951-d872f2087c98

New Blue style for for autofill Info-bar, to be eventually used for all info bars (for that more changes needed), it also Windows only.
BUG=47233
TEST=Mocks @ http://folder/roma/design/chrome/autofill/ page 23
Review URL: http://codereview.chromium.org/3027004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21461
TEST=GTK dialog matches Windows dialog.
Review URL: http://codereview.chromium.org/2813060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52815 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3028009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52814 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49404
TEST=none
TBR=ahendrickson
Review URL: http://codereview.chromium.org/3037007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52813 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sargrass
BUG=none
TEST=chromeos builder goes green

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3032006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52812 0039d316-1c4b-4281-b951-d872f2087c98

Avoid flashing when resizing plugins that use PaintManager.  Copy the bitmap from the old backing store to the new one so that we have something to display until the plugin repaints.  Credit to Darin for tracking this down and the suggested fix.
Review URL: http://codereview.chromium.org/2834052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=48883
TEST=Exercise Personal Stuff page via --enabled-tabbed-options

Review URL: http://codereview.chromium.org/2819046

TBR=sargrass@google.com
Review URL: http://codereview.chromium.org/3012007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52810 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52809 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6574
TEST=None

Review URL: http://codereview.chromium.org/2850031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52808 0039d316-1c4b-4281-b951-d872f2087c98

Certain decorations like the keyword-search bubble let mouse events
fall through to the field, as indicated by an i-beam cursor.  This
change causes decorations next to the text area to be aggregated into
the text-area's cursor rect.

BUG=41612
TEST=Keyword-search bubble shows I-beam cursor.
TEST=Location icon and star and page actions show arrow.

Review URL: http://codereview.chromium.org/2825048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52807 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2824057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52806 0039d316-1c4b-4281-b951-d872f2087c98

  --host-resolver-parallelism=XXX

This is a useful debugging tool, since for some users too many parallel DNS requests results in spurious DNS failures from their resolver.

BUG=44489
Review URL: http://codereview.chromium.org/3019007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52802 0039d316-1c4b-4281-b951-d872f2087c98

Revert 52799 - Add support for parsing certificate formats other than raw, DER-encoded certificates - specifically formats that represent collections of certificates. The certificate format can now be specified as an explicit format, or as a bit-mask of formats that are acceptable/expected, with the first parsable format winning.

This is one half of a commit to address BUG #37142, with the second half involving connecting this through the X509UserCertHandler and the actual UI.

R=wtc
BUG=37142
TEST=X509CertificateParseTest* and PEMTokenizerTest.*

Review URL: http://codereview.chromium.org/2819018

TBR=rsleevi@chromium.org
Review URL: http://codereview.chromium.org/2812064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52801 0039d316-1c4b-4281-b951-d872f2087c98

function to send pings to google for two reasons:

- I thought that chrome's own rlz pings would send all rlz information for all
  other products installed on the machine
- I did not want to allow an extension to DoS google by sending too many rlz
  pings

It turns out that the rlz library itself makes sure that a given product's
pings are never sent out more than once per day, as is required for rlz, so
there is no DoS danger by exposing a ping function.  Also, I was wrong in 
thinking that chrome's rlz pings would send out all rlz information about
other products installed on the machine: it sends out the other products rlz
strings, but it does not send out the other products rlz event information.
This makes sense since there are signatures and brand codes and other
information that cannot be determined by chrome for the extensions.

So adding a new rlz chrome extension function to expose sending pings.

BUG=None
TEST=See particular extension using this api

Review URL: http://codereview.chromium.org/3029001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52800 0039d316-1c4b-4281-b951-d872f2087c98