- 01 May, 2018 40 commits
-
-
Xianzhu Wang authored
For now we don't fully support subpixel layout in tables, but may produce subpixel layout results and different heights for cells in the same row (crbug.com/838401). Now use the traditional method to snap size to pixels before applying paint offset for collapsed borders. Bug: 834648 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic8866e1a9d52bb6b60ea96dfda692040af8ecea8 Reviewed-on: https://chromium-review.googlesource.com/1036305Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555171}
-
Hirokazu Honda authored
Move VideoDecodeAcceleratorTestEnvironment and TextureRef to VDA unittest heler in order to reduce the amount of code in VDAunittest.cc. BUG=chromium:834170 TEST=VDA unittest on kevin and caroline TEST=VDA unittest on other platforms in CQ Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib7912e98a7cc0c07c8a343f512094b7b2ba6bfa8 Reviewed-on: https://chromium-review.googlesource.com/1016443 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#555170}
-
danakj authored
Use the SkColor and cc::OverscrollBehavior types directly. One more step toward making WebLayer useless so it can go away. R=jbroman@chromium.org, pdr@chromium.org, piman@chromium.org TBR=halliwell@chromium.org Bug: 738465 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I78883c407cc42df815eecdf98d5804fc6cf16c5a Reviewed-on: https://chromium-review.googlesource.com/1033436Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#555169}
-
Hiroshige Hayashizaki authored
Issue 837308 is going to replace arrraysize() with base::size(), but base/stl_util.h (where base::size() is declared) is forbidden in blink/renderer/DEPS, while base/macros.h (where arraysize is declared) is allowed there. This CL also allows including base/stl_util.h from blink/renderer. Bug: 837308 Change-Id: Ifaf499dddbc99cec80c81c81f5588a2f6e3990a7 Reviewed-on: https://chromium-review.googlesource.com/1036597 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555168}
-
Hiroshige Hayashizaki authored
Issue 837308 is going to replace arrraysize() with base::size(), but previously base::size() was forbidden in Blink PRESUBMIT rules. Bug: 837308 Change-Id: I1531ea7ec7f25df42fbe5e17f9c01089ebd1b679 Reviewed-on: https://chromium-review.googlesource.com/1036118 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555167}
-
https://chromium.googlesource.com/angle/angle.git/+log/ad3aaeba3e0d..41529e5e0f66 $ git log ad3aaeba3..41529e5e0 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 lucferron Refactor StateChangeTests to use essl1_shaders instead 2018-04-23 lucferron Vulkan: Create tests to validate we created the pipeline when needed Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8ab1bdfcffe1d2c2e516b3cbeec2fe221c5dcf1f Reviewed-on: https://chromium-review.googlesource.com/1037908 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555166}
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I231420748dc882a780100e3b7c1ac1f35fdc0b5c Reviewed-on: https://chromium-review.googlesource.com/1022632 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#555165}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2351dee3eb10989a592e147cb653f7cb0e0ee8d1 Reviewed-on: https://chromium-review.googlesource.com/1037884 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555164}
-
Joe Downing authored
This CL fixes a bug which occurs when holding ESC to dismiss the Fullscreen exit UI. The issue occurred when the FullscreenControlHost receives keyboard input as fullscreen mode is being exited. Due to the ordering of events, the press and hold timer was being set and then the BrowserView would hide and disconnect the input handler for the control. There are a couple of other ways to fix this issue based on the event ordering but I think the safest is to just cancel the timer when the control is hidden. BUG=680809 Change-Id: I507aa751a8d29a5a39de6cf2fc338e3bff5fa564 Reviewed-on: https://chromium-review.googlesource.com/1037931Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#555163}
-
Hirokazu Honda authored
CL:950007 wrongly deletes md5sum for intel platforms Reupdate to add the md5sum. BUG=chromium:827032 TEST=video_VideoDecodeAccelerator on eve Change-Id: I2d8ee3b7517f997721741d4b532596c2fbf0641e Reviewed-on: https://chromium-review.googlesource.com/1037044Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#555162}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc3192b30a9e..e618eee83350 $ git log dc3192b30..e618eee83 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 skcms-skia-autoroll Roll skia/third_party/skcms f504cf9..a1c0fe6 (1 commits) 2018-05-01 brianosman Convert skcms to only export functions (not data) 2018-05-01 kjlubick Update all remaining Chromebooks to m67 2018-05-01 reed handle non-a8 masks in coverage blitter 2018-05-01 skcms-skia-autoroll Roll skia/third_party/skcms fdc6366..f504cf9 (1 commits) 2018-05-01 bsalomon Use a cached index buffer for triangle fans in GrDefaultPathRenderer. 2018-05-01 skcms-skia-autoroll Roll skia/third_party/skcms 8cf2d2c..fdc6366 (1 commits) 2018-05-01 mtklein Retry enabling skcms on Android Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ie5fa0c425fd009f615af87f48bb233a0d56928b8 Reviewed-on: https://chromium-review.googlesource.com/1037774Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555161}
-
Robert Ogden authored
Bucketing is done by retaining the two most significant bytes, as advised by privacy. Bug: 830949 Change-Id: If50e0593ab434eecfbdc6c194182f54c6d31f86a Reviewed-on: https://chromium-review.googlesource.com/1033916Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#555160}
-
Maks Orlovich authored
Change-Id: I27799361707f929f64ce01fc920fb16b2d32ecc8 Reviewed-on: https://chromium-review.googlesource.com/1030041 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555159}
-
Eric Orth authored
To avoid issues dealing between Time (as we have for removal window in BrowsingDataRemover) and TimeTick (as we have for cache timestamps), as well as cross-process complexities from TimeTick, added a new wall clock creation timestamp in the cache and new methods for absolute wall time clearing. Wall clock based clearing (eg those coming from BrowsingDataRemover) can use the new timestamp and other stuff that makes more sense using TimeTick (eg the histogram stuff in the cache class) can keep using the old timestamp. Bug: 824967 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I87bfce922ba28525ad20999fdfc6b7e2857451c0 Reviewed-on: https://chromium-review.googlesource.com/1026232Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#555158}
-
Paul Jensen authored
This is a reland of 10f4dd89 I disabled the gradle build when !use_platform_icu_alternatives so Android bots continue to build successfully. I also moved cronet_maven/ output directory to cronet/maven/ so it can be uploaded by the bots. Original change's description: > [Cronet] Build maven modules and test by building sample app with gradle > > This change builds maven modules for Cronet. > Each maven module includes: > 1. POM file defining module and listing dependent modules > 2. Jars > 3. Proguard files (optional) > 4. Native libraries (optional) > 5. Resources (optional) > 6. Javadocs (optional) > We build four maven modules: > 1. cronet-api: the Cronet API > 2. cronet-embedded: the Cronet native implementation > 3. cronet-fallback: the Cronet fallback implementation > 4. cronet-common: Cronet implementation in common with #3 and #4 > > To test the maven modules, this change builds the Cronet sample app using gradle. > You can install and run the resulting app by: > ninja -C out/Debug cronet_maven_test_build > adb install -r out/Debug/cronet_maven/test/build/outputs/apk/debug/test-debug.apk > adb install -r out/Debug/cronet_maven/test/build/outputs/apk/androidTest/debug/test-debug-androidTest.apk > adb shell am instrument -w org.chromium.cronet_sample_apk.test/android.support.test.runner.AndroidJUnitRunner > > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I5ed27e86f3e01dc3a6441ab449bbe942553343af > Reviewed-on: https://chromium-review.googlesource.com/998019 > Commit-Queue: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554608} Change-Id: Ieba6842b48d0b8e97ca1dc6686080cb31a87ed95 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet TBR=estevenson@chromium.org Eric already approved the build/ change in https://chromium-review.googlesource.com/998019 Change-Id: Ieba6842b48d0b8e97ca1dc6686080cb31a87ed95 Reviewed-on: https://chromium-review.googlesource.com/1037723 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#555157}
-
chcunningham authored
Encoders may use "phase inversion" to improve stereo compression. But this creates artifacts if the decoded stereo is later down-mixed to mono. This CL sets a flag on the decoder to disable the phase inversion decode step whenever the HW is detected as mono. Bug: 806219 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie5f911910dbcc61e48ea58da51c48c0c2c2ebdc3 Reviewed-on: https://chromium-review.googlesource.com/1030907 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555156}
-
rodmartin authored
Initially all the value type of each policy obteined from the UI was a string type. To be consistent with the actual policy types, before process the dictionary of policies got it from the UI, I check the value type and try to parse it if it's not valid. The status of each policy will be updated to |OK| if its value type is correct or |Invalid| otherwise. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4d1eaab0768e65080bd26d45511a9dc67c85890b Reviewed-on: https://chromium-review.googlesource.com/1013207 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#555155}
-
Martin Kreichgauer authored
Bug: 678128 Change-Id: I77057cf8f630668d07fa93f9c4d09fefae187aa3 Reviewed-on: https://chromium-review.googlesource.com/1013054 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#555154}
-
David Bokan authored
Real world reports show we are sometimes promoting elements to be the root scroller when that's clearly not wanted. This patch adds further restrictions so that we promote in fewer situations. Namely, we avoid promoting an element if: 1. It isn't visible 2. It doesn't have overflow 3. The main document has overflow and allows scrolling it Bug: 815068 Change-Id: I51aa03c23c67c7bd9c29b4fd119b89fc1f88ca24 Reviewed-on: https://chromium-review.googlesource.com/1035449Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555153}
-
Koji Ishii authored
This patch re-implements 'text-overflow: ellipsis' in LayoutNG. Before this patch, it was implemented in NGLineBreaker. It helped sharing the code with other line breaking logic, and working in logical coordinate made things simpler. However, some tests fail due to taller fonts/objects in the hidden part, or when out-of-flow/float objects in the line. While these look edge cases, given the high usage of the 'text-overflow' property, this patch fixes them by moving the logic to NGInlineLayoutAlgorithm. The logic is largely independent and that it is moved to a new class, NGLineTruncator. This patch also uses a new ShapeResult::OffsetToFit() function added in CL:1020760 for more accurate truncation. Relative position is not supported yet. And tests for inline-block container still fail, they will be investigated in following patches. Bug: 636993 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idb0d80b239d9f53cd6a4878a9378f5bfbc0d24ea Reviewed-on: https://chromium-review.googlesource.com/1013019 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#555152}
-
John Abd-El-Malek authored
The test class now works with frame requests when the network service is disabled. This change also: -removes the DCHECK in PageLoadTracker::WillProcessNavigationResponse since intercepted requests won't have a request ID (since they didn't go through ResourceDispatcherHost) -makes NavigationURLLoaderNetworkService::URLLoaderRequestController::OnReceiveResponse handle receiving a response when there's no net::URLRequest, for the same reason as above Bug: 776589 Change-Id: If68216f77ab08659bb65c6c37efca6ed9396a47a Reviewed-on: https://chromium-review.googlesource.com/1037769Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#555151}
-
John Rummell authored
CdmInfo will now keep track of the encryption schemes supported by each registered CDM. For component-updated Widevine, this will be determined from the manifest. For built-in CDMs, this list is compiled in. The set of encryption schemes supported is also passed to KeySystemSupport. BUG=657957,658026 TEST=new content_unittests pass Change-Id: I444091035e7ae1bc18720aff5bfea86afeca5ba7 Reviewed-on: https://chromium-review.googlesource.com/1019884Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#555150}
-
Fady Samuel authored
It doesn't seem like there's any reason to defer auto-resize embeddings anymore. There was a concern way back when about re-entrancy and flicker: https://codereview.chromium.org/9702068 Child allocated LocalSurfaceIds address both of these issues. Change-Id: Ieaefdf517f7c6c14d0e6a8ac496e233798185dc0 Reviewed-on: https://chromium-review.googlesource.com/1036501Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555149}
-
Miguel Casas authored
This CL adds a test case for the case of resolution change (which bit me in crbug.com/834146). In the process, a few common VaVDA<->test harness subsequences are factored out into methods: - QueueInputBufferSequence - AssignPictureBuffersSequence - DecodeOneFrameFast which allows to simplify other test cases. Finally, the test case SupportedPlatforms() is moved around untouched. Bug: 717265 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic19d89c1355eb74d12658f5fee04eaf17ee39c6e Reviewed-on: https://chromium-review.googlesource.com/1020303Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#555148}
-
Katie D authored
This is part of go/chromeos-sts-on-screen-ui, which requires the chrome process to be able to communicate bi-directionally with the Select-to-Speak extension: Chrome must be able to request Select-to-Speak to change states, and must get notified whenever Select-to-Speak's state changes. 1. This change hooks up the extension receiving requests from Chrome to change state, although the implementation of changing state logic in the extension is currently a TODO. 2. This change also hooks up the extension communicating its state back to Chrome, although the accessibility_extension_api method that receives the call is implemented as a TODO after converting accessibility_private state into a more universal mojom::SelectToSpeakState state. Note: We need mojom::SelectToSpeakState because chrome needs to communicate state changes through to the shelf in Ash, so the enum needs to be usable across processes. The next changes will complete the TODOs in 1. and 2. above. Bug: 753018 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia1785a85adea02b3e60ed2e60525012d166e7ad2 Reviewed-on: https://chromium-review.googlesource.com/1030901 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555147}
-
Nasko Oskov authored
The navigation performed in the MemoryInstrumentationTest::Navigate method is using a non-existing file, which means the navigation does not succeed. This CL fixes the code to use a file that exists and to check the navigation is actually successful. Bug: 838161 Change-Id: Icf0715f687a1cdf763b47e3bd3155321e761af96 Reviewed-on: https://chromium-review.googlesource.com/1037637Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555146}
-
Peter Kasting authored
This also adds some plumbing that will be used later for variable tab corner radii, and safes a few spots against crashes on startup (found when testing with unusual mode combinations, e.g. TRAILING NTB in non-MATERIAL_REFRESH mode). BUG=822037 TEST=none Change-Id: Iba16ab3f238887c0c93feac67451c36a7317e389 Reviewed-on: https://chromium-review.googlesource.com/1029422Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#555145}
-
Emircan Uysaler authored
Bug: 837565 Change-Id: I69f5061cfd9352fd2976cdea0f4d1b43f423163d Reviewed-on: https://chromium-review.googlesource.com/1036605Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555144}
-
Xiaohan Wang authored
Previously move-only types are not supported in gmock so we had to use a hack to workaround the issue. Now this is supported by gmock, and we can mock those methods directly. This CL only updates mock_filter.h and related tests. More changes will come later. Bug: 759710 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7ed40687c0eb2248b6f04989bad94e7bb17e37ba Reviewed-on: https://chromium-review.googlesource.com/1036649Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#555143}
-
Erik Luo authored
Allow Console to evaluate without throwOnSideEffect when the entire expression meets the same strict conditions used by JSAutocomplete. Bug: 810176 Change-Id: If5c80250cd75d81eec1e495d0414903213fac930 Reviewed-on: https://chromium-review.googlesource.com/1028934 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#555142}
-
Helen Li authored
Bug: 837753 Change-Id: Iaf98bcb0b98b096880a0e888da690e411505b3c4 Reviewed-on: https://chromium-review.googlesource.com/1037245 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555141}
-
Raymond Toy authored
Move many but not all WebAudio AudioParam tests to WPT. The criteria was whether Firefox passed the tests or, if not, the errors are actually bugs in Firefox. Most of the failures are because Firefox threw the wrong type of error. We also skipped over most of the tests that use offline.suspend(). Bug: 745778 Change-Id: If4755089938ddf1b9825faa3392d1d10e3b9293f Reviewed-on: https://chromium-review.googlesource.com/1036456Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555140}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Iaad06800c9481fb681d957ef11aa927829d71d3f Reviewed-on: https://chromium-review.googlesource.com/1037190Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#555139}
-
Becca Hughes authored
Add flag states and preload version to chrome://media-engagement to make it easier to diagnose bugs in MEI. BUG=835938 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I736f17f5b020b459c236abdabd9d0961efea29d3 Reviewed-on: https://chromium-review.googlesource.com/1024805 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555138}
-
Kevin Marshall authored
Wrap file path references with "EnsureFileExists()" which acts as a simple identity function, except for invalid paths for which it raises IOErrors. Bug: 837200 Change-Id: Ie718cd5517415b375ed3bf5d5112d59b32074c04 Reviewed-on: https://chromium-review.googlesource.com/1037778Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#555137}
-
Dan Sanders authored
This CL standardizes the |natural_size| computation in all decoder implementations to use the decoded |visible_size| and the VideoDecoderConfig's pixel aspect ratio. Bug: 766657, 837337 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I01a5bd59c353d6f07fd02c9fc3d3e64ab1a04434 Reviewed-on: https://chromium-review.googlesource.com/1026992 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#555136}
-
Gabriel Charette authored
Precursor for https://chromium-review.googlesource.com/c/chromium/src/+/1035788 TBR=fdoray@chromium.org Bug: 825327 Change-Id: Ic6e7440c152dde11b6cab9c1ccddd46106d48d8b Reviewed-on: https://chromium-review.googlesource.com/1037634 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#555135}
-
Dirk Pranke authored
It would be good if we could use `gn refs` to tell us which target generated a given executable. The docs suggested that refs should do this, but it doesn't appear to do so. Bug: 837876 Change-Id: I45f45bb3346ed21ede83fbacdea2207f1322ad69 Reviewed-on: https://chromium-review.googlesource.com/1033506 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555134}
-
Ahmed Fakhry authored
This CL adds: - Ctrl + Search + M to toggle the fullscreen magnifier on/off - Ctrl + Search + D to toggle the docked magnifier on/off It also adds their entries in the keyboard shortcut helper, and the keyboard overlay. BUG=838310 TEST=Added new test. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I65119263a39f3630118c87332099c7ec7e73439a Reviewed-on: https://chromium-review.googlesource.com/1036533Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#555133}
-
Bo Liu authored
Log intentional kill UMAs yet a new histogram entry. This time, instead of logging all possible combinations of states that we might care about, aggregate them into counts on the client side directly. So it's not really a "histogram" exactly. The up side is that this will be easily extensible in the future. Add renderer visibility to TerminationInfo which is needed for one of the new UMAs. Bug: 693484 Change-Id: I9bf4cc8cfa969a8098bcdabf002585f0bf4a713a Reviewed-on: https://chromium-review.googlesource.com/1032093Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555132}
-