- 11 Sep, 2018 40 commits
-
-
Yi Su authored
Add metrics for ImageFetchTabHelper::GetImageDataByJs to check if fetching image data by JavaScript methods works very often. If not, remove the JavaScript methods that are not likely to succeed. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I22a1bc9f16575d40836b7ed020a1e81a8c6a1b1e Reviewed-on: https://chromium-review.googlesource.com/1213146 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590334}
-
Stephane Zermatten authored
With this change, scripts without precondition are not treated as invalid, but runnable. Also includes a small test ProtocolUtils::ParseScripts. Bug: 806868 Change-Id: I6c286b1622bfeb4d635310396cb3b158ffd6933e Reviewed-on: https://chromium-review.googlesource.com/1219748Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#590333}
-
Scott Graham authored
More suitable for DEPS runhooks running. Bug: 724204 Change-Id: I105a57269b4c4f7b4b05bab80df7a4ef112bdf1f Reviewed-on: https://chromium-review.googlesource.com/1217850Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#590332}
-
Lukasz Anforowicz authored
This CL also makes sure that the default base::MemoryPressureMonitor won't be created when running browser tests. This helps insulate the tests from their environment and ensure that the tests behave deterministically (rather than flakily depending on things outside the test control, like the overall memory pressure on the bot which runs the test). This is accomplished by avoiding creating the monitor if --browser-test switch is present. Before this CL, the --browser-test switch would be injected by ContentBrowserTest::SetUp. After this CL, the switch is injected by BrowserTestBase::SetUp - this means that insulation from memory pressure covers not only content_browsertests, but also browser_tests (and other tests that subclass BrowserTestBase rather than ContentBrowserTest). This CL also makes tweaks in memory-pressure-monitoring code to make sure that things work properly after the changes described above. In particular, the CL also makes the following changes: - Move DummyMemoryPressureMonitor from //chrome/browser/chromeos/resource_reporter/resource_reporter_unittest.cc into //base (renaming the class into FakeMemoryPressureMonitor), so that it can be reused by TabManagerTest.OomPressureListener browser test. Note that the FakeMemoryPressureMonitor has to be constructed and present early during browser startup (so that TabManager::Start detects presence of the monitor). - Stop incorrect downcasting that used to be made by base::chromeos::MemoryPressureMonitor::Get There are also some opportunistic changes that are not really required for correctness: - Rewrite TabManager::OnMemoryPressure to follow most recent style guidelines that help enforce that missing a switch/case branch will lead to a compile error (thanks to a missing "default" branch). Bug: 852905 Change-Id: I6eb651a4f7a7bc6d1a2138ba31dd248c7e33f2a4 Reviewed-on: https://chromium-review.googlesource.com/1194879 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#590331}
-
Joe Mason authored
Also add new ERROR_IN_ARCHIVER removal status value, and update the override permissions map to handle it. Full code and tests to deal with QuarantineStatus will come in a followup. R=csharp Bug: 830892 Change-Id: Ib002f44b8aba6899f54b44148d8645c3c0c7178f Reviewed-on: https://chromium-review.googlesource.com/1217148Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#590330}
-
Dominic Battre authored
TBR=twellington@chromium.org,bsazonov@chromium.org Bug: 789531 Change-Id: I7ca028d21988508247c3798d8ce5fc1c5eba91f6 Reviewed-on: https://chromium-review.googlesource.com/1219613 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#590329}
-
Marc Treib authored
Some recent reports indicate that the Sync server might be sending duplicate client tag hashes. This is considered "invalid data", and is so far not handled well by the client. These metrics will help us evaluate how common this case is, and also whether the duplicates are within a single GetUpdates response, or across multiple responses (within a full paginated GetUpdates cycle). Bug: 872360 Change-Id: Id24baa351c80f2eb1ab59f890d50d6603cb89e6b Reviewed-on: https://chromium-review.googlesource.com/1203935Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#590328}
-
Daniel Bratell authored
In jumbo builds whole chunks of the code is compiled in the same translation unit, using the same anonymous namespace. If two files use the same symbol names they will then clash and that happened in chrome/browser/extensions between active_tab_permission_granter.cc and extension_tab_util.cc. This patch renames GetDelegate() and GetDelegateWrapper to include the more exact names of the Delegate type, making them unique. Bug: 865947 Change-Id: I46426e8dee715d57acaa3d2385e6dd5b6ac38cf1 Reviewed-on: https://chromium-review.googlesource.com/1219246 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590327}
-
Maks Orlovich authored
This is consistent with the bug backtrace, but not clearly with it being a regression. Also don't rely on sequencing within the same expression when setting up the map. Bug: 881905 Change-Id: I50ab04196e06e326d4489325fb5bb8adda786c8c Reviewed-on: https://chromium-review.googlesource.com/1219806 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#590326}
-
Dominic Battre authored
Unfortunately, the previous CL (https://chromium-review.googlesource.com/1218902) lacked an important negation. TBR=sky@chromium.org Bug: 882545 Change-Id: I730dbab7c05b0d67c11be67437b462ac51afd7b3 Reviewed-on: https://chromium-review.googlesource.com/1219750Reviewed-by:
-
Roger McFarlane authored
This CL extends the autofill form upload "vote" proto to include rich form/field metadata. Autofill will crowd-source bit-level randomized encodings of the first 64 bytes of the form's id, name and action as well as each field's id, name, label, aria-label, aria-description, css-class, placeholder value, plus a hash of the field initial value (to detect placeholders that are prepopulated as initial values). Each uploaded bit will randomly be sent as the true value or as a random value. Bug: 850606 Change-Id: I470876e4a04fca6cfabf5482f998573eacf86aa1 Reviewed-on: https://chromium-review.googlesource.com/1213878Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#590324}
-
Javier Ernesto Flores Robles authored
This CL wires all the parts and enables Manual Fallback, still work in progress, behind it's flag. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8bef297135511a1d122dcac0c6199e263f112566 Reviewed-on: https://chromium-review.googlesource.com/1203994 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#590323}
-
Artur Khachatryan authored
Storage and Location tests are failing on Android Chromium. Disabling tests for now. Bug: chromedriver:2580 Change-Id: Iab7bae5e4ea7b2a572de7bd42e00152a3c33779e Reviewed-on: https://chromium-review.googlesource.com/1217915Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590322}
-
Charlie Andrews authored
It was already disabled on Win 10, but it was failing on Win 7 also. TBR=sullivan@chromium.org CC=kouhei@chromium.org, ksakamoto@chromium.org NOTRY=true Bug: 879833 Change-Id: I926a38ef6713a0eaec1eebae71948e6dcc9d49b7 Reviewed-on: https://chromium-review.googlesource.com/1219966Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#590321}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b42a897819dc..bd6595544171 git log b42a897819dc..bd6595544171 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 brianosman@google.com Remove SkImageCacherator entirely Created with: gclient setdep -r src/third_party/skia@bd6595544171 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I623c92c6ad94f17f97c1e8c15cd2cfd64d584c24 Reviewed-on: https://chromium-review.googlesource.com/1219415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590320}
-
Anna Malova authored
Bug: 873098 Change-Id: Ic349be8e16680b2ccbf08e7ecbdee9dab7987077 Reviewed-on: https://chromium-review.googlesource.com/1176081Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#590319}
-
Charlie Andrews authored
TBR=sullivan@chromium.org NOTRY=true CC=yukishiino@chromium.org, jbroman@chromium.org, haraken@chromium.org Bug: 882881, 882882, 882883 Change-Id: Id509634ea963f688bc5cc0b761b1430398688ea2 Reviewed-on: https://chromium-review.googlesource.com/1219783Reviewed-by:
-
John Delaney authored
Now that we have an ad flag in the browser process, log per resource metrics for ad resource sizes. Also log new metrics for total ad bytes per-page and for top-level ads now that this information is available in the browser process. These metrics are different than the existing page byte totals as they account for network bytes that went towards canceled and incomplete resource loads. Bug: 851543,859080 Change-Id: I2ad863f0fc718f51521269d7ffd1c1bb8d0bf886 Reviewed-on: https://chromium-review.googlesource.com/1199576 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590317}
-
Fabio Tirelo authored
The goal is to allow experimentation with different font weights for primary info for Payment Methods and Addresses suggestions on the Autofill dropdown. Screenshots on Windows (Googlers only): https://drive.google.com/open?id=1BhZdvN0l9GTzZv2kvim7_OCE9r9OsOhK Bug: 882525 Change-Id: I9d1ec9ad662e858bd0d9c85c3b31849f13220b86 Reviewed-on: https://chromium-review.googlesource.com/1217171 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Eric Seckler authored
To unify the way tasks are posted, we're changing the way tasks are posted to a WebThread. Instead of WebThread::PostTask(WebThread::UI, ..) and alike, tasks are now posted via base::PostTaskWithTraits(FROM_HERE, {WebThread::UI}). Also replaces uses of TestWebThread with TestWebThreadBundle in ios_io_thread_unittest.mm and request_tracker_impl_unittest.mm. In a follow-up patch, we will remove public PostTask and GetTaskRunnerForThread methods from WebThread. Design doc for TaskTraits: https://docs.google.com/document/d/1SGy9VTXUwyXEX_yBZ0ukFAnS8B0hDeMUJD-1iALaE-Q/edit?usp=sharing Bug: 878356 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iedc1189834e5f1b1eeb00b2ae1fc707f8e4f5256 Reviewed-on: https://chromium-review.googlesource.com/1216663Reviewed-by:Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#590315}
-
Moe Ahmadi authored
Bug: 881869 Change-Id: Ib20092ce09f53b2b79280f3e79a7ab0785a66068 Reviewed-on: https://chromium-review.googlesource.com/1213868 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Matthew Cary authored
This changes CommandBufferProxyImpl::AllocateAndMapSharedMemory to use the new mojo shared memory region API for creating the unsafe shared memory region it uses. Bug: 872778 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia1b5380eb21afe54a05e81d26df8307819de23c0 Reviewed-on: https://chromium-review.googlesource.com/1171229Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#590313}
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: I3ff1bb22ead3a993ef0248814fa6b270ec2ace23 Reviewed-on: https://chromium-review.googlesource.com/1217917Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#590312}
-
Shahbaz Youssefi authored
`ExtensionPolicyMigrator::CopyPoliciesIfUnset()` now takes the hashed extension id, instead of the extension id itself, and linearly searches in the policy bundle to find a matching policy. Where this function was called with an extension id, the extension id is replaced with the hashed one. Note that HashedExtensionId generates a hash that uses upper-case letters. Bug: 878528 Change-Id: I6290fe894cfcc6e0c440b639908bd1f0866d49ba Reviewed-on: https://chromium-review.googlesource.com/1207891Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#590311}
-
Fady Samuel authored
This test doesn't seem to flake locally anymore. Bug: 867163 Change-Id: I7d73e63237739b7d173023011af64af3917e2969 Reviewed-on: https://chromium-review.googlesource.com/1217283Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590310}
-
Mugdha Lakhani authored
With this CL, 1. Record the BackgroundFetch.HasRequestsWithBody UMA metric, which is true if any requests in the background fetch contain a body, false otherwise. 2. Reject the fetch() promise, if any requests do contain a body. Bug: 881344 Change-Id: I595800adefe1dcc2c8bb04bec2295cc2886d963d Reviewed-on: https://chromium-review.googlesource.com/1210125 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#590309}
-
Thomas Tangl authored
In the AvatarToolbarButton, always use the explicitely-set profile icon instead of the generic avatar icon. Bug: 879106 Change-Id: I6f9f9fd30710e724516d2a3567a94145ad00b34a Reviewed-on: https://chromium-review.googlesource.com/1219490Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#590308}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3d50a31aad31..7cd0e15faf17 git log 3d50a31aad31..7cd0e15faf17 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 stefan@webrtc.org Add nisse@, ilnik@ and sprang@ as OWNERS to media/. 2018-09-11 gustaf@webrtc.org AEC3: Fix filter output transition when input and output is the same array 2018-09-11 mbonadei@webrtc.org Fix no_global_constructors in remote_bitrate_estimator. 2018-09-11 magjed@webrtc.org Android: Send original texture width/height in TextureBufferImpl 2018-09-11 nisse@webrtc.org Delete always true member voe::Channel::pacing_enabled_ 2018-09-11 sprang@webrtc.org Don't signal updated bitrate allocation on encoder paused 2018-09-11 sprang@webrtc.org Updated min bitrate for high-quality screenshare simulcast stream 2018-09-11 gustaf@webrtc.org AEC3: Bugfix in filter output transition Created with: gclient setdep -r src/third_party/webrtc@7cd0e15faf17 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:882789,chromium:None,chromium:882789 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icaca70c95614fddaf43c75b10737aa2f651594ab Reviewed-on: https://chromium-review.googlesource.com/1219413Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590307}
-
Joe Mason authored
Before M69 this code used mojo::edk::PlatformChannelPair, not mojo::edk::NamedPlatformChannelPair. R=csharp Bug: 830892 Change-Id: I69d4f3dd5ef730e38cbb76f3d827c9094b6492ab Reviewed-on: https://chromium-review.googlesource.com/1216710Reviewed-by:
-
Joe Mason authored
This lets the args be included from other directories. Also fix the license in REPORTER_BRANDING and CLEANER_BRANDING. R=csharp Bug: 830892 Change-Id: Ia753c988579ee65a969aa07103677b80da0eede4 Reviewed-on: https://chromium-review.googlesource.com/1216707Reviewed-by:
-
Olivier Robin authored
And cancel it on expiration. Bug: 881907 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I09af1c34ebf11b51a9cd7d0bb4925d7e97ddc3bb Reviewed-on: https://chromium-review.googlesource.com/1219611 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#590304}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2c2fee797908..324be76b9c4c git log 2c2fee797908..324be76b9c4c --date=short --no-merges --format='%ad %ae %s' 2018-09-11 dj2@everburning.com Fixup BUILD.gn file (#1886) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@324be76b9c4c The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibd1bb9e5ebebeef1367c98d133a2249f728ace8b Reviewed-on: https://chromium-review.googlesource.com/1219414Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590303}
-
Christian Fremerey authored
There are certain frame drop reasons that can occur for more than one media stream type. This CL distinguishes the UMA counts for those by media stream type. Bug: 878964 Change-Id: I2b698577afe66012f1e885d0f5dc0724832781e1 Reviewed-on: https://chromium-review.googlesource.com/1214077 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590302}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5dc19a54. With Chromium commits locally applied on WPT: d7762551 "Consistently use single quotes in Background Fetch WPTs." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24545 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I13c24755f2f7cedc4c8a2fbf2e8b781b9746fb13 Reviewed-on: https://chromium-review.googlesource.com/1219766 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590301}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/58aa824ddaea..b42a897819dc git log 58aa824ddaea..b42a897819dc --date=short --no-merges --format='%ad %ae %s' 2018-09-11 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6dafcf32ec41..17b75890e71a (12 commits) 2018-09-11 mtklein@google.com just zero flags Created with: gclient setdep -r src/third_party/skia@b42a897819dc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I93d073797402387387b88f5333bce52b900539ab Reviewed-on: https://chromium-review.googlesource.com/1219412Reviewed-by:
-
Nicolas Ouellet-payeur authored
Bug: 882533 Change-Id: I84f2d5a88f42d896b218e37c310da3f606b3578c Reviewed-on: https://chromium-review.googlesource.com/1216811Reviewed-by:
-
Adam Rice authored
Mark them as "stable" in runtime_enabled_features.json5. The runtime flag will be removed once M71 has shipped. Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/jx2joIL5SbU/pGuwgvi7EAAJ BUG=845427 Change-Id: I1fa93383958fbd3de64936375937730c27f8d1da Reviewed-on: https://chromium-review.googlesource.com/1212431Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#590298}
-
Bruno Kim Medeiros Cesar authored
This change enable parents to override SafeSearch with host patterns, like "*.sex.*". Currently "allow" patterns are not considered for the "try to block mature sites" setting, so the URL is allowed by DEFAULT but blocked by the SafeSearch check. By returning a MANUAL reason, instead, then it will be honored. This may introduce a conflict when different patterns match the same URL, but have different defaults, say, "www.google.*" and "*.google.com" both match "www.google.com". In this case, we prefer to honor a blacklist over a whitelist. parent settings. Bug: 880909 Test: Built a Chrome APK and verified different combinations for Change-Id: Ia8a2e8c9261c9ea0a539c32a2ca8fe5e3e576fae Reviewed-on: https://chromium-review.googlesource.com/1207573 Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
stkhapugin@chromium.org authored
Bug: 862404 Change-Id: I3d775805657d7303cfbf6a04f581d855deb5717b Reviewed-on: https://chromium-review.googlesource.com/1219507Reviewed-by:
-
Vadym Doroshenko authored
When saving with new parsing is on, both PasswordFormManager and NewPasswordFormManager works in parallel. Atm it's possible that when OnLoginSuccessful is called, there is no NewPasswordFormManager that corresponds to the submitted form. That leads to crash. This CL introduces quick fix, namely just make early return when it happens. This fix is supposed to be merged in beta, so it's very easy. Later more proper handling will be implemented. Bug: 880247, 831123 Change-Id: I709f5ce16ea2d92f079f47308ec9c9dde7cf01e1 Reviewed-on: https://chromium-review.googlesource.com/1219687Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#590295}
-
