- 15 Jan, 2021 40 commits
-
-
Alexey Baskakov authored
WebAppsChromeOs::GetMenuModel() appends the menu items using manifest resources already stored on disk (that part is already launched on all OSes) We override previously introduced WebAppsChromeOs::ExecuteContextMenuCommand() to launch the web app with url params appended. We implement ConvertSquareBitmapsToImageSkia helper function which converts manifest icons to hi-dpi in-memory representation needed by our AppService UI code. Bug: 1129721 Change-Id: Ic6aa0777f74db079c91d0f50f173f334d4be862e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462899 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843981}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610668478-796ed01e77791225afcd16f130ade4fe33aa8256.profdata to chrome-win64-master-1610679078-e6bf7486827a51823717a01d08f3ea1e32a813ef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieb438fbee42fbaacc0660857ebde6ae16ecc66c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632365Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843980}
-
Devlin Cronin authored
Update the various features.json files (_[api|manifest|permission|behavior]_features.json) to use allowlist and blocklist terminology. Bug: 842387 Change-Id: I3e165efd2415b21275df06f5f67a944330474ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606784 Auto-Submit: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#843979}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - column_visibility_controller.js - dialog_action_controller.js - search_controller.js Bug: 1133186 Change-Id: I1aaecd54946f4c5fd8d33eba74951765f23cf000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632111 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843978}
-
Takuto Ikuta authored
This is specified by default after https://crrev.com/c/2626865 Bug: 1127205 Change-Id: I6d1b64ab6c68283196cc5614bfd26a2e03b025be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627651 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#843977}
-
Glen Robertson authored
TestingProfile::IsNewProfile now defaults to false instead of defaulting to the impl's behaviour when not overridden. profile.cc's inclusion of first_run.h was its last dependency on //c/b/... except for constants that have separate GN targets, and profile_observer. Removing the dependency allows profile.{cc,h} and profile_observer.h to be moved from //c/b:browser to a separate GN target (will be done in subsequent CL). This will let us break dependency cycles and improve modularization of the codebase. Bug: 1149277 Change-Id: If4d4c30ca49df8da518f6b2c014f61d2e4d2c425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626814 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:Greg Thompson <grt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843976}
-
Daniel Cheng authored
This is a reland of bca5f7be The original CL passed the CQ, but https://crrev.com/843803 added a new usage in between the time the CQ run started and the CQ run seemingly succeeded. Original change's description: > Declare T as a base class of the BrowserAssociatedInterface<T> helper. > > When a class uses BrowserAssociatedInterface<T>, it should implement the > mojo interface T. Force that to be the case by making T a suclass of > BrowserAssociatedInterface<T>. > > Change-Id: Ide8ecd46c298ec86de57b229593ec7d6c4b6a3a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629670 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843845} Change-Id: I16fd909b587aa06402484d25184f2155974cc8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631985Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#843975}
-
Mitsuru Oshima authored
Bug: 1155308 Change-Id: Ida2d8011c7a7d1ac14aff806d084e524e46d2bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628930Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#843974}
-
Matt Menard authored
Fixes missing trailing 's' from WebUI message. Ensures print server printers are always loaded after new print server is selected. Fixes opposite flag for print server selector. Bug: b:168650771 Change-Id: Ie2c7020d2f8752ab9bf00520a2b4ec3b6cddb776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622352Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#843973}
-
Luciano Pacheco authored
Add JS modules for //ui/file_manager/file_manger/foreground/js/ : - element_importer.js - deferred_elements.m.js This replaces the elements_bundle.html. Bug: 1133186 Change-Id: I372fbb5afe8bdd22483d0fcccda3b2dd240f447a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631812 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843972}
-
rajendrant authored
This reverts commit c08b4303. Reason for revert: Revert due to test failures Original change's description: > Fix flaky test > > Fix the path used in test server. > > Bug: 1166280 > Change-Id: I34fc06dc911c69d00f8dc4d193052d088f99816a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626022 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843864} TBR=rajendrant@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ibfee8d1710479ea363bf41ea4cf02e8df400d964 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631913Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#843971}
-
wutao authored
Currently ambient mode will exit on key press. However, the key event is not consumed and will enter into the login pod. To be consistent with other platforms, the key press is consumed in ambient mode by making the ambient controller a pretarget event handler and stopping propagation of the key event. Bug: b/173642446 Test: new unittests Change-Id: Iad04b07a0e6124773326c1d52d4a48a919ab87fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626911 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843970}
-
Asami Doi authored
This CL adds external/wpt/html/cross-origin-embedder-policy/ tests to the PlzDedicatedWorker virtual test configuration and the "Tests" section in core/workers/README.md. Bug: 1060837 Change-Id: I2f2e654710ecba794e4c4e3c4e03138db23fd1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628271 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#843969}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610657917-c5f7c43f5defa75543fc37f687b27a8203dbe683.profdata to chrome-win32-master-1610668478-7263610d5b531e252a86c5f5dc54aba9a5ada050.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2c55b38e44305cc8f902596fef97e0ccc156594d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631471Reviewed-by:
-
Luciano Pacheco authored
Add JS module for //ui/file_manager/file_manager/foreground/js/ : Files app: Add JS module for quick_view_uma.js Files app: Add JS module for quick_view_controller.js Files app: Add JS module for scan_controller.js Bug: 1133186 Change-Id: I7a47a9fb7c5cb0a11ebeb123f86a12a312b23239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631654Reviewed-by:
-
Eugene Zemtsov authored
Currently VideoEncoder will readback frames as RGB even if they have mappable NV12 GPU buffers. There is no need to do it underlying encoders can map GPU buffers just fine. Test: https://wcwc.glitch.me/ Bug: 1166962 Change-Id: Ie72c65c4df114264a70b9da337af27a934a8b74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631407Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#843966}
-
Luciano Pacheco authored
Add JS module for //ui/file_manager/file_manager/foreground/js/ : - main_window_component.js - app_state_controller.js Bug: 1133186 Change-Id: Ifba0bd6bef3b4540bb76d316e3b0350315deeff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631869 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Greg Thompson authored
Chromium, Chrome Cleanup Tool, and Software Reporter Tool. R=nparker@chromium.org, oshima@chromium.org Bug: 764528,764538 Change-Id: I082ff80423baa2ab5e6d08c0dc80a8f2f21985f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611710Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843964}
-
Etienne Bergeron authored
Based on the doc of the GetTimeZoneInformation(...) API https://docs.microsoft.com/en-us/windows/win32/api/timezoneapi/nf-timezoneapi-gettimezoneinformation Returned value needs to be compare to the value TIME_ZONE_ID_INVALID (-1). Follow up on a bug introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/2583012 R=gab@chromium.org Bug: 1074036 Change-Id: I7d227cd7a85b0b50eaea6be364012dee3d9357b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631925Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#843963}
-
Michael Thiessen authored
Implements LaunchCause.MAIN_LAUNCHER_ICON_SHORTCUT, for the shortcuts accessed by long-pressing the Main Launcher Icon (currently just to open new regular/incognito windows). Bug: 1163961 Change-Id: Id7f1c7e177fce5f0d2a9472f6e7d79b35b7e4474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626424 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#843962}
-
Justin Cohen authored
CrashKeyString wraps AddReportParameter/RemoveReportParameter when using breakpad. Bug: 1061431 Change-Id: Ia651045b8efe2ae79b769a099d49d5d85e00688b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574024Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#843961}
-
Sophie Chang authored
Bug: 1166906 Change-Id: I29b4ffd8e91923e0e86dc4b7fa6a0f54f0e4f63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631745Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843960}
-
Sophie Chang authored
These regexps will explicitly be not matched against an opt filter Bug: 1158883 Change-Id: I25b0659bcfbe5580598a08719bd673f8fed46f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631447Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Yuta Hijikata authored
This is a mechanical change replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and adding BUILDFLAG(IS_CHROMEOS_LACROS) to defined(OS_LINUX) to ensure switching lacros' target_os from linux to chromeos does not affect the lacros binary. It also renames chromeos_is_browser_only with is_chromeos_lacros which was a gn var introduced to be used in place of chromeos_is_browser_only. More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: I7e3e5685549c2b8c655a788a9fe827805988b11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628711 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843958}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610657917-28dde97bcaff353b91ba180b51342313b1d23453.profdata to chrome-win64-master-1610668478-796ed01e77791225afcd16f130ade4fe33aa8256.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib80ff78c71af78d52a73cc6bf30cedc3e6ce4407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631218Reviewed-by:
-
Hirokazu Honda authored
This reverts commit 1980f0cb. Reason for revert: Kernel uprev for SKL is not complete in M89. Original change's description: > Revert "media/gpu/test/VFValidator: Workaround the buffer synchronization problem on intel 3.18" > > This reverts commit 276dd2ba. > > Reason for revert: The root cause of the synchronization is fixed. > Removes this workaround. > > Original change's description: > > media/gpu/test/VFValidator: Workaround the buffer synchronization problem on intel 3.18 > > > > There is a synchronization problem on the mapped buffer on intel > > skylake devices. This is due to some missing 9165 patches in kernel > > 3.18, and thus will be fixed if the kernel is upreved to 4.4 or > > newer. This bug causes a decoded content validation failure in > > video_decode_accelerator_tests. > > This is a workaround to this bug; usleep() is added after the > > buffer is mapped and before the frame validation if the kernel > > version is 3.18 and the processor is Skylake. > > > > Bug: b:149808895 > > Test: video_decode_accelerator_tests on sentry > > Change-Id: Ib77ebe0b83834e4d91bc994cbe6912348862e021 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371724 > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801614} > > TBR=mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: b:149808895 > Change-Id: Id0f1bdcc486effef2c6d3fd64275d71051020028 > Test: None > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631645 > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843919} TBR=mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: b:149808895 Change-Id: I1f592a49c0276154101c59044c63c652c173e6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631808Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843956}
-
Yuta Hijikata authored
This is a mechanical change replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and adding BUILDFLAG(IS_CHROMEOS_LACROS) to defined(OS_LINUX) to ensure switching lacros' target_os from linux to chromeos does not affect the lacros binary. More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: I0d0fb9ca7ba4de1cd4151bcf68f0314e4b0fe970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626951 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
-
Ionel Popescu authored
Looks like Mac10.14[1] and Mac10.15[2] builders produce different test results so I am disabling the test introduced by https://crrev.com/c/2623652. [1]: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/b8858077277866870224 [2]: https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/b8858076574903066048 TBR=masonfreed@chromium.org,yuzhehan@chromium.org,avi@chromium.org Bug: 1166988 Change-Id: Ifee799c23cd8134fe9a341d8e6556fe62a321a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632267Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#843954}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I7dcde45e914fc89cf122abff35313d084593418f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596278Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843953}
-
Hirokazu Honda authored
This CL adds three test cases to av1_decoder_unittest, 1.) the stream configuration changes during decoding, 2.) decode a stream, Reset() and decode the same stream. 3.) decode a stream, Reset() and decode a different stream. Bug: b:175895249 Test: av1_decoder_unittest Change-Id: I09b480d28a7b8caf7997597ff75fd923c963b638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627202 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843952}
-
Caitlin Fischer authored
The server-side config shows that this has launched. Bug: 1126640 Change-Id: Ib27ab13a1f6bd4365be76900c768bf451a8ed406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632186Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843951}
-
Tim Sergeant authored
This changes the existing --arc-force-cache-app-icons switch into the more generic --arc-generate-play-auto-install, to be used by developers who want to generate new Play Auto Install rosters. The value of this new switch is also passed through to ARC as a system property, where it can be used to enable behavior inside ARC code. At the moment, this is used to force web app APKs to be visible in the app list. The existing switch (--arc-force-cache-app-icons) is not used for anything other than PAI generation, and can be safely renamed. BUG=b:177035416 TEST=Verify `adb shell getprop ro.boot.arc_generate_pai` prints `1` when flag is set. Change-Id: I5f626a36ad40a8ad35956e888dccbbbdb27dabaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626610 Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#843950}
-
Koji Ishii authored
This patch removes |LayoutNGFragmentItem| runtime flag and |FragmentItem| feature. These flags are already on by default in stable. Bug: 1154531 Change-Id: I68bdd1e2cac5a32c69eba6d5cbff26b798ddab63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629331 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#843949}
-
Yuta Hijikata authored
This is a mechanical change adding BUILDFLAG(IS_CHROMEOS_LACROS) to defined(OS_LINUX) to ensure switching lacros' target_os from linux to chromeos does not affect the lacros binary. More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: Ia047bcc761acac4773b8d62930771e89cb6d8c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628870 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I5dd6f36473a83bc37b9f49e4c32558313fce09bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631472Reviewed-by:
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - crostini_controller.js - gear_menu_controller.js Bug: 1133186 Change-Id: Ie078a26ec4d4fd4b73f780061483e2c62600bab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631387Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4727ced0f682072d613cf2bd1256208bb19149c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631219Reviewed-by:
-
chrome://syncfs-internalsdpapad authored
In the process, removed flattenhtml=true to stop inlining main.css, and serving it from its own URL instead. Similarly for other <include> flags in main.html. Bug: 1132403,1152343 Change-Id: I6c367dd5361111124db4d2592fac67582c7db740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629108 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Richard Chui authored
Add in a new settings button on the capture bar that is used to toggle a settings bar. This bar will start off only holding one setting, to toggle audio recording in video capture. Settings for the audio recording flag will persist between sessions. Bug: 1145273 Test: manual, added test Change-Id: I2ffbd3ac2971254c9c2227a42c64f511793ce795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606118 Commit-Queue: Richard Chui <richui@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#843943}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::PositionForPointInInlineBox()| to ignore pseudo element and layout generated text, e.g. ellipsis, and style generated text, "content" in ::before/::after, to handle clicking right of content of ::after correctly. Before this patch, |closest_child_before| (point) holds fragment item for value of CSS "content" in |PositionForPointInInlineBox()|, then |PositionForPointInInlineBox()| returns null position because style generated text is not DOM position. After this patch, |closest_child_because| (point) holds fragment item for last layout object having non-null |GetNode()| before pseudo element ::after. Bug: 1164974 Change-Id: Iaba2f0807c345b13463b956e009b730449121096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627242 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#843942}
-
