- 24 Oct, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/962ec4e02afc..b6c3804254e9 git log 962ec4e02afc..b6c3804254e9 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 yshaul@google.com chromeos_config: Migrate no_hwtest_builder to test config 2018-10-24 yshaul@google.com chromeos_config: Migrate no_vmtest_builder to test config Created with: gclient setdep -r src/third_party/chromite@b6c3804254e9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If30a631bad91780e2c8b6b5e5fa675a8f31b9d42 Reviewed-on: https://chromium-review.googlesource.com/c/1298155Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602395}
-
Scott Graham authored
Bug: 898088 Change-Id: Iaf7c0013ff0c7fa64f008023619962526bc41b81 Reviewed-on: https://chromium-review.googlesource.com/c/1298223Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602394}
-
Xiaocheng Hu authored
The passed-in position in DragCaret::SetCaretPosition is a hit test result (see DragController::TryDocumentDrag), which is already a canonical position. Hence, there's no need to canonicalize it again. Bug: 897983 Change-Id: I58f9bff731842a4d9f7c201f95ec2af769e158d7 Reviewed-on: https://chromium-review.googlesource.com/c/1297641Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#602393}
-
Wez authored
We have neither a use for, nor an implementation of, named platform channels under Fuchsia, so remove the APIs and NamedPlatformChannel handle type entirely under that platform. Bug: 754038 Change-Id: I85319f7b2df2e897e1fd34046911a2a11d5f4a20 Reviewed-on: https://chromium-review.googlesource.com/c/1288900Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#602392}
-
Zhenyao Mo authored
We could blacklist WebGL based on GL version, which is after creating a context. Right now this will trigger a failure and GPU process will exit and then relaunch with SwiftShader mode, which pre-load SwiftShader before sandbox init. So users will not notice, but this GPU process exit and relaunch is less optimal and unnecessary. BUG=897914 TEST=manual R=kerrnel@chromium.org,kbr@chromium.org,sugoi@chromium.org Change-Id: Idcd018ca1f2e5161002cdae4563462c76316c606 Reviewed-on: https://chromium-review.googlesource.com/c/1297481Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#602391}
-
David Jacobo authored
git cl lint pointed TouchSelectionControllerImpl should include set. Bug: None Test: Build. Change-Id: I8b78fbf36092116e35e287edb96557fc9be9f70d Reviewed-on: https://chromium-review.googlesource.com/c/1297247Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#602390}
-
danakj authored
When a RenderWidget is created for a RenderViewImpl, it may be considered "swapped out". This means the main frame for this RenderView's frame tree is not local, the RenderView exists to hold some other local subframe, which will be composited and have a RenderWidget. Thus the RenderWidget attached to the RenderViewImpl is not actually used, there is no output from the remote main frame in this tree. I like to refer to these swapped out RenderWidgets as zombies. During navigations, a RenderViewImpl's main frame may change to or from being local, in which case the RenderWidget attached to it changes to or from being a zombie. When becoming a zombie, the WebFrameWidget attached to the RenderViewImpl (wrapping the WebViewImpl) is destroyed, and this marks the compositor as SetVisible(false) on the RenderWidget (via the WebViewImpl). When becoming alive again, a new WebFrameWidget is attached to the RenderViewImpl, and the WebFrameWidget marks the compositor as SetVisible(true) on the RenderWidget (via the WebViewImpl). While a zombie, the WebViewImpl is also told not to allow any visibility changes to be passed along to the RenderWidget. This is because as the local subframe becomes visible with the Page, we'd tell the WebView about this, to tell the Page. But since the WebView now has a zombie RenderWidget, it shouldn't also tell that. Note when the RenderViewImpl is created and initially swapped out it creates a RenderWidget but nothing tells its compositor about the zombie state of affairs, so it becomes visible, which makes it acquire a Gpu channel and start its scheduler etc. Woops. This CL rearranges things a bit. - A new RenderWidget does not SetVisible(true) if swapped out. - RenderViewImpl directly marks it SetVisible(false) when removing the WebFrameWidget. - RenderViewImpl *also* removes the LayerTreeFrameSink to drop the Gpu channel since we don't need to be fast at becoming visible (the RenderWidget is a zombie!) - RenderViewImpl directly marks it as SetVisible(true) when getting a new WebFrameWidget as the RenderWidget stops being a zombie. - WebViewImpl stops calling SetVisible on the RenderWidget when its main frame is not visible. In the future the RenderWidget should be a member of the main LocalFrame, and thus won't even exist when the main frame is not local. R=dcheng@chromium.org, piman@chromium.org Change-Id: I87a5d0dfeaaf08cb91c9348b26b4205db55b3a81 Bug: 894899, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1290140Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#602389}
-
Erik Chen authored
Restarting content shell between layout tests increases run time by 2-5x but produces more consistent results. Previously, this was implemented as a flag to content shell that would restart the renderer between tests. This CL changes the test runner to instead restart content shell between tests. This has comparable run time, with less complexity and even less probability of state carrying over between tests. The content shell flag --reset-shell-between-tests is now unused, and will be removed in a future CL. Bug: 894527 Change-Id: Idce9a74006000ded0d308affaff0568226a2cf7f Reviewed-on: https://chromium-review.googlesource.com/c/1296673 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#602388}
-
Ricardo Quesada authored
Update Underlay candidates' damage_rect even if they don't get promoted to overlays. At the moment they do have the damage_rect updated when they get promoted. But not otherwise. There is corner case when the damage_rect is must be updated redarless whether the candidate gets promoted. This CL fixes that. And also fixes some "git cl lint" warnings (missing #include <vector>) BUG=b:116355420 BUG=b:117341940 TEST=viz_unittests --gtest_filter=UnderlayTest* Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic543d844c09f47c845cfe0103f0462f5f67a9dbc Reviewed-on: https://chromium-review.googlesource.com/c/1286275 Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#602387}
-
Andrey Kosyakov authored
This removes protocol types used for response headers and auth challenge from InterceptedRequestInfo and replaces them with net: :HttpResponseHeaders and net::AuthChallengeInfo. Change-Id: I4fa916d0d6bf77a9c4de183396372a87948992c7 Reviewed-on: https://chromium-review.googlesource.com/c/1297573 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602386}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/safe_browsing. This CL was uploaded by git cl split. R=nparker@chromium.org Bug: 809610 Change-Id: I880627bdc67561e465ef16eae0bf1d3ad66c234d Reviewed-on: https://chromium-review.googlesource.com/c/1297415Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602385}
-
Victor Vasiliev authored
Change-Id: I87b3522aaa82c5e93f0a9032b2b82963f79b11f2 Reviewed-on: https://chromium-review.googlesource.com/c/1297258Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#602384}
-
Joe DeBlasio authored
Unicode character U+0A24 is easily confused with a '3'. This CL adds this character to the list of confusable characters to use when determining whether to render IDNs as punycode instead of their unicode representation. R=tommycli@chromium.org Bug: 896725 Change-Id: Ieaa38b5977b9afb454e672461722f3c8be9a2a2c Reviewed-on: https://chromium-review.googlesource.com/c/1297638Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#602383}
-
Philip Rogers authored
These tests can be run now that SPV2 clips work with fragmentation. The results for CompositedUnderMultiColumn have been updated. Bug: 796768 Change-Id: I3a77348fa7875c076098c0ad4b785b381ca311b9 Reviewed-on: https://chromium-review.googlesource.com/c/1298125 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602382}
-
Johannes Henkel authored
See https://chromium.googlesource.com/deps/inspector_protocol/+/460186cff1f0eead0d418626e7e75f52105182b2 Bug: chromium:891377 Change-Id: I77a350b5338d17c9cd0bf18423abcfe2d6f1e4eb Reviewed-on: https://chromium-review.googlesource.com/c/1297606 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#602381}
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: fast/d* Most of this patch is mechanical rebaseline, except that some LayoutNG-specific baselines become redundant and are removed Bug: 887148 Change-Id: Ib51d0cc74a66eab1a839404df20c6f427d1de216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1294219Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#602380}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/supervised_user. This CL was uploaded by git cl split. R=pam@chromium.org Bug: 809610 Change-Id: I702004601120d3c855ec3a1b1670358ee9b57fa8 Reviewed-on: https://chromium-review.googlesource.com/c/1297414Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602379}
-
Xianzhu Wang authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1277654, we no longer generate text result of many tests, thus these tests no longer need the text baselines. This CL checks for extra baselines in the following cases: 1. Extra -expected.png (existing logic) for ref tests; 2. Extra -expected.txt, -expected.png, -expected.wav if the test doesn't generate the result; 3. Extra -expected.txt for all-pass testharness tests. For 2, the extra baseline will be treated as a mismatch failure (which can be interpreted as that the test doesn't generate the result, but the baseline expects the result). For 1 and 3, there are just warning messages because for now we don't have a good way to present them in the layout test result page. We have already had a similar logic in pre-submit for 3 and the new check in run_web_tests is more accurate. For other types of extra baselines, it's hard to implement the check in presubmit because it needs more knowledge than static pre-submit knows. Bug: 703899 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9016d5583791f179f1d51561245602af615d21de Reviewed-on: https://chromium-review.googlesource.com/c/1286894 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#602378}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6d2f3f4..0d55c88 Includes suppressions for the following failures: conformance/rendering/rendering-sampling-feedback-loop.html conformance2/textures/misc/tex-mipmap-levels.html conformance2/textures/image_bitmap_from_video/ tex-2d-rgb565-rgb-unsigned_short_5_6_5.html deqp/functional/gles3/lifetime.html deqp/functional/gles3/shaderoperator/common_functions_*.html Bug: 660844, 739604, 766918, 849576, 886970, 890002, 890539, 898350, 898351, angleproject:2832 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: I85be441fa86090e5ed056a9366452248985693e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297570Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602377}
-
Alexandr Ilin authored
This CL replaces deprecated base::SharedMemory and base::SharedMemoryHandle classes with the new classes for shared memory. Bug: None Change-Id: I96073aef72ecd56153fcc49d96f0ab526003f3ef Reviewed-on: https://chromium-review.googlesource.com/c/1296537 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Ryan Hamilton authored
* Make the QuicPacketCreator use an explicitly passed in QuicRandom * Make PATH_CHALLENGE and PATH_RESPONSE frames instigate acks. Change-Id: Iaf749244c9e9fe34f35b7927b3dacebe4807b8c0 Reviewed-on: https://chromium-review.googlesource.com/c/1297352 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#602375}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/96e1e621..8bc0f79a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7de6a4e94e637a56de33df801531e9e7ff4eb4dc Reviewed-on: https://chromium-review.googlesource.com/c/1297742Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602374}
-
Lukasz Suder authored
The Server Payload should not only be passed for GetNextActions, but also for GetActions. Now it is saved inside ClientMemory as ScriptExecutor has too short lifetime (only 1 request/response roundtrip). Bug: 806868 Change-Id: Id18ab90bfc2c4ea69bd07caab6373c6d0dbf139f Reviewed-on: https://chromium-review.googlesource.com/c/1298013 Commit-Queue: Lukasz Suder <lsuder@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#602373}
-
Mario Sanchez Prada authored
This removes the dependency on OAuth2TokenService from AuthService, adapting all the clients of such API across the board, that is: - Private files from chrome/browser/chromeos/extensions/file_manager - drive::DriveAPIService (components/drive/service/drive_api_service.*) Likewise, in order to keep chromium building and tests passing, this changeset also updates the few clients of DriveAPIService in order to pass an IdentityManager from now on, instead of an OAuth2TokenService: - //c/b/chromeos/drive/drive_integration_service.cc - //c/b/sync_file_system/drive_backend/sync_engine.* - //c/b/apps/platform_apps/api/sync_file_system/sync_file_system_browsertest.cc ...where //c/b stands for //chrome/browser. Bug: 809440 Change-Id: I0c5691bcd2e86e8b0e7bca2f27fa42e2edc59a84 Reviewed-on: https://chromium-review.googlesource.com/c/1288571Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#602372}
-
sczs authored
- Moves InfobarContainerView inside a newly created InfobarContainerVC. - Adds constraints between InfobarContainerVC and the contained infobar, this makes it possible to delete some re-layouting calls that needed to happen whenever the Infobar changed heights. - Makes InfobarContainerVC conform to the SignInPresenter and InfobarContainerStateDelegate protocol instead of the Coordinator. Bug: 892376 Change-Id: I92d4dc6f82e9062311dee2936c28e3d8ec62b485 Reviewed-on: https://chromium-review.googlesource.com/c/1294469Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#602371}
-
Xiaoqian Dai authored
Refactoring of the internal input events blocker in TabletModeController. The input events should only be blocked if 1) we're currently in tablet mode or 2) we're currently in clamshell mode but the lid is flipped over, i.e., we are in laptop mode because of an attached external mouse. Bug: b/118049922, 887042 Test: Newly added test and existing tests passed. Also manually tested on convertible/clamshell/tablet devices Change-Id: I93d963cfab2ae14bd1cad19675f0ed4fed88c1b0 Reviewed-on: https://chromium-review.googlesource.com/c/1297577Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#602370}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc82994e3a76..472639d9f12f git log dc82994e3a76..472639d9f12f --date=short --no-merges --format='%ad %ae %s' 2018-10-24 reed@google.com add alignment and lcd to SkFont (for now) 2018-10-24 bsalomon@google.com Disable GrOp chaining. 2018-10-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8a587714cb9f..805d7616a05e (1 commits) 2018-10-24 mtklein@google.com serious SkEdgeBuilder refactoring 2018-10-24 caryclark@skia.org fix fuzz divide by zero 2018-10-24 csmartdalton@google.com ccpr: Fix an overzealous assert in DDL Created with: gclient setdep -r src/third_party/skia@472639d9f12f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:894015 TBR=brianosman@chromium.org Change-Id: If6b9cf59ad133403e89dbafbd72fc29a0a7cf6f0 Reviewed-on: https://chromium-review.googlesource.com/c/1298069Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e6749e0dd3f..62ae178357b7 git log 8e6749e0dd3f..62ae178357b7 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 titovartem@webrtc.org Remove deprecated pipe field from VideoQualityTestFixtureInterface::Params 2018-10-24 mbonadei@webrtc.org Revert "Encode RTC event logs in new format." 2018-10-24 titovartem@webrtc.org Remove deprecated DefaultNetworkSimulationConfig 2018-10-24 mbonadei@webrtc.org Use checkdeps to ensure API headers don't include internal headers. 2018-10-24 titovartem@webrtc.org Remove deprecated API: NetwrokSimulationInterface. 2018-10-24 eladalon@webrtc.org Add support for optional fields in FixedLengthDeltaEncoder 2018-10-24 nisse@webrtc.org Fix w3c URL for RTCIceTransport 2018-10-24 ilnik@webrtc.org Forward audio rtp frequency to Rtcp sender and use it for SR packets 2018-10-24 terelius@webrtc.org Encode RTC event logs in new format. 2018-10-24 peah@webrtc.org AEC3: Included missing parsing of config parameter Created with: gclient setdep -r src/third_party/webrtc@62ae178357b7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:898462 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5520aeb8a451c848b3a73d41741ce1d30c606be0 Reviewed-on: https://chromium-review.googlesource.com/c/1297347Reviewed-by:
-
Eric Orth authored
Mojo API to override system DNS config for built-in resolver resolutions. This is the servicification of the API added in CL 1259902. When a non-nullopt overrides struct is specified in CreateHostResolver calls, a separate internal net::HostResolver is created and used with the overrides. A better solution would be to use the normal shared net::HostResolver, eg by setting per-request overrides, but that is unnecessary and out of scope for the current needs where this is only expected to be used by a special case (DnsProbeService) that doesn't care about shared stuff like caching. TBR=caseq@chromium.org Bug: 846423 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1b49da83d166f80b503bd6955328f3492d553a5e Reviewed-on: https://chromium-review.googlesource.com/c/1269076 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#602367}
-
Xiaocheng Hu authored
FrameCaret::CaretPosition() is already canonicalized. There's no need to canonicalize it again. Bug: 897983 Change-Id: I3d58572099fa17b7aada06fe799989f6f8fe67f5 Reviewed-on: https://chromium-review.googlesource.com/c/1297633Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 11014 11018 11022 11038 11044 11048 11053 11059 11062 2 lines were removed and 4 lines were deflaked by consecutive results since 10995. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: Ic5ef6f5050c1310249066cd6e6bd12cabe0e4ea9 Reviewed-on: https://chromium-review.googlesource.com/c/1296729 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#602365}
-
Min Chen authored
Work area is not always starts from the top of the display, e.g, docked magnifier will put a view port window at the top area of the display. This will cause that in portrait screen orientation, the height of the work area is not always larger than the width of the work area. This cl tried to fix this by updating the divider position on |divider_closest_ratio_| instead on relying on the longer side of the work area. This cl also fixed the wrong bounds of the preview area, which was set in its own view coordinate. So should special consider the case that work area is not from the top of the display too. Bug: 866680, 897900 Change-Id: I86a98aee52ecbd706385cda0a639e5182997914b Reviewed-on: https://chromium-review.googlesource.com/c/1292833 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#602364}
-
Daniel Bratell authored
Up until now headers were removed from |sources| and then reinserted. Cleaner/easier is to never remove them from the start. Change-Id: I8f7560ef96f409880647e2924c2f71317f519468 Reviewed-on: https://chromium-review.googlesource.com/c/1290969Reviewed-by:
-
Daniel Bratell authored
Original developer and main maintainer. Change-Id: Ia7eacd431f2d83c30ffb5231745b8fcfab8ebd21 Reviewed-on: https://chromium-review.googlesource.com/c/1297135Reviewed-by:
-
Gauthier Ambard authored
This CL adds a switch enum to chrome://flags to change the icon displayed by the search button in the bottom toolbar. Bug: 866013 Change-Id: I1892cb02f42bc6d1324e276b9022663e48b45b3b Reviewed-on: https://chromium-review.googlesource.com/c/1297972 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Dale Curtis authored
This reverts commit cbcb1c3c. Reason for revert: breaking win-asan https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/1941 Original change's description: > Roll src/third_party/perfetto 78f4835a7135..c365e36901fe (3 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/78f4835a7135..c365e36901fe > > > git log 78f4835a7135..c365e36901fe --date=short --no-merges --format='%ad %ae %s' > 2018-10-24 fmayer@google.com profiling: Add fuzzer for unwinding. > 2018-10-24 treehugger-gerrit@google.com Merge "profiling: Fix register size calculation." > 2018-10-24 treehugger-gerrit@google.com Merge "perfetto: Add ASAN container size annotations to PagedMemory" > > > Created with: > gclient setdep -r src/third_party/perfetto@c365e36901fe > > The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=perfetto-bugs@google.com > > Change-Id: I3b9ef13668609404211f3779a56f9be144b2c761 > Reviewed-on: https://chromium-review.googlesource.com/c/1297340 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#602327} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I2c09d46fef5dca92de7b1280418cc5a5d6be0f51 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1298121Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602360}
-
Daniel Bratell authored
In jumbo builds, many cc files compile in the same translation unit which means that they also share the same anonymous namespace. This makes it necessary for constants and global scope functions to have names that are unique in the build target. This particular error only happens in extreme jumbo (many files compiled at once) and not the more modest jumbo configurations (8-50 files compiled at once) I think. Change-Id: I86d15bcfd5c55db9592cb9423943d2e46b8f2e5c Reviewed-on: https://chromium-review.googlesource.com/c/1297361Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#602359}
-
David Bokan authored
ScrollCustomization currently places the API surface on Element rather than Node, meaning a callback can only be set on Elements. This becomes a problem as the Document node is not an Element but is the node that's used to perform scrolling for the frame's viewport. This causes all kinds of contortions in various places in scrolling code. One example where this is causing an issue is https://crrev.com/c/1287176. See also ScrollManager::RecomputeScrollChain. This CL is a mechanical move of ScrollCustomization to use Node as the primitive on which callbacks operate. This will allow us to simplify scrolling code in several places; however, this patch is just a mechanical movement of the code from Element to Node. Future patches will actually modify the behavior to make use of the fact that we can now use the document node. Bug: 897288 Change-Id: I0cab17888d30f981b731848f5ba6e499f966efca Reviewed-on: https://chromium-review.googlesource.com/c/1297576Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602358}
-
Joshua Bell authored
Switch a few Cache Storage-related code paths from generic Bind/Callback to BindOnce/OnceCallback. Bug: 714018 Change-Id: I245cb56090228865cb0f4957caf8f704568eac39 Reviewed-on: https://chromium-review.googlesource.com/c/1289433Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbe27839a04c..cebaec875850 Created with: gclient setdep -r src-internal@cebaec875850 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie214ab101e3181983792c81e54e055bb2ceaf439 Reviewed-on: https://chromium-review.googlesource.com/c/1297348Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602356}
-
