- 26 Nov, 2019 40 commits
-
-
Trent Apted authored
This reverts commit 3e9d66eb. Reason for revert: Widespread bot failures for Step "isolate tests" error like: isolate: isolate /b/s/w/ir/cache/builder/src/out/Release/devtools_type_check.isolate: partitioning deps: lstat /b/s/w/ir/cache/builder/src/third_party/blink/renderer/core/inspector/browser_protocol.pdl: no such file or directory Bug: 1028446 Original change's description: > Move browser_protocol.pdl to third_party/blink/public/devtools_protocol > > Bug: 1018108 > > This still retains a copy of protocol.json for compatibility with > devtools front_end. > Also, remove a presubmit for front-end compilation upon a change to PDL > since the front-end is in another repository now. > > Change-Id: I2faea62feca80776d2fc0a0b4ea00a90439ae005 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898538 > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718903} TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org,jochen@chromium.org Change-Id: I39435e4be7dde62ffd48d1f72a0ecbbac9165ae1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935479Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#718977}
-
Kenichi Ishibashi authored
This isn't used, might be replaced with one in ServiceWorkerVersion. Bug: N/A Change-Id: I672ea9fd15f3d3ce0db772b070ae81791075db01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935767 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718976}
-
Eric Seckler authored
This is a reland of 4da16526. Relanding after the bad event nesting in v8's GC events was fixed. Also increases the default trace buffer size, because the traces with split events are slightly larger and cause some benchmarks to lose data otherwise. Furthermore, includes a fix for a bug that caused us to emit COMPLETE events as atrace events twice. Original change's description: > perfetto: Split COMPLETE events into BEGIN/END pairs > > There are a few reasons why this is desirable: > (1) Reduces need for complete event stack in ThreadLocalEventSinks, > which was brittle before (e.g. crbug.com/983307). > (2) Makes it possible to flush event sinks while tracing in the future > without losing not-yet-completed COMPLETE events from the stack > (streamed tracing use case). Events that didn't end before the > flush will still be present in the trace as BEGIN only. > (3) Prevents reordering of nested COMPLETE events - something which > could confuse TraceProcessor in the past (events with identical > begin timestamps would be imported incorrectly). > > To achieve this, this patch also plumbs the EXPLICIT_TIMESTAMP flag > and thread id through to TraceLog::UpdateTraceEventDurationExplicit, > because it seems that android can add COMPLETE events with explicit > timestamps / threads [1]. > > [1] https://cs.chromium.org/chromium/src/base/android/early_trace_event_binding.cc?q=INTERNAL_TRACE_EVENT_ADD_WITH_ID_TID_AND_TIMESTAMPS&ss=chromium&l=31 > > Bug: 983307, 928738, 1006770 > Change-Id: I66e685c04c068646d550f182185d3c45febcbfa8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899852 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716871} Bug: 983307, 928738, 1006770 Change-Id: I478ab4ade4bf5182d41cedb2f0b5fd22ba2e1604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931750 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#718975}
-
Peter Kasting authored
Intended change: Light mode: kGoogleRed700 -> kGoogleRed600 Dark mode: kGoogleRed700 -> kGoogleRed300 Bug: 1028245 Change-Id: Ida204c593a21f018fb39adc9091653012c1b259d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933943 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#718974}
-
Stuart Langley authored
- Change how arrays that are composed of other arrays are defined. - Fix some closure markup at while I'm here. Bug: 894342 Change-Id: I10355a93c6a5fae24a8626cd69a392158bdeba0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935667 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#718973}
-
Melissa Zhang authored
Code stub for reference. Change-Id: Ida9126ed845fcb4548ad7bd4b411054d14af3f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904565 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#718972}
-
Toni Barzic authored
Adds back fling from overview to home screen when kDragFromShelfToHomeOrOverview is enabled. With the feature disabled, drag/fling from bottom in overview transitions to home, and is handled by HomeLauncherGestureHandler. When the feature is enabled, the gesture is not propagated to HomeLauncherGestureHandler (as it might have to handle hotseat drag in split view). This adds handling for the fling in overview to shelf_layout_manager, to re-enable the gesture - the handling is moved from HomeLauncherGestureHandler to ShelfLayoutManager to better handle the case where the hotseat starts off in the hidden state (and fling in split view can either bring up the hotseat, or go to home screen, depending on the gesture length) - handling the gesture in HomeLauncherGestureHandler means that the drag event would not be handled as shelf drag event (which brings up the hotseat). The fling is expected to transition to home if: * in overview mode * in split view mode with overview, and fling is on the overview side (otherwise, the gesture should be handled by window_drag_controller_) BUG=1023910 Change-Id: I2385d195aa06f04d264da926091e6fc4b5f8fe26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935107 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718971}
-
Daniele Castagna authored
CreateSharedImage with usage SHARED_IMAGE_USAGE_SCANOUT tries to allocate the underlying buffer with BufferUsage::SCANOUT. BufferUsage::SCANOUT might fail in some circumentances when a buffer can still be allocated, but it's not possible to use it for scanout (e.g: on virtio_gpu AddFramebuffer will fail for buffers smaller than a certain threshold). This changes the logic of CreateSharedImage so that in cases where we fail to allocate a buffer for scanout, we try again to allocate just for GL. Bug: 1024019 Test: crrev.com/c/1918316 in webgl_conformance_tests on chromeos-amd64-generic-rel Change-Id: I20615e0780e47425a4074204f706bc66018e2071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933198 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718970}
-
nancy authored
BUG=1016159 Change-Id: Ide7712b6f6abf19c3ffcd054d69ecf1468cbe605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933673 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
-
Emircan Uysaler authored
This is a mitigation step as we observed DCHECKs hit and flickers with accelerated canvas. Bug: 1019212 Change-Id: I11948318dbd6905f2d9930823719871fd5832aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935412Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718968}
-
Stuart Langley authored
Add a specific message when trying to open a zip file that will exceed the limit of mounted FSPs. Bug: 1014806 Change-Id: I8231465c7f9f1f15f1226d5707f26b55bfdbc8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935309Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#718967}
-
ssid authored
The delayed task causes crash if shared db is deleted at shutdown before the task gets executed. This is temporary fix to avoid crashes. BUG=1014088 Change-Id: Idacdac48b3cccd8265ed8542a251710b0fc5dce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935494Reviewed-by:
-
Khushal authored
The only blocker for this is the input latency regression which we hope to recover with skbug.com/9455. But the regression is in the order of 4 to 11% at the 99th percentile, which is not severe enough to hold back the rollout. Bug: 757605 Change-Id: I77618b2b1de99c9367e85fa10a445f387380b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929637 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#718965}
-
Alex Newcomer authored
The shelf size can change, now that target bounds are stored in ShelfLayoutManager, use this to ensure the hotseat does not jump. Bug: 1022155 Change-Id: I19fbf1f0193f433bceeb21963d3967c01340e9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935128Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#718964}
-
Simon Que authored
These builder def functions set Goma RBE backend by default: ci.star: - gpu_fyi_linux_builder() - linux_builder() try.star: - gpu_linux_builder() - linux_builder() Bug: 1025325 Change-Id: Id013d72d11744a7192790fe1fa60c2b4e4dfb616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933829Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#718963}
-
Megan Jablonski authored
Add a close button on the Translate error dialog in the new tabbed UI. Also fix margins and use an 'Options' button rather than 'Cancel'. Bug: 976352 Change-Id: I70cca26d27a78ebc9605988300e9ca10745b4228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922917 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#718962}
-
Piotr Bialecki authored
Generated in a semi-automated way by running the below command & fixing up build breaks related to WTF::Bind and WTF::IsHashTraitsEmptyValue. grep -rl third_party/blink/renderer/modules/xr/ -e 'WTF::' | xargs sed -i 's/WTF:://g' In response to the CL feedback: https://crrev.com/c/1919942/8/third_party/blink/renderer/modules/xr/xr_session.cc#168 Change-Id: I06b109dab7e196b2ee13ca81f1edf1b096a74515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931407 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#718961}
-
Noel Gordon authored
In the files-ng case, the active / inactive icon of a directory tree .tree-row will be handled with a -webkit-mask-image. Since .tree-row are directly followed by a .file-row child element in files-ng, then the -webkit-mask-image rules are written as follows: .tree-row > .file-row > blah ... { -webkit-mask-image: url(../some/source/image.svg); } so they only match in the files-ng case. Next, the pre-existing .tree-row[selected] blah ... .tree-row blah ... rules can match in both normal and files-ng files app. Rewrite those rules with direct descendant selectors: .tree-row[selected] > blah ... .tree-row > blah .. so they continue to match in the normal files app case (no change in behavior) but do not match in the files-ng case. Bug: 992819 Change-Id: Idba611834f12f951becfc45bdad6db9ac6090bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934132Reviewed-by:Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#718960}
-
Matthew Mourgos authored
This change ensures that ShelfItems have the same ordering in both the ShelfView's |view_model_| and the ShelfView's child views. This is done to keep the child views in correct traversal order for ChromeVox. This change also ensures that views that are removed from the |view_model_| are also removed as child views from ShelfView. This is done in ShelfItemRemoved() by initializing a unique_ptr to the removed view. Once the unique_ptr goes out of scope the removed view is deleted and removed as a child view. Bug: 1024085 Change-Id: I4b4d6c3a855b41fc315a1d76f39c56ca0db380d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925783Reviewed-by:
-
John Lee authored
Bug: 1028253 Change-Id: Ia92c155d22f7f1d7e0692b7baea50d84146a70a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935127 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#718958}
-
Matt Menke authored
This is needed to separate out host resolutions made from different sites. Also make PreconnectManager pass in the correct NetworkIsolationKey. The two other consumers of the API currently pass in empty NetworkIsolationKeys, and will be fixed in followup CLs. Bug: 1021661 TBR: hashimoto@chromium.org, raymes@chromium.org, jam@chromium.org Change-Id: I49d6d147f25dacce9d02112b2d0bfbe75a8a9b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925136Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#718957}
-
Bo Liu authored
Fling has moved to browser side. Remove webview's hooks into root layer fling on the renderer side since they are obsolete. Change-Id: I81489a2458b6808ee516a4f76ca79df58e44f38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933448Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718956}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/004dbc282e4c..d0dd9068ec64 git log 004dbc282e4c..d0dd9068ec64 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 primiano@google.com Fix build and address nits from aosp/1172102 Created with: gclient setdep -r src/third_party/perfetto@d0dd9068ec64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:132880619 Tbr: perfetto-bugs@google.com Change-Id: Ia4d2d21e0984983baf9ba44a88269994b055d35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718955}
-
Ayu Ishii authored
This change allows developers to use the SMS Receiver API with the Abort Controller to cancel once the API is called. This will help developers with flows for retrying and sending a new code and they want to abort the previous call they made to the API. If the InfoBar is up during abort, it will leave the InfoBar open while returning an AbortError to the website. If another request is made while the InfoBar for 1st request is still open (after abort), upon clicking 'Verify' the SMS retrieved for the 1st request will return to the 2nd request. Original CL: https://crrev.com/c/1866914 Revert CL: https://crrev.com/c/1930275 Failure ticket: https://crbug.com/1027386 Failure locally reproducible with following test command: python testing/scripts/run_isolated_script_test.py third_party/blink/tools/run_web_tests.py -t LinuxTest third_party/blink/web_tests/external/wpt/sms/interceptor.https.html --isolated-script-test-output=output.json --isolated-script-test-perf-output=perftest-output.json --additional-expectations third_party/blink/web_tests/LeakExpectations --enable-leak-detection Bug: 976401 Change-Id: I9b1208a6cf9c05185fa734809ab275235238cf4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929864Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Remove duplicated types from |VolumeManagerCommon| namespace, instead change code to use type and enums directly from IDL and its externs. Mock the enums to unittest because chrome.fileManagerPrivate isn't available in the unittest running environment. Add |hasCellularNetworkAccess| where required by closure because the previous type deifinition in |VolumeManagerCommon| didn't have this attribute, defaulting to |false| which is semantically the same as |undefined|. Reasons: 1. Remove type/enum duplication. 2. Avoids comparing enums to strings which is weaker. Bug: 931971 Fix: 931971 Change-Id: I436717e2d1541ff51581a83be6f120ccba5f13db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934128 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8dfc2b05d987..4b53273c1292 git log 8dfc2b05d987..4b53273c1292 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 courtneygo@google.com Vulkan: Fix validation issue with swiftshader 2019-11-25 flibitijibibo@gmail.com Implement BaseVertex draw calls for Vulkan, OpenGL, NULL contexts. Created with: gclient setdep -r src/third_party/angle@4b53273c1292 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I7556c6207eb87ede82e65f9fb3b109e03dc8213c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935435Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6620506591b7..13ea34f30537 git log 6620506591b7..13ea34f30537 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 steveanton@webrtc.org Revert "Add IvfVideoFrameGenerator" 2019-11-25 elrello@microsoft.com Address failing wpt test cases for the rollback feature Created with: gclient setdep -r src/third_party/webrtc@13ea34f30537 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1025557,chromium:1025542 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8c25c235083e26df7cc59d4746006311e4c3658e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935436Reviewed-by:
-
Matt Mueller authored
These names are more descriptive and also free up the name TestNetLog for use in a future CL. Bug: 177538 Change-Id: I46a0680a690e7868bb4c325cbe27c161c2e95b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912783Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5504dc6427fb..83aafc979fa6 git log 5504dc6427fb..83aafc979fa6 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 ehmaldonado@chromium.org depot_tools: Make gsutil compatible with python3. Created with: gclient setdep -r src/third_party/depot_tools@83aafc979fa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1026371 Tbr: agable@chromium.org Change-Id: Icd8ef91db7e7a3860156b7e25d00ee6597dc0efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935017Reviewed-by:
-
Matt Mueller authored
Forgot to document the new params added in https://chromium.googlesource.com/chromium/src/+/c13f3d7bb95c1717de7abd4282db8c7e0ffac7e7 Change-Id: I939c9ed126b063ad93f34f3ba8c1d8817fdb1059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930255Reviewed-by:
-
Johannes Henkel authored
PS: I admit that I've already introduced some usages cowboy-style, using the --bypass-hooks flag. I didn't remember which script to edit. Andrey's PR reminded me - thank you! Change-Id: Ie4b645fc80c2d3b28898a91a1c557bcc3d683d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935442Reviewed-by:
-
Alex Newcomer authored
When the hotseat is enabled, animate the shelf and hotseat at the same speed as the minimize/maximize animation. Bug: 1028387 Change-Id: I5fae2038258b3353776bd283950509ec53d26e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935492Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Johannes Henkel authored
Feels the most efficient way to accomplish this is to make data() and size() return appropriate values when impl_ isn't set. Bug: 1026646 Change-Id: I8f9f1cb6621173ced066065f4ec6b64b5a609322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935430Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#718945}
-
Matt Falkenhagen authored
Bug: 1007763 Change-Id: I9c934d13eb233f42734098d0343bb18f5b53099d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928390Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#718944}
-
Demetrios Papadopoulos authored
Most of these have been fixed automatically with ESLint's --fix flag. This is in preparation of turning on presubmit checks for no-var and prefer-const for components/. Bug: 792774,720034 Change-Id: Idd8773f1d3dca7bc17f23a8ea5cac635f63546fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918694 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718943}
-
Jarryd authored
Change the QuotaSettings tests to better cover the incognito quota experiment, as described by pwnall@ in https://crrev.com/c/1895074/4/ Bug: 1017120 Change-Id: Idd55ca10f1215908a80e98bdedce48d137100244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913172Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#718942}
-
Collin Baker authored
This suppresses the default context menu and shows a custom one similar to that shown when right clicking on the native window frame. Fixed: 997887 Change-Id: Ia9cc3b394b42e245b1bee783e313d94917f5c50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931596Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#718941}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f65850fd60b..069565ced288 Created with: gclient setdep -r src-internal@069565ced288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None,chromium:1004848,chromium:b/143469908,chromium:b/143118392,chromium:b/131785528,chromium:b/139309841,chromium:950146,chromium:1027573,chromium:951275 Tbr: jbudorick@google.com Change-Id: I2e3fd62fe32ad2158193e8abbd08402d74fd95dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935015Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718940}
-
Donn Denman authored
Disables a few Omnibox tests on all versions of Android beyond KitKat because they are flaky. This is a correction to https://crrev.com/c/1931856 which got the sense of the disabling for > KitKat backwards. BUG=1027549 TBR=twellington@chromium.org Change-Id: I91be9e20633fbc418e2cb0bfd1d3101d95b6f8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932170 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#718939}
-
Caleb Rouleau authored
This reverts commit 76dc2efe. Reason for revert: https://chromium-review.googlesource.com/c/catapult/+/1896356 landed, so relanding this is fine. NOw this will have no impact on anything unless you pass in the --run-abridged-story-set flag. Original change's description: > Revert "[Telemetry] Provide abridged story sets for rendering and system health." > > This reverts commit 9867b18b. > > Reason for revert: This causes unexpected behavior per Ross's comment on https://chromium-review.googlesource.com/c/catapult/+/1874453 . I will reland this once I fix Telemetry. > > Original change's description: > > [Telemetry] Provide abridged story sets for rendering and system health. > > > > Note that this will have no impact on what is currently running > > on the waterfall because all benchmarks are labeled as > > abridged: False right now. > > > > This change is now possible because: > > > > 1. Pinpoint was taught to use the --run-full-story-set flag by > > https://chromium-review.googlesource.com/c/catapult/+/1874451 > > > > 2. benchmark_smoke_unittest.py was fixed: > > https://chromium-review.googlesource.com/c/chromium/src/+/1874821 > > > > Note that system_health_smoke_test.py is fixed as part of this > > change. > > I tested this fix by running > > /run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:game > > and seeing that the stories, a mix of health_check stories > > and stories without the health_check tag were all run. > > > > Bug: 965158 > > Change-Id: I42ca28543155536da62d9b02d9bf31d8eb311ac3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687783 > > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711017} > > TBR=sadrul@chromium.org,perezju@chromium.org,crouleau@chromium.org > > Change-Id: I9e7ae496ef48ed00bcf2a8d67df42c577d3162d3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 965158 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893738 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711311} TBR=sadrul@chromium.org,perezju@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965158 Change-Id: I6420ec079c4738913bc701a6490fcd6b47b4aa3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932895Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718938}
-
