- 21 Jan, 2021 40 commits
-
-
sauski authored
The "last_survey_check_time" preference value associated with a survey trigger limits the rate at which contact is attempted to be made with the HaTS service to once per 24hrs. Previously the creation of a HaTS Next dialog, which immediately attempts to contact the HaTS service, did not set this value. This could result in an individual client making unlimited requests to the HaTS service. This CL adjusts logic such that this value is set on creation of a HaTS Next dialog, and is consulted earlier in attempting to show a survey. Specifically as part of the CanShowSurvey check, rather than CheckSurveyStatusAndMaybeShow. Bug: 1110888 Change-Id: I289245893ed0ff7c49afeb5b560b970df02a5416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640433Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#845563}
-
Simon Zünd authored
Design doc: https://bit.ly/devtools-trust-tokens This CL adds a new "getTrustTokens" method in the storage domain that returns the number of available Trust Tokens per issuer. R=caseq@chromium.org, sigurds@chromium.org Bug: chromium:1126824 Change-Id: Ic4693dfb5f4d88b54fd0f733ce38acd36632541d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593112 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#845562}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/profiles. Bug: 1148570 Change-Id: I657d9decc3489b8883957b55fb05ff62e4143c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639149 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845561}
-
arthursonzogni authored
Move CSPEE code from the AncestorThrottle toward the NavigationRequest. Why? 1) AncestorThrottle is a NavigationThrottle. NavigationThrottle doesn't run for several URLs like about:blank. This fixes two two test case introduced recently for bug 1163174 2) CSPEE can add a 'sandbox' directive. This might modify the origin. The origin needs to be computed before running the NavigationThrottle. So this isn't possible to check CSPEE in the NavigationThrottle. Taking CSPEE into accounts for sandbox will be fixed in a follow-up. Bug: 1163174 Change-Id: I193d7821b7819339912a6ba92bdb28e8fa893256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611269 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#845560}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611187144-39ea136b6ebfd3c490dd8e8da57ed07347596a8e.profdata to chrome-mac-master-1611208290-983521cb9aa454798e29d76ad68922e8cdd2db84.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic7bbe12b83fdc9ac14d0e8cc1821d4504aa4e50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845559}
-
Alice Wang authored
This CL moves SigninUtils to signin.ui target. Bug: 1163470 Change-Id: I24da246f47205e60cdbb2be66bb4527eb7c26ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640397Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845558}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/137271ffc54d..bb7660008b16 2021-01-21 timvp@google.com Vulkan: Move Flush during SyncHelper::clientWait() earlier 2021-01-21 syoussefi@chromium.org Translator: Stop allocating TIntermSequence If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1060139 Tbr: cnorthrop@google.com Test: Test: CopyOutputScalingPixelTest.ScaledCopyOfDrawnFrame/48 Change-Id: I214048bd0724c4c4e073eb9e9910bfedf7b2f2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641484Reviewed-by:
-
Hidehiko Abe authored
Supporting multi clients on crosapi, in order decouple the concept of "browser" and the lacros as the browser implementation, remove the proper noun "Lacros" from crosapi interfaces. BUG=1148448 TEST=Ran tryjob. TBR=iby@chromium.org, droger@chromium.org, emaxx@chromium.org, rjkroege@chromium.org Change-Id: Id5ba84994d6a41196abb7b837a118f1ae3492d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639422 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845556}
-
Side Yilmaz authored
This CL passes OTRProfileID to getAllDownloads function to support multiple off-the-record profiles. Bug: 1099577, 1060940 Change-Id: I6746b60b2eeabab1d03957cce285067275ab6908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626435Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845555}
-
Henrique Ferreiro authored
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1101837, 1164001 Change-Id: I9f547f785679fcc03dde65f60b090b28c250f95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640253Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f1a39a74b67f..1557fad065c6 2021-01-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iddf3f387faaf830562880b12270edf79305744e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641656Reviewed-by:
-
Luciano Pacheco authored
Enable all integration tests to run as JS modules. I have hand selected some tests to continue to run as non-js-modules to have some coverage in case we need to flip back to it. Bug: 1133186 Change-Id: Iddb5b65bd82c62a5288e856bdd0ff5587f80ac24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641688Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#845552}
-
David Van Cleve authored
The structured_headers::Item constructor has a default argument that determines whether a given Item will serialize as a "byte sequence" or a "string" Structured Headers item. Elsewhere in trust_token_request_signing_helper.cc, we try explicitly to provide kStringType or kByteSequenceType to the constructor to make it clear at the callsite which of the two types each particular item has. This change is a no-op adding kStringType at a callsite to make it apparent to readers that the Item in question is string-type. Bug: None Change-Id: Id7a12f4d57ed6ecdb3ab48b3ca5468cf3b7459dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638563 Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#845551}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611187144-091cd0ce23c5cf7321279c1e02f3c90b64671b48.profdata to chrome-win32-master-1611197911-ad3187e6248266adece06729ea19dc5d8f4016ce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I63443f0a7713b129efc28fbc8ded688ad5979718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641482Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0be184647794..49b20f919abe 2021-01-21 deadbeef@webrtc.org Fix race with SctpTransport destruction and usrsctp timer thread. 2021-01-20 peah@webrtc.org Allow separate dump sets for the data dumper in APM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1162424 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5bc6e013069836d57d9401c39ea4313969267d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641483Reviewed-by:
-
Manuel Rego Casasnovas authored
Like the rest of the platforms, this patch avoids setting ImeTextSpan::underline_color to black color. That way when the IME composition underline is painted it'll use the text color and not be always black. This makes the composition underline visible when you have a dark background. Bug: 1168012 Change-Id: Id4ec27ffe8e698ff41de93fc1260363f96e4aa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637495Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#845548}
-
Luciano Pacheco authored
When running as non-js-modules the <bread-crumb> has its images in-lined by grit, however when running as JS modules the <bread-crumb> is in-lined via rollup, then it runs from the path foreground/js/ instead of its actual path foreground/js/ui/ making the relative address to its images incompatible. Fix by duplicating the 2 affected images, moving them up 1 directory so the relative path is consistent. NOTE: These 2 images are the only references to "/images" inside the ui/ directory. [1] [1] - https://source.chromium.org/search?q=%22images%2F%22&sq=&ss=chromium%2Fchromium%2Fsrc:ui%2Ffile_manager%2Ffile_manager%2Fforeground%2Fjs%2Fui%2F Bug: 1133186 Change-Id: I71a10286c325e54c3adecc0f079002aeab7a0344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640006Reviewed-by:
-
Xiaodan Zhu authored
This CL implements the reordering of the desks by keyboard. When a desk thumbnail is highlighted. - Pressing Ctrl + -> will swap current desk with the right one. - Pressing Ctrl + <- will swap current desk with the left one. Bug: 1164025 Change-Id: Ibb14098073191faa4d31e9075cde275006a29edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623719Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845546}
-
Gavin Williams authored
Move the common dropdown code for sorting and choosing the default option to SelectBehavior. Add getSelectedOption(), sortOptions(), and isDefaultOption() to each settings dropdown. These functions are called from SelectBehavior. Bug: 1168346 Change-Id: I186a6e2ef18b335fdba0f81e4002f4859d27d0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638499 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#845545}
-
Luciano Pacheco authored
The i18n strings in the deferred elements need the `loadTimeData` which is initialized in the background page and in the initBackgroundPagePromise_. Change the initialization for JS modules to wait the background promise before importing the deferred elements. Bug: 1133186 Change-Id: I2f82cc3ca89964900c5711652379fbcbdff17acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641785 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/821a84558bd4..3c142940b9dd 2021-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 311a17a8feae to 762814bd9229 (7 revisions) 2021-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 89fd1480b47e to b3e5c440d239 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I0b05fe93dd42dc6a98f308619bfa28099785b7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641481Reviewed-by:
-
Shik Chen authored
Bug: b/176879728, b/172344433 Test: Manually verify the animations Change-Id: I6bd326171812531c3d150b1531564fe4cecc38a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639613Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#845542}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96b7ec727bac..d5c88e60cff4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1164189,chromium:1166926 Tbr: keishi@google.com Change-Id: I9dcdf56fe37aee5ee87dd0f0fc928b78c4c1befb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641648Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845541}
-
Bartek Nowierski authored
The names are highly confusing and misleading. These functions don't return an actual size, but an underlying capacity, which may or may not be readily available to the app. AllocationCapacity* names reflect the behavior better. Change-Id: I4c59dbf75397b31ed58c1467c019ca23057031c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636748 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845540}
-
Nikolai Artemiev authored
Allows the --form-factor flag to be used to override the form factor value from the LSB release info. BUG=b:173179861 TEST=CQ Change-Id: Ic4dd3eb52dd562d35debac3fea168f686d728e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631393 Commit-Queue: Nikolai Artemiev <nartemiev@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Nikolai Artemiev <nartemiev@google.com> Cr-Commit-Position: refs/heads/master@{#845539}
-
Bruce Dawson authored
Chrome sometimes needs to detect when an object has been deleted in the middle of a member function. Manually maintaining a destroyed pointer/flag is error prone and verbose so this change switches to using WeakPtr. In the NativeMenuWin case the destroyed pointer wasn't even used, making deleting it particularly easy. Idea from dcheng@ Bug: 1152152 Change-Id: Ie913fa6255c5db4667e59b724732df2dbedf5580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637268Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#845538}
-
Kenichi Ishibashi authored
This reverts commit b53ca149. Reason for revert: Caused test flakiness (crbug.com/1168509) and crashes (crbug.com/1168509). Original change's description: > Quota: Mojofy Service Workers's QuotaClient. > > Bug: 1163048 > Change-Id: I1744df8280e11bc96073415354a0006f49fd6a9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628078 > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Commit-Queue: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844768} TBR=falken@chromium.org,pwnall@chromium.org,siggi@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1163048 Change-Id: I1ae404f8353ca73c65ed0a8aa8621055c34e3efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640317Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845537}
-
Nancy Wang authored
The full restore calls BrowserAppLauncher::LaunchAppWithParams to restore the system web apps: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/full_restore/app_launch_handler.cc;l=210 So modify BrowserAppLauncher::LaunchAppWithParams to save the launch parameters to prepare the full restore for the next reboot. Modify ExtensionAppsChromeOs to save the launch parameters for platform apps only. Modify WebAppsChromeOs to save the launch parameters for the system web apps only. Because if the apps opened in tab or with browser, the full restore component can get the info from the window property kWindowIdKey, and Chrome session restore can restore browsers, so we don't need to save the launch parameter. BUG=1146900 Change-Id: I1231bcbc1d665918f5f6d7efbf19751387bf8ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639346Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845536}
-
edchin authored
Extracts web_contents from PasswordProtectionRequest into a derived class. The base class will be moved to /core in a future CL. Bug: 1147967 Change-Id: I011f1a853168ce6c40108bc5d0fb1dd78e1321fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638775 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#845535}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7acbae90a490..561f5af9ef1e 2021-01-21 tsepez@chromium.org Enable incremental sweeping for XFA 2021-01-21 tsepez@chromium.org Remove includes of windows tchar.h. 2021-01-21 awscreen@chromium.org Roll third_party/skia/ ae95077db..81bfabeb1 (783 commits) 2021-01-21 awscreen@chromium.org Roll third_party/zlib/ c29ee8c9c..2c183c9f9 (1 commit) 2021-01-21 awscreen@chromium.org Roll third_party/libjpeg_turbo/ d5148db38..518d81558 (4 commits) 2021-01-21 awscreen@chromium.org Roll v8/ c52956d09..1d681a1a9 (483 commits) 2021-01-21 awscreen@chromium.org Roll base/trace_event/common/ eb94f1c7a..9b2775773 (1 commit) 2021-01-20 awscreen@chromium.org Roll third_party/instrumented_libraries/ 6ba978ccb..4d3867052 (1 commit) 2021-01-20 awscreen@chromium.org Roll third_party/icu/ 6a33b647c..899e18383 (4 commits) 2021-01-20 awscreen@chromium.org Roll third_party/googletest/src/ 4fe018038..d128fc825 (156 commits) 2021-01-20 awscreen@chromium.org Roll third_party/freetype/src/ 8cc4d0dc3..03ceda970 (87 commits) 2021-01-20 awscreen@chromium.org Roll third_party/depot_tools/ 18f45d287..3253a1dec (83 commits; 22 trivial rolls) 2021-01-20 awscreen@chromium.org Roll tools/clang/ 9ec0bb322..683dad603 (18 commits) 2021-01-20 awscreen@chromium.org Roll buildtools/ 6302c1175..c38b5ab1c (5 commits) 2021-01-20 awscreen@chromium.org Roll build/ 33d5eb773..781f0025b (185 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156170 Tbr: pdfium-deps-rolls@chromium.org Change-Id: If5588051d04a818c95631e7bad57a3670f0e5fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641647Reviewed-by:
-
Asami Doi authored
This CL adds 3 test cases for clients.claim(): 1) a blob URL worker (parent) creates a blob URL worker (child) 2) a blob URL worker (parent) creates a worker (child) 3) a worker (parent) creates a blob URL worker (child) Bug: 1017034 Change-Id: Iaef9c84661f0fe1c1b10a4a6f8cccc5e839355c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638960 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#845533}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: Ieebd11507009669b138584be6a09d31e4ce20a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640316Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aeaf8b9be0c2..f1a39a74b67f 2021-01-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-21 andoli@chromium.org [module.json extensions] mobile_throttling If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87d59897389f7ae57c36796fae86cb5f68b18a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641646Reviewed-by:
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: I65e1a8acdf573ce233b9d78bcdc213f12cb1109e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639431 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Jenny Zhang authored
This cl makes several improvements: 1. Run callback function of LacrosChromeService api with return value on IPC thread instead of UI thread. 2. Run GetCompressedHistograms in base's thread pool instead of UI thread, since it calls functions marking as blocking. 3. Do not store the callback passed to LacrosChromeServiceDelegateImpl. Bug: 1167026 Change-Id: I85ec998517e78bad067f1da49c7cff05e4222539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633192Reviewed-by:
-
Kenton Lam authored
Brief changes: - Set dialog window size. - Fix emoji spacing. - Hide (currently non-functional) search field. - Use Roboto font. - Sticky tab row to top while scrolling emoji. - Replace "frequently used" with "recently used" to match its behaviour (which is not implemented yet). Screenshot: https://screenshot.googleplex.com/4Y8zvfGgpmMHq9y.png Bug: 1152237 Change-Id: I25c3a1787e80f6693edd483f502692fafe586e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639615Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#845528}
-
Inker Kuo authored
This reverts commit a6df04e9. Reason for revert: crbug.com/1168666 Original change's description: > [VideoCapture] Make VideoCaptureHost per frame instead of per process > > Prior to this CL, there was a VideoCaptureHost mojo object per renderer > process. This CL makes it per frame, which is preferred. > > This CL keeps the mojo client (VideoCaptureImpl and > WebVideoCaptureImplManager) in platform since they do not really need > to know about frames, only about a browser interface broker. > LocalVideoCaptureClientImpl is moved to modules/mediastream, where it > can know about frames and can pass the corresponding BIB to the video. > The other user of the video-capture client is pepper, which already > knew about frames. > > > Bug: 1167900 > Change-Id: I699a1b0e1285e8b384c9be6bb9c6d04d0951c9c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632614 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845096} TBR=kinuko@chromium.org,haraken@chromium.org,guidou@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I6d4e81112386671fb49a0d73a5cf892c98dc25b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1167900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641824Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/08f5311ae142..821a84558bd4 2021-01-21 reed@google.com remove dead code from old drawimage virtuals If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I42a58c0d83938e862199f60f756dbd13c7323927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641354Reviewed-by:
-
John Palmer authored
View an autocorrect as accepted if we hide the underline after 4 keypresses. There is one minor edge case where the user has an autocorrect and quickly leaves the text field. I think for now, it is safe to ignore this edge case. Requires some changes to blink code as existing getAutocorrectRange() only works when cursor is in the autocorrect range, otherwise it returns an empty range. This change means that getAutocorrectRange() works even when the cursor is not in the range, which is needed to know if the range is still there to record the metric. Bug: b/170682691 Change-Id: I44f22b7c6990a2dd03dc45072290924710c968e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613845Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845525}
-
Fergus Dall authored
We're trying to track down the cause of some login flake in tast tests, which is inhibited by not being able to see the error response from the gaia servers. Add some VLOG statements to GenerateAuthError to record the exact error type and response. These will be enabled in some tast tests. Bug: 1166530 Change-Id: Ie9fc408f49e406ffc3790a7ec5dc65bf1eedf2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639338Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#845524}
-
