- 21 May, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bb633c91606e..fe49ce29c3e1 2020-05-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d45b30b5a554 to e8b8b8164520 (6 revisions) 2020-05-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 179a84ca to 16e86c0b (485 revisions) 2020-05-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b6e8c3f0f483 to cc5cda0f997d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I797792ba85893048e5b3815cb5f8f66f769eb39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211475Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770968}
-
Koji Ishii authored
Following bot results are included. 2299 2303 2304 2328 2330 2341 19 lines were removed and 2 lines were deflaked by consecutive results since 2220. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ib381327ac9c44a998f3184b2fa3fca2280aa29d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193352Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#770967}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1082664 Change-Id: I11df4fcd668a517d160c9bbe29656f92e312cfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205001 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770966}
-
Wei-Yin Chen (陳威尹) authored
After simplifying the tests, there's no need to use EmbeddedTestServer in StartSurfaceTest anymore. Bug: None Change-Id: Id9898777ba8a423439bfb2168293d8fe2a980a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206335 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#770965}
-
Noel Gordon authored
Rewrite the toaster in terms of <cr-toast> which supports animating the toast on and off the screen using CSS transitions effects, has in-built ARIA support, and provides <slot>s for inserting the toast text element <div> and action <cr-button>. Styling this component for ChromeOS files-ng: <cr-toast> mostly does it for us with little extra work. We only need to control toast min-height and number of lines shown (at most 2), a few margins and one background color. Delete all our CSS that <cr-toast> now does for us. Elevation +2 shadows are the <cr-toast> default internal style and flex display too. Users must add justify-content: space-between to keep text pinned to the left and the action button pinned to the right. The default <cr-toast> position is 24px,24px from the lower-left corner so CSS move it to the lower-right corner in LTR per FilesApp usage. The toast duration is controlled by that <cr-toast> attribute: add that attribute in markup and use the same value as before: 5000 ms. Update the externs file definition (it was out-of-date) and add TODO to fix <cr-toast> iron-a11y-announcer BUILD.gn deps issue. Remove ES6 lint exceptions, add comments, add closure markup. Fix UI test sharing tests: <cr-toast> fails to work in that system. Add <files-toast> mock to workaround that failure. Test: browser_tests --gtest_filter="FilemanagerJsTest*FilesToast" Bug: 1002391, 1033660 Change-Id: I06113a6bcdc564bc374df559a3830a2a9df031f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208166 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#770964}
-
Yao Xiao authored
Previously we added this field to the "visits" table. This CL adds the field to URLResult and fills in this field inside HistoryBackend::QueryHistoryBasic and HistoryBackend::QueryHistoryText. Bug: 1062736 Change-Id: I8e0690a43f1c5648dc5b2bd611a06ae92c62afba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211051 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#770963}
-
Hitoshi Yoshida authored
We used to use an empty ScriptValue as a default null value, and we will distinguish them in the new code generator. Then we found the default value expressions need to know what they depend on, such as a null value for ScriptValue type needs v8::Isolate. This CL makes DefaultValueExpr dataset to have dependency information to work for the case. Bug: 839389, 1070964 Change-Id: I19dd7a109bb1752df6c53a502ea2fd815fd3c348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198764Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#770962}
-
François Beaufort authored
Change-Id: I8c30b541360493298675bad413c3e999220f3a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209212 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#770961}
-
Sara Kato authored
Mainly in ARC++ we often see that focus going into containers with clickable parents. This is evident in lists (as described in bugs), where the containing children will also receive focus. This CL adds a condition, which considers focusable nodes that have children with the same name should be considered as a leaf (thus preventing further focus propagation). announced twice. AX-Relnotes: Ensure that nodes with static text with same name don't get Bug: b:156426961 Bug: b:154875936 Test: ChromeVoxBackgroundTest.FocusableNamedDivIsNotContainer Test: manual (open FamilylinkApp, Hangouts app), navigate using search+arrow and note that items are read once. Change-Id: I569b9059c2a8eb458f9e8684bd4d645b0260b93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198047 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770960}
-
Takashi Toyoshima authored
* virtual/omt-worker-fetch/external/wpt/resource-timing/redirects.sub.html * virtual/omt-worker-fetch/external/wpt/resource-timing/resource_connection_reuse_mixed_content_redirect.html NOTRY=true TBR=kinuko@chromium.org Bug: 1085332 Change-Id: I7da0d3f0549655a55fa768e558e61b20fbfc63e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211582Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#770959}
-
Alexey Baskakov authored
Return runtime error if finalizer is not started. Unfortunately, WebAppInstallFinalizer::FinalizeInstall is used directly by PendingAppManager (for now). This is a speculative fix for the crash in the bug: Do not even initiate the writing operation if web app provider is not yet ready. In next CLs: Add more started/shutdown checks in WebAppInstallManager, ManifestUpdateManager. We should return WebAppProviderNotReady error as early as possible (in WebAppInstallManager API). Bug: 1084939 Change-Id: I3f7a27f587da4d2c8676f9863f94650f7357d5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208889 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#770958}
-
Takashi Toyoshima authored
* external/wpt/resource-timing/redirects.sub.html * external/wpt/resource-timing/resource_connection_reuse_mixed_content_redirect.html * http/tests/misc/resource-timing-sizes-redirect-worker.html * http/tests/misc/resource-timing-sizes-redirect.html NOTRY=true TBR=kinuko@chromium.org Bug: 1085332 Change-Id: I6c74264b0cc8e931680f1e26c8ea686a1902ed60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210182Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c0578632217..bb633c91606e 2020-05-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 78f7e8640f14 to 8a3cc5c4dfd8 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I502c742785014d731821b8990f2c05de53d40b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211468Reviewed-by:
-
Rob Buis authored
MathML Core support the script level functionality both using a font-size extension and as an attribute on MathML elements. The scriptlevel attributes simply maps to the font-size extension [1]. The font-size extension follows the algorithm stated in [2]. In order to keep track of the internal scriptlevel [3] an internal property MathScriptLevel is added to the computed style. Finally various stylesheet rules related to script level are taken as-is from the specification stylesheet [4]. [1] https://mathml-refresh.github.io/mathml-core/#the-displaystyle-and-scriptlevel-attributes [2] https://mathml-refresh.github.io/mathml-core/#the-math-script-level-property [3] https://mathml-refresh.github.io/mathml-core/#dfn-internal-scriptlevel [4] https://mathml-refresh.github.io/mathml-core/#user-agent-stylesheet Bug: 1023292 Change-Id: I47ed250a63049b15daff53f9c0942cf676b21acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184131Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#770955}
-
Karandeep Bhatia authored
Types which are only referenced once are inlined by the Docserver by default. This causes excessive nesting in documentation for declarativeNetRequest. Prevent this by explicitly disallowing inlining for these types. BUG=1085326 Change-Id: I2d2a938832fdfd26915b8956b14f1d41e3b0a646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209966 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770954}
-
Shik Chen authored
This CL removes the renaming behavior for video recording to simplify the logic, and mitigate thumbnail regeneration timeout issue in Files app for long video. Bug: 1058325, 1080869 Test: Verify the file name manually, and pass CCAUIRecordVideo and CCAUIIntent Change-Id: I074885d95e8cf41d85cf46ef866c47500726708b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210201 Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#770953}
-
Hiroki Nakagawa authored
For code cleanup, this CL renames LinkFetchResource that was used only for <link rel='prefetch'> to LinkPrefetchResource. This also renames LinkResourceFactory to Factory. That is the internal class of LinkPrefetchResource, so just naming it "Factory" would be simpler and still understandable. Bug: 1075582 Change-Id: If057c89242a41ea1969045ba19f1ceef6d4195a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210202 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#770952}
-
Daniel Murphy authored
There is a pre-installed Youtube app that is a hosted app (and not a bookmark app), but it is hard coded as a bookmark app. To add to this weirdness, the app id is not the hash of the start url, so this causes problems within the bookmark app system which assumes this. This CL fixes the default app configuration, and adds migration code to fix this for all installs. R=alancutter@chromium.org, loyso@chromium.org Bug: 1068453 Fixed: 1084848, 1078450 Change-Id: I7fab1714edede1fbf4030beb55c118b8300f4ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181827 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ae2ed9f992e1..98dedb300ca7 2020-05-21 dberris@chromium.org auto-bisect: Add more details to creation message If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084858 Tbr: sadrul@google.com Change-Id: I2bdd1ceaa0ea39697c4aa2e12f249a98fdce69d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211466Reviewed-by:
-
Brian Manthos authored
Change-Id: I20f5b9b18345272e435b478f7688a0e0bf10694f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210540Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Brian Manthos <brianman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770949}
-
Sonny Rao authored
We still use these histograms to keep track of memory issues and other crashes. Bug: 1072534 Change-Id: I5a32a787a456685385f1a7c7e647f12d923ec920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211362Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#770948}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590019092-0150ca95063dc0ad33468a89535d4804f9e0bc6b.profdata to chrome-mac-master-1590033536-e720add817899a0a9587c78e7de615e881dda3e9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I25f2bf4a4f959f17136c63aa859c14bcf524cb8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211470Reviewed-by:
-
Mohsen Izadi authored
Please see a screenshot from a sample trace at: https://drive.google.com/file/d/1rTdrSmfPoM07ycf76cpLAC1zHZrfwus0/view Bug: 1054009 Change-Id: Ia24056e6a9951dae4e4be00f1e58aa6c93ff2706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166637Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#770946}
-
chrome://media-appTrent Apted authored
Currently the color is specified in the manifest and on the <backlight-app> element loaded in the iframe. But the element only loads after translations are ready, so there's a period where the background color is white. Setting it on <body> in the main frame (and not also in the iframe) appears to be sufficient to avoid any white flash, since everything else is transparent. Bug: 996088 Change-Id: If9dbff68fb07a535113c26133721c5c8b28ea6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210337Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#770945}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/13e565a5999c..8a3cc5c4dfd8 2020-05-21 jiawei.shao@intel.com Add adapter type in test name when the adapter is Microsoft Basic Render If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1b6de2a49c6249a6ba1480d71cebfb929588eaad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211464Reviewed-by:
-
Hiroki Nakagawa authored
For code cleanup, this CL removes the resource type param from the ctor of LinkFetchResource that was always ResourceType::kPrefetch, and instead hard-codes the resource type in the class. Bug: 1075582 Change-Id: I2230f107968969c6df71bacd8089d1a82b1dd0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210338Reviewed-by:
-
John Abd-El-Malek authored
Bug: 1084612 Change-Id: I23eb128c361064f4a490c1316139415a582dbdc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209292 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Nicholas Verne authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/2b37f52a06d9..6b108dadbc56 $ git log 2b37f52a0..6b108dadb --date=short --no-merges --format='%ad %ae %s' 2020-05-13 nverne permission_broker: Support USBDEVFS_DROP_PRIVILEGES mask. 2020-05-19 akhouderchah hermes: Have SM-DS create pending Profile object rather than Event tuple Created with: roll-dep src/third_party/cros_system_api Bug: 1082075 Change-Id: I776b14c5a6083d71f64842f9192ea97dfc7a2946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210086 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#770941}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c256b1f2a5f3..a6b59e58b6b5 2020-05-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4aa114627f15dc25fa9de0640f5d8ce958b662ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211463Reviewed-by:
-
sangseok.jang authored
These functions' body was removed by previous patch(https://chromium-review.googlesource.com/c/chromium/src/+/1983215) but declarations still remain. Bug: none Change-Id: I06f2a3e9f80350132465f2f4320b373f8604570a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208313 Commit-Queue: SANGSEOK JANG <sangseok.jang@gmail.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#770939}
-
Alex Gough authored
Does not change behavior. Prelude to removing WithSandboxType option from service process host API. See linked bug for rationale. Tests: content_browsertests StoragePartitionImplBrowsertest Bug: 1065087 Change-Id: Ic3aed7e47eecfe75fbe0fcc630af3d362854a0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209295Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#770938}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab2265ec86ea..3bc19daeb343 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1041701,chromium:1084764 Tbr: yosin@google.com Change-Id: I53eac19a0c52e9ca7231ab4839364f6aa3c68a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210913Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770937}
-
John Z Wu authored
This fixes issue where the generated .modulemap file is referencing a nonexistent header file. Change-Id: I156ccff21b5a8cd56b56e4777c2dd601957c5eb3 Bug: 1084855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209569 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#770936}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I002852ecc746ea9e1c66eabf1a8d66134bf2cd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211465Reviewed-by:
-
Dmitry Torokhov authored
We need to re-notify the user about each and every failure to start Plugin VM, otherwise, if notification was closed, but not dismissed, the failure appears to be silent. Bug: b/155685388 Change-Id: I018af01601562747053b0ade7b0c3e214728c1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211156Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#770934}
-
Luciano Pacheco authored
The sorting icon should be an arrow pointing up when sorting in ascending order. Bug: 1081853 Change-Id: If559358bb05aa34a4875504ea4386364c25ccd01 Fixed: 1081853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208887 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#770933}
-
Luciano Pacheco authored
Only show focus ring only when interacting with keyboard. Add the hover color/style for OK button. Fix font face when opening delete dialog from <quick-view>, it was using Arial font, because it was missing "text_defaults.css" in this context. Bug: 992827, 1062902 Change-Id: Ibc4f6c576779a764d496d3d810d46bfa5378eef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208779 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
In next CLs: Add more started/shutdown checks in WebAppInstallFinalizer, WebAppInstallManager, ManifestUpdateManager. Bug: 1084939 Change-Id: I720cbdd79998e895f5b9171e3173f89c6977be6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210085 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Alex Danilo authored
The drop-down menu hanging off the elider button has a width range between 192px and 288px depending on the content inside it. Wide menus can get clipped on the right hand side if the window width is reduced to the smallest size possible, obscuring any scroll bar in the drop-down. Changes the max-width selector to take the minimum of 288px or 40vw which guarantees the right side of the menu doesn't get clipped out. Bug: 1083046 Change-Id: Ia64dc5befe62e5d4370044fe2545c1c720efee40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210177 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Wenyu Fu authored
Add paddingTop to make spacing consistent between top and bottom. Bug: 1068831, 1084791 Change-Id: I68639415615c24d3fa7889c53b74d9102482a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209895Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770929}
-
